From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Guenter Roeck <guenter.roeck@ericsson.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than
Date: Sat, 18 Dec 2010 15:39:50 +0000 [thread overview]
Message-ID: <20101218153950.GA22649@srcf.ucam.org> (raw)
In-Reply-To: <20101218153012.GA1506@polaris.bitmath.org>
On Sat, Dec 18, 2010 at 04:30:12PM +0100, Henrik Rydberg wrote:
> > Hm. Is this an oops or a lockdep warning?
>
> It is a null-pointer dereference in sysfs_create_file(). Probably the
> kernel is asking the same question as I did - do you actually see the
> sysfs nodes when testing the patch?
Yup. Not sure what's happening there. I'll try to figure that out.
> > > So where to attach the sysfs nodes... There is also a userspace issue
> > > here, since a lot of applications are hard-wired to
> > > /sys/devices/platform/applesmc.768/.
> >
> > The correct sysfs ABI is to use the /sys/class interface and the names
> > under there rather than assuming a hardwired platform device path.
>
> Still breaks user-space, but it seems this is already under control.
If it turns out that there's code that relies on it then we could
obviously retain the platform device, but it's kind of ugly. sysfs
paths aren't intended to be hardcoded.
--
Matthew Garrett | mjg59@srcf.ucam.org
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Guenter Roeck <guenter.roeck@ericsson.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices
Date: Sat, 18 Dec 2010 15:39:50 +0000 [thread overview]
Message-ID: <20101218153950.GA22649@srcf.ucam.org> (raw)
In-Reply-To: <20101218153012.GA1506@polaris.bitmath.org>
On Sat, Dec 18, 2010 at 04:30:12PM +0100, Henrik Rydberg wrote:
> > Hm. Is this an oops or a lockdep warning?
>
> It is a null-pointer dereference in sysfs_create_file(). Probably the
> kernel is asking the same question as I did - do you actually see the
> sysfs nodes when testing the patch?
Yup. Not sure what's happening there. I'll try to figure that out.
> > > So where to attach the sysfs nodes... There is also a userspace issue
> > > here, since a lot of applications are hard-wired to
> > > /sys/devices/platform/applesmc.768/.
> >
> > The correct sysfs ABI is to use the /sys/class interface and the names
> > under there rather than assuming a hardwired platform device path.
>
> Still breaks user-space, but it seems this is already under control.
If it turns out that there's code that relies on it then we could
obviously retain the platform device, but it's kind of ugly. sysfs
paths aren't intended to be hardcoded.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-12-18 15:39 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 15:33 [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than hardcoding Matthew Garrett
2010-12-16 15:33 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-16 15:33 ` [lm-sensors] [PATCH 2/2] applesmc: Perform some more sanity Matthew Garrett
2010-12-16 15:33 ` [PATCH 2/2] applesmc: Perform some more sanity checking on temperatures Matthew Garrett
2010-12-16 16:48 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than Henrik Rydberg
2010-12-16 16:48 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-16 17:00 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than Matthew Garrett
2010-12-16 17:00 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-16 17:00 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than Guenter Roeck
2010-12-16 17:00 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Guenter Roeck
2010-12-17 21:57 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather Matthew Garrett
2010-12-17 21:57 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-17 21:58 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than hardcoding Matthew Garrett
2010-12-17 21:58 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-17 22:16 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than Guenter Roeck
2010-12-17 22:16 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Guenter Roeck
2010-12-17 22:22 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than Matthew Garrett
2010-12-17 22:22 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-17 22:24 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Matthew Garrett
2010-12-17 22:24 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-18 4:23 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Guenter Roeck
2010-12-18 4:23 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Guenter Roeck
2010-12-18 9:07 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 9:07 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-18 14:40 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Matthew Garrett
2010-12-18 14:40 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-18 15:31 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 15:31 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-18 9:37 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 9:37 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-18 10:09 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Jean Delvare
2010-12-18 10:09 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Jean Delvare
2010-12-18 10:31 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 10:31 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-18 11:29 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Julien BLACHE
2010-12-18 11:29 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Julien BLACHE
2010-12-18 11:57 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 11:57 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-20 13:44 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Mikael Ström
2010-12-20 13:44 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Mikael Ström
2010-12-20 13:57 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Jean Delvare
2010-12-20 13:57 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Jean Delvare
2010-12-20 14:23 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-20 14:23 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-20 14:28 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather Matthew Garrett
2010-12-20 14:28 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-20 15:06 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-20 15:06 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-20 15:12 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather Matthew Garrett
2010-12-20 15:12 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-20 15:37 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-20 15:37 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-20 14:00 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather Matthew Garrett
2010-12-20 14:00 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-21 6:04 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Mikael Ström
2010-12-21 6:04 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Mikael Ström
2010-12-21 11:09 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Julien BLACHE
2010-12-21 11:09 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Julien BLACHE
2010-12-18 14:43 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Matthew Garrett
2010-12-18 14:43 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-18 15:30 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 15:30 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-18 15:39 ` Matthew Garrett [this message]
2010-12-18 15:39 ` Matthew Garrett
2010-12-17 22:24 ` [lm-sensors] [PATCH 2/2 V3] applesmc: Perform some more sanity Matthew Garrett
2010-12-17 22:24 ` [PATCH 2/2 V3] applesmc: Perform some more sanity checking on temperatures Matthew Garrett
2010-12-17 21:58 ` [lm-sensors] [PATCH 2/2] applesmc: Perform some more sanity Matthew Garrett
2010-12-17 21:58 ` [PATCH 2/2] applesmc: Perform some more sanity checking on temperatures Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101218153950.GA22649@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=guenter.roeck@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.