From: Andrew Morton <akpm@linux-foundation.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
linux-kernel@vger.kernel.org,
David Rientjes <rientjes@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Oleg Nesterov <oleg@redhat.com>,
linux-mm <linux-mm@kvack.org>, Andrey Vagin <avagin@openvz.org>,
Hugh Dickins <hughd@google.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Nick Piggin <npiggin@kernel.dk>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH 1/5] vmscan: remove all_unreclaimable check from direct reclaim path completely
Date: Wed, 23 Mar 2011 20:04:58 -0700 [thread overview]
Message-ID: <20110323200458.724f2af8.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110324114842.CC70.A69D9226@jp.fujitsu.com>
On Thu, 24 Mar 2011 11:48:19 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> > On Thu, 24 Mar 2011 11:11:46 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> >
> > > Subject: [PATCH] vmscan: remove all_unreclaimable check from direct reclaim path completely
> >
> > zone.all_unreclaimable is there to prevent reclaim from wasting CPU
> > cycles scanning a zone which has no reclaimable pages. When originally
> > implemented it did this very well.
> >
> > That you guys keep breaking it, or don't feel like improving it is not a
> > reason to remove it!
> >
> > If the code is unneeded and the kernel now reliably solves this problem
> > by other means then this should have been fully explained in the
> > changelog, but it was not even mentioned.
>
> The changelog says, the logic was removed at 2008. three years ago.
> even though it's unintentionally. and I and minchan tried to resurrect
> the broken logic and resurrected a bug in the logic too. then, we
> are discussed it should die or alive.
>
> Which part is hard to understand for you?
>
The part which isn't there: how does the kernel now address the problem
which that code fixed?
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
linux-kernel@vger.kernel.org,
David Rientjes <rientjes@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Oleg Nesterov <oleg@redhat.com>,
linux-mm <linux-mm@kvack.org>, Andrey Vagin <avagin@openvz.org>,
Hugh Dickins <hughd@google.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Nick Piggin <npiggin@kernel.dk>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH 1/5] vmscan: remove all_unreclaimable check from direct reclaim path completely
Date: Wed, 23 Mar 2011 20:04:58 -0700 [thread overview]
Message-ID: <20110323200458.724f2af8.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110324114842.CC70.A69D9226@jp.fujitsu.com>
On Thu, 24 Mar 2011 11:48:19 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> > On Thu, 24 Mar 2011 11:11:46 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> >
> > > Subject: [PATCH] vmscan: remove all_unreclaimable check from direct reclaim path completely
> >
> > zone.all_unreclaimable is there to prevent reclaim from wasting CPU
> > cycles scanning a zone which has no reclaimable pages. When originally
> > implemented it did this very well.
> >
> > That you guys keep breaking it, or don't feel like improving it is not a
> > reason to remove it!
> >
> > If the code is unneeded and the kernel now reliably solves this problem
> > by other means then this should have been fully explained in the
> > changelog, but it was not even mentioned.
>
> The changelog says, the logic was removed at 2008. three years ago.
> even though it's unintentionally. and I and minchan tried to resurrect
> the broken logic and resurrected a bug in the logic too. then, we
> are discussed it should die or alive.
>
> Which part is hard to understand for you?
>
The part which isn't there: how does the kernel now address the problem
which that code fixed?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-24 3:09 UTC|newest]
Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 1:49 Linux 2.6.38 Linus Torvalds
2011-03-15 3:13 ` David Rientjes
2011-03-15 4:06 ` Steven Rostedt
2011-03-15 4:14 ` Linus Torvalds
2011-03-15 4:29 ` David Rientjes
2011-03-15 4:33 ` Andrew Morton
2011-03-15 4:50 ` David Rientjes
2011-03-15 6:21 ` Andrew Morton
2011-03-16 9:09 ` KOSAKI Motohiro
2011-03-22 11:04 ` [patch 0/5] oom: a few anti fork bomb patches KOSAKI Motohiro
2011-03-22 11:05 ` [PATCH 1/5] vmscan: remove all_unreclaimable check from direct reclaim path completely KOSAKI Motohiro
2011-03-22 11:05 ` KOSAKI Motohiro
2011-03-22 14:49 ` Minchan Kim
2011-03-22 14:49 ` Minchan Kim
2011-03-23 5:21 ` KOSAKI Motohiro
2011-03-23 5:21 ` KOSAKI Motohiro
2011-03-23 6:59 ` Minchan Kim
2011-03-23 6:59 ` Minchan Kim
2011-03-23 7:13 ` KOSAKI Motohiro
2011-03-23 7:13 ` KOSAKI Motohiro
2011-03-23 8:24 ` Minchan Kim
2011-03-23 8:24 ` Minchan Kim
2011-03-23 8:44 ` KOSAKI Motohiro
2011-03-23 8:44 ` KOSAKI Motohiro
2011-03-23 9:02 ` Minchan Kim
2011-03-23 9:02 ` Minchan Kim
2011-03-24 2:11 ` KOSAKI Motohiro
2011-03-24 2:11 ` KOSAKI Motohiro
2011-03-24 2:21 ` Andrew Morton
2011-03-24 2:21 ` Andrew Morton
2011-03-24 2:48 ` KOSAKI Motohiro
2011-03-24 2:48 ` KOSAKI Motohiro
2011-03-24 3:04 ` Andrew Morton [this message]
2011-03-24 3:04 ` Andrew Morton
2011-03-24 5:35 ` KOSAKI Motohiro
2011-03-24 5:35 ` KOSAKI Motohiro
2011-03-24 4:19 ` Minchan Kim
2011-03-24 4:19 ` Minchan Kim
2011-03-24 5:35 ` KOSAKI Motohiro
2011-03-24 5:35 ` KOSAKI Motohiro
2011-03-24 5:53 ` Minchan Kim
2011-03-24 5:53 ` Minchan Kim
2011-03-24 6:16 ` KOSAKI Motohiro
2011-03-24 6:16 ` KOSAKI Motohiro
2011-03-24 6:32 ` Minchan Kim
2011-03-24 6:32 ` Minchan Kim
2011-03-24 7:03 ` KOSAKI Motohiro
2011-03-24 7:03 ` KOSAKI Motohiro
2011-03-24 7:25 ` Minchan Kim
2011-03-24 7:25 ` Minchan Kim
2011-03-24 7:28 ` KOSAKI Motohiro
2011-03-24 7:28 ` KOSAKI Motohiro
2011-03-24 7:34 ` Minchan Kim
2011-03-24 7:34 ` Minchan Kim
2011-03-24 7:41 ` Minchan Kim
2011-03-24 7:41 ` Minchan Kim
2011-03-24 7:43 ` KOSAKI Motohiro
2011-03-24 7:43 ` KOSAKI Motohiro
2011-03-24 7:43 ` Minchan Kim
2011-03-24 7:43 ` Minchan Kim
2011-03-23 7:41 ` KAMEZAWA Hiroyuki
2011-03-23 7:41 ` KAMEZAWA Hiroyuki
2011-03-23 7:55 ` KOSAKI Motohiro
2011-03-23 7:55 ` KOSAKI Motohiro
2011-03-22 11:06 ` [PATCH 2/5] Revert "oom: give the dying task a higher priority" KOSAKI Motohiro
2011-03-23 7:42 ` KAMEZAWA Hiroyuki
2011-03-23 13:40 ` Luis Claudio R. Goncalves
2011-03-23 13:40 ` Luis Claudio R. Goncalves
2011-03-24 0:06 ` KOSAKI Motohiro
2011-03-24 0:06 ` KOSAKI Motohiro
2011-03-24 15:27 ` Minchan Kim
2011-03-24 15:27 ` Minchan Kim
2011-03-28 9:48 ` KOSAKI Motohiro
2011-03-28 9:48 ` KOSAKI Motohiro
2011-03-28 12:28 ` Minchan Kim
2011-03-28 12:28 ` Minchan Kim
2011-03-28 9:51 ` Peter Zijlstra
2011-03-28 9:51 ` Peter Zijlstra
2011-03-28 12:21 ` Minchan Kim
2011-03-28 12:21 ` Minchan Kim
2011-03-28 12:28 ` Peter Zijlstra
2011-03-28 12:28 ` Peter Zijlstra
2011-03-28 12:40 ` Minchan Kim
2011-03-28 12:40 ` Minchan Kim
2011-03-28 13:10 ` Luis Claudio R. Goncalves
2011-03-28 13:10 ` Luis Claudio R. Goncalves
2011-03-28 13:18 ` Peter Zijlstra
2011-03-28 13:18 ` Peter Zijlstra
2011-03-28 13:56 ` Luis Claudio R. Goncalves
2011-03-28 13:56 ` Luis Claudio R. Goncalves
2011-03-29 2:46 ` KOSAKI Motohiro
2011-03-29 2:46 ` KOSAKI Motohiro
2011-03-28 13:48 ` Minchan Kim
2011-03-28 13:48 ` Minchan Kim
2011-03-22 11:08 ` [PATCH 3/5] oom: create oom autogroup KOSAKI Motohiro
2011-03-22 11:08 ` KOSAKI Motohiro
2011-03-22 23:21 ` Minchan Kim
2011-03-22 23:21 ` Minchan Kim
2011-03-23 1:27 ` KOSAKI Motohiro
2011-03-23 1:27 ` KOSAKI Motohiro
2011-03-23 2:41 ` Mike Galbraith
2011-03-23 2:41 ` Mike Galbraith
2011-03-22 11:08 ` [PATCH 4/5] mm: introduce wait_on_page_locked_killable KOSAKI Motohiro
2011-03-22 11:08 ` KOSAKI Motohiro
2011-03-23 7:44 ` KAMEZAWA Hiroyuki
2011-03-23 7:44 ` KAMEZAWA Hiroyuki
2011-03-24 15:04 ` Minchan Kim
2011-03-24 15:04 ` Minchan Kim
2011-03-22 11:09 ` [PATCH 5/5] x86,mm: make pagefault killable KOSAKI Motohiro
2011-03-22 11:09 ` KOSAKI Motohiro
2011-03-23 7:49 ` KAMEZAWA Hiroyuki
2011-03-23 7:49 ` KAMEZAWA Hiroyuki
2011-03-23 8:09 ` KOSAKI Motohiro
2011-03-23 8:09 ` KOSAKI Motohiro
2011-03-23 14:34 ` Linus Torvalds
2011-03-23 14:34 ` Linus Torvalds
2011-03-24 15:10 ` Minchan Kim
2011-03-24 15:10 ` Minchan Kim
2011-03-24 17:13 ` Oleg Nesterov
2011-03-24 17:13 ` Oleg Nesterov
2011-03-24 17:34 ` Linus Torvalds
2011-03-24 17:34 ` Linus Torvalds
2011-03-28 7:00 ` KOSAKI Motohiro
2011-03-28 7:00 ` KOSAKI Motohiro
2011-03-15 21:08 ` Linux 2.6.38 Oleg Nesterov
2011-03-15 23:32 ` unnecessary oom killer panics in 2.6.38 (was Re: Linux 2.6.38) David Rientjes
2011-03-15 3:14 ` Linux 2.6.38 Steven Rostedt
2011-03-15 4:15 ` Linus Torvalds
2011-03-16 17:30 ` i915/kms regression after 2.6.38-rc8 (was: Re: Linux 2.6.38) Melchior FRANZ
2011-03-16 19:22 ` i915/kms regression after 2.6.38-rc8 Jiri Slaby
2011-03-16 19:22 ` Jiri Slaby
2011-03-16 19:43 ` i915/kms regression after 2.6.38-rc8 (was: Re: Linux 2.6.38) Chris Wilson
2011-03-16 21:09 ` i915/kms regression after 2.6.38-rc8 Melchior FRANZ
2011-03-20 18:30 ` i915/kms regression after 2.6.38-rc8 (was: Re: Linux 2.6.38) Maciej Rutecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323200458.724f2af8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=avagin@openvz.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=npiggin@kernel.dk \
--cc=oleg@redhat.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.