From: Sughosh Ganu <urwithsughosh@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.
Date: Wed, 11 Jan 2012 20:39:53 +0530 [thread overview]
Message-ID: <20120111150952.GB4301@Hardy> (raw)
In-Reply-To: <201201111601.31484.marek.vasut@gmail.com>
On Wed Jan 11, 2012 at 04:01:31PM +0100, Marek Vasut wrote:
> > More so, given the fact that we don't have any control over
> > rbl -- so if rbl changes it's layout for any subsequent board, we'd
> > have to add that as well to the nand driver, and both in u-boot as
> > well as the kernel.
> >
> > I guess the cleanest solution would have been for the rbl to have
> > used the same layout as the one used by u-boot and linux.
>
> Yep, why not do that then?
Because rbl is a proprietary bootloader from TI.
> >
> > Btw, can you please review this change, that this patch
> > fixes. ACK/NAK?
>
> I'll think about it. It's ok, but it piles one workaround on top of another one,
> I don't like that approach.
Flushing the data cache before disabling it is not a workaround,
it's a fix. The current code is invalidating the cache instead of
flushing it.
-sughosh
next prev parent reply other threads:[~2012-01-11 15:09 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 18:25 [U-Boot] [PATCH 1/2] Flush the date cache before disabling it Sughosh Ganu
2012-01-09 18:41 ` Mike Frysinger
2012-01-09 18:51 ` Sughosh Ganu
2012-01-10 18:12 ` [U-Boot] [PATCH 1/2 V2] arm926: Flush the data " Sughosh Ganu
2012-01-10 20:07 ` Marek Vasut
2012-01-11 6:20 ` Sughosh Ganu
2012-01-11 10:47 ` Marek Vasut
2012-01-11 12:11 ` Sughosh Ganu
2012-01-11 12:42 ` Marek Vasut
2012-01-11 13:31 ` Sughosh Ganu
2012-01-11 13:51 ` Marek Vasut
2012-01-11 13:52 ` Marek Vasut
2012-01-11 14:50 ` Sughosh Ganu
2012-01-11 15:01 ` Marek Vasut
2012-01-11 15:09 ` Sughosh Ganu [this message]
2012-01-11 18:50 ` Marek Vasut
2012-01-11 21:07 ` Christian Riesch
2012-01-11 22:13 ` Marek Vasut
2012-01-12 5:56 ` Christian Riesch
2012-01-12 6:29 ` Sughosh Ganu
2012-01-14 9:09 ` Albert ARIBAUD
2012-01-14 17:18 ` Christian Riesch
2012-01-12 12:03 ` Christian Riesch
2012-01-12 13:53 ` Sughosh Ganu
2012-01-12 14:04 ` Christian Riesch
2012-01-12 14:43 ` Sughosh Ganu
2012-01-14 17:20 ` Christian Riesch
2012-01-14 18:02 ` Sughosh Ganu
2012-01-13 8:06 ` Christian Riesch
2012-01-13 8:26 ` Sughosh Ganu
2012-01-13 14:41 ` Tom Rini
2012-01-13 17:23 ` Sughosh Ganu
2012-01-13 15:29 ` Heiko Schocher
2012-01-13 17:38 ` Sughosh Ganu
2012-01-13 18:19 ` Aneesh V
2012-01-14 7:45 ` Sughosh Ganu
2012-01-15 8:13 ` Heiko Schocher
2012-01-16 17:57 ` Tom Rini
2012-01-17 6:39 ` Heiko Schocher
2012-01-17 6:46 ` Sughosh Ganu
2012-01-17 15:27 ` Tom Rini
2012-01-19 6:53 ` Sughosh Ganu
2012-01-19 10:17 ` Aneesh V
2012-01-19 11:30 ` Christian Riesch
2012-01-19 11:54 ` Aneesh V
2012-01-20 7:28 ` Christian Riesch
2012-01-20 8:52 ` Aneesh V
2012-01-20 9:21 ` Christian Riesch
2012-01-20 12:13 ` Aneesh V
2012-01-20 12:48 ` Christian Riesch
2012-01-20 13:06 ` Aneesh V
2012-01-27 18:33 ` Tom Rini
2012-01-29 13:36 ` Christian Riesch
2012-01-30 6:39 ` Heiko Schocher
2012-01-30 8:10 ` Christian Riesch
2012-01-30 9:04 ` Sughosh Ganu
2012-01-30 10:38 ` Christian Riesch
2012-01-30 7:06 ` Sughosh Ganu
2012-01-30 17:03 ` Tom Rini
2012-01-31 4:09 ` Sughosh Ganu
2012-01-31 13:58 ` Christian Riesch
2012-01-20 11:56 ` Tom Rini
2012-01-13 15:06 ` Heiko Schocher
2012-01-13 17:22 ` Sughosh Ganu
2012-01-14 7:49 ` [U-Boot] [PATCH 1/2 V3] " Sughosh Ganu
2012-01-14 9:02 ` Albert ARIBAUD
2012-01-14 9:21 ` Sughosh Ganu
2012-01-14 10:34 ` Albert ARIBAUD
2012-01-14 14:02 ` [U-Boot] [PATCH 1/2 V4] " Sughosh Ganu
2012-02-18 15:41 ` Albert ARIBAUD
2012-02-18 18:51 ` [U-Boot] [PATCH 1/2 V3] " Christian Riesch
2012-02-19 8:31 ` Albert ARIBAUD
2012-01-20 9:22 ` [U-Boot] [PATCH 1/2 V2] " James W.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111150952.GB4301@Hardy \
--to=urwithsughosh@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.