* [PATCH RFC] virtio-net: remove useless disable on freeze @ 2012-04-04 9:19 ` Michael S. Tsirkin 0 siblings, 0 replies; 16+ messages in thread From: Michael S. Tsirkin @ 2012-04-04 9:19 UTC (permalink / raw) To: netdev; +Cc: Amit Shah, linux-kernel, kvm, virtualization disable_cb is just an optimization: it can not guarantee that there are no callbacks. I didn't yet figure out whether a callback in freeze will trigger a bug, but disable_cb won't address it in any case. So let's remove the useless calls as a first step. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/net/virtio_net.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 019da01..971931e5 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1182,11 +1182,6 @@ static int virtnet_freeze(struct virtio_device *vdev) { struct virtnet_info *vi = vdev->priv; - virtqueue_disable_cb(vi->rvq); - virtqueue_disable_cb(vi->svq); - if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ)) - virtqueue_disable_cb(vi->cvq); - netif_device_detach(vi->dev); cancel_delayed_work_sync(&vi->refill); -- 1.7.9.111.gf3fb0 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH RFC] virtio-net: remove useless disable on freeze @ 2012-04-04 9:19 ` Michael S. Tsirkin 0 siblings, 0 replies; 16+ messages in thread From: Michael S. Tsirkin @ 2012-04-04 9:19 UTC (permalink / raw) To: netdev; +Cc: Rusty Russell, virtualization, linux-kernel, Amit Shah, kvm disable_cb is just an optimization: it can not guarantee that there are no callbacks. I didn't yet figure out whether a callback in freeze will trigger a bug, but disable_cb won't address it in any case. So let's remove the useless calls as a first step. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/net/virtio_net.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 019da01..971931e5 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1182,11 +1182,6 @@ static int virtnet_freeze(struct virtio_device *vdev) { struct virtnet_info *vi = vdev->priv; - virtqueue_disable_cb(vi->rvq); - virtqueue_disable_cb(vi->svq); - if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ)) - virtqueue_disable_cb(vi->cvq); - netif_device_detach(vi->dev); cancel_delayed_work_sync(&vi->refill); -- 1.7.9.111.gf3fb0 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH RFC] virtio-net: remove useless disable on freeze 2012-04-04 9:19 ` Michael S. Tsirkin @ 2012-05-03 10:59 ` Amit Shah -1 siblings, 0 replies; 16+ messages in thread From: Amit Shah @ 2012-05-03 10:59 UTC (permalink / raw) To: Michael S. Tsirkin; +Cc: netdev, linux-kernel, kvm, virtualization On (Wed) 04 Apr 2012 [12:19:55], Michael S. Tsirkin wrote: > disable_cb is just an optimization: it > can not guarantee that there are no callbacks. Even then, what's the harm in keeping it? If indeed there's an attempt to raise an interrupt after the host has been notified, it will be suppressed. Also, disable_cb seems to be used elsewhere in the virtio_net.c file, to suit similar purposes. Amit ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH RFC] virtio-net: remove useless disable on freeze @ 2012-05-03 10:59 ` Amit Shah 0 siblings, 0 replies; 16+ messages in thread From: Amit Shah @ 2012-05-03 10:59 UTC (permalink / raw) To: Michael S. Tsirkin Cc: netdev, Rusty Russell, virtualization, linux-kernel, kvm On (Wed) 04 Apr 2012 [12:19:55], Michael S. Tsirkin wrote: > disable_cb is just an optimization: it > can not guarantee that there are no callbacks. Even then, what's the harm in keeping it? If indeed there's an attempt to raise an interrupt after the host has been notified, it will be suppressed. Also, disable_cb seems to be used elsewhere in the virtio_net.c file, to suit similar purposes. Amit ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH RFC] virtio-net: remove useless disable on freeze 2012-05-03 10:59 ` Amit Shah @ 2012-05-03 11:08 ` Michael S. Tsirkin -1 siblings, 0 replies; 16+ messages in thread From: Michael S. Tsirkin @ 2012-05-03 11:08 UTC (permalink / raw) To: Amit Shah; +Cc: netdev, linux-kernel, kvm, virtualization On Thu, May 03, 2012 at 04:29:59PM +0530, Amit Shah wrote: > On (Wed) 04 Apr 2012 [12:19:55], Michael S. Tsirkin wrote: > > disable_cb is just an optimization: it > > can not guarantee that there are no callbacks. > > Even then, what's the harm in keeping it? If indeed there's an > attempt to raise an interrupt after the host has been notified, it > will be suppressed. It won't. It's not a guarantee, e.g. with event index on it does nothing at all. > Also, disable_cb seems to be used elsewhere in the virtio_net.c file, > to suit similar purposes. > > Amit Where? ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH RFC] virtio-net: remove useless disable on freeze @ 2012-05-03 11:08 ` Michael S. Tsirkin 0 siblings, 0 replies; 16+ messages in thread From: Michael S. Tsirkin @ 2012-05-03 11:08 UTC (permalink / raw) To: Amit Shah; +Cc: netdev, Rusty Russell, virtualization, linux-kernel, kvm On Thu, May 03, 2012 at 04:29:59PM +0530, Amit Shah wrote: > On (Wed) 04 Apr 2012 [12:19:55], Michael S. Tsirkin wrote: > > disable_cb is just an optimization: it > > can not guarantee that there are no callbacks. > > Even then, what's the harm in keeping it? If indeed there's an > attempt to raise an interrupt after the host has been notified, it > will be suppressed. It won't. It's not a guarantee, e.g. with event index on it does nothing at all. > Also, disable_cb seems to be used elsewhere in the virtio_net.c file, > to suit similar purposes. > > Amit Where? ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH RFC] virtio-net: remove useless disable on freeze 2012-04-04 9:19 ` Michael S. Tsirkin @ 2012-05-28 12:53 ` Michael S. Tsirkin -1 siblings, 0 replies; 16+ messages in thread From: Michael S. Tsirkin @ 2012-05-28 12:53 UTC (permalink / raw) To: netdev; +Cc: Amit Shah, linux-kernel, kvm, virtualization On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote: > disable_cb is just an optimization: it > can not guarantee that there are no callbacks. > > I didn't yet figure out whether a callback > in freeze will trigger a bug, but disable_cb > won't address it in any case. So let's remove > the useless calls as a first step. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Looks like this isn't in the 3.5 pull request - just lost in the shuffle? disable_cb is advisory so can't be relied upon. > --- > drivers/net/virtio_net.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 019da01..971931e5 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -1182,11 +1182,6 @@ static int virtnet_freeze(struct virtio_device *vdev) > { > struct virtnet_info *vi = vdev->priv; > > - virtqueue_disable_cb(vi->rvq); > - virtqueue_disable_cb(vi->svq); > - if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ)) > - virtqueue_disable_cb(vi->cvq); > - > netif_device_detach(vi->dev); > cancel_delayed_work_sync(&vi->refill); > > -- > 1.7.9.111.gf3fb0 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH RFC] virtio-net: remove useless disable on freeze @ 2012-05-28 12:53 ` Michael S. Tsirkin 0 siblings, 0 replies; 16+ messages in thread From: Michael S. Tsirkin @ 2012-05-28 12:53 UTC (permalink / raw) To: netdev; +Cc: Rusty Russell, virtualization, linux-kernel, Amit Shah, kvm On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote: > disable_cb is just an optimization: it > can not guarantee that there are no callbacks. > > I didn't yet figure out whether a callback > in freeze will trigger a bug, but disable_cb > won't address it in any case. So let's remove > the useless calls as a first step. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Looks like this isn't in the 3.5 pull request - just lost in the shuffle? disable_cb is advisory so can't be relied upon. > --- > drivers/net/virtio_net.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 019da01..971931e5 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -1182,11 +1182,6 @@ static int virtnet_freeze(struct virtio_device *vdev) > { > struct virtnet_info *vi = vdev->priv; > > - virtqueue_disable_cb(vi->rvq); > - virtqueue_disable_cb(vi->svq); > - if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ)) > - virtqueue_disable_cb(vi->cvq); > - > netif_device_detach(vi->dev); > cancel_delayed_work_sync(&vi->refill); > > -- > 1.7.9.111.gf3fb0 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH RFC] virtio-net: remove useless disable on freeze 2012-05-28 12:53 ` Michael S. Tsirkin @ 2012-05-30 10:11 ` Rusty Russell -1 siblings, 0 replies; 16+ messages in thread From: Rusty Russell @ 2012-05-30 10:11 UTC (permalink / raw) To: Michael S. Tsirkin, netdev; +Cc: Amit Shah, linux-kernel, kvm, virtualization On Mon, 28 May 2012 15:53:25 +0300, "Michael S. Tsirkin" <mst@redhat.com> wrote: > On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote: > > disable_cb is just an optimization: it > > can not guarantee that there are no callbacks. > > > > I didn't yet figure out whether a callback > > in freeze will trigger a bug, but disable_cb > > won't address it in any case. So let's remove > > the useless calls as a first step. > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > Looks like this isn't in the 3.5 pull request - > just lost in the shuffle? > disable_cb is advisory so can't be relied upon. I always (try to?) reply as I accept patches. This one did slip by, but it's harmless so no need to push AFAICT. Applied. Thanks! Rusty. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH RFC] virtio-net: remove useless disable on freeze @ 2012-05-30 10:11 ` Rusty Russell 0 siblings, 0 replies; 16+ messages in thread From: Rusty Russell @ 2012-05-30 10:11 UTC (permalink / raw) To: Michael S. Tsirkin, netdev; +Cc: virtualization, linux-kernel, Amit Shah, kvm On Mon, 28 May 2012 15:53:25 +0300, "Michael S. Tsirkin" <mst@redhat.com> wrote: > On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote: > > disable_cb is just an optimization: it > > can not guarantee that there are no callbacks. > > > > I didn't yet figure out whether a callback > > in freeze will trigger a bug, but disable_cb > > won't address it in any case. So let's remove > > the useless calls as a first step. > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > Looks like this isn't in the 3.5 pull request - > just lost in the shuffle? > disable_cb is advisory so can't be relied upon. I always (try to?) reply as I accept patches. This one did slip by, but it's harmless so no need to push AFAICT. Applied. Thanks! Rusty. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH RFC] virtio-net: remove useless disable on freeze 2012-05-30 10:11 ` Rusty Russell @ 2012-05-31 8:35 ` Stephen Rothwell -1 siblings, 0 replies; 16+ messages in thread From: Stephen Rothwell @ 2012-05-31 8:35 UTC (permalink / raw) To: Rusty Russell Cc: kvm, Michael S. Tsirkin, netdev, linux-kernel, virtualization, Amit Shah [-- Attachment #1.1: Type: text/plain, Size: 1213 bytes --] Hi all, On Wed, 30 May 2012 19:41:47 +0930 Rusty Russell <rusty@rustcorp.com.au> wrote: > > On Mon, 28 May 2012 15:53:25 +0300, "Michael S. Tsirkin" <mst@redhat.com> wrote: > > On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote: > > > disable_cb is just an optimization: it > > > can not guarantee that there are no callbacks. > > > > > > I didn't yet figure out whether a callback > > > in freeze will trigger a bug, but disable_cb > > > won't address it in any case. So let's remove > > > the useless calls as a first step. > > > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > > > Looks like this isn't in the 3.5 pull request - > > just lost in the shuffle? > > disable_cb is advisory so can't be relied upon. > > I always (try to?) reply as I accept patches. > > This one did slip by, but it's harmless so no need to push AFAICT. > > Applied. This patch exists in two trees in linux-next already ... Davem's net tree (so presumably he will send it to Linus shortly) and Michael's vhost tree (is that tree needed any more?). Presumably it is now also in the rr tree? -- Cheers, Stephen Rothwell sfr@canb.auug.org.au [-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --] [-- Attachment #2: Type: text/plain, Size: 183 bytes --] _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH RFC] virtio-net: remove useless disable on freeze @ 2012-05-31 8:35 ` Stephen Rothwell 0 siblings, 0 replies; 16+ messages in thread From: Stephen Rothwell @ 2012-05-31 8:35 UTC (permalink / raw) To: Rusty Russell Cc: Michael S. Tsirkin, netdev, virtualization, linux-kernel, Amit Shah, kvm [-- Attachment #1: Type: text/plain, Size: 1213 bytes --] Hi all, On Wed, 30 May 2012 19:41:47 +0930 Rusty Russell <rusty@rustcorp.com.au> wrote: > > On Mon, 28 May 2012 15:53:25 +0300, "Michael S. Tsirkin" <mst@redhat.com> wrote: > > On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote: > > > disable_cb is just an optimization: it > > > can not guarantee that there are no callbacks. > > > > > > I didn't yet figure out whether a callback > > > in freeze will trigger a bug, but disable_cb > > > won't address it in any case. So let's remove > > > the useless calls as a first step. > > > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > > > Looks like this isn't in the 3.5 pull request - > > just lost in the shuffle? > > disable_cb is advisory so can't be relied upon. > > I always (try to?) reply as I accept patches. > > This one did slip by, but it's harmless so no need to push AFAICT. > > Applied. This patch exists in two trees in linux-next already ... Davem's net tree (so presumably he will send it to Linus shortly) and Michael's vhost tree (is that tree needed any more?). Presumably it is now also in the rr tree? -- Cheers, Stephen Rothwell sfr@canb.auug.org.au [-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH RFC] virtio-net: remove useless disable on freeze 2012-05-31 8:35 ` Stephen Rothwell @ 2012-05-31 8:47 ` Michael S. Tsirkin -1 siblings, 0 replies; 16+ messages in thread From: Michael S. Tsirkin @ 2012-05-31 8:47 UTC (permalink / raw) To: Stephen Rothwell; +Cc: kvm, netdev, linux-kernel, virtualization, Amit Shah On Thu, May 31, 2012 at 06:35:08PM +1000, Stephen Rothwell wrote: > Hi all, > > On Wed, 30 May 2012 19:41:47 +0930 Rusty Russell <rusty@rustcorp.com.au> wrote: > > > > On Mon, 28 May 2012 15:53:25 +0300, "Michael S. Tsirkin" <mst@redhat.com> wrote: > > > On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote: > > > > disable_cb is just an optimization: it > > > > can not guarantee that there are no callbacks. > > > > > > > > I didn't yet figure out whether a callback > > > > in freeze will trigger a bug, but disable_cb > > > > won't address it in any case. So let's remove > > > > the useless calls as a first step. > > > > > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > > > > > Looks like this isn't in the 3.5 pull request - > > > just lost in the shuffle? > > > disable_cb is advisory so can't be relied upon. > > > > I always (try to?) reply as I accept patches. > > > > This one did slip by, but it's harmless so no need to push AFAICT. > > > > Applied. > > This patch exists in two trees in linux-next already ... Davem's net tree > (so presumably he will send it to Linus shortly) and Michael's vhost tree > (is that tree needed any more?). Yes and I dropped the patch from there, just did not push yet. > Presumably it is now also in the rr > tree? > > -- > Cheers, > Stephen Rothwell sfr@canb.auug.org.au ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH RFC] virtio-net: remove useless disable on freeze @ 2012-05-31 8:47 ` Michael S. Tsirkin 0 siblings, 0 replies; 16+ messages in thread From: Michael S. Tsirkin @ 2012-05-31 8:47 UTC (permalink / raw) To: Stephen Rothwell Cc: Rusty Russell, netdev, virtualization, linux-kernel, Amit Shah, kvm On Thu, May 31, 2012 at 06:35:08PM +1000, Stephen Rothwell wrote: > Hi all, > > On Wed, 30 May 2012 19:41:47 +0930 Rusty Russell <rusty@rustcorp.com.au> wrote: > > > > On Mon, 28 May 2012 15:53:25 +0300, "Michael S. Tsirkin" <mst@redhat.com> wrote: > > > On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote: > > > > disable_cb is just an optimization: it > > > > can not guarantee that there are no callbacks. > > > > > > > > I didn't yet figure out whether a callback > > > > in freeze will trigger a bug, but disable_cb > > > > won't address it in any case. So let's remove > > > > the useless calls as a first step. > > > > > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > > > > > Looks like this isn't in the 3.5 pull request - > > > just lost in the shuffle? > > > disable_cb is advisory so can't be relied upon. > > > > I always (try to?) reply as I accept patches. > > > > This one did slip by, but it's harmless so no need to push AFAICT. > > > > Applied. > > This patch exists in two trees in linux-next already ... Davem's net tree > (so presumably he will send it to Linus shortly) and Michael's vhost tree > (is that tree needed any more?). Yes and I dropped the patch from there, just did not push yet. > Presumably it is now also in the rr > tree? > > -- > Cheers, > Stephen Rothwell sfr@canb.auug.org.au ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH RFC] virtio-net: remove useless disable on freeze 2012-05-31 8:47 ` Michael S. Tsirkin @ 2012-05-31 9:04 ` Michael S. Tsirkin -1 siblings, 0 replies; 16+ messages in thread From: Michael S. Tsirkin @ 2012-05-31 9:04 UTC (permalink / raw) To: Stephen Rothwell; +Cc: kvm, netdev, linux-kernel, virtualization, Amit Shah On Thu, May 31, 2012 at 11:47:17AM +0300, Michael S. Tsirkin wrote: > On Thu, May 31, 2012 at 06:35:08PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > On Wed, 30 May 2012 19:41:47 +0930 Rusty Russell <rusty@rustcorp.com.au> wrote: > > > > > > On Mon, 28 May 2012 15:53:25 +0300, "Michael S. Tsirkin" <mst@redhat.com> wrote: > > > > On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote: > > > > > disable_cb is just an optimization: it > > > > > can not guarantee that there are no callbacks. > > > > > > > > > > I didn't yet figure out whether a callback > > > > > in freeze will trigger a bug, but disable_cb > > > > > won't address it in any case. So let's remove > > > > > the useless calls as a first step. > > > > > > > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > > > > > > > Looks like this isn't in the 3.5 pull request - > > > > just lost in the shuffle? > > > > disable_cb is advisory so can't be relied upon. > > > > > > I always (try to?) reply as I accept patches. > > > > > > This one did slip by, but it's harmless so no need to push AFAICT. > > > > > > Applied. > > > > This patch exists in two trees in linux-next already ... Davem's net tree > > (so presumably he will send it to Linus shortly) and Michael's vhost tree > > (is that tree needed any more?). > > Yes and I dropped the patch from there, just did not push yet. pushed. There's usually not too much in my tree but it helps me a lot that it's in linux-next. > > Presumably it is now also in the rr > > tree? > > > > -- > > Cheers, > > Stephen Rothwell sfr@canb.auug.org.au > > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH RFC] virtio-net: remove useless disable on freeze @ 2012-05-31 9:04 ` Michael S. Tsirkin 0 siblings, 0 replies; 16+ messages in thread From: Michael S. Tsirkin @ 2012-05-31 9:04 UTC (permalink / raw) To: Stephen Rothwell Cc: Rusty Russell, netdev, virtualization, linux-kernel, Amit Shah, kvm On Thu, May 31, 2012 at 11:47:17AM +0300, Michael S. Tsirkin wrote: > On Thu, May 31, 2012 at 06:35:08PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > On Wed, 30 May 2012 19:41:47 +0930 Rusty Russell <rusty@rustcorp.com.au> wrote: > > > > > > On Mon, 28 May 2012 15:53:25 +0300, "Michael S. Tsirkin" <mst@redhat.com> wrote: > > > > On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote: > > > > > disable_cb is just an optimization: it > > > > > can not guarantee that there are no callbacks. > > > > > > > > > > I didn't yet figure out whether a callback > > > > > in freeze will trigger a bug, but disable_cb > > > > > won't address it in any case. So let's remove > > > > > the useless calls as a first step. > > > > > > > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > > > > > > > Looks like this isn't in the 3.5 pull request - > > > > just lost in the shuffle? > > > > disable_cb is advisory so can't be relied upon. > > > > > > I always (try to?) reply as I accept patches. > > > > > > This one did slip by, but it's harmless so no need to push AFAICT. > > > > > > Applied. > > > > This patch exists in two trees in linux-next already ... Davem's net tree > > (so presumably he will send it to Linus shortly) and Michael's vhost tree > > (is that tree needed any more?). > > Yes and I dropped the patch from there, just did not push yet. pushed. There's usually not too much in my tree but it helps me a lot that it's in linux-next. > > Presumably it is now also in the rr > > tree? > > > > -- > > Cheers, > > Stephen Rothwell sfr@canb.auug.org.au > > ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2012-05-31 9:04 UTC | newest] Thread overview: 16+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-04-04 9:19 [PATCH RFC] virtio-net: remove useless disable on freeze Michael S. Tsirkin 2012-04-04 9:19 ` Michael S. Tsirkin 2012-05-03 10:59 ` Amit Shah 2012-05-03 10:59 ` Amit Shah 2012-05-03 11:08 ` Michael S. Tsirkin 2012-05-03 11:08 ` Michael S. Tsirkin 2012-05-28 12:53 ` Michael S. Tsirkin 2012-05-28 12:53 ` Michael S. Tsirkin 2012-05-30 10:11 ` Rusty Russell 2012-05-30 10:11 ` Rusty Russell 2012-05-31 8:35 ` Stephen Rothwell 2012-05-31 8:35 ` Stephen Rothwell 2012-05-31 8:47 ` Michael S. Tsirkin 2012-05-31 8:47 ` Michael S. Tsirkin 2012-05-31 9:04 ` Michael S. Tsirkin 2012-05-31 9:04 ` Michael S. Tsirkin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.