All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dong Aisheng <aisheng.dong@freescale.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Shawn Guo <shawn.guo@linaro.org>,
	Hui Wang <jason77.wang@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org
Subject: Re: [PATCH v2 2/2] net: flexcan: add transceiver switch gpios support
Date: Thu, 28 Jun 2012 19:39:03 +0800	[thread overview]
Message-ID: <20120628113902.GK6406@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <4FEC329C.7070004@pengutronix.de>

On Thu, Jun 28, 2012 at 12:31:56PM +0200, Marc Kleine-Budde wrote:
> On 06/28/2012 05:21 AM, Shawn Guo wrote:
> > The flexcan driver has function pointer transceiver_switch defined in
> > flexcan_platform_data for platform codes to hook up their transceiver
> > switch implementation.  However this does not cope with device tree
> > probe.
> > 
> > It's been observed that platforms mostly use gpios to control the
> > switch of flexcan transceiver, like enable and standby.  The patch
> > adds transceiver switch gpios support into flexcan driver, so that
> > platforms booting from device tree can just define properties
> > phy-enable-gpios and phy-standby-gpios to have flexcan driver control
> > the gpios.
> 
> Hmm I'm wondering if transceiver or phy is the correct name here. In
> platform_data it's called transceiver_switch.
> 
Hmm, i also had this wondering.
I quote some info from the spec like:
"The MC33902 is a high speed CAN physical interface. The device 
includes an internal 5.0 V supply for the CAN bus transceiver, and 
requires only a connection to a battery line."

Maybe transceiver is more close to spec.

Regards
Dong Aisheng


WARNING: multiple messages have this Message-ID (diff)
From: aisheng.dong@freescale.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] net: flexcan: add transceiver switch gpios support
Date: Thu, 28 Jun 2012 19:39:03 +0800	[thread overview]
Message-ID: <20120628113902.GK6406@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <4FEC329C.7070004@pengutronix.de>

On Thu, Jun 28, 2012 at 12:31:56PM +0200, Marc Kleine-Budde wrote:
> On 06/28/2012 05:21 AM, Shawn Guo wrote:
> > The flexcan driver has function pointer transceiver_switch defined in
> > flexcan_platform_data for platform codes to hook up their transceiver
> > switch implementation.  However this does not cope with device tree
> > probe.
> > 
> > It's been observed that platforms mostly use gpios to control the
> > switch of flexcan transceiver, like enable and standby.  The patch
> > adds transceiver switch gpios support into flexcan driver, so that
> > platforms booting from device tree can just define properties
> > phy-enable-gpios and phy-standby-gpios to have flexcan driver control
> > the gpios.
> 
> Hmm I'm wondering if transceiver or phy is the correct name here. In
> platform_data it's called transceiver_switch.
> 
Hmm, i also had this wondering.
I quote some info from the spec like:
"The MC33902 is a high speed CAN physical interface. The device 
includes an internal 5.0 V supply for the CAN bus transceiver, and 
requires only a connection to a battery line."

Maybe transceiver is more close to spec.

Regards
Dong Aisheng

  parent reply	other threads:[~2012-06-28 11:44 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28  3:21 [PATCH v2 0/2] flexcan driver updates Shawn Guo
2012-06-28  3:21 ` Shawn Guo
2012-06-28  3:21 ` [PATCH v2 1/2] net: flexcan: clock-frequency is optional for device tree probe Shawn Guo
2012-06-28  3:21   ` Shawn Guo
2012-06-28 11:23   ` Dong Aisheng
2012-06-28 11:23     ` Dong Aisheng
2012-06-28  3:21 ` [PATCH v2 2/2] net: flexcan: add transceiver switch gpios support Shawn Guo
2012-06-28  3:21   ` Shawn Guo
2012-06-28  5:22   ` Lothar Waßmann
2012-06-28  5:22     ` Lothar Waßmann
2012-06-28  5:30     ` Shawn Guo
2012-06-28  5:30       ` Shawn Guo
2012-06-28  6:14   ` Hui Wang
2012-06-28  6:14     ` Hui Wang
2012-06-28  6:34     ` Shawn Guo
2012-06-28  6:34       ` Shawn Guo
2012-06-28  7:01       ` Hui Wang
2012-06-28  7:01         ` Hui Wang
2012-06-28 10:32         ` Marc Kleine-Budde
2012-06-28 10:32           ` Marc Kleine-Budde
2012-06-28 10:31   ` Marc Kleine-Budde
2012-06-28 10:31     ` Marc Kleine-Budde
2012-06-28 11:21     ` Shawn Guo
2012-06-28 11:21       ` Shawn Guo
2012-06-28 11:29       ` Marc Kleine-Budde
2012-06-28 11:29         ` Marc Kleine-Budde
2012-06-28 11:41         ` Shawn Guo
2012-06-28 11:41           ` Shawn Guo
2012-06-28 11:52           ` Shawn Guo
2012-06-28 11:52             ` Shawn Guo
2012-06-28 12:05             ` Shawn Guo
2012-06-28 12:05               ` Shawn Guo
2012-06-28 12:11               ` Dong Aisheng
2012-06-28 12:11                 ` Dong Aisheng
2012-06-28 12:19             ` Lothar Waßmann
2012-06-28 12:19               ` Lothar Waßmann
2012-06-28 12:07           ` Lothar Waßmann
2012-06-28 12:07             ` Lothar Waßmann
2012-06-28 12:13             ` Shawn Guo
2012-06-28 12:13               ` Shawn Guo
2012-06-28 12:24               ` Lothar Waßmann
2012-06-28 12:24                 ` Lothar Waßmann
2012-07-02  2:55                 ` Hui Wang
2012-07-02  2:55                   ` Hui Wang
2012-06-28 12:08           ` Kurt Van Dijck
2012-06-28 12:08             ` Kurt Van Dijck
2012-06-28 12:10             ` Marc Kleine-Budde
2012-06-28 12:10               ` Marc Kleine-Budde
2012-06-28 12:16             ` Shawn Guo
2012-06-28 12:16               ` Shawn Guo
2012-06-28 11:39     ` Dong Aisheng [this message]
2012-06-28 11:39       ` Dong Aisheng
2012-06-28 11:33   ` Dong Aisheng
2012-06-28 11:33     ` Dong Aisheng
2012-06-28 11:46     ` Shawn Guo
2012-06-28 11:46       ` Shawn Guo
2012-06-28 11:48       ` Dong Aisheng
2012-06-28 11:48         ` Dong Aisheng
2012-06-28 12:00         ` Shawn Guo
2012-06-28 12:00           ` Shawn Guo
2012-06-28 12:02         ` Dong Aisheng
2012-06-28 12:02           ` Dong Aisheng
2012-06-28 12:19           ` Shawn Guo
2012-06-28 12:19             ` Shawn Guo
2012-06-28 12:05       ` Marc Kleine-Budde
2012-06-28 12:05         ` Marc Kleine-Budde
2012-06-28 12:18         ` Dong Aisheng
2012-06-28 12:18           ` Dong Aisheng
2012-06-28 12:32           ` Lothar Waßmann
2012-06-28 12:32             ` Lothar Waßmann
2012-06-28 12:40             ` Shawn Guo
2012-06-28 12:40               ` Shawn Guo
2012-06-28 12:47             ` Dong Aisheng
2012-06-28 12:47               ` Dong Aisheng
2012-06-28 12:39           ` Shawn Guo
2012-06-28 12:39             ` Shawn Guo
2012-06-29  9:27           ` Marc Kleine-Budde
2012-06-29  9:27             ` Marc Kleine-Budde
     [not found]   ` <502226AB.4050205@gmail.com>
2012-08-08  9:55     ` Marc Kleine-Budde
2012-08-09  2:39       ` Hui Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120628113902.GK6406@shlinux2.ap.freescale.net \
    --to=aisheng.dong@freescale.com \
    --cc=davem@davemloft.net \
    --cc=jason77.wang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.