All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Shawn Guo <shawn.guo@linaro.org>,
	Hui Wang <jason77.wang@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-can@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] net: flexcan: add transceiver switch gpios support
Date: Thu, 28 Jun 2012 14:10:21 +0200	[thread overview]
Message-ID: <4FEC49AD.1000609@pengutronix.de> (raw)
In-Reply-To: <20120628120835.GA3402@vandijck-laurijssen.be>

[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]

On 06/28/2012 02:08 PM, Kurt Van Dijck wrote:
> On Thu, Jun 28, 2012 at 07:41:10PM +0800, Shawn Guo wrote:
>> On Thu, Jun 28, 2012 at 01:29:19PM +0200, Marc Kleine-Budde wrote:
>>> I mean which name is more precise, do these gpio enable/standy a "phy"
>>> or a "transceiver". For example:
>>> http://www.nxp.com/documents/application_note/AN00094.pdf, this document
>>> says: TJA1041/1041A high speed CAN transceiver.
>>>
>> Isn't term "phy" (physical interface) generally meant to be the same
>> thing as "transceiver"?  I just happened to like the shorter one as
>> what Hui did in his patch.
> 
> 'trx' seemed the right abbreviation
> http://www.acronymfinder.com/TRX.html
> 
> thanks to Oliver, in his email on May 9th.

I was about to propose CamelCase to keep the variable names shorter:

bool transceiverStbyActiveLow;

scnr, Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] net: flexcan: add transceiver switch gpios support
Date: Thu, 28 Jun 2012 14:10:21 +0200	[thread overview]
Message-ID: <4FEC49AD.1000609@pengutronix.de> (raw)
In-Reply-To: <20120628120835.GA3402@vandijck-laurijssen.be>

On 06/28/2012 02:08 PM, Kurt Van Dijck wrote:
> On Thu, Jun 28, 2012 at 07:41:10PM +0800, Shawn Guo wrote:
>> On Thu, Jun 28, 2012 at 01:29:19PM +0200, Marc Kleine-Budde wrote:
>>> I mean which name is more precise, do these gpio enable/standy a "phy"
>>> or a "transceiver". For example:
>>> http://www.nxp.com/documents/application_note/AN00094.pdf, this document
>>> says: TJA1041/1041A high speed CAN transceiver.
>>>
>> Isn't term "phy" (physical interface) generally meant to be the same
>> thing as "transceiver"?  I just happened to like the shorter one as
>> what Hui did in his patch.
> 
> 'trx' seemed the right abbreviation
> http://www.acronymfinder.com/TRX.html
> 
> thanks to Oliver, in his email on May 9th.

I was about to propose CamelCase to keep the variable names shorter:

bool transceiverStbyActiveLow;

scnr, Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120628/667b8137/attachment.sig>

  reply	other threads:[~2012-06-28 12:10 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28  3:21 [PATCH v2 0/2] flexcan driver updates Shawn Guo
2012-06-28  3:21 ` Shawn Guo
2012-06-28  3:21 ` [PATCH v2 1/2] net: flexcan: clock-frequency is optional for device tree probe Shawn Guo
2012-06-28  3:21   ` Shawn Guo
2012-06-28 11:23   ` Dong Aisheng
2012-06-28 11:23     ` Dong Aisheng
2012-06-28  3:21 ` [PATCH v2 2/2] net: flexcan: add transceiver switch gpios support Shawn Guo
2012-06-28  3:21   ` Shawn Guo
2012-06-28  5:22   ` Lothar Waßmann
2012-06-28  5:22     ` Lothar Waßmann
2012-06-28  5:30     ` Shawn Guo
2012-06-28  5:30       ` Shawn Guo
2012-06-28  6:14   ` Hui Wang
2012-06-28  6:14     ` Hui Wang
2012-06-28  6:34     ` Shawn Guo
2012-06-28  6:34       ` Shawn Guo
2012-06-28  7:01       ` Hui Wang
2012-06-28  7:01         ` Hui Wang
2012-06-28 10:32         ` Marc Kleine-Budde
2012-06-28 10:32           ` Marc Kleine-Budde
2012-06-28 10:31   ` Marc Kleine-Budde
2012-06-28 10:31     ` Marc Kleine-Budde
2012-06-28 11:21     ` Shawn Guo
2012-06-28 11:21       ` Shawn Guo
2012-06-28 11:29       ` Marc Kleine-Budde
2012-06-28 11:29         ` Marc Kleine-Budde
2012-06-28 11:41         ` Shawn Guo
2012-06-28 11:41           ` Shawn Guo
2012-06-28 11:52           ` Shawn Guo
2012-06-28 11:52             ` Shawn Guo
2012-06-28 12:05             ` Shawn Guo
2012-06-28 12:05               ` Shawn Guo
2012-06-28 12:11               ` Dong Aisheng
2012-06-28 12:11                 ` Dong Aisheng
2012-06-28 12:19             ` Lothar Waßmann
2012-06-28 12:19               ` Lothar Waßmann
2012-06-28 12:07           ` Lothar Waßmann
2012-06-28 12:07             ` Lothar Waßmann
2012-06-28 12:13             ` Shawn Guo
2012-06-28 12:13               ` Shawn Guo
2012-06-28 12:24               ` Lothar Waßmann
2012-06-28 12:24                 ` Lothar Waßmann
2012-07-02  2:55                 ` Hui Wang
2012-07-02  2:55                   ` Hui Wang
2012-06-28 12:08           ` Kurt Van Dijck
2012-06-28 12:08             ` Kurt Van Dijck
2012-06-28 12:10             ` Marc Kleine-Budde [this message]
2012-06-28 12:10               ` Marc Kleine-Budde
2012-06-28 12:16             ` Shawn Guo
2012-06-28 12:16               ` Shawn Guo
2012-06-28 11:39     ` Dong Aisheng
2012-06-28 11:39       ` Dong Aisheng
2012-06-28 11:33   ` Dong Aisheng
2012-06-28 11:33     ` Dong Aisheng
2012-06-28 11:46     ` Shawn Guo
2012-06-28 11:46       ` Shawn Guo
2012-06-28 11:48       ` Dong Aisheng
2012-06-28 11:48         ` Dong Aisheng
2012-06-28 12:00         ` Shawn Guo
2012-06-28 12:00           ` Shawn Guo
2012-06-28 12:02         ` Dong Aisheng
2012-06-28 12:02           ` Dong Aisheng
2012-06-28 12:19           ` Shawn Guo
2012-06-28 12:19             ` Shawn Guo
2012-06-28 12:05       ` Marc Kleine-Budde
2012-06-28 12:05         ` Marc Kleine-Budde
2012-06-28 12:18         ` Dong Aisheng
2012-06-28 12:18           ` Dong Aisheng
2012-06-28 12:32           ` Lothar Waßmann
2012-06-28 12:32             ` Lothar Waßmann
2012-06-28 12:40             ` Shawn Guo
2012-06-28 12:40               ` Shawn Guo
2012-06-28 12:47             ` Dong Aisheng
2012-06-28 12:47               ` Dong Aisheng
2012-06-28 12:39           ` Shawn Guo
2012-06-28 12:39             ` Shawn Guo
2012-06-29  9:27           ` Marc Kleine-Budde
2012-06-29  9:27             ` Marc Kleine-Budde
     [not found]   ` <502226AB.4050205@gmail.com>
2012-08-08  9:55     ` Marc Kleine-Budde
2012-08-09  2:39       ` Hui Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FEC49AD.1000609@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=davem@davemloft.net \
    --cc=jason77.wang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.