All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3.9] Driver for 7-segment displays connected over GPIOs
Date: Mon, 7 Jan 2013 10:36:42 -0800	[thread overview]
Message-ID: <20130107183642.GA26612@kroah.com> (raw)
In-Reply-To: <20130107185357.6da83d60@skate>

On Mon, Jan 07, 2013 at 06:53:57PM +0100, Thomas Petazzoni wrote:
> Dear Greg Kroah-Hartman,
> 
> On Mon, 7 Jan 2013 09:23:40 -0800, Greg Kroah-Hartman wrote:
> 
> > > Not having a kernel driver means that gazillions of applications
> > > re-invent the same piece of code over and over again, have to hardcode
> > > the GPIO numbers for a given piece of hardware, while the kernel
> > > abstract all of this very nicely.
> > 
> > That sounds like a wonderful use of a userspace library to do this
> > properly.  Much like libusb does, right?
> > 
> > I still think as this can be done in userspace, it probably should be.
> 
> So that's why we have drivers/usb/misc/usbsevseg.c in the kernel, which
> uses sysfs files to output text or numbers on a 7-segment display,
> while it could all be done using libusb from userspace? Seems like back
> in 2008 you Signed-off-by on the patch adding this driver :-)

I don't remember what I committed a month ago, let alone 4 years ago.
So trying to use that as an excuse as to why I should take your patch
isn't a really good idea, sorry :)

As Russell points out, if you want this in the kernel, it needs to have
a good userspace api, and that needs a lot more work than just a single
sysfs file.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Thomas Petazzoni
	<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
	Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 3.9] Driver for 7-segment displays connected over GPIOs
Date: Mon, 7 Jan 2013 10:36:42 -0800	[thread overview]
Message-ID: <20130107183642.GA26612@kroah.com> (raw)
In-Reply-To: <20130107185357.6da83d60@skate>

On Mon, Jan 07, 2013 at 06:53:57PM +0100, Thomas Petazzoni wrote:
> Dear Greg Kroah-Hartman,
> 
> On Mon, 7 Jan 2013 09:23:40 -0800, Greg Kroah-Hartman wrote:
> 
> > > Not having a kernel driver means that gazillions of applications
> > > re-invent the same piece of code over and over again, have to hardcode
> > > the GPIO numbers for a given piece of hardware, while the kernel
> > > abstract all of this very nicely.
> > 
> > That sounds like a wonderful use of a userspace library to do this
> > properly.  Much like libusb does, right?
> > 
> > I still think as this can be done in userspace, it probably should be.
> 
> So that's why we have drivers/usb/misc/usbsevseg.c in the kernel, which
> uses sysfs files to output text or numbers on a 7-segment display,
> while it could all be done using libusb from userspace? Seems like back
> in 2008 you Signed-off-by on the patch adding this driver :-)

I don't remember what I committed a month ago, let alone 4 years ago.
So trying to use that as an excuse as to why I should take your patch
isn't a really good idea, sorry :)

As Russell points out, if you want this in the kernel, it needs to have
a good userspace api, and that needs a lot more work than just a single
sysfs file.

thanks,

greg k-h

  reply	other threads:[~2013-01-07 18:36 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 16:42 [PATCH 3.9] Driver for 7-segment displays connected over GPIOs Thomas Petazzoni
2013-01-07 16:42 ` Thomas Petazzoni
2013-01-07 16:42 ` [PATCH 3.9 1/3] misc: new driver for GPIO-connected 7-segment displays Thomas Petazzoni
2013-01-07 16:42   ` Thomas Petazzoni
2013-01-07 19:43   ` Arnd Bergmann
2013-01-07 19:43     ` Arnd Bergmann
2013-01-07 19:58     ` Thomas Petazzoni
2013-01-07 19:58       ` Thomas Petazzoni
2013-01-07 21:41       ` Arnd Bergmann
2013-01-07 21:41         ` Arnd Bergmann
2013-02-08 22:38         ` Grant Likely
2013-02-08 22:38           ` Grant Likely
2013-02-08 22:35   ` Grant Likely
2013-02-08 22:35     ` Grant Likely
2013-01-07 16:42 ` [PATCH 3.9 2/3] arm: mvebu: add the 7-segment display DT informations to Armada 370 DB Thomas Petazzoni
2013-01-07 16:42   ` Thomas Petazzoni
2013-01-07 16:42 ` [PATCH 3.9 3/3] arm: mvebu: add the 7-segment display DT informations to Armada XP DB Thomas Petazzoni
2013-01-07 16:42   ` Thomas Petazzoni
2013-02-08 22:39   ` Grant Likely
2013-02-08 22:39     ` Grant Likely
2013-01-07 16:48 ` [PATCH 3.9] Driver for 7-segment displays connected over GPIOs Greg Kroah-Hartman
2013-01-07 16:48   ` Greg Kroah-Hartman
2013-01-07 17:07   ` Thomas Petazzoni
2013-01-07 17:07     ` Thomas Petazzoni
2013-01-07 17:23     ` Greg Kroah-Hartman
2013-01-07 17:23       ` Greg Kroah-Hartman
2013-01-07 17:40       ` Thomas Petazzoni
2013-01-07 17:40         ` Thomas Petazzoni
2013-01-07 17:43         ` Thomas Petazzoni
2013-01-07 17:43           ` Thomas Petazzoni
2013-01-07 17:56           ` H Hartley Sweeten
2013-01-07 17:56             ` H Hartley Sweeten
2013-01-07 18:02             ` Jason Cooper
2013-01-07 18:02               ` Jason Cooper
2013-01-07 18:06           ` Russell King - ARM Linux
2013-01-07 18:06             ` Russell King - ARM Linux
2013-01-07 17:53       ` Thomas Petazzoni
2013-01-07 17:53         ` Thomas Petazzoni
2013-01-07 18:36         ` Greg Kroah-Hartman [this message]
2013-01-07 18:36           ` Greg Kroah-Hartman
2013-01-07 18:38           ` Thomas Petazzoni
2013-01-07 18:38             ` Thomas Petazzoni
2013-01-07 23:05 ` Linus Walleij
2013-01-07 23:05   ` Linus Walleij
2013-02-09 16:28   ` Pavel Machek
2013-02-09 16:28     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130107183642.GA26612@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.