From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3.9 3/3] arm: mvebu: add the 7-segment display DT informations to Armada XP DB
Date: Fri, 08 Feb 2013 22:39:45 +0000 [thread overview]
Message-ID: <20130208223945.D316E3E2C27@localhost> (raw)
In-Reply-To: <1357576928-29133-4-git-send-email-thomas.petazzoni@free-electrons.com>
On Mon, 7 Jan 2013 17:42:08 +0100, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Now that we have a 7-segment display driver in the kernel, use it on
> the Marvell Armada XP DB evaluation board.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> arch/arm/boot/dts/armada-xp-db.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-xp-db.dts b/arch/arm/boot/dts/armada-xp-db.dts
> index 8e53b25..8654c1b 100644
> --- a/arch/arm/boot/dts/armada-xp-db.dts
> +++ b/arch/arm/boot/dts/armada-xp-db.dts
> @@ -90,5 +90,10 @@
> phy = <&phy3>;
> phy-mode = "sgmii";
> };
> + gpio-7seg at 0 {
> + compatible = "generic,gpio-7seg";
> + status = "okay";
> + gpios = <&gpio0 26 0 &gpio0 27 0 &gpio1 16 0>;
> + };
Nit: The node probably belongs at the base of the tree. A direct child
of the root node because it really doen't make sense as a child of
anything else. It's more of a system level device.
g.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Cc: Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 3.9 3/3] arm: mvebu: add the 7-segment display DT informations to Armada XP DB
Date: Fri, 08 Feb 2013 22:39:45 +0000 [thread overview]
Message-ID: <20130208223945.D316E3E2C27@localhost> (raw)
In-Reply-To: <1357576928-29133-4-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
On Mon, 7 Jan 2013 17:42:08 +0100, Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> Now that we have a 7-segment display driver in the kernel, use it on
> the Marvell Armada XP DB evaluation board.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> ---
> arch/arm/boot/dts/armada-xp-db.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-xp-db.dts b/arch/arm/boot/dts/armada-xp-db.dts
> index 8e53b25..8654c1b 100644
> --- a/arch/arm/boot/dts/armada-xp-db.dts
> +++ b/arch/arm/boot/dts/armada-xp-db.dts
> @@ -90,5 +90,10 @@
> phy = <&phy3>;
> phy-mode = "sgmii";
> };
> + gpio-7seg@0 {
> + compatible = "generic,gpio-7seg";
> + status = "okay";
> + gpios = <&gpio0 26 0 &gpio0 27 0 &gpio1 16 0>;
> + };
Nit: The node probably belongs at the base of the tree. A direct child
of the root node because it really doen't make sense as a child of
anything else. It's more of a system level device.
g.
next prev parent reply other threads:[~2013-02-08 22:39 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 16:42 [PATCH 3.9] Driver for 7-segment displays connected over GPIOs Thomas Petazzoni
2013-01-07 16:42 ` Thomas Petazzoni
2013-01-07 16:42 ` [PATCH 3.9 1/3] misc: new driver for GPIO-connected 7-segment displays Thomas Petazzoni
2013-01-07 16:42 ` Thomas Petazzoni
2013-01-07 19:43 ` Arnd Bergmann
2013-01-07 19:43 ` Arnd Bergmann
2013-01-07 19:58 ` Thomas Petazzoni
2013-01-07 19:58 ` Thomas Petazzoni
2013-01-07 21:41 ` Arnd Bergmann
2013-01-07 21:41 ` Arnd Bergmann
2013-02-08 22:38 ` Grant Likely
2013-02-08 22:38 ` Grant Likely
2013-02-08 22:35 ` Grant Likely
2013-02-08 22:35 ` Grant Likely
2013-01-07 16:42 ` [PATCH 3.9 2/3] arm: mvebu: add the 7-segment display DT informations to Armada 370 DB Thomas Petazzoni
2013-01-07 16:42 ` Thomas Petazzoni
2013-01-07 16:42 ` [PATCH 3.9 3/3] arm: mvebu: add the 7-segment display DT informations to Armada XP DB Thomas Petazzoni
2013-01-07 16:42 ` Thomas Petazzoni
2013-02-08 22:39 ` Grant Likely [this message]
2013-02-08 22:39 ` Grant Likely
2013-01-07 16:48 ` [PATCH 3.9] Driver for 7-segment displays connected over GPIOs Greg Kroah-Hartman
2013-01-07 16:48 ` Greg Kroah-Hartman
2013-01-07 17:07 ` Thomas Petazzoni
2013-01-07 17:07 ` Thomas Petazzoni
2013-01-07 17:23 ` Greg Kroah-Hartman
2013-01-07 17:23 ` Greg Kroah-Hartman
2013-01-07 17:40 ` Thomas Petazzoni
2013-01-07 17:40 ` Thomas Petazzoni
2013-01-07 17:43 ` Thomas Petazzoni
2013-01-07 17:43 ` Thomas Petazzoni
2013-01-07 17:56 ` H Hartley Sweeten
2013-01-07 17:56 ` H Hartley Sweeten
2013-01-07 18:02 ` Jason Cooper
2013-01-07 18:02 ` Jason Cooper
2013-01-07 18:06 ` Russell King - ARM Linux
2013-01-07 18:06 ` Russell King - ARM Linux
2013-01-07 17:53 ` Thomas Petazzoni
2013-01-07 17:53 ` Thomas Petazzoni
2013-01-07 18:36 ` Greg Kroah-Hartman
2013-01-07 18:36 ` Greg Kroah-Hartman
2013-01-07 18:38 ` Thomas Petazzoni
2013-01-07 18:38 ` Thomas Petazzoni
2013-01-07 23:05 ` Linus Walleij
2013-01-07 23:05 ` Linus Walleij
2013-02-09 16:28 ` Pavel Machek
2013-02-09 16:28 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130208223945.D316E3E2C27@localhost \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.