All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3.9] Driver for 7-segment displays connected over GPIOs
Date: Mon, 7 Jan 2013 08:48:45 -0800	[thread overview]
Message-ID: <20130107164845.GA2911@kroah.com> (raw)
In-Reply-To: <1357576928-29133-1-git-send-email-thomas.petazzoni@free-electrons.com>

On Mon, Jan 07, 2013 at 05:42:05PM +0100, Thomas Petazzoni wrote:
> Dear drivers/{char,misc}/ maintainers,
> 
> This patch series implements a simple driver for 7-segment displays
> connected over GPIOs through a BCD encoder. The userspace interface of
> the driver is very simple: just a "value" file in the sysfs directory
> of the device, which can be written to (changes the value shown on the
> 7-segment display) and read (gives the current value).

If you ever add/remove/modify sysfs files, you have to also do the same
for the Documentation/ABI/ files as well, please redo that in this patch
series.

But, the bigger question is, why is this a kernel driver at all?  Can't
you do this from userspace today without any new kernel code?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Thomas Petazzoni
	<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
	Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 3.9] Driver for 7-segment displays connected over GPIOs
Date: Mon, 7 Jan 2013 08:48:45 -0800	[thread overview]
Message-ID: <20130107164845.GA2911@kroah.com> (raw)
In-Reply-To: <1357576928-29133-1-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

On Mon, Jan 07, 2013 at 05:42:05PM +0100, Thomas Petazzoni wrote:
> Dear drivers/{char,misc}/ maintainers,
> 
> This patch series implements a simple driver for 7-segment displays
> connected over GPIOs through a BCD encoder. The userspace interface of
> the driver is very simple: just a "value" file in the sysfs directory
> of the device, which can be written to (changes the value shown on the
> 7-segment display) and read (gives the current value).

If you ever add/remove/modify sysfs files, you have to also do the same
for the Documentation/ABI/ files as well, please redo that in this patch
series.

But, the bigger question is, why is this a kernel driver at all?  Can't
you do this from userspace today without any new kernel code?

thanks,

greg k-h

  parent reply	other threads:[~2013-01-07 16:48 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 16:42 [PATCH 3.9] Driver for 7-segment displays connected over GPIOs Thomas Petazzoni
2013-01-07 16:42 ` Thomas Petazzoni
2013-01-07 16:42 ` [PATCH 3.9 1/3] misc: new driver for GPIO-connected 7-segment displays Thomas Petazzoni
2013-01-07 16:42   ` Thomas Petazzoni
2013-01-07 19:43   ` Arnd Bergmann
2013-01-07 19:43     ` Arnd Bergmann
2013-01-07 19:58     ` Thomas Petazzoni
2013-01-07 19:58       ` Thomas Petazzoni
2013-01-07 21:41       ` Arnd Bergmann
2013-01-07 21:41         ` Arnd Bergmann
2013-02-08 22:38         ` Grant Likely
2013-02-08 22:38           ` Grant Likely
2013-02-08 22:35   ` Grant Likely
2013-02-08 22:35     ` Grant Likely
2013-01-07 16:42 ` [PATCH 3.9 2/3] arm: mvebu: add the 7-segment display DT informations to Armada 370 DB Thomas Petazzoni
2013-01-07 16:42   ` Thomas Petazzoni
2013-01-07 16:42 ` [PATCH 3.9 3/3] arm: mvebu: add the 7-segment display DT informations to Armada XP DB Thomas Petazzoni
2013-01-07 16:42   ` Thomas Petazzoni
2013-02-08 22:39   ` Grant Likely
2013-02-08 22:39     ` Grant Likely
2013-01-07 16:48 ` Greg Kroah-Hartman [this message]
2013-01-07 16:48   ` [PATCH 3.9] Driver for 7-segment displays connected over GPIOs Greg Kroah-Hartman
2013-01-07 17:07   ` Thomas Petazzoni
2013-01-07 17:07     ` Thomas Petazzoni
2013-01-07 17:23     ` Greg Kroah-Hartman
2013-01-07 17:23       ` Greg Kroah-Hartman
2013-01-07 17:40       ` Thomas Petazzoni
2013-01-07 17:40         ` Thomas Petazzoni
2013-01-07 17:43         ` Thomas Petazzoni
2013-01-07 17:43           ` Thomas Petazzoni
2013-01-07 17:56           ` H Hartley Sweeten
2013-01-07 17:56             ` H Hartley Sweeten
2013-01-07 18:02             ` Jason Cooper
2013-01-07 18:02               ` Jason Cooper
2013-01-07 18:06           ` Russell King - ARM Linux
2013-01-07 18:06             ` Russell King - ARM Linux
2013-01-07 17:53       ` Thomas Petazzoni
2013-01-07 17:53         ` Thomas Petazzoni
2013-01-07 18:36         ` Greg Kroah-Hartman
2013-01-07 18:36           ` Greg Kroah-Hartman
2013-01-07 18:38           ` Thomas Petazzoni
2013-01-07 18:38             ` Thomas Petazzoni
2013-01-07 23:05 ` Linus Walleij
2013-01-07 23:05   ` Linus Walleij
2013-02-09 16:28   ` Pavel Machek
2013-02-09 16:28     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130107164845.GA2911@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.