From: Andrew Murray <andrew.murray@arm.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Jingoo Han <jg1.han@samsung.com>,
"'Kukjin Kim'" <kgene.kim@samsung.com>,
"'Bjorn Helgaas'" <bhelgaas@google.com>,
"'Jason Gunthorpe'" <jgunthorpe@obsidianresearch.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"'Siva Reddy Kallam'" <siva.kallam@samsung.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"'Thierry Reding'" <thierry.reding@avionic-design.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"'Grant Likely'" <grant.likely@secretlab.ca>,
"'Surendranath Gurivireddy Balla'" <suren.reddy@samsung.com>,
"'Thomas Abraham'" <thomas.abraham@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/6] of/pci: Provide support for parsing PCI DT ranges property
Date: Mon, 25 Mar 2013 10:21:06 +0000 [thread overview]
Message-ID: <20130325102106.GA20770@arm.com> (raw)
In-Reply-To: <20130323143704.5da5d20c@skate>
On Sat, Mar 23, 2013 at 01:37:04PM +0000, Thomas Petazzoni wrote:
>
> On Sat, 23 Mar 2013 10:41:56 +0000, Russell King - ARM Linux wrote:
>
> > Please look at how IORESOURCE_* stuff is defined:
> > #define IORESOURCE_TYPE_BITS 0x00001f00 /* Resource type */
> > #define IORESOURCE_IO 0x00000100 /* PCI/ISA I/O ports */
> > #define IORESOURCE_MEM 0x00000200
> > #define IORESOURCE_REG 0x00000300 /* Register offsets */
> > #define IORESOURCE_IRQ 0x00000400
> > #define IORESOURCE_DMA 0x00000800
> > #define IORESOURCE_BUS 0x00001000
> >
> > Notice that it's not an array of bits.
> >
> > So this should be:
> > if ((iter.flags & IORESOURCE_TYPE_BITS) == IORESOURCE_IO) {
>
> What I've done for the Marvell PCIe driver is:
>
> + for_each_of_pci_range(&iter, np) {
> + unsigned long restype = iter.flags & IORESOURCE_TYPE_BITS;
> + if (restype == IORESOURCE_IO) {
> [...]
> + if (restype == IORESOURCE_MEM) {
> [...]
OK I'll update this patch and also include Thierry's suggestions.
Andrew Murray
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Murray <andrew.murray-5wv7dgnIgG8@public.gmane.org>
To: Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: 'Kukjin Kim' <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Russell King - ARM Linux
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
'Siva Reddy Kallam'
<siva.kallam-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
"linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
'Jason Gunthorpe'
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
"linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
'Bjorn Helgaas'
<bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
'Surendranath Gurivireddy Balla'
<suren.reddy-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 1/6] of/pci: Provide support for parsing PCI DT ranges property
Date: Mon, 25 Mar 2013 10:21:06 +0000 [thread overview]
Message-ID: <20130325102106.GA20770@arm.com> (raw)
In-Reply-To: <20130323143704.5da5d20c@skate>
On Sat, Mar 23, 2013 at 01:37:04PM +0000, Thomas Petazzoni wrote:
>
> On Sat, 23 Mar 2013 10:41:56 +0000, Russell King - ARM Linux wrote:
>
> > Please look at how IORESOURCE_* stuff is defined:
> > #define IORESOURCE_TYPE_BITS 0x00001f00 /* Resource type */
> > #define IORESOURCE_IO 0x00000100 /* PCI/ISA I/O ports */
> > #define IORESOURCE_MEM 0x00000200
> > #define IORESOURCE_REG 0x00000300 /* Register offsets */
> > #define IORESOURCE_IRQ 0x00000400
> > #define IORESOURCE_DMA 0x00000800
> > #define IORESOURCE_BUS 0x00001000
> >
> > Notice that it's not an array of bits.
> >
> > So this should be:
> > if ((iter.flags & IORESOURCE_TYPE_BITS) == IORESOURCE_IO) {
>
> What I've done for the Marvell PCIe driver is:
>
> + for_each_of_pci_range(&iter, np) {
> + unsigned long restype = iter.flags & IORESOURCE_TYPE_BITS;
> + if (restype == IORESOURCE_IO) {
> [...]
> + if (restype == IORESOURCE_MEM) {
> [...]
OK I'll update this patch and also include Thierry's suggestions.
Andrew Murray
WARNING: multiple messages have this Message-ID (diff)
From: andrew.murray@arm.com (Andrew Murray)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] of/pci: Provide support for parsing PCI DT ranges property
Date: Mon, 25 Mar 2013 10:21:06 +0000 [thread overview]
Message-ID: <20130325102106.GA20770@arm.com> (raw)
In-Reply-To: <20130323143704.5da5d20c@skate>
On Sat, Mar 23, 2013 at 01:37:04PM +0000, Thomas Petazzoni wrote:
>
> On Sat, 23 Mar 2013 10:41:56 +0000, Russell King - ARM Linux wrote:
>
> > Please look at how IORESOURCE_* stuff is defined:
> > #define IORESOURCE_TYPE_BITS 0x00001f00 /* Resource type */
> > #define IORESOURCE_IO 0x00000100 /* PCI/ISA I/O ports */
> > #define IORESOURCE_MEM 0x00000200
> > #define IORESOURCE_REG 0x00000300 /* Register offsets */
> > #define IORESOURCE_IRQ 0x00000400
> > #define IORESOURCE_DMA 0x00000800
> > #define IORESOURCE_BUS 0x00001000
> >
> > Notice that it's not an array of bits.
> >
> > So this should be:
> > if ((iter.flags & IORESOURCE_TYPE_BITS) == IORESOURCE_IO) {
>
> What I've done for the Marvell PCIe driver is:
>
> + for_each_of_pci_range(&iter, np) {
> + unsigned long restype = iter.flags & IORESOURCE_TYPE_BITS;
> + if (restype == IORESOURCE_IO) {
> [...]
> + if (restype == IORESOURCE_MEM) {
> [...]
OK I'll update this patch and also include Thierry's suggestions.
Andrew Murray
next prev parent reply other threads:[~2013-03-25 10:21 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-23 4:04 [PATCH 1/6] of/pci: Provide support for parsing PCI DT ranges property Jingoo Han
2013-03-23 4:04 ` Jingoo Han
2013-03-23 4:05 ` [PATCH 2/6] of/pci: Add of_pci_parse_bus_range() function Jingoo Han
2013-03-23 4:05 ` Jingoo Han
2013-03-23 4:05 ` Jingoo Han
2013-03-23 4:06 ` [PATCH 3/6] pci: infrastructure to add drivers in drivers/pci/host Jingoo Han
2013-03-23 4:06 ` Jingoo Han
2013-03-23 4:07 ` [PATCH 4/6] pci: Add PCIe driver for Samsung Exynos Jingoo Han
2013-03-23 4:07 ` Jingoo Han
2013-03-23 4:07 ` Jingoo Han
2013-03-26 21:33 ` Rob Herring
2013-03-26 21:33 ` Rob Herring
2013-03-27 1:29 ` Jingoo Han
2013-03-27 1:29 ` Jingoo Han
2013-03-23 4:08 ` [PATCH 5/6] ARM: EXYNOS: Enable PCIe support for Exynos5440 Jingoo Han
2013-03-23 4:08 ` Jingoo Han
2013-03-23 4:09 ` [PATCH 6/6] ARM: dts: Add pcie controller node for Samsung EXYNOS5440 SoC Jingoo Han
2013-03-23 4:09 ` Jingoo Han
2013-03-25 17:04 ` Jason Gunthorpe
2013-03-25 17:04 ` Jason Gunthorpe
2013-03-27 8:35 ` Jingoo Han
2013-03-27 8:35 ` Jingoo Han
2013-03-27 8:35 ` Jingoo Han
2013-03-27 16:13 ` Jason Gunthorpe
2013-03-27 16:13 ` Jason Gunthorpe
2013-04-08 9:08 ` Jingoo Han
2013-04-08 9:08 ` Jingoo Han
2013-04-08 9:08 ` Jingoo Han
2013-04-08 16:56 ` Jason Gunthorpe
2013-04-08 16:56 ` Jason Gunthorpe
2013-06-07 9:19 ` Jingoo Han
2013-06-07 9:19 ` Jingoo Han
2013-06-07 11:59 ` Arnd Bergmann
2013-06-07 11:59 ` Arnd Bergmann
2013-06-07 16:20 ` Jason Gunthorpe
2013-06-07 16:20 ` Jason Gunthorpe
2013-06-07 17:43 ` Arnd Bergmann
2013-06-07 17:43 ` Arnd Bergmann
2013-06-10 8:38 ` Jingoo Han
2013-06-10 8:38 ` Jingoo Han
2013-06-10 15:22 ` Arnd Bergmann
2013-06-10 15:22 ` Arnd Bergmann
2013-06-11 6:00 ` Jingoo Han
2013-06-11 6:00 ` Jingoo Han
2013-06-12 15:10 ` Arnd Bergmann
2013-06-12 15:10 ` Arnd Bergmann
2013-03-23 10:41 ` [PATCH 1/6] of/pci: Provide support for parsing PCI DT ranges property Russell King - ARM Linux
2013-03-23 10:41 ` Russell King - ARM Linux
2013-03-23 13:37 ` Thomas Petazzoni
2013-03-23 13:37 ` Thomas Petazzoni
2013-03-25 10:21 ` Andrew Murray [this message]
2013-03-25 10:21 ` Andrew Murray
2013-03-25 10:21 ` Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325102106.GA20770@arm.com \
--to=andrew.murray@arm.com \
--cc=bhelgaas@google.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jg1.han@samsung.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=siva.kallam@samsung.com \
--cc=suren.reddy@samsung.com \
--cc=thierry.reding@avionic-design.de \
--cc=thomas.abraham@linaro.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.