From: Simon Guinot <simon.guinot@sequanux.org>
To: Arnaud Ebalard <arno@natisbad.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <khali@linux-fr.org>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
lm-sensors@lm-sensors.org, devicetree-discuss@lists.ozlabs.org,
Rob Landley <rob@landley.net>,
linux-doc@vger.kernel.org,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
Olivier Mouchet <olivier.mouchet@gmail.com>
Subject: Re: [lm-sensors] [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan controller
Date: Sat, 27 Apr 2013 14:03:31 +0000 [thread overview]
Message-ID: <20130427140331.GL17771@kw.sim.vm.gnt> (raw)
In-Reply-To: <63961d39aee9db94767f28fd441312bec2029473.1366753420.git.arno@natisbad.org>
[-- Attachment #1.1: Type: text/plain, Size: 664 bytes --]
On Wed, Apr 24, 2013 at 12:05:56AM +0200, Arnaud Ebalard wrote:
> + /*
> + * Set default configuration values before passing the structure
> + * to OF helpers to overload them using those provided by .dts
> + * file (if any). Final config is then commited.
> + */
> + g762_config_init(&conf);
> + g762_config_of_overload(client, &conf);
> + err = g762_config_commit(client, &conf);
> + if (err)
> + goto out;
One more comment... Sorry for the multiple replies :)
I am not sure that applying a configuration anyway is a good idea.
I think it could be best to stick with the bootloader configuration if
no platform data nor device tree data are given.
Simon
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: simon.guinot@sequanux.org (Simon Guinot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan controller
Date: Sat, 27 Apr 2013 16:03:31 +0200 [thread overview]
Message-ID: <20130427140331.GL17771@kw.sim.vm.gnt> (raw)
In-Reply-To: <63961d39aee9db94767f28fd441312bec2029473.1366753420.git.arno@natisbad.org>
On Wed, Apr 24, 2013 at 12:05:56AM +0200, Arnaud Ebalard wrote:
> + /*
> + * Set default configuration values before passing the structure
> + * to OF helpers to overload them using those provided by .dts
> + * file (if any). Final config is then commited.
> + */
> + g762_config_init(&conf);
> + g762_config_of_overload(client, &conf);
> + err = g762_config_commit(client, &conf);
> + if (err)
> + goto out;
One more comment... Sorry for the multiple replies :)
I am not sure that applying a configuration anyway is a good idea.
I think it could be best to stick with the bootloader configuration if
no platform data nor device tree data are given.
Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130427/d3d421c7/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Guinot <simon.guinot@sequanux.org>
To: Arnaud Ebalard <arno@natisbad.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <khali@linux-fr.org>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
lm-sensors@lm-sensors.org, devicetree-discuss@lists.ozlabs.org,
Rob Landley <rob@landley.net>,
linux-doc@vger.kernel.org,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
Olivier Mouchet <olivier.mouchet@gmail.com>
Subject: Re: [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan controller
Date: Sat, 27 Apr 2013 16:03:31 +0200 [thread overview]
Message-ID: <20130427140331.GL17771@kw.sim.vm.gnt> (raw)
In-Reply-To: <63961d39aee9db94767f28fd441312bec2029473.1366753420.git.arno@natisbad.org>
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
On Wed, Apr 24, 2013 at 12:05:56AM +0200, Arnaud Ebalard wrote:
> + /*
> + * Set default configuration values before passing the structure
> + * to OF helpers to overload them using those provided by .dts
> + * file (if any). Final config is then commited.
> + */
> + g762_config_init(&conf);
> + g762_config_of_overload(client, &conf);
> + err = g762_config_commit(client, &conf);
> + if (err)
> + goto out;
One more comment... Sorry for the multiple replies :)
I am not sure that applying a configuration anyway is a good idea.
I think it could be best to stick with the bootloader configuration if
no platform data nor device tree data are given.
Simon
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-04-27 14:03 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 22:27 [lm-sensors] [RFC, PATCHv0 0/3] Add support for GMT G762/G763 PWM fan controller Arnaud Ebalard
2013-04-18 22:27 ` [RFC,PATCHv0 " Arnaud Ebalard
2013-04-18 22:27 ` Arnaud Ebalard
2013-04-18 22:28 ` [lm-sensors] [PATCH 1/3] Add support for GMT G72/G763 " Arnaud Ebalard
2013-04-18 22:28 ` Arnaud Ebalard
2013-04-18 22:28 ` Arnaud Ebalard
2013-04-19 4:35 ` [lm-sensors] " Guenter Roeck
2013-04-19 4:35 ` Guenter Roeck
2013-04-19 4:35 ` Guenter Roeck
2013-04-19 5:34 ` [lm-sensors] " Arnaud Ebalard
2013-04-19 5:34 ` Arnaud Ebalard
2013-04-19 5:34 ` Arnaud Ebalard
2013-04-23 22:05 ` [lm-sensors] [PATCHv1 0/3] hwmon: " Arnaud Ebalard
2013-04-23 22:05 ` Arnaud Ebalard
2013-04-23 22:05 ` Arnaud Ebalard
2013-04-23 22:05 ` [lm-sensors] [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 " Arnaud Ebalard
2013-04-23 22:05 ` Arnaud Ebalard
2013-04-23 22:05 ` Arnaud Ebalard
2013-04-24 5:37 ` [lm-sensors] " Andrew Lunn
2013-04-24 5:37 ` Andrew Lunn
2013-04-24 5:37 ` Andrew Lunn
2013-04-24 9:06 ` [lm-sensors] " Arnaud Ebalard
2013-04-24 9:06 ` Arnaud Ebalard
2013-04-24 9:06 ` Arnaud Ebalard
2013-04-24 10:04 ` [lm-sensors] " Simon Guinot
2013-04-24 10:04 ` Simon Guinot
2013-04-24 10:04 ` Simon Guinot
2013-04-24 10:50 ` [lm-sensors] " Arnaud Ebalard
2013-04-24 10:50 ` Arnaud Ebalard
2013-04-24 10:50 ` Arnaud Ebalard
2013-04-24 13:38 ` [lm-sensors] " Guenter Roeck
2013-04-24 13:38 ` Guenter Roeck
2013-04-24 13:38 ` Guenter Roeck
2013-04-24 20:28 ` [lm-sensors] " Arnaud Ebalard
2013-04-24 20:28 ` Arnaud Ebalard
2013-04-24 20:28 ` Arnaud Ebalard
2013-04-24 22:47 ` [lm-sensors] " Guenter Roeck
2013-04-24 22:47 ` Guenter Roeck
2013-04-24 22:47 ` Guenter Roeck
2013-04-25 10:14 ` [lm-sensors] " Simon Guinot
2013-04-25 10:14 ` Simon Guinot
2013-04-25 10:14 ` Simon Guinot
2013-04-24 17:06 ` [lm-sensors] " Simon Guinot
2013-04-24 17:06 ` Simon Guinot
2013-04-24 17:06 ` Simon Guinot
2013-04-24 23:37 ` [lm-sensors] " Guenter Roeck
2013-04-24 23:37 ` Guenter Roeck
2013-04-24 23:37 ` Guenter Roeck
2013-04-25 9:58 ` [lm-sensors] " Simon Guinot
2013-04-25 9:58 ` Simon Guinot
2013-04-25 9:58 ` Simon Guinot
2013-04-27 14:03 ` Simon Guinot [this message]
2013-04-27 14:03 ` Simon Guinot
2013-04-27 14:03 ` Simon Guinot
2013-04-27 14:12 ` [lm-sensors] " Jean Delvare
2013-04-27 14:12 ` Jean Delvare
2013-04-27 14:12 ` Jean Delvare
2013-04-27 16:56 ` [lm-sensors] " Guenter Roeck
2013-04-27 16:56 ` Guenter Roeck
2013-04-27 16:56 ` Guenter Roeck
2013-04-27 18:55 ` [lm-sensors] " Arnaud Ebalard
2013-04-27 18:55 ` Arnaud Ebalard
2013-04-27 18:55 ` Arnaud Ebalard
2013-04-23 22:06 ` [lm-sensors] [PATCHv1 2/3] hwmon: Add documentation for g762 driver Arnaud Ebalard
2013-04-23 22:06 ` Arnaud Ebalard
2013-04-23 22:06 ` Arnaud Ebalard
2013-04-24 17:32 ` [lm-sensors] " Guenter Roeck
2013-04-24 17:32 ` Guenter Roeck
2013-04-24 17:32 ` Guenter Roeck
2013-04-24 20:33 ` [lm-sensors] " Arnaud Ebalard
2013-04-24 20:33 ` Arnaud Ebalard
2013-04-24 20:33 ` Arnaud Ebalard
2013-04-23 22:06 ` [lm-sensors] [PATCHv1 3/3] hwmon: Add DT " Arnaud Ebalard
2013-04-23 22:06 ` Arnaud Ebalard
2013-04-23 22:06 ` Arnaud Ebalard
2013-04-23 22:23 ` [lm-sensors] " Jason Cooper
2013-04-23 22:23 ` Jason Cooper
2013-04-23 22:23 ` Jason Cooper
2013-04-24 5:43 ` [lm-sensors] " Arnaud Ebalard
2013-04-24 5:43 ` Arnaud Ebalard
2013-04-24 5:43 ` Arnaud Ebalard
2013-04-19 5:50 ` [lm-sensors] [PATCH 1/3] Add support for GMT G72/G763 PWM fan controller Andrew Lunn
2013-04-19 5:50 ` Andrew Lunn
2013-04-19 5:50 ` Andrew Lunn
2013-04-19 11:30 ` [lm-sensors] " Arnaud Ebalard
2013-04-19 11:30 ` Arnaud Ebalard
2013-04-19 11:30 ` Arnaud Ebalard
2013-04-19 13:37 ` [lm-sensors] " Guenter Roeck
2013-04-19 13:37 ` Guenter Roeck
2013-04-19 13:37 ` Guenter Roeck
2013-04-19 6:05 ` [lm-sensors] " Jean Delvare
2013-04-19 6:05 ` Jean Delvare
2013-04-19 6:05 ` Jean Delvare
2013-04-19 11:31 ` [lm-sensors] " Arnaud Ebalard
2013-04-19 11:31 ` Arnaud Ebalard
2013-04-19 11:31 ` Arnaud Ebalard
2013-04-18 22:28 ` [lm-sensors] [RFC, PATCHv0 2/3] Add DT documentation for G762 " Arnaud Ebalard
2013-04-18 22:28 ` [RFC,PATCHv0 " Arnaud Ebalard
2013-04-18 22:28 ` Arnaud Ebalard
2013-04-18 22:28 ` [lm-sensors] [PATCH 3/3] Add documentation for g762 driver Arnaud Ebalard
2013-04-18 22:28 ` Arnaud Ebalard
2013-04-18 22:28 ` Arnaud Ebalard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130427140331.GL17771@kw.sim.vm.gnt \
--to=simon.guinot@sequanux.org \
--cc=andrew@lunn.ch \
--cc=arno@natisbad.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jason@lakedaemon.net \
--cc=khali@linux-fr.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=olivier.mouchet@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.