Re: [lm-sensors] [PATCHv1 2/3] hwmon: Add documentation for g762 driver

[arno@natisbad.org (Arnaud Ebalard)]

Hi,

Guenter Roeck <linux@roeck-us.net> writes:

> On Wed, Apr 24, 2013 at 12:06:08AM +0200, Arnaud Ebalard wrote:
>> 
>> Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
>> ---
>>  Documentation/hwmon/g762 |   67 ++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 67 insertions(+)
>>  create mode 100644 Documentation/hwmon/g762
>> 
>> diff --git a/Documentation/hwmon/g762 b/Documentation/hwmon/g762
>> new file mode 100644
>> index 0000000..5015829
>> --- /dev/null
>> +++ b/Documentation/hwmon/g762
>> @@ -0,0 +1,67 @@
>> +Kernel driver g762
>> +=========
>> +
>> +This documentation is based on G760a one, GMT G762 datasheet available
>
> G760a ? If this refers to Documentation/hwmon/g760a, I think it is just
> confusing.
>
>> +at http://natisbad.org/NAS/ref/GMT_EDS-762_763-080710-0.2.pdf (used
>> +for the development of the driver) and sysfs bindings described in
>
> I would hope that you used the data sheet for the driver ;), but that
> information does not add much if any value here. I would suggest
> to drop it. Just point to the data sheet.
>
>> +  fan1_gear_mode: fan gear mode. Supported values are 0, 1 and 2. Default
>> +            value is 0. The value is a characteristic of the system
>> +            and a higher value can be set for more precisely control
>> +            fans with a high rotation speed. Note that this affects the
>> +            measurable speed range, not the read value.
>> +
> This attribute no longer exists.

All thoses will be fixed in v2.

a+

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors