[PATCH] iterate_bdevs() should be exported

[PATCH] iterate_bdevs() should be exported

[Richard Yao]

Systems where the rootfs is ZFS currently rely on their initramfs software to
to scan the block devices, identify those belonging to a pool and import the
pool. The root dataset name (which includes the pool name) is passed to the
initramfs via the kernel commandline. This a headache for users whose
distributions' sanctioned initramfs software lacks ZFS support. This is also a
maintenance headache for the maintainers of initramfs software that has ZFS
support because the scan can race with the kernel's block device initialization
routines.

I want to change things so that arbitrary initramfs software can mount a ZFS
root filesystem provided that it includes the appropriate kernel modules,
passes module parameters to kernel modules and includes mount.zfs. This would
be accomplished by having the ZFS kernel module receive the root dataset name
through a kernel module parameter, and then do the required pool import and
rootfs mount when asked to mount /dev/root.

This requires that the ZFS kernel module do a scan of all devices as
part of the rootfs mount, for which iterate_bdevs() is perfect. Unfortunately,
iterate_bdevs() is not exported, which prevents its use by kernel modules.
iterate_bdevs() was recently introduced. It is in the company of several other
bdev/device functions that are already exported, so I believe that there should
be no problem exporting it as well.

Richard Yao (1):
  fs: Export iterate_bdevs

 fs/block_dev.c | 1 +
 1 file changed, 1 insertion(+)

-- 
1.8.1.5

[PATCH] fs: Export iterate_bdevs

[Richard Yao]

iterate_bdevs() was recently introduced. It is in the company of several
other bdev/device functions that are already exported, so I believe that
there should be no problem exporting it as well.

Signed-off-by: Richard Yao <ryao-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
---
 fs/block_dev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 2091db8..0f659f3 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -1713,3 +1713,4 @@ void iterate_bdevs(void (*func)(struct block_device *, void *), void *arg)
 	spin_unlock(&inode_sb_list_lock);
 	iput(old_inode);
 }
+EXPORT_SYMBOL(iterate_bdevs);
-- 
1.8.1.5

[PATCH] fs: generic_file_llseek_size() should recognize invalid whence values

[Richard Yao]

generic_file_llseek_size() handles whence values in a switch statement,
but it lacks cases for both SEEK_SET and invalid values. This causes it
to treat all invalid whence values as SEEK_SET, which is wrong.

We fix that by adding a case for SEEK_SET and a default case.

Signed-off-by: Richard Yao <ryao-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
---
 fs/read_write.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/read_write.c b/fs/read_write.c
index 0343000..54b8808 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -81,6 +81,7 @@ generic_file_llseek_size(struct file *file, loff_t offset, int whence,
 	switch (whence) {
 	case SEEK_END:
 		offset += eof;
+	case SEEK_SET:
 		break;
 	case SEEK_CUR:
 		/*
@@ -118,6 +119,8 @@ generic_file_llseek_size(struct file *file, loff_t offset, int whence,
 			return -ENXIO;
 		offset = eof;
 		break;
+	default:
+		return -EINVAL;
 	}
 
 	return lseek_execute(file, inode, offset, maxsize);
-- 
1.8.1.5

Re: [PATCH] fs: generic_file_llseek_size() should recognize invalid whence values

[Richard Yao]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

Please disregard this patch. This was in my outgoing folder from
something that I had previously written, but it had no place being sent
to the list (again).

On 06/27/2013 10:22 PM, Richard Yao wrote:
> generic_file_llseek_size() handles whence values in a switch statement,
> but it lacks cases for both SEEK_SET and invalid values. This causes it
> to treat all invalid whence values as SEEK_SET, which is wrong.
> 
> We fix that by adding a case for SEEK_SET and a default case.
> 
> Signed-off-by: Richard Yao <ryao-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
> ---
>  fs/read_write.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fs/read_write.c b/fs/read_write.c
> index 0343000..54b8808 100644
> --- a/fs/read_write.c
> +++ b/fs/read_write.c
> @@ -81,6 +81,7 @@ generic_file_llseek_size(struct file *file, loff_t offset, int whence,
>  	switch (whence) {
>  	case SEEK_END:
>  		offset += eof;
> +	case SEEK_SET:
>  		break;
>  	case SEEK_CUR:
>  		/*
> @@ -118,6 +119,8 @@ generic_file_llseek_size(struct file *file, loff_t offset, int whence,
>  			return -ENXIO;
>  		offset = eof;
>  		break;
> +	default:
> +		return -EINVAL;
>  	}
>  
>  	return lseek_execute(file, inode, offset, maxsize);
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

Re: [PATCH] fs: generic_file_llseek_size() should recognize invalid whence values

[Al Viro]

On Thu, Jun 27, 2013 at 10:22:38PM -0400, Richard Yao wrote:
> generic_file_llseek_size() handles whence values in a switch statement,
> but it lacks cases for both SEEK_SET and invalid values. This causes it
> to treat all invalid whence values as SEEK_SET, which is wrong.
> 
> We fix that by adding a case for SEEK_SET and a default case.

NAK.  Validation of whence is done before we even get to vfs_llseek().
Leaving it to ->llseek() instances would've been an insanity.

Re: [PATCH] fs: generic_file_llseek_size() should recognize invalid whence values

[Richard Yao]

[-- Attachment #1: Type: text/plain, Size: 695 bytes --]

On 06/27/2013 11:09 PM, Al Viro wrote:
> On Thu, Jun 27, 2013 at 10:22:38PM -0400, Richard Yao wrote:
>> generic_file_llseek_size() handles whence values in a switch statement,
>> but it lacks cases for both SEEK_SET and invalid values. This causes it
>> to treat all invalid whence values as SEEK_SET, which is wrong.
>>
>> We fix that by adding a case for SEEK_SET and a default case.
> 
> NAK.  Validation of whence is done before we even get to vfs_llseek().
> Leaving it to ->llseek() instances would've been an insanity.
> 

Agreed. That patch was written before I spotted that and was not meant
to go out. It came along for the ride because my outgoing/ folder was dirty.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

[PATCH] fs: generic_file_llseek_size() should recognize invalid whence values

[Richard Yao]

generic_file_llseek_size() handles whence values in a switch statement,
but it lacks cases for both SEEK_SET and invalid values. This causes it
to treat all invalid whence values as SEEK_SET, which is wrong.

We fix that by adding a case for SEEK_SET and a default case.

Signed-off-by: Richard Yao <ryao@gentoo.org>
---
 fs/read_write.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/read_write.c b/fs/read_write.c
index 0343000..54b8808 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -81,6 +81,7 @@ generic_file_llseek_size(struct file *file, loff_t offset, int whence,
 	switch (whence) {
 	case SEEK_END:
 		offset += eof;
+	case SEEK_SET:
 		break;
 	case SEEK_CUR:
 		/*
@@ -118,6 +119,8 @@ generic_file_llseek_size(struct file *file, loff_t offset, int whence,
 			return -ENXIO;
 		offset = eof;
 		break;
+	default:
+		return -EINVAL;
 	}
 
 	return lseek_execute(file, inode, offset, maxsize);
-- 
1.8.1.5