* [PATCH] drm/nouveau/disp: Use NULL for pointers
@ 2014-07-21 12:02 Thierry Reding
2014-10-13 11:47 ` Thierry Reding
0 siblings, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2014-07-21 12:02 UTC (permalink / raw)
To: Ben Skeggs; +Cc: dri-devel
From: Thierry Reding <treding@nvidia.com>
The return type of exec_lookup() is struct nvkm_output *, so it should
return NULL rather than 0.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c b/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
index fa30d8196f35..ebf64e1d0a70 100644
--- a/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
+++ b/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
@@ -939,7 +939,7 @@ exec_lookup(struct nv50_disp_priv *priv, int head, int or, u32 ctrl,
case 0x00000900: type = DCB_OUTPUT_DP; mask = 2; break;
default:
nv_error(priv, "unknown SOR mc 0x%08x\n", ctrl);
- return 0x0000;
+ return NULL;
}
}
--
2.0.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/nouveau/disp: Use NULL for pointers
2014-07-21 12:02 [PATCH] drm/nouveau/disp: Use NULL for pointers Thierry Reding
@ 2014-10-13 11:47 ` Thierry Reding
2014-10-13 19:16 ` Emil Velikov
0 siblings, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2014-10-13 11:47 UTC (permalink / raw)
To: Ben Skeggs; +Cc: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 974 bytes --]
On Mon, Jul 21, 2014 at 02:02:58PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The return type of exec_lookup() is struct nvkm_output *, so it should
> return NULL rather than 0.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c b/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
> index fa30d8196f35..ebf64e1d0a70 100644
> --- a/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
> +++ b/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
> @@ -939,7 +939,7 @@ exec_lookup(struct nv50_disp_priv *priv, int head, int or, u32 ctrl,
> case 0x00000900: type = DCB_OUTPUT_DP; mask = 2; break;
> default:
> nv_error(priv, "unknown SOR mc 0x%08x\n", ctrl);
> - return 0x0000;
> + return NULL;
> }
> }
>
Ping?
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/nouveau/disp: Use NULL for pointers
2014-10-13 11:47 ` Thierry Reding
@ 2014-10-13 19:16 ` Emil Velikov
2015-06-05 11:33 ` Thierry Reding
0 siblings, 1 reply; 4+ messages in thread
From: Emil Velikov @ 2014-10-13 19:16 UTC (permalink / raw)
To: Thierry Reding, Ben Skeggs; +Cc: emil.l.velikov, dri-devel
On 13/10/14 12:47, Thierry Reding wrote:
> On Mon, Jul 21, 2014 at 02:02:58PM +0200, Thierry Reding wrote:
>> From: Thierry Reding <treding@nvidia.com>
>>
>> The return type of exec_lookup() is struct nvkm_output *, so it should
>> return NULL rather than 0.
>>
>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>> ---
>> drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c b/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
>> index fa30d8196f35..ebf64e1d0a70 100644
>> --- a/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
>> +++ b/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
>> @@ -939,7 +939,7 @@ exec_lookup(struct nv50_disp_priv *priv, int head, int or, u32 ctrl,
>> case 0x00000900: type = DCB_OUTPUT_DP; mask = 2; break;
>> default:
>> nv_error(priv, "unknown SOR mc 0x%08x\n", ctrl);
>> - return 0x0000;
>> + return NULL;
>> }
>> }
>>
>
> Ping?
>
> Thierry
>
I have an identical patch in a local branch, but with worse commit
message :) Fwiw the patch is
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
-Emil
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/nouveau/disp: Use NULL for pointers
2014-10-13 19:16 ` Emil Velikov
@ 2015-06-05 11:33 ` Thierry Reding
0 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2015-06-05 11:33 UTC (permalink / raw)
To: Emil Velikov; +Cc: Ben Skeggs, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1467 bytes --]
On Mon, Oct 13, 2014 at 08:16:57PM +0100, Emil Velikov wrote:
> On 13/10/14 12:47, Thierry Reding wrote:
> > On Mon, Jul 21, 2014 at 02:02:58PM +0200, Thierry Reding wrote:
> >> From: Thierry Reding <treding@nvidia.com>
> >>
> >> The return type of exec_lookup() is struct nvkm_output *, so it should
> >> return NULL rather than 0.
> >>
> >> Signed-off-by: Thierry Reding <treding@nvidia.com>
> >> ---
> >> drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c b/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
> >> index fa30d8196f35..ebf64e1d0a70 100644
> >> --- a/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
> >> +++ b/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
> >> @@ -939,7 +939,7 @@ exec_lookup(struct nv50_disp_priv *priv, int head, int or, u32 ctrl,
> >> case 0x00000900: type = DCB_OUTPUT_DP; mask = 2; break;
> >> default:
> >> nv_error(priv, "unknown SOR mc 0x%08x\n", ctrl);
> >> - return 0x0000;
> >> + return NULL;
> >> }
> >> }
> >>
> >
> > Ping?
> >
> > Thierry
> >
> I have an identical patch in a local branch, but with worse commit
> message :) Fwiw the patch is
>
> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Ben, any chance you could pick this up? It should still apply as-is on
recent trees, but I can resend if you prefer.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-05 11:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-21 12:02 [PATCH] drm/nouveau/disp: Use NULL for pointers Thierry Reding
2014-10-13 11:47 ` Thierry Reding
2014-10-13 19:16 ` Emil Velikov
2015-06-05 11:33 ` Thierry Reding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.