* [PATCH] staging: rtl8712: fix comparison test warnings
@ 2015-10-05 18:39 Alison Schofield
2015-10-05 20:38 ` [Outreachy kernel] " Julia Lawall
2015-10-06 7:53 ` Arnd Bergmann
0 siblings, 2 replies; 7+ messages in thread
From: Alison Schofield @ 2015-10-05 18:39 UTC (permalink / raw)
To: outreachy-kernel
This patch fixes multiple instances of the checkpatch.pl warning:
WARNING: Comparisons should place the constant on the right side of the
test
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 143be0f..528e9f5 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -140,7 +140,7 @@ static inline void handle_pairwise_key(struct sta_info *psta,
static inline void handle_group_key(struct ieee_param *param,
struct _adapter *padapter)
{
- if (0 < param->u.crypt.idx &&
+ if (param->u.crypt.idx > 0 &&
param->u.crypt.idx < 3) {
/* group key idx is 1 or 2 */
memcpy(padapter->securitypriv.XGrpKey[param->u.crypt.
@@ -957,7 +957,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
if (IS_ERR(ext))
return PTR_ERR(ext);
- if (0 == strcasecmp(ext, "RSSI")) {
+ if (strcasecmp(ext, "RSSI") == 0) {
/*Return received signal strength indicator in -db for */
/* current AP */
/*<ssid> Rssi xx */
@@ -974,7 +974,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
} else {
sprintf(ext, "OK");
}
- } else if (0 == strcasecmp(ext, "LINKSPEED")) {
+ } else if (strcasecmp(ext, "LINKSPEED") == 0) {
/*Return link speed in MBPS */
/*LinkSpeed xx */
union iwreq_data wrqd;
@@ -982,30 +982,30 @@ static int r871x_wx_set_priv(struct net_device *dev,
int mbps;
ret_inner = r8711_wx_get_rate(dev, info, &wrqd, extra);
- if (0 != ret_inner)
+ if (ret_inner != 0)
mbps = 0;
else
mbps = wrqd.bitrate.value / 1000000;
sprintf(ext, "LINKSPEED %d", mbps);
- } else if (0 == strcasecmp(ext, "MACADDR")) {
+ } else if (strcasecmp(ext, "MACADDR") == 0) {
/*Return mac address of the station */
/* Macaddr = xx:xx:xx:xx:xx:xx */
sprintf(ext, "MACADDR = %pM", dev->dev_addr);
- } else if (0 == strcasecmp(ext, "SCAN-ACTIVE")) {
+ } else if (strcasecmp(ext, "SCAN-ACTIVE") == 0) {
/*Set scan type to active */
/*OK if successful */
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
pmlmepriv->passive_mode = 1;
sprintf(ext, "OK");
- } else if (0 == strcasecmp(ext, "SCAN-PASSIVE")) {
+ } else if (strcasecmp(ext, "SCAN-PASSIVE") == 0) {
/*Set scan type to passive */
/*OK if successful */
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
pmlmepriv->passive_mode = 0;
sprintf(ext, "OK");
- } else if (0 == strncmp(ext, "DCE-E", 5)) {
+ } else if (strncmp(ext, "DCE-E", 5) == 0) {
/*Set scan type to passive */
/*OK if successful */
r8712_disconnectCtrlEx_cmd(padapter
@@ -1015,7 +1015,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
, 5000 /*u32 firstStageTO */
);
sprintf(ext, "OK");
- } else if (0 == strncmp(ext, "DCE-D", 5)) {
+ } else if (strncmp(ext, "DCE-D", 5) == 0) {
/*Set scan type to passive */
/*OK if successfu */
r8712_disconnectCtrlEx_cmd(padapter
@@ -1454,7 +1454,7 @@ static int r8711_wx_get_rate(struct net_device *dev,
if (ht_cap == true) {
if (mcs_rate & 0x8000 /* MCS15 */
&&
- RTL8712_RF_2T2R == rf_type)
+ rf_type == RTL8712_RF_2T2R)
max_rate = (bw_40MHz) ? ((short_GI) ? 300 :
270) : ((short_GI) ? 144 : 130);
else /* default MCS7 */
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: rtl8712: fix comparison test warnings
2015-10-05 18:39 [PATCH] staging: rtl8712: fix comparison test warnings Alison Schofield
@ 2015-10-05 20:38 ` Julia Lawall
2015-10-05 21:38 ` Alison Schofield
2015-10-06 7:53 ` Arnd Bergmann
1 sibling, 1 reply; 7+ messages in thread
From: Julia Lawall @ 2015-10-05 20:38 UTC (permalink / raw)
To: Alison Schofield; +Cc: outreachy-kernel
On Mon, 5 Oct 2015, Alison Schofield wrote:
> This patch fixes multiple instances of the checkpatch.pl warning:
>
> WARNING: Comparisons should place the constant on the right side of the
> test
Thanks for the patch, but try to avoid using "fix" in your commit message.
Say instead what you have done to do the fix. Here, you could say
something like "Move constant to the right side of a comparison operator,
as suggested by checkpatch".
julia
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> ---
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index 143be0f..528e9f5 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -140,7 +140,7 @@ static inline void handle_pairwise_key(struct sta_info *psta,
> static inline void handle_group_key(struct ieee_param *param,
> struct _adapter *padapter)
> {
> - if (0 < param->u.crypt.idx &&
> + if (param->u.crypt.idx > 0 &&
> param->u.crypt.idx < 3) {
> /* group key idx is 1 or 2 */
> memcpy(padapter->securitypriv.XGrpKey[param->u.crypt.
> @@ -957,7 +957,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
> if (IS_ERR(ext))
> return PTR_ERR(ext);
>
> - if (0 == strcasecmp(ext, "RSSI")) {
> + if (strcasecmp(ext, "RSSI") == 0) {
> /*Return received signal strength indicator in -db for */
> /* current AP */
> /*<ssid> Rssi xx */
> @@ -974,7 +974,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
> } else {
> sprintf(ext, "OK");
> }
> - } else if (0 == strcasecmp(ext, "LINKSPEED")) {
> + } else if (strcasecmp(ext, "LINKSPEED") == 0) {
> /*Return link speed in MBPS */
> /*LinkSpeed xx */
> union iwreq_data wrqd;
> @@ -982,30 +982,30 @@ static int r871x_wx_set_priv(struct net_device *dev,
> int mbps;
>
> ret_inner = r8711_wx_get_rate(dev, info, &wrqd, extra);
> - if (0 != ret_inner)
> + if (ret_inner != 0)
> mbps = 0;
> else
> mbps = wrqd.bitrate.value / 1000000;
> sprintf(ext, "LINKSPEED %d", mbps);
> - } else if (0 == strcasecmp(ext, "MACADDR")) {
> + } else if (strcasecmp(ext, "MACADDR") == 0) {
> /*Return mac address of the station */
> /* Macaddr = xx:xx:xx:xx:xx:xx */
> sprintf(ext, "MACADDR = %pM", dev->dev_addr);
> - } else if (0 == strcasecmp(ext, "SCAN-ACTIVE")) {
> + } else if (strcasecmp(ext, "SCAN-ACTIVE") == 0) {
> /*Set scan type to active */
> /*OK if successful */
> struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
>
> pmlmepriv->passive_mode = 1;
> sprintf(ext, "OK");
> - } else if (0 == strcasecmp(ext, "SCAN-PASSIVE")) {
> + } else if (strcasecmp(ext, "SCAN-PASSIVE") == 0) {
> /*Set scan type to passive */
> /*OK if successful */
> struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
>
> pmlmepriv->passive_mode = 0;
> sprintf(ext, "OK");
> - } else if (0 == strncmp(ext, "DCE-E", 5)) {
> + } else if (strncmp(ext, "DCE-E", 5) == 0) {
> /*Set scan type to passive */
> /*OK if successful */
> r8712_disconnectCtrlEx_cmd(padapter
> @@ -1015,7 +1015,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
> , 5000 /*u32 firstStageTO */
> );
> sprintf(ext, "OK");
> - } else if (0 == strncmp(ext, "DCE-D", 5)) {
> + } else if (strncmp(ext, "DCE-D", 5) == 0) {
> /*Set scan type to passive */
> /*OK if successfu */
> r8712_disconnectCtrlEx_cmd(padapter
> @@ -1454,7 +1454,7 @@ static int r8711_wx_get_rate(struct net_device *dev,
> if (ht_cap == true) {
> if (mcs_rate & 0x8000 /* MCS15 */
> &&
> - RTL8712_RF_2T2R == rf_type)
> + rf_type == RTL8712_RF_2T2R)
> max_rate = (bw_40MHz) ? ((short_GI) ? 300 :
> 270) : ((short_GI) ? 144 : 130);
> else /* default MCS7 */
> --
> 2.1.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151005183935.GA3350%40Ubuntu-D830.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: rtl8712: fix comparison test warnings
2015-10-05 20:38 ` [Outreachy kernel] " Julia Lawall
@ 2015-10-05 21:38 ` Alison Schofield
2015-10-06 4:27 ` Sudip Mukherjee
0 siblings, 1 reply; 7+ messages in thread
From: Alison Schofield @ 2015-10-05 21:38 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel
On Mon, Oct 05, 2015 at 09:38:28PM +0100, Julia Lawall wrote:
> On Mon, 5 Oct 2015, Alison Schofield wrote:
>
> > This patch fixes multiple instances of the checkpatch.pl warning:
> >
> > WARNING: Comparisons should place the constant on the right side of the
> > test
>
> Thanks for the patch, but try to avoid using "fix" in your commit message.
> Say instead what you have done to do the fix. Here, you could say
> something like "Move constant to the right side of a comparison operator,
> as suggested by checkpatch".
>
> julia
Thanks for the quick review and I will check that on future patches.
Do I need to amend and resend this one?
alison
> > Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> > ---
> > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 20 ++++++++++----------
> > 1 file changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > index 143be0f..528e9f5 100644
> > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > @@ -140,7 +140,7 @@ static inline void handle_pairwise_key(struct sta_info *psta,
> > static inline void handle_group_key(struct ieee_param *param,
> > struct _adapter *padapter)
> > {
> > - if (0 < param->u.crypt.idx &&
> > + if (param->u.crypt.idx > 0 &&
> > param->u.crypt.idx < 3) {
> > /* group key idx is 1 or 2 */
> > memcpy(padapter->securitypriv.XGrpKey[param->u.crypt.
> > @@ -957,7 +957,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
> > if (IS_ERR(ext))
> > return PTR_ERR(ext);
> >
> > - if (0 == strcasecmp(ext, "RSSI")) {
> > + if (strcasecmp(ext, "RSSI") == 0) {
> > /*Return received signal strength indicator in -db for */
> > /* current AP */
> > /*<ssid> Rssi xx */
> > @@ -974,7 +974,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
> > } else {
> > sprintf(ext, "OK");
> > }
> > - } else if (0 == strcasecmp(ext, "LINKSPEED")) {
> > + } else if (strcasecmp(ext, "LINKSPEED") == 0) {
> > /*Return link speed in MBPS */
> > /*LinkSpeed xx */
> > union iwreq_data wrqd;
> > @@ -982,30 +982,30 @@ static int r871x_wx_set_priv(struct net_device *dev,
> > int mbps;
> >
> > ret_inner = r8711_wx_get_rate(dev, info, &wrqd, extra);
> > - if (0 != ret_inner)
> > + if (ret_inner != 0)
> > mbps = 0;
> > else
> > mbps = wrqd.bitrate.value / 1000000;
> > sprintf(ext, "LINKSPEED %d", mbps);
> > - } else if (0 == strcasecmp(ext, "MACADDR")) {
> > + } else if (strcasecmp(ext, "MACADDR") == 0) {
> > /*Return mac address of the station */
> > /* Macaddr = xx:xx:xx:xx:xx:xx */
> > sprintf(ext, "MACADDR = %pM", dev->dev_addr);
> > - } else if (0 == strcasecmp(ext, "SCAN-ACTIVE")) {
> > + } else if (strcasecmp(ext, "SCAN-ACTIVE") == 0) {
> > /*Set scan type to active */
> > /*OK if successful */
> > struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
> >
> > pmlmepriv->passive_mode = 1;
> > sprintf(ext, "OK");
> > - } else if (0 == strcasecmp(ext, "SCAN-PASSIVE")) {
> > + } else if (strcasecmp(ext, "SCAN-PASSIVE") == 0) {
> > /*Set scan type to passive */
> > /*OK if successful */
> > struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
> >
> > pmlmepriv->passive_mode = 0;
> > sprintf(ext, "OK");
> > - } else if (0 == strncmp(ext, "DCE-E", 5)) {
> > + } else if (strncmp(ext, "DCE-E", 5) == 0) {
> > /*Set scan type to passive */
> > /*OK if successful */
> > r8712_disconnectCtrlEx_cmd(padapter
> > @@ -1015,7 +1015,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
> > , 5000 /*u32 firstStageTO */
> > );
> > sprintf(ext, "OK");
> > - } else if (0 == strncmp(ext, "DCE-D", 5)) {
> > + } else if (strncmp(ext, "DCE-D", 5) == 0) {
> > /*Set scan type to passive */
> > /*OK if successfu */
> > r8712_disconnectCtrlEx_cmd(padapter
> > @@ -1454,7 +1454,7 @@ static int r8711_wx_get_rate(struct net_device *dev,
> > if (ht_cap == true) {
> > if (mcs_rate & 0x8000 /* MCS15 */
> > &&
> > - RTL8712_RF_2T2R == rf_type)
> > + rf_type == RTL8712_RF_2T2R)
> > max_rate = (bw_40MHz) ? ((short_GI) ? 300 :
> > 270) : ((short_GI) ? 144 : 130);
> > else /* default MCS7 */
> > --
> > 2.1.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151005183935.GA3350%40Ubuntu-D830.
> > For more options, visit https://groups.google.com/d/optout.
> >
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: rtl8712: fix comparison test warnings
2015-10-05 21:38 ` Alison Schofield
@ 2015-10-06 4:27 ` Sudip Mukherjee
2015-10-06 4:28 ` Julia Lawall
0 siblings, 1 reply; 7+ messages in thread
From: Sudip Mukherjee @ 2015-10-06 4:27 UTC (permalink / raw)
To: Alison Schofield; +Cc: Julia Lawall, outreachy-kernel
On Mon, Oct 05, 2015 at 02:38:49PM -0700, Alison Schofield wrote:
> On Mon, Oct 05, 2015 at 09:38:28PM +0100, Julia Lawall wrote:
> > On Mon, 5 Oct 2015, Alison Schofield wrote:
> >
> > > This patch fixes multiple instances of the checkpatch.pl warning:
> > >
> > > WARNING: Comparisons should place the constant on the right side of the
> > > test
> >
> > Thanks for the patch, but try to avoid using "fix" in your commit message.
> > Say instead what you have done to do the fix. Here, you could say
> > something like "Move constant to the right side of a comparison operator,
> > as suggested by checkpatch".
> >
> > julia
>
> Thanks for the quick review and I will check that on future patches.
> Do I need to amend and resend this one?
I think no need to resend this one. But keep in mind what Julia said in
your next patches.
regards
sudip
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rtl8712: fix comparison test warnings
2015-10-06 4:27 ` Sudip Mukherjee
@ 2015-10-06 4:28 ` Julia Lawall
0 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2015-10-06 4:28 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Alison Schofield, outreachy-kernel
On Tue, 6 Oct 2015, Sudip Mukherjee wrote:
> On Mon, Oct 05, 2015 at 02:38:49PM -0700, Alison Schofield wrote:
> > On Mon, Oct 05, 2015 at 09:38:28PM +0100, Julia Lawall wrote:
> > > On Mon, 5 Oct 2015, Alison Schofield wrote:
> > >
> > > > This patch fixes multiple instances of the checkpatch.pl warning:
> > > >
> > > > WARNING: Comparisons should place the constant on the right side of the
> > > > test
> > >
> > > Thanks for the patch, but try to avoid using "fix" in your commit message.
> > > Say instead what you have done to do the fix. Here, you could say
> > > something like "Move constant to the right side of a comparison operator,
> > > as suggested by checkpatch".
> > >
> > > julia
> >
> > Thanks for the quick review and I will check that on future patches.
> > Do I need to amend and resend this one?
>
> I think no need to resend this one. But keep in mind what Julia said in
> your next patches.
Fine with me.
julia
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rtl8712: fix comparison test warnings
2015-10-05 18:39 [PATCH] staging: rtl8712: fix comparison test warnings Alison Schofield
2015-10-05 20:38 ` [Outreachy kernel] " Julia Lawall
@ 2015-10-06 7:53 ` Arnd Bergmann
2015-10-06 17:32 ` Alison Schofield
1 sibling, 1 reply; 7+ messages in thread
From: Arnd Bergmann @ 2015-10-06 7:53 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Alison Schofield
On Monday 05 October 2015 11:39:35 Alison Schofield wrote:
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -140,7 +140,7 @@ static inline void handle_pairwise_key(struct sta_info *psta,
> static inline void handle_group_key(struct ieee_param *param,
> struct _adapter *padapter)
> {
> - if (0 < param->u.crypt.idx &&
> + if (param->u.crypt.idx > 0 &&
> param->u.crypt.idx < 3) {
> /* group key idx is 1 or 2 */
> memcpy(padapter->securitypriv.XGrpKey[param->u.crypt.
this part is good.
> @@ -957,7 +957,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
> if (IS_ERR(ext))
> return PTR_ERR(ext);
>
> - if (0 == strcasecmp(ext, "RSSI")) {
> + if (strcasecmp(ext, "RSSI") == 0) {
> /*Return received signal strength indicator in -db for */
> /* current AP */
> /*<ssid> Rssi xx */
while this and most of the other comparisons below can be further
improved by removing the "== 0" part. You can write this as
if (!strcasecmp(ext, "RSSI")) {
Arnd
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: rtl8712: fix comparison test warnings
2015-10-06 7:53 ` Arnd Bergmann
@ 2015-10-06 17:32 ` Alison Schofield
0 siblings, 0 replies; 7+ messages in thread
From: Alison Schofield @ 2015-10-06 17:32 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: outreachy-kernel
On Tue, Oct 06, 2015 at 09:53:46AM +0200, Arnd Bergmann wrote:
> On Monday 05 October 2015 11:39:35 Alison Schofield wrote:
> > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > @@ -140,7 +140,7 @@ static inline void handle_pairwise_key(struct sta_info *psta,
> > static inline void handle_group_key(struct ieee_param *param,
> > struct _adapter *padapter)
> > {
> > - if (0 < param->u.crypt.idx &&
> > + if (param->u.crypt.idx > 0 &&
> > param->u.crypt.idx < 3) {
> > /* group key idx is 1 or 2 */
> > memcpy(padapter->securitypriv.XGrpKey[param->u.crypt.
>
> this part is good.
>
>
> > @@ -957,7 +957,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
> > if (IS_ERR(ext))
> > return PTR_ERR(ext);
> >
> > - if (0 == strcasecmp(ext, "RSSI")) {
> > + if (strcasecmp(ext, "RSSI") == 0) {
> > /*Return received signal strength indicator in -db for */
> > /* current AP */
> > /*<ssid> Rssi xx */
>
> while this and most of the other comparisons below can be further
> improved by removing the "== 0" part. You can write this as
>
> if (!strcasecmp(ext, "RSSI")) {
>
>
> Arnd
Thanks & understood. v2 in the works with ! and commit msg changes.
alison
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-10-06 17:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-05 18:39 [PATCH] staging: rtl8712: fix comparison test warnings Alison Schofield
2015-10-05 20:38 ` [Outreachy kernel] " Julia Lawall
2015-10-05 21:38 ` Alison Schofield
2015-10-06 4:27 ` Sudip Mukherjee
2015-10-06 4:28 ` Julia Lawall
2015-10-06 7:53 ` Arnd Bergmann
2015-10-06 17:32 ` Alison Schofield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.