From: peterz@infradead.org (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: bpf: add BPF XADD instruction
Date: Wed, 11 Nov 2015 19:41:34 +0100 [thread overview]
Message-ID: <20151111184134.GG11639@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20151111183128.GS17308@twins.programming.kicks-ass.net>
On Wed, Nov 11, 2015 at 07:31:28PM +0100, Peter Zijlstra wrote:
> > Adding new intrinsic to llvm is not a big deal. I'll add it as soon
> > as I have time to work on it or if somebody beats me to it I would be
> > glad to test it and apply it.
>
> This isn't a speed coding contest. You want to think about this
> properly.
That is, I don't think you want to go add LLVM intrinsics at all. You
want to piggy back on the memory model work done by the C/C++11 people.
What you want to think about is what the memory model of your virtual
machine is and how many instructions you want to expose for that.
Concurrency is a right pain, a little time and effort now will safe
heaps of pain down the road.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: David Miller <davem@davemloft.net>,
will.deacon@arm.com, daniel@iogearbox.net, arnd@arndb.de,
yang.shi@linaro.org, linaro-kernel@lists.linaro.org,
eric.dumazet@gmail.com, zlim.lnx@gmail.com, ast@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
xi.wang@gmail.com, catalin.marinas@arm.com,
linux-arm-kernel@lists.infradead.org, yhs@plumgrid.com,
bblanco@plumgrid.com
Subject: Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction
Date: Wed, 11 Nov 2015 19:41:34 +0100 [thread overview]
Message-ID: <20151111184134.GG11639@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20151111183128.GS17308@twins.programming.kicks-ass.net>
On Wed, Nov 11, 2015 at 07:31:28PM +0100, Peter Zijlstra wrote:
> > Adding new intrinsic to llvm is not a big deal. I'll add it as soon
> > as I have time to work on it or if somebody beats me to it I would be
> > glad to test it and apply it.
>
> This isn't a speed coding contest. You want to think about this
> properly.
That is, I don't think you want to go add LLVM intrinsics at all. You
want to piggy back on the memory model work done by the C/C++11 people.
What you want to think about is what the memory model of your virtual
machine is and how many instructions you want to expose for that.
Concurrency is a right pain, a little time and effort now will safe
heaps of pain down the road.
next prev parent reply other threads:[~2015-11-11 18:41 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 22:41 [PATCH 0/2] arm64: bpf: add BPF_ST and BPF_XADD instructions support Yang Shi
2015-11-10 22:41 ` Yang Shi
2015-11-10 22:41 ` Yang Shi
2015-11-10 22:41 ` [PATCH 1/2] arm64: bpf: add 'store immediate' instruction Yang Shi
2015-11-10 22:41 ` Yang Shi
2015-11-11 2:45 ` Z Lim
2015-11-11 2:45 ` Z Lim
2015-11-11 12:12 ` Will Deacon
2015-11-11 12:12 ` Will Deacon
2015-11-11 12:39 ` Will Deacon
2015-11-11 12:39 ` Will Deacon
2015-11-12 19:33 ` Shi, Yang
2015-11-12 19:33 ` Shi, Yang
2015-11-13 3:45 ` Z Lim
2015-11-13 3:45 ` Z Lim
2015-11-23 19:34 ` Shi, Yang
2015-11-23 19:34 ` Shi, Yang
2015-11-10 22:41 ` [PATCH 2/2] arm64: bpf: add BPF XADD instruction Yang Shi
2015-11-10 22:41 ` Yang Shi
2015-11-11 0:08 ` Eric Dumazet
2015-11-11 0:08 ` Eric Dumazet
2015-11-11 0:26 ` Shi, Yang
2015-11-11 0:26 ` Shi, Yang
2015-11-11 0:42 ` Alexei Starovoitov
2015-11-11 0:42 ` Alexei Starovoitov
2015-11-11 2:52 ` Z Lim
2015-11-11 2:52 ` Z Lim
2015-11-11 8:49 ` Arnd Bergmann
2015-11-11 8:49 ` Arnd Bergmann
2015-11-11 10:24 ` Will Deacon
2015-11-11 10:24 ` Will Deacon
2015-11-11 10:42 ` Daniel Borkmann
2015-11-11 10:42 ` Daniel Borkmann
2015-11-11 11:58 ` Will Deacon
2015-11-11 11:58 ` Will Deacon
2015-11-11 12:21 ` Daniel Borkmann
2015-11-11 12:21 ` Daniel Borkmann
2015-11-11 12:38 ` Will Deacon
2015-11-11 12:38 ` Will Deacon
2015-11-11 12:58 ` Peter Zijlstra
2015-11-11 12:58 ` Peter Zijlstra
2015-11-11 15:52 ` Daniel Borkmann
2015-11-11 15:52 ` Daniel Borkmann
2015-11-11 16:23 ` Will Deacon
2015-11-11 16:23 ` Will Deacon
2015-11-11 17:27 ` Alexei Starovoitov
2015-11-11 17:27 ` Alexei Starovoitov
2015-11-11 17:35 ` David Miller
2015-11-11 17:35 ` David Miller
2015-11-11 17:44 ` Will Deacon
2015-11-11 17:44 ` Will Deacon
2015-11-11 19:01 ` David Miller
2015-11-11 19:01 ` David Miller
2015-11-11 17:57 ` Peter Zijlstra
2015-11-11 17:57 ` Peter Zijlstra
2015-11-11 18:11 ` Alexei Starovoitov
2015-11-11 18:11 ` Alexei Starovoitov
2015-11-11 18:31 ` Peter Zijlstra
2015-11-11 18:31 ` Peter Zijlstra
2015-11-11 18:41 ` Peter Zijlstra [this message]
2015-11-11 18:41 ` Peter Zijlstra
2015-11-11 18:44 ` Peter Zijlstra
2015-11-11 18:44 ` Peter Zijlstra
2015-11-11 18:54 ` Peter Zijlstra
2015-11-11 18:54 ` Peter Zijlstra
2015-11-11 19:55 ` Alexei Starovoitov
2015-11-11 19:55 ` Alexei Starovoitov
2015-11-11 22:21 ` Peter Zijlstra
2015-11-11 22:21 ` Peter Zijlstra
2015-11-11 23:40 ` Alexei Starovoitov
2015-11-11 23:40 ` Alexei Starovoitov
2015-11-11 23:40 ` Alexei Starovoitov
2015-11-12 8:57 ` Peter Zijlstra
2015-11-12 8:57 ` Peter Zijlstra
2015-11-11 18:50 ` Daniel Borkmann
2015-11-11 18:50 ` Daniel Borkmann
2015-11-11 19:04 ` David Miller
2015-11-11 19:04 ` David Miller
2015-11-11 19:23 ` Peter Zijlstra
2015-11-11 19:23 ` Peter Zijlstra
2015-11-11 19:41 ` Daniel Borkmann
2015-11-11 19:41 ` Daniel Borkmann
2015-11-11 18:46 ` Will Deacon
2015-11-11 18:46 ` Will Deacon
2015-11-11 19:01 ` David Miller
2015-11-11 19:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111184134.GG11639@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.