From: Tony Lindgren <tony@atomide.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Kevin Hilman <khilman@baylibre.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: PM regression with commit 5de85b9d57ab PM runtime re-init in v4.5-rc1
Date: Tue, 26 Jan 2016 15:52:23 -0800 [thread overview]
Message-ID: <20160126235222.GF19432@atomide.com> (raw)
In-Reply-To: <CAJZ5v0gTRvyWHVmYNb8Q1QZzhVhokXo541+48mFyDRYv7Hi-Uw@mail.gmail.com>
* Rafael J. Wysocki <rafael@kernel.org> [160126 15:38]:
> On Wed, Jan 27, 2016 at 12:22 AM, Tony Lindgren <tony@atomide.com> wrote:
> > * Rafael J. Wysocki <rafael@kernel.org> [160126 15:15]:
> >> On Tue, Jan 26, 2016 at 11:48 PM, Tony Lindgren <tony@atomide.com> wrote:
> >> > Hi,
> >> >
> >> > Looks like commit 5de85b9d57ab ("PM / runtime: Re-init runtime
> >> > PM states at probe error and driver unbind") broke PM on at least
> >> > omap3. It seems we now need to additionally also call
> >> > pm_runtime_dont_use_autosuspend() to get things working again?
> >> >
> >> > The following fixes idling on omap3, but I'm wondering if we
> >> > should do something in pm_runtime_reinit() instead?
> >>
> >> Well, does it actually help if you add
> >> pm_runtime_dont_use_autosuspend(dev) to pm_runtime_reinit()?
> >
> > No adding it to pm_runtime_reinit() does not help.
>
> Yes, I realized that it wouldn't help only after sending the previous
> message, sorry about that.
>
> The reason why it helps in the driver code seems to be that
> autosuspend_delay happens to be negative, so update_autosuspend()
> decrements the usage counter that would have stayed incremented
> otherwise. Or at least that's the only way it can help I see ATM.
Oh OK.
> > Looks like we have RPM_ACTIVE set in pm_runtime_reinit() if that
> > gives any clues.
>
> It looks like pm_runtime_reinit() should clear the usage counter too.
Yeah if we do this when !pm_runtime_enabled(dev) it seems it's
safe to pretty much reset everything?
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: PM regression with commit 5de85b9d57ab PM runtime re-init in v4.5-rc1
Date: Tue, 26 Jan 2016 15:52:23 -0800 [thread overview]
Message-ID: <20160126235222.GF19432@atomide.com> (raw)
In-Reply-To: <CAJZ5v0gTRvyWHVmYNb8Q1QZzhVhokXo541+48mFyDRYv7Hi-Uw@mail.gmail.com>
* Rafael J. Wysocki <rafael@kernel.org> [160126 15:38]:
> On Wed, Jan 27, 2016 at 12:22 AM, Tony Lindgren <tony@atomide.com> wrote:
> > * Rafael J. Wysocki <rafael@kernel.org> [160126 15:15]:
> >> On Tue, Jan 26, 2016 at 11:48 PM, Tony Lindgren <tony@atomide.com> wrote:
> >> > Hi,
> >> >
> >> > Looks like commit 5de85b9d57ab ("PM / runtime: Re-init runtime
> >> > PM states at probe error and driver unbind") broke PM on at least
> >> > omap3. It seems we now need to additionally also call
> >> > pm_runtime_dont_use_autosuspend() to get things working again?
> >> >
> >> > The following fixes idling on omap3, but I'm wondering if we
> >> > should do something in pm_runtime_reinit() instead?
> >>
> >> Well, does it actually help if you add
> >> pm_runtime_dont_use_autosuspend(dev) to pm_runtime_reinit()?
> >
> > No adding it to pm_runtime_reinit() does not help.
>
> Yes, I realized that it wouldn't help only after sending the previous
> message, sorry about that.
>
> The reason why it helps in the driver code seems to be that
> autosuspend_delay happens to be negative, so update_autosuspend()
> decrements the usage counter that would have stayed incremented
> otherwise. Or at least that's the only way it can help I see ATM.
Oh OK.
> > Looks like we have RPM_ACTIVE set in pm_runtime_reinit() if that
> > gives any clues.
>
> It looks like pm_runtime_reinit() should clear the usage counter too.
Yeah if we do this when !pm_runtime_enabled(dev) it seems it's
safe to pretty much reset everything?
Regards,
Tony
next prev parent reply other threads:[~2016-01-26 23:52 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 22:48 PM regression with commit 5de85b9d57ab PM runtime re-init in v4.5-rc1 Tony Lindgren
2016-01-26 22:48 ` Tony Lindgren
2016-01-26 22:50 ` Tony Lindgren
2016-01-26 22:50 ` Tony Lindgren
2016-01-26 23:14 ` Rafael J. Wysocki
2016-01-26 23:14 ` Rafael J. Wysocki
2016-01-26 23:22 ` Tony Lindgren
2016-01-26 23:22 ` Tony Lindgren
2016-01-26 23:37 ` Rafael J. Wysocki
2016-01-26 23:37 ` Rafael J. Wysocki
2016-01-26 23:52 ` Tony Lindgren [this message]
2016-01-26 23:52 ` Tony Lindgren
2016-01-27 7:54 ` Rafael J. Wysocki
2016-01-27 7:54 ` Rafael J. Wysocki
2016-01-27 8:17 ` Ulf Hansson
2016-01-27 8:17 ` Ulf Hansson
2016-01-27 15:19 ` Tony Lindgren
2016-01-27 15:19 ` Tony Lindgren
2016-01-27 22:51 ` Rafael J. Wysocki
2016-01-27 22:51 ` Rafael J. Wysocki
2016-01-28 14:29 ` Ulf Hansson
2016-01-28 14:29 ` Ulf Hansson
2016-01-28 16:58 ` Tony Lindgren
2016-01-28 16:58 ` Tony Lindgren
2016-02-01 16:44 ` Ulf Hansson
2016-02-01 16:44 ` Ulf Hansson
2016-02-01 18:11 ` Tony Lindgren
2016-02-01 18:11 ` Tony Lindgren
2016-02-01 22:06 ` Tony Lindgren
2016-02-01 22:06 ` Tony Lindgren
2016-02-01 22:17 ` Rafael J. Wysocki
2016-02-01 22:17 ` Rafael J. Wysocki
2016-02-01 22:29 ` Tony Lindgren
2016-02-01 22:29 ` Tony Lindgren
2016-02-01 23:10 ` Rafael J. Wysocki
2016-02-01 23:10 ` Rafael J. Wysocki
2016-02-01 23:28 ` Tony Lindgren
2016-02-01 23:28 ` Tony Lindgren
2016-02-01 23:44 ` Tony Lindgren
2016-02-01 23:44 ` Tony Lindgren
2016-02-01 23:49 ` Alan Stern
2016-02-01 23:49 ` Alan Stern
2016-02-02 3:05 ` Tony Lindgren
2016-02-02 3:05 ` Tony Lindgren
2016-02-02 10:07 ` Ulf Hansson
2016-02-02 10:07 ` Ulf Hansson
2016-02-02 10:42 ` Ulf Hansson
2016-02-02 10:42 ` Ulf Hansson
2016-02-02 16:23 ` Alan Stern
2016-02-02 16:23 ` Alan Stern
2016-02-02 16:35 ` Tony Lindgren
2016-02-02 16:35 ` Tony Lindgren
2016-02-02 20:47 ` Ulf Hansson
2016-02-02 20:47 ` Ulf Hansson
2016-02-02 23:41 ` Tony Lindgren
2016-02-02 23:41 ` Tony Lindgren
2016-02-03 10:23 ` Ulf Hansson
2016-02-03 10:23 ` Ulf Hansson
2016-02-03 10:25 ` Ulf Hansson
2016-02-03 10:25 ` Ulf Hansson
2016-02-03 12:18 ` Rafael J. Wysocki
2016-02-03 12:18 ` Rafael J. Wysocki
2016-02-03 14:58 ` Ulf Hansson
2016-02-03 14:58 ` Ulf Hansson
2016-02-03 15:45 ` Alan Stern
2016-02-03 15:45 ` Alan Stern
2016-02-03 16:09 ` Tony Lindgren
2016-02-03 16:09 ` Tony Lindgren
2016-02-03 16:24 ` Ulf Hansson
2016-02-03 16:24 ` Ulf Hansson
2016-02-03 17:01 ` Tony Lindgren
2016-02-03 17:01 ` Tony Lindgren
2016-02-03 17:16 ` Rafael J. Wysocki
2016-02-03 17:16 ` Rafael J. Wysocki
2016-02-03 16:27 ` Tony Lindgren
2016-02-03 16:27 ` Tony Lindgren
2016-02-03 18:02 ` Ulf Hansson
2016-02-03 18:02 ` Ulf Hansson
2016-02-03 18:28 ` Tony Lindgren
2016-02-03 18:28 ` Tony Lindgren
2016-02-03 18:37 ` Ulf Hansson
2016-02-03 18:37 ` Ulf Hansson
2016-02-03 18:45 ` Tony Lindgren
2016-02-03 18:45 ` Tony Lindgren
2016-02-03 21:51 ` Tony Lindgren
2016-02-03 21:51 ` Tony Lindgren
2016-02-02 16:15 ` Alan Stern
2016-02-02 16:15 ` Alan Stern
2016-02-02 16:49 ` Tony Lindgren
2016-02-02 16:49 ` Tony Lindgren
2016-02-02 18:05 ` Tony Lindgren
2016-02-02 18:05 ` Tony Lindgren
2016-02-02 18:43 ` Alan Stern
2016-02-02 18:43 ` Alan Stern
2016-02-02 18:54 ` Tony Lindgren
2016-02-02 18:54 ` Tony Lindgren
2016-02-02 19:16 ` Alan Stern
2016-02-02 19:16 ` Alan Stern
2016-02-02 21:03 ` Tony Lindgren
2016-02-02 21:03 ` Tony Lindgren
2016-02-02 21:45 ` Alan Stern
2016-02-02 21:45 ` Alan Stern
2016-02-02 23:46 ` Tony Lindgren
2016-02-02 23:46 ` Tony Lindgren
2016-02-03 13:06 ` Rafael J. Wysocki
2016-02-03 13:06 ` Rafael J. Wysocki
2016-02-03 16:36 ` Tony Lindgren
2016-02-03 16:36 ` Tony Lindgren
2016-02-03 15:48 ` Alan Stern
2016-02-03 15:48 ` Alan Stern
2016-02-03 16:37 ` Tony Lindgren
2016-02-03 16:37 ` Tony Lindgren
2016-02-03 17:18 ` Rafael J. Wysocki
2016-02-03 17:18 ` Rafael J. Wysocki
2016-02-03 17:22 ` Tony Lindgren
2016-02-03 17:22 ` Tony Lindgren
2016-02-03 17:27 ` Rafael J. Wysocki
2016-02-03 17:27 ` Rafael J. Wysocki
2016-02-04 10:20 ` Ulf Hansson
2016-02-04 10:20 ` Ulf Hansson
2016-02-04 16:04 ` Alan Stern
2016-02-04 16:04 ` Alan Stern
2016-02-04 17:20 ` Tony Lindgren
2016-02-04 17:20 ` Tony Lindgren
2016-02-04 21:11 ` Ulf Hansson
2016-02-04 21:11 ` Ulf Hansson
2016-02-04 22:09 ` Alan Stern
2016-02-04 22:09 ` Alan Stern
2016-02-04 22:34 ` Ulf Hansson
2016-02-04 22:34 ` Ulf Hansson
2016-02-05 1:08 ` Tony Lindgren
2016-02-05 1:08 ` Tony Lindgren
2016-02-05 6:54 ` Ulf Hansson
2016-02-05 6:54 ` Ulf Hansson
2016-02-05 19:10 ` Tony Lindgren
2016-02-05 19:10 ` Tony Lindgren
2016-02-02 18:47 ` Tony Lindgren
2016-02-02 18:47 ` Tony Lindgren
2016-02-02 20:24 ` Ulf Hansson
2016-02-02 20:24 ` Ulf Hansson
2016-02-02 21:24 ` Alan Stern
2016-02-02 21:24 ` Alan Stern
2016-02-02 21:39 ` Tony Lindgren
2016-02-02 21:39 ` Tony Lindgren
2016-02-03 13:03 ` Rafael J. Wysocki
2016-02-03 13:03 ` Rafael J. Wysocki
2016-02-03 16:49 ` Tony Lindgren
2016-02-03 16:49 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126235222.GF19432@atomide.com \
--to=tony@atomide.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.