From: Tony Lindgren <tony@atomide.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Kevin Hilman <khilman@baylibre.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: PM regression with commit 5de85b9d57ab PM runtime re-init in v4.5-rc1
Date: Tue, 2 Feb 2016 08:49:10 -0800 [thread overview]
Message-ID: <20160202164910.GV19432@atomide.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1602021112320.1653-100000@iolanthe.rowland.org>
* Alan Stern <stern@rowland.harvard.edu> [160202 08:17]:
> On Tue, 2 Feb 2016, Ulf Hansson wrote:
> >
> > Your observations is correct. The hardware will be kept active
> > in-between the probe attempts (and thus also if probing fails).
> > Although, that's not a regression as that's the behaviour you get from
> > runtime PM, when drivers are implemented like omap_hsmmc.
>
> Perhaps this is what we should do. If probing gets deferred a few
> times, doing runtime suspends and resumes in between will be a waste of
> time.
That sounds like an optimization though. We'd still have to disable
the deviec somehow after deferred probe gives up.
> ? pm_runtime_put_sync() _already_ does not respect the autosuspend
> mode. If you want to respect it, you have to call
> pm_runtime_put_sync_autosuspend() instead.
I think you found the real bug there. So the right fix is to
call pm_runtime_put_sync_autosuspend() at the end of failed
probe in omap_hsmmc. Let me give that a try here.
Can we add some warning to pm_runtime_put_sync() about that?
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: PM regression with commit 5de85b9d57ab PM runtime re-init in v4.5-rc1
Date: Tue, 2 Feb 2016 08:49:10 -0800 [thread overview]
Message-ID: <20160202164910.GV19432@atomide.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1602021112320.1653-100000@iolanthe.rowland.org>
* Alan Stern <stern@rowland.harvard.edu> [160202 08:17]:
> On Tue, 2 Feb 2016, Ulf Hansson wrote:
> >
> > Your observations is correct. The hardware will be kept active
> > in-between the probe attempts (and thus also if probing fails).
> > Although, that's not a regression as that's the behaviour you get from
> > runtime PM, when drivers are implemented like omap_hsmmc.
>
> Perhaps this is what we should do. If probing gets deferred a few
> times, doing runtime suspends and resumes in between will be a waste of
> time.
That sounds like an optimization though. We'd still have to disable
the deviec somehow after deferred probe gives up.
> ? pm_runtime_put_sync() _already_ does not respect the autosuspend
> mode. If you want to respect it, you have to call
> pm_runtime_put_sync_autosuspend() instead.
I think you found the real bug there. So the right fix is to
call pm_runtime_put_sync_autosuspend() at the end of failed
probe in omap_hsmmc. Let me give that a try here.
Can we add some warning to pm_runtime_put_sync() about that?
Regards,
Tony
next prev parent reply other threads:[~2016-02-02 16:49 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 22:48 PM regression with commit 5de85b9d57ab PM runtime re-init in v4.5-rc1 Tony Lindgren
2016-01-26 22:48 ` Tony Lindgren
2016-01-26 22:50 ` Tony Lindgren
2016-01-26 22:50 ` Tony Lindgren
2016-01-26 23:14 ` Rafael J. Wysocki
2016-01-26 23:14 ` Rafael J. Wysocki
2016-01-26 23:22 ` Tony Lindgren
2016-01-26 23:22 ` Tony Lindgren
2016-01-26 23:37 ` Rafael J. Wysocki
2016-01-26 23:37 ` Rafael J. Wysocki
2016-01-26 23:52 ` Tony Lindgren
2016-01-26 23:52 ` Tony Lindgren
2016-01-27 7:54 ` Rafael J. Wysocki
2016-01-27 7:54 ` Rafael J. Wysocki
2016-01-27 8:17 ` Ulf Hansson
2016-01-27 8:17 ` Ulf Hansson
2016-01-27 15:19 ` Tony Lindgren
2016-01-27 15:19 ` Tony Lindgren
2016-01-27 22:51 ` Rafael J. Wysocki
2016-01-27 22:51 ` Rafael J. Wysocki
2016-01-28 14:29 ` Ulf Hansson
2016-01-28 14:29 ` Ulf Hansson
2016-01-28 16:58 ` Tony Lindgren
2016-01-28 16:58 ` Tony Lindgren
2016-02-01 16:44 ` Ulf Hansson
2016-02-01 16:44 ` Ulf Hansson
2016-02-01 18:11 ` Tony Lindgren
2016-02-01 18:11 ` Tony Lindgren
2016-02-01 22:06 ` Tony Lindgren
2016-02-01 22:06 ` Tony Lindgren
2016-02-01 22:17 ` Rafael J. Wysocki
2016-02-01 22:17 ` Rafael J. Wysocki
2016-02-01 22:29 ` Tony Lindgren
2016-02-01 22:29 ` Tony Lindgren
2016-02-01 23:10 ` Rafael J. Wysocki
2016-02-01 23:10 ` Rafael J. Wysocki
2016-02-01 23:28 ` Tony Lindgren
2016-02-01 23:28 ` Tony Lindgren
2016-02-01 23:44 ` Tony Lindgren
2016-02-01 23:44 ` Tony Lindgren
2016-02-01 23:49 ` Alan Stern
2016-02-01 23:49 ` Alan Stern
2016-02-02 3:05 ` Tony Lindgren
2016-02-02 3:05 ` Tony Lindgren
2016-02-02 10:07 ` Ulf Hansson
2016-02-02 10:07 ` Ulf Hansson
2016-02-02 10:42 ` Ulf Hansson
2016-02-02 10:42 ` Ulf Hansson
2016-02-02 16:23 ` Alan Stern
2016-02-02 16:23 ` Alan Stern
2016-02-02 16:35 ` Tony Lindgren
2016-02-02 16:35 ` Tony Lindgren
2016-02-02 20:47 ` Ulf Hansson
2016-02-02 20:47 ` Ulf Hansson
2016-02-02 23:41 ` Tony Lindgren
2016-02-02 23:41 ` Tony Lindgren
2016-02-03 10:23 ` Ulf Hansson
2016-02-03 10:23 ` Ulf Hansson
2016-02-03 10:25 ` Ulf Hansson
2016-02-03 10:25 ` Ulf Hansson
2016-02-03 12:18 ` Rafael J. Wysocki
2016-02-03 12:18 ` Rafael J. Wysocki
2016-02-03 14:58 ` Ulf Hansson
2016-02-03 14:58 ` Ulf Hansson
2016-02-03 15:45 ` Alan Stern
2016-02-03 15:45 ` Alan Stern
2016-02-03 16:09 ` Tony Lindgren
2016-02-03 16:09 ` Tony Lindgren
2016-02-03 16:24 ` Ulf Hansson
2016-02-03 16:24 ` Ulf Hansson
2016-02-03 17:01 ` Tony Lindgren
2016-02-03 17:01 ` Tony Lindgren
2016-02-03 17:16 ` Rafael J. Wysocki
2016-02-03 17:16 ` Rafael J. Wysocki
2016-02-03 16:27 ` Tony Lindgren
2016-02-03 16:27 ` Tony Lindgren
2016-02-03 18:02 ` Ulf Hansson
2016-02-03 18:02 ` Ulf Hansson
2016-02-03 18:28 ` Tony Lindgren
2016-02-03 18:28 ` Tony Lindgren
2016-02-03 18:37 ` Ulf Hansson
2016-02-03 18:37 ` Ulf Hansson
2016-02-03 18:45 ` Tony Lindgren
2016-02-03 18:45 ` Tony Lindgren
2016-02-03 21:51 ` Tony Lindgren
2016-02-03 21:51 ` Tony Lindgren
2016-02-02 16:15 ` Alan Stern
2016-02-02 16:15 ` Alan Stern
2016-02-02 16:49 ` Tony Lindgren [this message]
2016-02-02 16:49 ` Tony Lindgren
2016-02-02 18:05 ` Tony Lindgren
2016-02-02 18:05 ` Tony Lindgren
2016-02-02 18:43 ` Alan Stern
2016-02-02 18:43 ` Alan Stern
2016-02-02 18:54 ` Tony Lindgren
2016-02-02 18:54 ` Tony Lindgren
2016-02-02 19:16 ` Alan Stern
2016-02-02 19:16 ` Alan Stern
2016-02-02 21:03 ` Tony Lindgren
2016-02-02 21:03 ` Tony Lindgren
2016-02-02 21:45 ` Alan Stern
2016-02-02 21:45 ` Alan Stern
2016-02-02 23:46 ` Tony Lindgren
2016-02-02 23:46 ` Tony Lindgren
2016-02-03 13:06 ` Rafael J. Wysocki
2016-02-03 13:06 ` Rafael J. Wysocki
2016-02-03 16:36 ` Tony Lindgren
2016-02-03 16:36 ` Tony Lindgren
2016-02-03 15:48 ` Alan Stern
2016-02-03 15:48 ` Alan Stern
2016-02-03 16:37 ` Tony Lindgren
2016-02-03 16:37 ` Tony Lindgren
2016-02-03 17:18 ` Rafael J. Wysocki
2016-02-03 17:18 ` Rafael J. Wysocki
2016-02-03 17:22 ` Tony Lindgren
2016-02-03 17:22 ` Tony Lindgren
2016-02-03 17:27 ` Rafael J. Wysocki
2016-02-03 17:27 ` Rafael J. Wysocki
2016-02-04 10:20 ` Ulf Hansson
2016-02-04 10:20 ` Ulf Hansson
2016-02-04 16:04 ` Alan Stern
2016-02-04 16:04 ` Alan Stern
2016-02-04 17:20 ` Tony Lindgren
2016-02-04 17:20 ` Tony Lindgren
2016-02-04 21:11 ` Ulf Hansson
2016-02-04 21:11 ` Ulf Hansson
2016-02-04 22:09 ` Alan Stern
2016-02-04 22:09 ` Alan Stern
2016-02-04 22:34 ` Ulf Hansson
2016-02-04 22:34 ` Ulf Hansson
2016-02-05 1:08 ` Tony Lindgren
2016-02-05 1:08 ` Tony Lindgren
2016-02-05 6:54 ` Ulf Hansson
2016-02-05 6:54 ` Ulf Hansson
2016-02-05 19:10 ` Tony Lindgren
2016-02-05 19:10 ` Tony Lindgren
2016-02-02 18:47 ` Tony Lindgren
2016-02-02 18:47 ` Tony Lindgren
2016-02-02 20:24 ` Ulf Hansson
2016-02-02 20:24 ` Ulf Hansson
2016-02-02 21:24 ` Alan Stern
2016-02-02 21:24 ` Alan Stern
2016-02-02 21:39 ` Tony Lindgren
2016-02-02 21:39 ` Tony Lindgren
2016-02-03 13:03 ` Rafael J. Wysocki
2016-02-03 13:03 ` Rafael J. Wysocki
2016-02-03 16:49 ` Tony Lindgren
2016-02-03 16:49 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202164910.GV19432@atomide.com \
--to=tony@atomide.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.