From: hch@lst.de (Christoph Hellwig)
Subject: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional
Date: Mon, 8 Feb 2016 11:13:50 +0100 [thread overview]
Message-ID: <20160208101350.GA32632@lst.de> (raw)
In-Reply-To: <56B8676C.20600@dev.mellanox.co.il>
On Mon, Feb 08, 2016@12:01:16PM +0200, Sagi Grimberg wrote:
>
>> Do we have defined sysfs attributes for NVMe devices nowadays?
>
> /sys/block/nvme0n1/uuid
That's only supported for NVMe 1.1 and higher devices, and optional.
For older or stupid devices we need to support the algorithm based
on the serial attribute from nvme_fill_device_id_scsi_string() in
drivers/nvme/host/scsi.c.
Which btw is ?ncorrect as it doesn't identify namespaces properly,
and thus the associatation of 0 is an actively harmful lie.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagig@dev.mellanox.co.il>
Cc: Hannes Reinecke <hare@suse.de>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional
Date: Mon, 8 Feb 2016 11:13:50 +0100 [thread overview]
Message-ID: <20160208101350.GA32632@lst.de> (raw)
In-Reply-To: <56B8676C.20600@dev.mellanox.co.il>
On Mon, Feb 08, 2016 at 12:01:16PM +0200, Sagi Grimberg wrote:
>
>> Do we have defined sysfs attributes for NVMe devices nowadays?
>
> /sys/block/nvme0n1/uuid
That's only supported for NVMe 1.1 and higher devices, and optional.
For older or stupid devices we need to support the algorithm based
on the serial attribute from nvme_fill_device_id_scsi_string() in
drivers/nvme/host/scsi.c.
Which btw is іncorrect as it doesn't identify namespaces properly,
and thus the associatation of 0 is an actively harmful lie.
next prev parent reply other threads:[~2016-02-08 10:13 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 18:33 complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional James Bottomley
2016-02-06 18:33 ` James Bottomley
2016-02-07 9:22 ` Christoph Hellwig
2016-02-07 9:22 ` Christoph Hellwig
2016-02-07 16:04 ` James Bottomley
2016-02-07 16:04 ` James Bottomley
2016-02-07 22:28 ` Jens Axboe
2016-02-07 22:28 ` Jens Axboe
2016-02-07 23:07 ` James Bottomley
2016-02-07 23:07 ` James Bottomley
2016-02-08 7:24 ` Christoph Hellwig
2016-02-08 7:24 ` Christoph Hellwig
2016-02-08 7:32 ` Hannes Reinecke
2016-02-08 7:32 ` Hannes Reinecke
2016-02-08 10:01 ` Sagi Grimberg
2016-02-08 10:01 ` Sagi Grimberg
2016-02-08 10:13 ` Christoph Hellwig [this message]
2016-02-08 10:13 ` Christoph Hellwig
2016-02-08 15:12 ` Keith Busch
2016-02-08 15:12 ` Keith Busch
2016-02-08 15:19 ` Hannes Reinecke
2016-02-08 15:19 ` Hannes Reinecke
2016-02-08 16:15 ` Keith Busch
2016-02-08 16:15 ` Keith Busch
2016-02-08 15:23 ` James Bottomley
2016-02-08 15:23 ` James Bottomley
2016-02-09 12:50 ` Christoph Hellwig
2016-02-09 12:50 ` Christoph Hellwig
2016-02-09 13:29 ` Jens Axboe
2016-02-09 13:29 ` Jens Axboe
2016-02-09 17:12 ` Christoph Hellwig
2016-02-09 17:12 ` Christoph Hellwig
2016-02-09 17:14 ` Jens Axboe
2016-02-09 17:14 ` Jens Axboe
2016-02-09 17:19 ` Christoph Hellwig
2016-02-09 17:19 ` Christoph Hellwig
2016-02-09 17:19 ` Jens Axboe
2016-02-09 17:19 ` Jens Axboe
2016-02-09 15:37 ` James Bottomley
2016-02-09 15:37 ` James Bottomley
2016-02-08 7:26 ` Hannes Reinecke
2016-02-08 7:26 ` Hannes Reinecke
2016-02-08 7:26 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208101350.GA32632@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.