All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	"M. Braun" <michael-dev@fami-braun.de>,
	Johannes Berg <johannes@sipsolutions.net>,
	"David S . Miller" <davem@davemloft.net>,
	Felix Fietkau <nbd@nbd.name>
Subject: Re: [Bridge] [PATCH net-next] bridge: multicast to unicast
Date: Mon, 9 Jan 2017 13:30:32 -0800	[thread overview]
Message-ID: <20170109133032.221f8669@xeon-e3> (raw)
In-Reply-To: <20170109212345.GA5513@otheros>

On Mon, 9 Jan 2017 22:23:45 +0100
Linus Lüssing <linus.luessing@c0d3.blue> wrote:

> On Mon, Jan 09, 2017 at 12:44:19PM +0100, M. Braun wrote:
> > Am 09.01.2017 um 09:08 schrieb Johannes Berg:  
> > > Does it make sense to implement the two in separate layers though?
> > > 
> > > Clearly, this part needs to be implemented in the bridge layer due to
> > > the snooping knowledge, but the code is very similar to what mac80211
> > > has now.  
> > 
> > Does the bridge always know about all stations connected?  
> 
> The bridge does not always know about all stations, especially the
> silent ones like in your DVB-T example.
> 
> However, concerning IP multicast, there is IGMP/MLD. So the bridge
> does know about all stations which are interested in a specific IP
> multicast stream.
> 
> (As long as there is a querier on the link, which periodically
> queriers for IGMP/MLD reports from any listener. If there is no
> querier then the bridge multicast snooping, including the bridge
> multicast-to-unicast will fall back to flooding)
> 
> 
> So if your television example uses IP multicast properly, it is
> completely doable with the bridge multicast-to-unicast, thanks to
> IGMP/MLD.

I wonder if MAC80211 should be doing IGMP snooping and not bridge
in this environment.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: "M. Braun" <michael-dev@fami-braun.de>,
	Johannes Berg <johannes@sipsolutions.net>,
	Felix Fietkau <nbd@nbd.name>,
	netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH net-next] bridge: multicast to unicast
Date: Mon, 9 Jan 2017 13:30:32 -0800	[thread overview]
Message-ID: <20170109133032.221f8669@xeon-e3> (raw)
In-Reply-To: <20170109212345.GA5513@otheros>

On Mon, 9 Jan 2017 22:23:45 +0100
Linus L=C3=BCssing <linus.luessing@c0d3.blue> wrote:

> On Mon, Jan 09, 2017 at 12:44:19PM +0100, M. Braun wrote:
> > Am 09.01.2017 um 09:08 schrieb Johannes Berg: =20
> > > Does it make sense to implement the two in separate layers though?
> > >=20
> > > Clearly, this part needs to be implemented in the bridge layer due to
> > > the snooping knowledge, but the code is very similar to what mac80211
> > > has now. =20
> >=20
> > Does the bridge always know about all stations connected? =20
>=20
> The bridge does not always know about all stations, especially the
> silent ones like in your DVB-T example.
>=20
> However, concerning IP multicast, there is IGMP/MLD. So the bridge
> does know about all stations which are interested in a specific IP
> multicast stream.
>=20
> (As long as there is a querier on the link, which periodically
> queriers for IGMP/MLD reports from any listener. If there is no
> querier then the bridge multicast snooping, including the bridge
> multicast-to-unicast will fall back to flooding)
>=20
>=20
> So if your television example uses IP multicast properly, it is
> completely doable with the bridge multicast-to-unicast, thanks to
> IGMP/MLD.

I wonder if MAC80211 should be doing IGMP snooping and not bridge
in this environment.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: "M. Braun" <michael-dev@fami-braun.de>,
	Johannes Berg <johannes@sipsolutions.net>,
	Felix Fietkau <nbd@nbd.name>,
	netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH net-next] bridge: multicast to unicast
Date: Mon, 9 Jan 2017 13:30:32 -0800	[thread overview]
Message-ID: <20170109133032.221f8669@xeon-e3> (raw)
In-Reply-To: <20170109212345.GA5513@otheros>

On Mon, 9 Jan 2017 22:23:45 +0100
Linus Lüssing <linus.luessing@c0d3.blue> wrote:

> On Mon, Jan 09, 2017 at 12:44:19PM +0100, M. Braun wrote:
> > Am 09.01.2017 um 09:08 schrieb Johannes Berg:  
> > > Does it make sense to implement the two in separate layers though?
> > > 
> > > Clearly, this part needs to be implemented in the bridge layer due to
> > > the snooping knowledge, but the code is very similar to what mac80211
> > > has now.  
> > 
> > Does the bridge always know about all stations connected?  
> 
> The bridge does not always know about all stations, especially the
> silent ones like in your DVB-T example.
> 
> However, concerning IP multicast, there is IGMP/MLD. So the bridge
> does know about all stations which are interested in a specific IP
> multicast stream.
> 
> (As long as there is a querier on the link, which periodically
> queriers for IGMP/MLD reports from any listener. If there is no
> querier then the bridge multicast snooping, including the bridge
> multicast-to-unicast will fall back to flooding)
> 
> 
> So if your television example uses IP multicast properly, it is
> completely doable with the bridge multicast-to-unicast, thanks to
> IGMP/MLD.

I wonder if MAC80211 should be doing IGMP snooping and not bridge
in this environment.

  reply	other threads:[~2017-01-09 21:30 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 19:32 [Bridge] [PATCH net-next] bridge: multicast to unicast Linus Lüssing
2017-01-02 19:32 ` Linus Lüssing
2017-01-02 19:32 ` Linus Lüssing
2017-01-03 11:58 ` [Bridge] " Nikolay Aleksandrov
2017-01-03 11:58   ` Nikolay Aleksandrov via Bridge
2017-01-03 11:58   ` Nikolay Aleksandrov
2017-01-03 13:15 ` [Bridge] " Felix Fietkau
2017-01-03 13:15   ` Felix Fietkau
2017-01-06 12:47 ` [Bridge] " Johannes Berg
2017-01-06 12:47   ` Johannes Berg
2017-01-06 12:47   ` Johannes Berg
2017-01-06 13:52   ` [Bridge] " Felix Fietkau
2017-01-06 13:52     ` Felix Fietkau
2017-01-06 13:54     ` [Bridge] " Johannes Berg
2017-01-06 13:54       ` Johannes Berg
2017-01-06 13:54       ` Johannes Berg
2017-01-06 13:54       ` [Bridge] " Felix Fietkau
2017-01-06 13:54         ` Felix Fietkau
2017-01-07 10:32       ` [Bridge] " M. Braun
2017-01-07 10:32         ` M. Braun
2017-01-07 10:32         ` M. Braun
2017-01-07 14:55         ` [Bridge] " Linus Lüssing
2017-01-07 14:55           ` Linus Lüssing
2017-01-07 14:55           ` Linus Lüssing
2017-01-09  8:08           ` [Bridge] " Johannes Berg
2017-01-09  8:08             ` Johannes Berg
2017-01-09  8:08             ` Johannes Berg
2017-01-09 11:44             ` [Bridge] " M. Braun
2017-01-09 11:44               ` M. Braun
2017-01-09 11:44               ` M. Braun
2017-01-09 12:15               ` [Bridge] " Johannes Berg
2017-01-09 12:15                 ` Johannes Berg
2017-01-09 12:15                 ` Johannes Berg
2017-01-09 15:25                 ` [Bridge] " michael-dev
2017-01-09 15:25                   ` michael-dev
2017-01-09 15:47                   ` [Bridge] " Johannes Berg
2017-01-09 15:47                     ` Johannes Berg
2017-01-09 15:47                     ` Johannes Berg
2017-01-09 21:23               ` [Bridge] " Linus Lüssing
2017-01-09 21:23                 ` Linus Lüssing
2017-01-09 21:30                 ` Stephen Hemminger [this message]
2017-01-09 21:30                   ` Stephen Hemminger
2017-01-09 21:30                   ` Stephen Hemminger
2017-01-10  4:18                   ` [Bridge] " Linus Lüssing
2017-01-10  4:18                     ` Linus Lüssing
2017-01-10  4:18                     ` Linus Lüssing
2017-01-10 10:56                     ` [Bridge] " Johannes Berg
2017-01-10 10:56                       ` Johannes Berg
2017-01-10 10:56                       ` Johannes Berg
2017-01-10 17:17                       ` [Bridge] " Dave Taht
2017-01-10 17:17                         ` Dave Taht
2017-01-10 17:23                         ` [Bridge] " Felix Fietkau
2017-01-10 17:23                           ` Felix Fietkau
2017-01-10 17:23                           ` Felix Fietkau
2017-01-10 18:24                           ` [Bridge] " Dave Taht
2017-01-10 18:24                             ` Dave Taht
2017-01-10 18:24                             ` Dave Taht
2017-01-10 21:27                       ` [Bridge] " Felix Fietkau
2017-01-10 21:27                         ` Felix Fietkau
2017-01-10 21:27                         ` Felix Fietkau
2017-01-11 11:26                         ` [Bridge] " IgorMitsyanko
2017-01-11 11:26                           ` IgorMitsyanko
2017-01-11 11:30                           ` [Bridge] " Felix Fietkau
2017-01-11 11:30                             ` Felix Fietkau
2017-01-11 12:15                             ` [Bridge] " IgorMitsyanko
2017-01-11 12:15                               ` IgorMitsyanko
2017-01-11 12:21                               ` [Bridge] " Felix Fietkau
2017-01-11 12:21                                 ` Felix Fietkau
2017-01-07 15:15   ` [Bridge] " Linus Lüssing
2017-01-07 15:15     ` Linus Lüssing
2017-01-07 15:15     ` Linus Lüssing
2017-01-09  8:05     ` [Bridge] " Johannes Berg
2017-01-09  8:05       ` Johannes Berg
2017-01-09  8:05       ` Johannes Berg
2017-01-09 12:42       ` [Bridge] " Linus Lüssing
2017-01-09 12:42         ` Linus Lüssing
2017-01-09 12:42         ` Linus Lüssing
2017-01-09 12:44         ` [Bridge] " Johannes Berg
2017-01-09 12:44           ` Johannes Berg
2017-01-09 12:44           ` Johannes Berg
2017-01-09 23:12           ` [Bridge] " Linus Lüssing
2017-01-09 23:12             ` Linus Lüssing
2017-01-09 23:12             ` Linus Lüssing
2017-01-11  9:17             ` [Bridge] " Johannes Berg
2017-01-11  9:17               ` Johannes Berg
2017-01-11  9:17               ` Johannes Berg
2017-01-07  3:13 ` [Bridge] " Stephen Hemminger
2017-01-07  3:13   ` Stephen Hemminger
2017-01-07  3:13   ` Stephen Hemminger
2017-01-07  3:13   ` Stephen Hemminger
2017-01-07 15:06   ` [Bridge] " Linus Lüssing
2017-01-07 15:06     ` Linus Lüssing
2017-01-07 15:06     ` Linus Lüssing
2017-01-09  8:36   ` [Bridge] " Jean-Pierre Tosoni
2017-01-09  8:36     ` Jean-Pierre Tosoni
2017-01-09  8:36     ` Jean-Pierre Tosoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170109133032.221f8669@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=johannes@sipsolutions.net \
    --cc=linus.luessing@c0d3.blue \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michael-dev@fami-braun.de \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.