* [PATCH] drm: Reduce scope of 'state' variable
@ 2017-06-15 10:41 ` Dawid Kurek
0 siblings, 0 replies; 10+ messages in thread
From: Dawid Kurek @ 2017-06-15 10:41 UTC (permalink / raw)
To: Daniel Vetter, Jani Nikula, Sean Paul, David Airlie, dri-devel,
linux-kernel
Smaller scope reduces visibility of variable and makes usage of
uninitialized variable less possible.
---
drivers/gpu/drm/drm_atomic.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index f32506a..ea5a9a7 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -108,10 +108,11 @@ struct drm_atomic_state *
drm_atomic_state_alloc(struct drm_device *dev)
{
struct drm_mode_config *config = &dev->mode_config;
- struct drm_atomic_state *state;
if (!config->funcs->atomic_state_alloc) {
- state = kzalloc(sizeof(*state), GFP_KERNEL);
+ struct drm_atomic_state *state
+ = kzalloc(sizeof(*state), GFP_KERNEL);
+
if (!state)
return NULL;
if (drm_atomic_state_init(dev, state) < 0) {
--
2.10.0
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] drm: Reduce scope of 'state' variable
@ 2017-06-15 10:41 ` Dawid Kurek
0 siblings, 0 replies; 10+ messages in thread
From: Dawid Kurek @ 2017-06-15 10:41 UTC (permalink / raw)
To: Daniel Vetter, Jani Nikula, Sean Paul, David Airlie, dri-devel,
linux-kernel
Smaller scope reduces visibility of variable and makes usage of
uninitialized variable less possible.
---
drivers/gpu/drm/drm_atomic.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index f32506a..ea5a9a7 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -108,10 +108,11 @@ struct drm_atomic_state *
drm_atomic_state_alloc(struct drm_device *dev)
{
struct drm_mode_config *config = &dev->mode_config;
- struct drm_atomic_state *state;
if (!config->funcs->atomic_state_alloc) {
- state = kzalloc(sizeof(*state), GFP_KERNEL);
+ struct drm_atomic_state *state
+ = kzalloc(sizeof(*state), GFP_KERNEL);
+
if (!state)
return NULL;
if (drm_atomic_state_init(dev, state) < 0) {
--
2.10.0
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] drm: Reduce scope of 'state' variable
2017-06-15 10:41 ` Dawid Kurek
@ 2017-06-15 11:09 ` Jani Nikula
-1 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2017-06-15 11:09 UTC (permalink / raw)
To: Dawid Kurek, Daniel Vetter, Sean Paul, David Airlie, dri-devel,
linux-kernel
On Thu, 15 Jun 2017, Dawid Kurek <dawikur@gmail.com> wrote:
> Smaller scope reduces visibility of variable and makes usage of
> uninitialized variable less possible.
> ---
> drivers/gpu/drm/drm_atomic.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
> index f32506a..ea5a9a7 100644
> --- a/drivers/gpu/drm/drm_atomic.c
> +++ b/drivers/gpu/drm/drm_atomic.c
> @@ -108,10 +108,11 @@ struct drm_atomic_state *
> drm_atomic_state_alloc(struct drm_device *dev)
> {
> struct drm_mode_config *config = &dev->mode_config;
> - struct drm_atomic_state *state;
>
> if (!config->funcs->atomic_state_alloc) {
> - state = kzalloc(sizeof(*state), GFP_KERNEL);
> + struct drm_atomic_state *state
> + = kzalloc(sizeof(*state), GFP_KERNEL);
Separate declaration and initialization would lead to a cleaner patch
and result.
BR,
Jani.
> +
> if (!state)
> return NULL;
> if (drm_atomic_state_init(dev, state) < 0) {
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] drm: Reduce scope of 'state' variable
@ 2017-06-15 11:09 ` Jani Nikula
0 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2017-06-15 11:09 UTC (permalink / raw)
To: Dawid Kurek, Daniel Vetter, Sean Paul, David Airlie, dri-devel,
linux-kernel
On Thu, 15 Jun 2017, Dawid Kurek <dawikur@gmail.com> wrote:
> Smaller scope reduces visibility of variable and makes usage of
> uninitialized variable less possible.
> ---
> drivers/gpu/drm/drm_atomic.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
> index f32506a..ea5a9a7 100644
> --- a/drivers/gpu/drm/drm_atomic.c
> +++ b/drivers/gpu/drm/drm_atomic.c
> @@ -108,10 +108,11 @@ struct drm_atomic_state *
> drm_atomic_state_alloc(struct drm_device *dev)
> {
> struct drm_mode_config *config = &dev->mode_config;
> - struct drm_atomic_state *state;
>
> if (!config->funcs->atomic_state_alloc) {
> - state = kzalloc(sizeof(*state), GFP_KERNEL);
> + struct drm_atomic_state *state
> + = kzalloc(sizeof(*state), GFP_KERNEL);
Separate declaration and initialization would lead to a cleaner patch
and result.
BR,
Jani.
> +
> if (!state)
> return NULL;
> if (drm_atomic_state_init(dev, state) < 0) {
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] drm: Reduce scope of 'state' variable
2017-06-15 11:09 ` Jani Nikula
@ 2017-06-15 14:24 ` Dawid Kurek
-1 siblings, 0 replies; 10+ messages in thread
From: Dawid Kurek @ 2017-06-15 14:24 UTC (permalink / raw)
To: Jani Nikula; +Cc: Daniel Vetter, linux-kernel, dri-devel
On 15/06/17, Jani Nikula wrote:
> On Thu, 15 Jun 2017, Dawid Kurek <dawikur@gmail.com> wrote:
> > Smaller scope reduces visibility of variable and makes usage of
> > uninitialized variable less possible.
> > ---
> > drivers/gpu/drm/drm_atomic.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
> > index f32506a..ea5a9a7 100644
> > --- a/drivers/gpu/drm/drm_atomic.c
> > +++ b/drivers/gpu/drm/drm_atomic.c
> > @@ -108,10 +108,11 @@ struct drm_atomic_state *
> > drm_atomic_state_alloc(struct drm_device *dev)
> > {
> > struct drm_mode_config *config = &dev->mode_config;
> > - struct drm_atomic_state *state;
> >
> > if (!config->funcs->atomic_state_alloc) {
> > - state = kzalloc(sizeof(*state), GFP_KERNEL);
> > + struct drm_atomic_state *state
> > + = kzalloc(sizeof(*state), GFP_KERNEL);
>
> Separate declaration and initialization would lead to a cleaner patch
> and result.
I saw combining declaration and initialization is quite common, i.e. in
drm_atomic file. Personally, I also prefer those in one statement. But yes, it
looks cleaner here, in two lines.
v2 sent :)
Thanks,
Dawid
>
> BR,
> Jani.
>
> > +
> > if (!state)
> > return NULL;
> > if (drm_atomic_state_init(dev, state) < 0) {
>
> --
> Jani Nikula, Intel Open Source Technology Center
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] drm: Reduce scope of 'state' variable
@ 2017-06-15 14:24 ` Dawid Kurek
0 siblings, 0 replies; 10+ messages in thread
From: Dawid Kurek @ 2017-06-15 14:24 UTC (permalink / raw)
To: Jani Nikula
Cc: Daniel Vetter, Sean Paul, David Airlie, dri-devel, linux-kernel
On 15/06/17, Jani Nikula wrote:
> On Thu, 15 Jun 2017, Dawid Kurek <dawikur@gmail.com> wrote:
> > Smaller scope reduces visibility of variable and makes usage of
> > uninitialized variable less possible.
> > ---
> > drivers/gpu/drm/drm_atomic.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
> > index f32506a..ea5a9a7 100644
> > --- a/drivers/gpu/drm/drm_atomic.c
> > +++ b/drivers/gpu/drm/drm_atomic.c
> > @@ -108,10 +108,11 @@ struct drm_atomic_state *
> > drm_atomic_state_alloc(struct drm_device *dev)
> > {
> > struct drm_mode_config *config = &dev->mode_config;
> > - struct drm_atomic_state *state;
> >
> > if (!config->funcs->atomic_state_alloc) {
> > - state = kzalloc(sizeof(*state), GFP_KERNEL);
> > + struct drm_atomic_state *state
> > + = kzalloc(sizeof(*state), GFP_KERNEL);
>
> Separate declaration and initialization would lead to a cleaner patch
> and result.
I saw combining declaration and initialization is quite common, i.e. in
drm_atomic file. Personally, I also prefer those in one statement. But yes, it
looks cleaner here, in two lines.
v2 sent :)
Thanks,
Dawid
>
> BR,
> Jani.
>
> > +
> > if (!state)
> > return NULL;
> > if (drm_atomic_state_init(dev, state) < 0) {
>
> --
> Jani Nikula, Intel Open Source Technology Center
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] drm: Reduce scope of 'state' variable
2017-06-15 14:24 ` Dawid Kurek
@ 2017-06-15 15:10 ` Jani Nikula
-1 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2017-06-15 15:10 UTC (permalink / raw)
To: Dawid Kurek; +Cc: Daniel Vetter, linux-kernel, dri-devel
On Thu, 15 Jun 2017, Dawid Kurek <dawikur@gmail.com> wrote:
> On 15/06/17, Jani Nikula wrote:
>> Separate declaration and initialization would lead to a cleaner patch
>> and result.
>
> I saw combining declaration and initialization is quite common, i.e. in
> drm_atomic file. Personally, I also prefer those in one statement. But yes, it
> looks cleaner here, in two lines.
I'd say the rule of thumb is that combined declaration and
initialization is fine if the initialization is trivial, in particular
can never fail. If you need to check the return value, like in this
case, I'd prefer separate initialization.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm: Reduce scope of 'state' variable
@ 2017-06-15 15:10 ` Jani Nikula
0 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2017-06-15 15:10 UTC (permalink / raw)
To: Dawid Kurek
Cc: Daniel Vetter, Sean Paul, David Airlie, dri-devel, linux-kernel
On Thu, 15 Jun 2017, Dawid Kurek <dawikur@gmail.com> wrote:
> On 15/06/17, Jani Nikula wrote:
>> Separate declaration and initialization would lead to a cleaner patch
>> and result.
>
> I saw combining declaration and initialization is quite common, i.e. in
> drm_atomic file. Personally, I also prefer those in one statement. But yes, it
> looks cleaner here, in two lines.
I'd say the rule of thumb is that combined declaration and
initialization is fine if the initialization is trivial, in particular
can never fail. If you need to check the return value, like in this
case, I'd prefer separate initialization.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm: Reduce scope of 'state' variable
2017-06-15 15:10 ` Jani Nikula
@ 2017-06-15 16:56 ` Dawid Kurek
-1 siblings, 0 replies; 10+ messages in thread
From: Dawid Kurek @ 2017-06-15 16:56 UTC (permalink / raw)
To: Jani Nikula; +Cc: Daniel Vetter, linux-kernel, dri-devel
On 15/06/17, Jani Nikula wrote:
> On Thu, 15 Jun 2017, Dawid Kurek <dawikur@gmail.com> wrote:
> > On 15/06/17, Jani Nikula wrote:
> >> Separate declaration and initialization would lead to a cleaner patch
> >> and result.
> >
> > I saw combining declaration and initialization is quite common, i.e. in
> > drm_atomic file. Personally, I also prefer those in one statement. But yes, it
> > looks cleaner here, in two lines.
>
> I'd say the rule of thumb is that combined declaration and
> initialization is fine if the initialization is trivial, in particular
> can never fail. If you need to check the return value, like in this
> case, I'd prefer separate initialization.
>
Yeah, makes sense. If you need to check then it exceeds simple initialization,
and then it is not declare&initialize. Yes, now I see it.
Thanks a lot,
Dawid
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm: Reduce scope of 'state' variable
@ 2017-06-15 16:56 ` Dawid Kurek
0 siblings, 0 replies; 10+ messages in thread
From: Dawid Kurek @ 2017-06-15 16:56 UTC (permalink / raw)
To: Jani Nikula
Cc: Daniel Vetter, Sean Paul, David Airlie, dri-devel, linux-kernel
On 15/06/17, Jani Nikula wrote:
> On Thu, 15 Jun 2017, Dawid Kurek <dawikur@gmail.com> wrote:
> > On 15/06/17, Jani Nikula wrote:
> >> Separate declaration and initialization would lead to a cleaner patch
> >> and result.
> >
> > I saw combining declaration and initialization is quite common, i.e. in
> > drm_atomic file. Personally, I also prefer those in one statement. But yes, it
> > looks cleaner here, in two lines.
>
> I'd say the rule of thumb is that combined declaration and
> initialization is fine if the initialization is trivial, in particular
> can never fail. If you need to check the return value, like in this
> case, I'd prefer separate initialization.
>
Yeah, makes sense. If you need to check then it exceeds simple initialization,
and then it is not declare&initialize. Yes, now I see it.
Thanks a lot,
Dawid
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-06-15 16:57 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-15 10:41 [PATCH] drm: Reduce scope of 'state' variable Dawid Kurek
2017-06-15 10:41 ` Dawid Kurek
2017-06-15 11:09 ` Jani Nikula
2017-06-15 11:09 ` Jani Nikula
2017-06-15 14:24 ` Dawid Kurek
2017-06-15 14:24 ` Dawid Kurek
2017-06-15 15:10 ` Jani Nikula
2017-06-15 15:10 ` Jani Nikula
2017-06-15 16:56 ` Dawid Kurek
2017-06-15 16:56 ` Dawid Kurek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.