From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Manikanta Maddireddy <mmaddireddy@nvidia.com>,
bhelgaas@google.com, jonathanh@nvidia.com, vidyas@nvidia.com,
mperttunen@nvidia.com, linux-tegra@vger.kernel.org,
linux-pci@vger.kernel.org, kthota@nvidia.com
Subject: Re: [PATCH V3 02/12] PCI: tegra: Move REFCLK pad settings out of phy_power_on()
Date: Tue, 19 Dec 2017 12:40:41 +0000 [thread overview]
Message-ID: <20171219124041.GC19911@red-moon> (raw)
In-Reply-To: <20171214151452.GD13733@ulmo>
On Thu, Dec 14, 2017 at 04:14:52PM +0100, Thierry Reding wrote:
> On Mon, Oct 30, 2017 at 07:27:13PM +0530, Manikanta Maddireddy wrote:
> > In Tegra186 PHY programming is done by BPMP-FW, so PHY calls are skipped
> > in driver. REFCLK pad settings are independent of PHY and should be
> > programmed by driver. So move REFCLK pad settings out of phy_power_on().
> > These pad settings improve REFCLK peak to peak amplitude.
> >
> > Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
> > ---
> > V3:
> > * Corrected commit log
> > V2:
> > * no change in this patch
> >
> > drivers/pci/host/pci-tegra.c | 20 +++++++++++++-------
> > 1 file changed, 13 insertions(+), 7 deletions(-)
>
> As far as I can tell, this is a bugfix that can and should be applied
> independently of the rest of the series.
>
> Acked-by: Thierry Reding <treding@nvidia.com>
Ok, I will apply - I would add a Fixes: tag though.
Is:
Fixes: cf5d31801278 ("PCI: tegra: Program PADS_REFCLK_CFG* always, not
just on legacy SoCs")
the correct commit ?
Thanks,
Lorenzo
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>
To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Manikanta Maddireddy
<mmaddireddy-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
vidyas-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kthota-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH V3 02/12] PCI: tegra: Move REFCLK pad settings out of phy_power_on()
Date: Tue, 19 Dec 2017 12:40:41 +0000 [thread overview]
Message-ID: <20171219124041.GC19911@red-moon> (raw)
In-Reply-To: <20171214151452.GD13733@ulmo>
On Thu, Dec 14, 2017 at 04:14:52PM +0100, Thierry Reding wrote:
> On Mon, Oct 30, 2017 at 07:27:13PM +0530, Manikanta Maddireddy wrote:
> > In Tegra186 PHY programming is done by BPMP-FW, so PHY calls are skipped
> > in driver. REFCLK pad settings are independent of PHY and should be
> > programmed by driver. So move REFCLK pad settings out of phy_power_on().
> > These pad settings improve REFCLK peak to peak amplitude.
> >
> > Signed-off-by: Manikanta Maddireddy <mmaddireddy-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> > ---
> > V3:
> > * Corrected commit log
> > V2:
> > * no change in this patch
> >
> > drivers/pci/host/pci-tegra.c | 20 +++++++++++++-------
> > 1 file changed, 13 insertions(+), 7 deletions(-)
>
> As far as I can tell, this is a bugfix that can and should be applied
> independently of the rest of the series.
>
> Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Ok, I will apply - I would add a Fixes: tag though.
Is:
Fixes: cf5d31801278 ("PCI: tegra: Program PADS_REFCLK_CFG* always, not
just on legacy SoCs")
the correct commit ?
Thanks,
Lorenzo
next prev parent reply other threads:[~2017-12-19 12:39 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 13:57 [PATCH V3 00/12] Enable Tegra root port features and apply SW fixups Manikanta Maddireddy
2017-10-30 13:57 ` Manikanta Maddireddy
2017-10-30 13:57 ` [PATCH V3 01/12] PCI: tegra: Start LTSSM after programming root port Manikanta Maddireddy
2017-10-30 13:57 ` Manikanta Maddireddy
2017-12-12 11:32 ` Lorenzo Pieralisi
2017-12-12 11:32 ` Lorenzo Pieralisi
2017-12-13 11:50 ` Manikanta Maddireddy
2017-12-13 11:50 ` Manikanta Maddireddy
2017-12-13 14:08 ` Lorenzo Pieralisi
2017-12-13 14:08 ` Lorenzo Pieralisi
2017-12-13 16:32 ` Manikanta Maddireddy
2017-12-13 16:32 ` Manikanta Maddireddy
2017-12-13 18:34 ` Lorenzo Pieralisi
2017-12-13 18:34 ` Lorenzo Pieralisi
2017-12-13 19:27 ` Manikanta Maddireddy
2017-12-13 19:27 ` Manikanta Maddireddy
2017-12-14 9:57 ` Lorenzo Pieralisi
2017-12-14 9:57 ` Lorenzo Pieralisi
2018-03-07 12:00 ` Lorenzo Pieralisi
2018-03-07 17:10 ` Manikanta Maddireddy
2017-10-30 13:57 ` [PATCH V3 02/12] PCI: tegra: Move REFCLK pad settings out of phy_power_on() Manikanta Maddireddy
2017-10-30 13:57 ` Manikanta Maddireddy
2017-12-12 11:45 ` Lorenzo Pieralisi
2017-12-12 11:45 ` Lorenzo Pieralisi
2017-12-13 12:02 ` Manikanta Maddireddy
2017-12-13 12:02 ` Manikanta Maddireddy
2017-12-13 14:23 ` Lorenzo Pieralisi
2017-12-13 1:16 ` Mikko Perttunen
2017-12-13 1:16 ` Mikko Perttunen
2017-12-14 15:14 ` Thierry Reding
2017-12-19 12:40 ` Lorenzo Pieralisi [this message]
2017-12-19 12:40 ` Lorenzo Pieralisi
2017-10-30 13:57 ` [PATCH V3 03/12] PCI: tegra: Retrain link for Gen2 speed Manikanta Maddireddy
2017-10-30 13:57 ` Manikanta Maddireddy
2017-12-12 14:32 ` Lorenzo Pieralisi
2017-12-12 14:32 ` Lorenzo Pieralisi
2017-12-13 17:54 ` Manikanta Maddireddy
2017-12-13 17:54 ` Manikanta Maddireddy
2017-12-13 18:51 ` Lorenzo Pieralisi
2017-12-13 18:51 ` Lorenzo Pieralisi
2017-12-13 19:10 ` Bjorn Helgaas
2017-12-13 19:10 ` Bjorn Helgaas
2017-12-21 19:48 ` Ley Foon Tan
2017-12-21 19:48 ` Ley Foon Tan
2017-10-30 13:57 ` [PATCH V3 04/12] PCI: tegra: Advertise PCIe Advanced Error Reporting (AER) capability Manikanta Maddireddy
2017-10-30 13:57 ` Manikanta Maddireddy
2017-12-14 15:29 ` Thierry Reding
2017-12-14 15:29 ` Thierry Reding
2017-10-30 13:57 ` [PATCH V3 05/12] PCI: tegra: Program UPHY electrical settings in Tegra210 Manikanta Maddireddy
2017-10-30 13:57 ` Manikanta Maddireddy
2017-12-14 15:28 ` Thierry Reding
2017-12-14 15:28 ` Thierry Reding
2017-10-30 13:57 ` [PATCH V3 06/12] PCI: tegra: Enable opportunistic update FC and ACK Manikanta Maddireddy
2017-10-30 13:57 ` Manikanta Maddireddy
2017-12-14 15:30 ` Thierry Reding
2017-12-14 15:30 ` Thierry Reding
2017-10-30 13:57 ` [PATCH V3 07/12] PCI: tegra: Disable AFI dynamic clock gating Manikanta Maddireddy
2017-10-30 13:57 ` Manikanta Maddireddy
2017-12-14 15:32 ` Thierry Reding
2017-12-14 15:32 ` Thierry Reding
2017-10-30 13:57 ` [PATCH V3 08/12] PCI: tegra: Wait for DLLP to finish before entering L1 or L2 Manikanta Maddireddy
2017-10-30 13:57 ` Manikanta Maddireddy
2017-12-14 15:34 ` Thierry Reding
2017-12-14 15:34 ` Thierry Reding
2017-10-30 13:57 ` [PATCH V3 09/12] PCI: tegra: Enable PCIe xclk clock clamping Manikanta Maddireddy
2017-10-30 13:57 ` Manikanta Maddireddy
2017-12-14 15:58 ` Thierry Reding
2017-12-14 15:58 ` Thierry Reding
2017-10-30 13:57 ` [PATCH V3 10/12] PCI: tegra: Add SW fixup for RAW violations Manikanta Maddireddy
2017-10-30 13:57 ` Manikanta Maddireddy
2017-12-14 16:00 ` Thierry Reding
2017-12-14 16:00 ` Thierry Reding
2017-10-30 13:57 ` [PATCH V3 11/12] PCI: tegra: Increase the deskew retry time Manikanta Maddireddy
2017-10-30 13:57 ` Manikanta Maddireddy
2017-12-14 16:02 ` Thierry Reding
2017-10-30 13:57 ` [PATCH V3 12/12] PCI: tegra: Update flow control threshold in Tegra210 Manikanta Maddireddy
2017-10-30 13:57 ` Manikanta Maddireddy
2017-12-12 17:43 ` Lorenzo Pieralisi
2017-12-12 17:43 ` Lorenzo Pieralisi
2017-12-14 16:13 ` Thierry Reding
2017-12-14 16:13 ` Thierry Reding
2017-12-14 16:14 ` Thierry Reding
2017-12-14 16:14 ` Thierry Reding
2017-11-25 19:59 ` [PATCH V3 00/12] Enable Tegra root port features and apply SW fixups Manikanta Maddireddy
2017-11-25 19:59 ` Manikanta Maddireddy
2017-11-27 18:09 ` Lorenzo Pieralisi
2017-11-27 18:09 ` Lorenzo Pieralisi
2017-11-27 18:27 ` Manikanta Maddireddy
2017-11-27 18:27 ` Manikanta Maddireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219124041.GC19911@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=mperttunen@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.