All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Appana Durga Kedareswara Rao <appanad@xilinx.com>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"akinobu.mita@gmail.com" <akinobu.mita@gmail.com>,
	"joabreu@synopsys.com" <joabreu@synopsys.com>,
	"mike.looijmans@topic.nl" <mike.looijmans@topic.nl>,
	"kedare06@gmail.com" <kedare06@gmail.com>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [v2,1/4] dmaengine: xilinx_dma: populate dma caps properly
Date: Tue, 9 Jan 2018 10:34:50 +0530	[thread overview]
Message-ID: <20180109050449.GO18649@localhost> (raw)

On Tue, Jan 09, 2018 at 04:48:10AM +0000, Appana Durga Kedareswara Rao wrote:
> Hi,
> 
> >On Mon, Jan 08, 2018 at 05:25:01PM +0000, Appana Durga Kedareswara Rao
> >wrote:
> >> Hi,
> >>
> >> <Snip>
> >> >> >> +	xdev->common.dst_addr_widths = BIT(addr_width / 8);
> >> >> >> +	xdev->common.src_addr_widths = BIT(addr_width / 8);
> >> >> >
> >> >> >Do you not support trf of 1byte, 2 bytes, or 4 bytes wide transfers?
> >> >> >What is value of addr_width here typically? Usually controllers
> >> >> >can support different widths and this is a surprise that you
> >> >> >support only one value
> >> >>
> >> >> Controller supports address width of 32 and 64.
> >> >
> >> >Then this should have both 32 and 64 values here
> >>
> >> Address width is configurable parameter at the h/w level.
> >> Since this IP is a soft IP user can create a design with either 32-bit
> >> or 64-bit address configuration.
> >
> >and not both right?
> 
> Yes not both at the same time... 
> Axi dma controller can be configured for either 32-bit or 64-bit address...

So my suspicion was correct.  I would suggest you to read up on the
documentation again. The src/dst_addr_widths has _nothing_ to do with 32/64
bit addresses used.

It is the capability of the dma controller to do transfers with data width as
8bits, 16 bits, so on. iKey is "data width" and not address type.
This typically translates to DMA FIFO configuration of the controller!

WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly
Date: Tue, 9 Jan 2018 10:34:50 +0530	[thread overview]
Message-ID: <20180109050449.GO18649@localhost> (raw)
In-Reply-To: <CY1PR02MB1692292DE4B4F346B92BD4EBDC100@CY1PR02MB1692.namprd02.prod.outlook.com>

On Tue, Jan 09, 2018 at 04:48:10AM +0000, Appana Durga Kedareswara Rao wrote:
> Hi,
> 
> >On Mon, Jan 08, 2018 at 05:25:01PM +0000, Appana Durga Kedareswara Rao
> >wrote:
> >> Hi,
> >>
> >> <Snip>
> >> >> >> +	xdev->common.dst_addr_widths = BIT(addr_width / 8);
> >> >> >> +	xdev->common.src_addr_widths = BIT(addr_width / 8);
> >> >> >
> >> >> >Do you not support trf of 1byte, 2 bytes, or 4 bytes wide transfers?
> >> >> >What is value of addr_width here typically? Usually controllers
> >> >> >can support different widths and this is a surprise that you
> >> >> >support only one value
> >> >>
> >> >> Controller supports address width of 32 and 64.
> >> >
> >> >Then this should have both 32 and 64 values here
> >>
> >> Address width is configurable parameter at the h/w level.
> >> Since this IP is a soft IP user can create a design with either 32-bit
> >> or 64-bit address configuration.
> >
> >and not both right?
> 
> Yes not both at the same time... 
> Axi dma controller can be configured for either 32-bit or 64-bit address...

So my suspicion was correct.  I would suggest you to read up on the
documentation again. The src/dst_addr_widths has _nothing_ to do with 32/64
bit addresses used.

It is the capability of the dma controller to do transfers with data width as
8bits, 16 bits, so on. iKey is "data width" and not address type.
This typically translates to DMA FIFO configuration of the controller!

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Appana Durga Kedareswara Rao <appanad@xilinx.com>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"akinobu.mita@gmail.com" <akinobu.mita@gmail.com>,
	"joabreu@synopsys.com" <joabreu@synopsys.com>,
	"mike.looijmans@topic.nl" <mike.looijmans@topic.nl>,
	"kedare06@gmail.com" <kedare06@gmail.com>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly
Date: Tue, 9 Jan 2018 10:34:50 +0530	[thread overview]
Message-ID: <20180109050449.GO18649@localhost> (raw)
In-Reply-To: <CY1PR02MB1692292DE4B4F346B92BD4EBDC100@CY1PR02MB1692.namprd02.prod.outlook.com>

On Tue, Jan 09, 2018 at 04:48:10AM +0000, Appana Durga Kedareswara Rao wrote:
> Hi,
> 
> >On Mon, Jan 08, 2018 at 05:25:01PM +0000, Appana Durga Kedareswara Rao
> >wrote:
> >> Hi,
> >>
> >> <Snip>
> >> >> >> +	xdev->common.dst_addr_widths = BIT(addr_width / 8);
> >> >> >> +	xdev->common.src_addr_widths = BIT(addr_width / 8);
> >> >> >
> >> >> >Do you not support trf of 1byte, 2 bytes, or 4 bytes wide transfers?
> >> >> >What is value of addr_width here typically? Usually controllers
> >> >> >can support different widths and this is a surprise that you
> >> >> >support only one value
> >> >>
> >> >> Controller supports address width of 32 and 64.
> >> >
> >> >Then this should have both 32 and 64 values here
> >>
> >> Address width is configurable parameter at the h/w level.
> >> Since this IP is a soft IP user can create a design with either 32-bit
> >> or 64-bit address configuration.
> >
> >and not both right?
> 
> Yes not both at the same time... 
> Axi dma controller can be configured for either 32-bit or 64-bit address...

So my suspicion was correct.  I would suggest you to read up on the
documentation again. The src/dst_addr_widths has _nothing_ to do with 32/64
bit addresses used.

It is the capability of the dma controller to do transfers with data width as
8bits, 16 bits, so on. iKey is "data width" and not address type.
This typically translates to DMA FIFO configuration of the controller!

-- 
~Vinod

             reply	other threads:[~2018-01-09  5:04 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09  5:04 Vinod Koul [this message]
2018-01-09  5:04 ` [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly Vinod Koul
2018-01-09  5:04 ` Vinod Koul
  -- strict thread matches above, loose matches on Subject: below --
2018-01-11  6:21 [v2,1/4] " Vinod Koul
2018-01-11  6:21 ` [PATCH v2 1/4] " Vinod Koul
2018-01-11  6:21 ` Vinod Koul
2018-01-09  7:36 [v2,1/4] " Appana Durga Kedareswara Rao
2018-01-09  7:36 ` [PATCH v2 1/4] " Appana Durga Kedareswara Rao
2018-01-09  7:36 ` Appana Durga Kedareswara Rao
2018-01-09  4:48 [v2,1/4] " Vinod Koul
2018-01-09  4:48 ` [PATCH v2 1/4] " Vinod Koul
2018-01-09  4:48 ` Vinod Koul
2018-01-09  4:48 [v2,1/4] " Appana Durga Kedareswara Rao
2018-01-09  4:48 ` [PATCH v2 1/4] " Appana Durga Kedareswara Rao
2018-01-09  4:48 ` Appana Durga Kedareswara Rao
2018-01-08 17:25 [v2,1/4] " Appana Durga Kedareswara Rao
2018-01-08 17:25 ` [PATCH v2 1/4] " Appana Durga Kedareswara Rao
2018-01-08 17:25 ` Appana Durga Kedareswara Rao
2018-01-08 17:06 [v2,1/4] " Vinod Koul
2018-01-08 17:06 ` [PATCH v2 1/4] " Vinod Koul
2018-01-08 17:06 ` Vinod Koul
2018-01-08 10:55 [v2,2/4] dmaengine: xilinx_dma: properly configure the SG mode bit in the driver for cdma Vinod Koul
2018-01-08 10:55 ` [PATCH v2 2/4] " Vinod Koul
2018-01-08 10:55 ` Vinod Koul
2018-01-08 10:52 [v2,1/4] dmaengine: xilinx_dma: populate dma caps properly Appana Durga Kedareswara Rao
2018-01-08 10:52 ` [PATCH v2 1/4] " Appana Durga Kedareswara Rao
2018-01-08 10:52 ` Appana Durga Kedareswara Rao
2018-01-08 10:38 [v2,1/4] " Vinod Koul
2018-01-08 10:38 ` [PATCH v2 1/4] " Vinod Koul
2018-01-08 10:38 ` Vinod Koul
2018-01-03  6:42 [v2,4/4] dmaengine: xilinx_dma: Free BD consistent memory Kedareswara rao Appana
2018-01-03  6:42 ` [PATCH v2 4/4] " Kedareswara rao Appana
2018-01-03  6:42 ` Kedareswara rao Appana
2018-01-03  6:42 [v2,3/4] dmaengine: xilinx_dma: Fix warning variable prev set but not used Kedareswara rao Appana
2018-01-03  6:42 ` [PATCH v2 3/4] " Kedareswara rao Appana
2018-01-03  6:42 ` Kedareswara rao Appana
2018-01-03  6:42 [v2,2/4] dmaengine: xilinx_dma: properly configure the SG mode bit in the driver for cdma Kedareswara rao Appana
2018-01-03  6:42 ` [PATCH v2 2/4] " Kedareswara rao Appana
2018-01-03  6:42 ` Kedareswara rao Appana
2018-01-03  6:42 [v2,1/4] dmaengine: xilinx_dma: populate dma caps properly Kedareswara rao Appana
2018-01-03  6:42 ` [PATCH v2 1/4] " Kedareswara rao Appana
2018-01-03  6:42 ` Kedareswara rao Appana
2018-01-03  6:42 [PATCH v2 0/4] dmaengine: xilinx_dma: Bug fixes Kedareswara rao Appana
2018-01-03  6:42 ` Kedareswara rao Appana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180109050449.GO18649@localhost \
    --to=vinod.koul@intel.com \
    --cc=akinobu.mita@gmail.com \
    --cc=appanad@xilinx.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=joabreu@synopsys.com \
    --cc=kedare06@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=mike.looijmans@topic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.