Re: [Qemu-devel] [PATCH] qemu: include generated files with <> and not ""

From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
	sheepdog@lists.wpkg.org,
	"Ronnie Sahlberg" <ronniesahlberg@gmail.com>,
	"Li Zhijian" <lizhijian@cn.fujitsu.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Jeff Cody" <jcody@redhat.com>,
	"Zhang Chen" <zhangckid@gmail.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	"Keith Busch" <keith.busch@intel.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Jiri Pirko" <jiri@resnulli.us>,
	"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
	"Michael Roth" <mdroth@linux.vnet.ibm.com>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"Josh Durgin" <jdurgin@redhat.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Alberto Garcia" <berto@igalia.com>,
	zhanghailiang <zhang.zhanghailiang@huawei.com>,
	"Ben Warren" <ben@skyportsystems.com>,
	"Marcel Apfelbaum" <marcel@redhat.com>,
	"Yongbok Kim" <yongbok.kim@mips.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	kvm-devel <kvm@vger.kernel.org>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Shannon Zhao" <zhaoshenglong@huawei.com>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Liu Yuan" <namei.unix@gmail.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Jason Wang" <jasowang@redhat.com>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Riku Voipio" <riku.voipio@iki.fi>, "Fam Zheng" <famz@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Corey Minyard" <minyard@acm.org>, "Amit Shah" <amit@kernel.org>,
	"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
	"Stefan Weil" <sw@weilnetz.de>,
	"Xie Changlong" <xiechanglong.d@gmail.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Peter Lieven" <pl@kamp.de>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Fabien Chouteau" <chouteau@adacore.com>,
	"Greg Kurz" <groug@kaod.org>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	qemu-arm <qemu-arm@nongnu.org>,
	"Peter Chubb" <peter.chubb@nicta.com.au>,
	"Yuval Shaia" <yuval.shaia@oracle.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"open list:X86" <xen-devel@lists.xenproject.org>,
	"John Snow" <jsnow@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Kevin Wolf" <kwolf@redhat.com>, "Alexander Graf" <agraf@suse.de>,
	Qemu-block <qemu-block@nongnu.org>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"Hitoshi Mitake" <mitake.hitoshi@lab.ntt.co.jp>,
	"Wen Congyang" <wencongyang2@huawei.com>,
	qemu-s390x <qemu-s390x@nongnu.org>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Juan Quintela" <quintela@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Michael Walle" <michael@walle.cc>,
	qemu-ppc@nongnu.org, "Andreas Färber" <afaerber@suse.de>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Hannes Reinecke" <hare@suse.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH] qemu: include generated files with <> and not ""
Date: Tue, 20 Mar 2018 10:27:19 +0000	[thread overview]
Message-ID: <20180320102719.GF4530@redhat.com> (raw)
In-Reply-To: <CAFEAcA-eoyPokMLqUBcHvEgp=GQnODv3r3A_9LRkc=8do6ea1A@mail.gmail.com>

On Tue, Mar 20, 2018 at 10:01:24AM +0000, Peter Maydell wrote:
> On 20 March 2018 at 09:44, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > We can follow what autoconf does, and add a check to configure to see if
> > there are generated files left in the source dir, when configuring with
> > builddir != srcdir, and exit with error, telling user to clean their
> > src dir first.
> 
> We already do this in our makefile...it just doesn't check every
> single generated file.

Ah yes, indeed:

$ make
Makefile:59: *** This is an out of tree build but your source tree
(/home/berrange/src/virt/qemu) seems to have been used for an in-tree
build. You can fix this by running "make distclean && rm -rf *-linux-user
 *-softmmu" in your source tree.  Stop.

It is checking for existance of config-host.mak.

We have a convenient list of generated files in $(GENERATED_FILES), so
I wonder if there's a practical way to check all of those too.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|