Re: [Qemu-arm] [PATCH] qemu: include generated files with <> and not ""

From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
	sheepdog@lists.wpkg.org,
	"Ronnie Sahlberg" <ronniesahlberg@gmail.com>,
	"Li Zhijian" <lizhijian@cn.fujitsu.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Jeff Cody" <jcody@redhat.com>,
	"Zhang Chen" <zhangckid@gmail.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	qemu-devel@nongnu.org, "Richard W.M. Jones" <rjones@redhat.com>,
	"Keith Busch" <keith.busch@intel.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Jiri Pirko" <jiri@resnulli.us>,
	"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Michael Roth" <mdroth@linux.vnet.ibm.com>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"Josh Durgin" <jdurgin@redhat.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Alberto Garcia" <berto@igalia.com>,
	zhanghailiang <zhang.zhanghailiang@huawei.com>,
	"Ben Warren" <ben@skyportsystems.com>,
	"Marcel Apfelbaum" <marcel@redhat.com>,
	"Yongbok Kim" <yongbok.kim@mips.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	kvm@vger.kernel.org, "Hervé Poussineau" <hpoussin@reactos.org>,
	"Shannon Zhao" <zhaoshenglong@huawei.com>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Liu Yuan" <namei.unix@gmail.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Andrzej Zaborowski" <balrogg@gmail.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Riku Voipio" <riku.voipio@iki.fi>, "Fam Zheng" <famz@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Corey Minyard" <minyard@acm.org>, "Amit Shah" <amit@kernel.org>,
	"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
	"Stefan Weil" <sw@weilnetz.de>,
	"Xie Changlong" <xiechanglong.d@gmail.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Peter Lieven" <pl@kamp.de>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Fabien Chouteau" <chouteau@adacore.com>,
	"Greg Kurz" <groug@kaod.org>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	qemu-arm@nongnu.org, "Peter Chubb" <peter.chubb@nicta.com.au>,
	"Yuval Shaia" <yuval.shaia@oracle.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	xen-devel@lists.xenproject.org,
	"BALATON Zoltan" <balaton@eik.bme.hu>,
	"John Snow" <jsnow@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Kevin Wolf" <kwolf@redhat.com>, "Alexander Graf" <agraf@suse.de>,
	qemu-block@nongnu.org,
	"Hitoshi Mitake" <mitake.hitoshi@lab.ntt.co.jp>,
	"Wen Congyang" <wencongyang2@huawei.com>,
	qemu-s390x@nongnu.org, "Cornelia Huck" <cohuck@redhat.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Juan Quintela" <quintela@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Michael Walle" <michael@walle.cc>,
	qemu-ppc@nongnu.org, "Andreas Färber" <afaerber@suse.de>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Hannes Reinecke" <hare@suse.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-arm] [PATCH] qemu: include generated files with <> and not ""
Date: Tue, 20 Mar 2018 13:41:17 +0000	[thread overview]
Message-ID: <20180320134117.GS4530@redhat.com> (raw)
In-Reply-To: <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org>

On Tue, Mar 20, 2018 at 02:32:16PM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > > So for these, we should use "".  None of these are generated files though.
> > 
> > That leads to crazy inconsistent message for developers where 50% of QEMU
> > header files must use <> and the other 50% of header files must use "".
> 
> The rules are pretty simple though:
> 
>    (1) Headers which are generated use <>.
>    (2) Headers which are in include/ use <>.
>    (3) Headers sitting in the same directory as the source files use "".

We have 1200 header files in QEMU - a developer might just reasonably remember
which header file is a QEMU header, vs which is a 3rd party system header.
Expecting devs to remember which of those 3 buckets each QEMU header falls
under is unreasonable IMHO. 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|