All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	Mark Rutland <mark.rutland@arm.com>,
	Marcel Partap <mpartap@gmx.net>,
	Michael Scott <michael.scott@linaro.org>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4
Date: Thu, 22 Mar 2018 09:46:33 -0700	[thread overview]
Message-ID: <20180322164633.GF5799@atomide.com> (raw)
In-Reply-To: <20180322135553.GA27648@amd>

[-- Attachment #1: Type: text/plain, Size: 1865 bytes --]

* Pavel Machek <pavel@ucw.cz> [180322 13:57]:
> Hi!
> 
> > idle lcd off	phy-mapphone-mdm6600	ohci-platform
> > 153mW		284mW			344mW
> > 
> > So it seems that MDM6600 is currently not yet idling even with it's
> > radio turned off, but that's something that is beyond the control of
> > this USB PHY driver. This patch does get us to the point where modem
> > data and GPS are usable with libqmi and ModemManager for example.
> > Voice calls need more audio driver work.
> 
> Ok, let me try. I believe I should see the modem device on lsusb, but
> I don't.
> 
> user@devuan:/sys/devices/platform/44000000.ocp/4a064000.usbhshost$
> sudo lsusb
> Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
> user@devuan:/sys/devices/platform/44000000.ocp/4a064000.usbhshost$
> zcat /proc/config.gz | grep MAPPH
> CONFIG_PHY_MAPPHONE_MDM6600=y
> user@devuan:/sys/devices/platform/44000000.ocp/4a064000.usbhshost$
> zcat /proc/config.gz | grep OHCI_
> CONFIG_USB_OHCI_LITTLE_ENDIAN=y
> CONFIG_USB_OHCI_HCD=y
> CONFIG_USB_OHCI_HCD_OMAP3=y
> CONFIG_USB_OHCI_HCD_PLATFORM=y
> user@devuan:/sys/devices/platform/44000000.ocp/4a064000.usbhshost$
> 
> As far as I can tell,
> 
> +CONFIG_USB_WDM=y
> +CONFIG_USB_SERIAL=y
> +CONFIG_USB_SERIAL_QUALCOMM=y
> +CONFIG_USB_SERIAL_WWAN=y
> 
> should be enabled to enable the drivers (and I did that), but without
> device showing on the bus...
> 
> Any ideas?

Do you have the related dts patches picked from next?

fdd192037fce ("ARM: dts: omap4-droid4: Fix USB PHY port naming")
e5b9fd7bdeb5 ("ARM: dts: omap4-droid4: Configure MDM6600 USB PHY")

But yeah all you need to do is have phy-mapphone-mdm6600 and
ohci-platform loaded and then ifconfig should show four wwan
interfaces being added.

Regards,

Tony


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	Mark Rutland <mark.rutland@arm.com>,
	Marcel Partap <mpartap@gmx.net>,
	Michael Scott <michael.scott@linaro.org>,
	Rob Herring <robh+dt@kernel.org>
Subject: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4
Date: Thu, 22 Mar 2018 09:46:33 -0700	[thread overview]
Message-ID: <20180322164633.GF5799@atomide.com> (raw)

* Pavel Machek <pavel@ucw.cz> [180322 13:57]:
> Hi!
> 
> > idle lcd off	phy-mapphone-mdm6600	ohci-platform
> > 153mW		284mW			344mW
> > 
> > So it seems that MDM6600 is currently not yet idling even with it's
> > radio turned off, but that's something that is beyond the control of
> > this USB PHY driver. This patch does get us to the point where modem
> > data and GPS are usable with libqmi and ModemManager for example.
> > Voice calls need more audio driver work.
> 
> Ok, let me try. I believe I should see the modem device on lsusb, but
> I don't.
> 
> user@devuan:/sys/devices/platform/44000000.ocp/4a064000.usbhshost$
> sudo lsusb
> Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
> user@devuan:/sys/devices/platform/44000000.ocp/4a064000.usbhshost$
> zcat /proc/config.gz | grep MAPPH
> CONFIG_PHY_MAPPHONE_MDM6600=y
> user@devuan:/sys/devices/platform/44000000.ocp/4a064000.usbhshost$
> zcat /proc/config.gz | grep OHCI_
> CONFIG_USB_OHCI_LITTLE_ENDIAN=y
> CONFIG_USB_OHCI_HCD=y
> CONFIG_USB_OHCI_HCD_OMAP3=y
> CONFIG_USB_OHCI_HCD_PLATFORM=y
> user@devuan:/sys/devices/platform/44000000.ocp/4a064000.usbhshost$
> 
> As far as I can tell,
> 
> +CONFIG_USB_WDM=y
> +CONFIG_USB_SERIAL=y
> +CONFIG_USB_SERIAL_QUALCOMM=y
> +CONFIG_USB_SERIAL_WWAN=y
> 
> should be enabled to enable the drivers (and I did that), but without
> device showing on the bus...
> 
> Any ideas?

Do you have the related dts patches picked from next?

fdd192037fce ("ARM: dts: omap4-droid4: Fix USB PHY port naming")
e5b9fd7bdeb5 ("ARM: dts: omap4-droid4: Configure MDM6600 USB PHY")

But yeah all you need to do is have phy-mapphone-mdm6600 and
ohci-platform loaded and then ifconfig should show four wwan
interfaces being added.

Regards,

Tony

  reply	other threads:[~2018-03-22 16:46 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-09  2:37 [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4 Tony Lindgren
2018-03-09  2:37 ` Tony Lindgren
2018-03-09  9:44 ` Pavel Machek
2018-03-09  9:44   ` Pavel Machek
2018-03-09 14:52   ` Tony Lindgren
2018-03-09 14:52     ` Tony Lindgren
2018-03-22 13:55 ` Pavel Machek
2018-03-22 13:55   ` Pavel Machek
2018-03-22 16:46   ` Tony Lindgren [this message]
2018-03-22 16:46     ` Tony Lindgren
2018-03-22 19:28     ` Pavel Machek
2018-03-22 19:28       ` Pavel Machek
2018-03-22 22:23       ` Dan Williams
2018-03-22 22:23         ` Dan Williams
2018-03-23 10:54         ` Pavel Machek
2018-03-23 10:54           ` Pavel Machek
2018-03-23 11:35           ` Sebastian Reichel
2018-03-23 11:35             ` Sebastian Reichel
2018-03-23 20:13             ` Pavel Machek
2018-03-23 20:13               ` Pavel Machek
2018-03-24 13:59               ` Dan Williams
2018-03-24 13:59                 ` Dan Williams
2018-03-24 14:25                 ` Tony Lindgren
2018-03-24 14:25                   ` Tony Lindgren
2018-03-24 20:02                   ` Pavel Machek
2018-03-24 20:02                     ` Pavel Machek
2018-03-25 15:45                     ` Tony Lindgren
2018-03-25 15:45                       ` Tony Lindgren
2018-03-25 18:58                       ` Pavel Machek
2018-03-25 18:58                         ` Pavel Machek
2018-03-25 20:52                         ` Tony Lindgren
2018-03-25 20:52                           ` Tony Lindgren
2018-03-25 22:55                           ` Pavel Machek
2018-03-25 22:55                             ` Pavel Machek
2018-03-26  0:22                             ` Tony Lindgren
2018-03-26  0:22                               ` Tony Lindgren
2018-03-26  0:30                               ` Tony Lindgren
2018-03-26  0:30                                 ` Tony Lindgren
2018-03-26 15:16                           ` Dan Williams
2018-03-26 15:16                             ` Dan Williams
2018-03-27  0:45                             ` Tony Lindgren
2018-03-27  0:45                               ` Tony Lindgren
2018-03-29 19:44                 ` Pavel Machek
2018-03-29 19:44                   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180322164633.GF5799@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=michael.scott@linaro.org \
    --cc=mpartap@gmx.net \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.