All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Dan Williams <dcbw@redhat.com>
Cc: Pavel Machek <pavel@ucw.cz>, Sebastian Reichel <sre@kernel.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	Mark Rutland <mark.rutland@arm.com>,
	Marcel Partap <mpartap@gmx.net>,
	Michael Scott <michael.scott@linaro.org>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4
Date: Sat, 24 Mar 2018 07:25:17 -0700	[thread overview]
Message-ID: <20180324142517.GA94954@atomide.com> (raw)
In-Reply-To: <bd79e802944f16b844c1850572928d93f3f2c4b2.camel@redhat.com>

* Dan Williams <dcbw@redhat.com> [180324 14:00]:
> On Fri, 2018-03-23 at 21:13 +0100, Pavel Machek wrote:
> > Does ofonod work for you? I could not get that one to work...
> 
> Because it's looking for a Gobi modem but the MDM6600 isn't one and
> doesn't expose that layout (and doesn't really need to anyway).  I
> don't think ofono has a generic QMI driver, so you'd either need to for
> ce it to use the telitqmi or quectelqmi drivers, or write your own
> generic QMI one.

We also get five USB uarts if we add the device id with something
like the patch below. I don't quite get why we get five UARTS?

Also not sure if we should be using drivers/usb/serial/qcaux.c
instead of qcserial.c?

And from what I recall trying it out, adding the USB UARTs
somehow confused ModemManager I think, that needs to be retested
though :)

And the USB UARTs added do not offer the same set of AT commands
as the n_gsm serial mux.

Regards,

Tony

8< ------------------
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -181,6 +181,9 @@ static const struct usb_device_id id_table[] = {
 	/* Huawei devices */
 	{DEVICE_HWI(0x03f0, 0x581d)},	/* HP lt4112 LTE/HSPA+ Gobi 4G Modem (Huawei me906e) */
 
+	/* Motorola devices */
+	{DEVICE_HWI(0x22b8, 0x2a70)},	/* Droid 4 mdm6600 */
+
 	{ }				/* Terminating entry */
 };
 MODULE_DEVICE_TABLE(usb, id_table);
-- 
2.16.2

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Dan Williams <dcbw@redhat.com>
Cc: Pavel Machek <pavel@ucw.cz>, Sebastian Reichel <sre@kernel.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	Mark Rutland <mark.rutland@arm.com>,
	Marcel Partap <mpartap@gmx.net>,
	Michael Scott <michael.scott@linaro.org>,
	Rob Herring <robh+dt@kernel.org>
Subject: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4
Date: Sat, 24 Mar 2018 07:25:17 -0700	[thread overview]
Message-ID: <20180324142517.GA94954@atomide.com> (raw)

* Dan Williams <dcbw@redhat.com> [180324 14:00]:
> On Fri, 2018-03-23 at 21:13 +0100, Pavel Machek wrote:
> > Does ofonod work for you? I could not get that one to work...
> 
> Because it's looking for a Gobi modem but the MDM6600 isn't one and
> doesn't expose that layout (and doesn't really need to anyway).  I
> don't think ofono has a generic QMI driver, so you'd either need to for
> ce it to use the telitqmi or quectelqmi drivers, or write your own
> generic QMI one.

We also get five USB uarts if we add the device id with something
like the patch below. I don't quite get why we get five UARTS?

Also not sure if we should be using drivers/usb/serial/qcaux.c
instead of qcserial.c?

And from what I recall trying it out, adding the USB UARTs
somehow confused ModemManager I think, that needs to be retested
though :)

And the USB UARTs added do not offer the same set of AT commands
as the n_gsm serial mux.

Regards,

Tony

8< ------------------

diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -181,6 +181,9 @@ static const struct usb_device_id id_table[] = {
 	/* Huawei devices */
 	{DEVICE_HWI(0x03f0, 0x581d)},	/* HP lt4112 LTE/HSPA+ Gobi 4G Modem (Huawei me906e) */
 
+	/* Motorola devices */
+	{DEVICE_HWI(0x22b8, 0x2a70)},	/* Droid 4 mdm6600 */
+
 	{ }				/* Terminating entry */
 };
 MODULE_DEVICE_TABLE(usb, id_table);

  reply	other threads:[~2018-03-24 14:25 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-09  2:37 [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4 Tony Lindgren
2018-03-09  2:37 ` Tony Lindgren
2018-03-09  9:44 ` Pavel Machek
2018-03-09  9:44   ` Pavel Machek
2018-03-09 14:52   ` Tony Lindgren
2018-03-09 14:52     ` Tony Lindgren
2018-03-22 13:55 ` Pavel Machek
2018-03-22 13:55   ` Pavel Machek
2018-03-22 16:46   ` Tony Lindgren
2018-03-22 16:46     ` Tony Lindgren
2018-03-22 19:28     ` Pavel Machek
2018-03-22 19:28       ` Pavel Machek
2018-03-22 22:23       ` Dan Williams
2018-03-22 22:23         ` Dan Williams
2018-03-23 10:54         ` Pavel Machek
2018-03-23 10:54           ` Pavel Machek
2018-03-23 11:35           ` Sebastian Reichel
2018-03-23 11:35             ` Sebastian Reichel
2018-03-23 20:13             ` Pavel Machek
2018-03-23 20:13               ` Pavel Machek
2018-03-24 13:59               ` Dan Williams
2018-03-24 13:59                 ` Dan Williams
2018-03-24 14:25                 ` Tony Lindgren [this message]
2018-03-24 14:25                   ` Tony Lindgren
2018-03-24 20:02                   ` Pavel Machek
2018-03-24 20:02                     ` Pavel Machek
2018-03-25 15:45                     ` Tony Lindgren
2018-03-25 15:45                       ` Tony Lindgren
2018-03-25 18:58                       ` Pavel Machek
2018-03-25 18:58                         ` Pavel Machek
2018-03-25 20:52                         ` Tony Lindgren
2018-03-25 20:52                           ` Tony Lindgren
2018-03-25 22:55                           ` Pavel Machek
2018-03-25 22:55                             ` Pavel Machek
2018-03-26  0:22                             ` Tony Lindgren
2018-03-26  0:22                               ` Tony Lindgren
2018-03-26  0:30                               ` Tony Lindgren
2018-03-26  0:30                                 ` Tony Lindgren
2018-03-26 15:16                           ` Dan Williams
2018-03-26 15:16                             ` Dan Williams
2018-03-27  0:45                             ` Tony Lindgren
2018-03-27  0:45                               ` Tony Lindgren
2018-03-29 19:44                 ` Pavel Machek
2018-03-29 19:44                   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180324142517.GA94954@atomide.com \
    --to=tony@atomide.com \
    --cc=dcbw@redhat.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=michael.scott@linaro.org \
    --cc=mpartap@gmx.net \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.