All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	zhang.zhanghailiang@huawei.com,
	"Ben Warren" <ben@skyportsystems.com>,
	qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore
Date: Fri, 22 Jun 2018 16:35:22 -0300	[thread overview]
Message-ID: <20180622193522.GI7451@localhost.localdomain> (raw)
In-Reply-To: <c10c2ffa-7ee2-5106-07d1-528df939d6ad@redhat.com>

On Fri, Jun 22, 2018 at 09:19:56PM +0200, Thomas Huth wrote:
> On 22.06.2018 20:11, Eduardo Habkost wrote:
> > On Tue, Jun 19, 2018 at 06:16:33PM +0200, Paolo Bonzini wrote:
> >> On 19/06/2018 17:15, Cornelia Huck wrote:
> >>>> Why does a user have to know how to enable KVM?  Oh, because our default
> >>>> is "run this guest much slower than necessary".  Great!
> >>> Should we try again to default to a better accelerator, if possible? I
> >>> don't quite recall why we didn't do so the last time that came up...
> >>> was it tests?
> >>
> >> My plan was to create qemu-{kvm,hax,hvf,whpx} binaries that default to a
> >> better accelerator, and leave qemu-system-* as defaulting to TCG.  This
> >> matches what distributions already do.
> > 
> > Why is this better than using KVM by default if it's available?
> 
> The answer is (as almost always): Compatibility with migration. Nobody
> dares to sacrifice that chicken :-(

We can now kill it if we announce the feature as deprecated a
couple of releases in advance.

If we declare that compatibility when the accelerator is omitted
is deprecated in 3.0, in QEMU 3.3 we will be free to choose a
different default accelerator.

-- 
Eduardo


WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	zhang.zhanghailiang@huawei.com,
	"Ben Warren" <ben@skyportsystems.com>,
	qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore
Date: Fri, 22 Jun 2018 16:35:22 -0300	[thread overview]
Message-ID: <20180622193522.GI7451@localhost.localdomain> (raw)
In-Reply-To: <c10c2ffa-7ee2-5106-07d1-528df939d6ad@redhat.com>

On Fri, Jun 22, 2018 at 09:19:56PM +0200, Thomas Huth wrote:
> On 22.06.2018 20:11, Eduardo Habkost wrote:
> > On Tue, Jun 19, 2018 at 06:16:33PM +0200, Paolo Bonzini wrote:
> >> On 19/06/2018 17:15, Cornelia Huck wrote:
> >>>> Why does a user have to know how to enable KVM?  Oh, because our default
> >>>> is "run this guest much slower than necessary".  Great!
> >>> Should we try again to default to a better accelerator, if possible? I
> >>> don't quite recall why we didn't do so the last time that came up...
> >>> was it tests?
> >>
> >> My plan was to create qemu-{kvm,hax,hvf,whpx} binaries that default to a
> >> better accelerator, and leave qemu-system-* as defaulting to TCG.  This
> >> matches what distributions already do.
> > 
> > Why is this better than using KVM by default if it's available?
> 
> The answer is (as almost always): Compatibility with migration. Nobody
> dares to sacrifice that chicken :-(

We can now kill it if we announce the feature as deprecated a
couple of releases in advance.

If we declare that compatibility when the accelerator is omitted
is deprecated in 3.0, in QEMU 3.3 we will be free to choose a
different default accelerator.

-- 
Eduardo

  reply	other threads:[~2018-06-22 19:35 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13  5:05 [Qemu-trivial] [PATCH 0/4] Clean up accelerator options Thomas Huth
2018-06-13  5:05 ` [Qemu-devel] " Thomas Huth
2018-06-13  5:05 ` [Qemu-trivial] [PATCH 1/4] Replace '-machine accel=xyz' with '-accel xyz' Thomas Huth
2018-06-13  5:05   ` [Qemu-devel] " Thomas Huth
2018-06-13 12:20   ` [Qemu-trivial] " Eric Blake
2018-06-13 12:20     ` Eric Blake
2018-06-13 12:48   ` [Qemu-trivial] " Paolo Bonzini
2018-06-13 12:48     ` [Qemu-devel] " Paolo Bonzini
2018-06-13 12:53     ` [Qemu-trivial] " Thomas Huth
2018-06-13 12:53       ` [Qemu-devel] " Thomas Huth
2018-06-13 13:54       ` [Qemu-trivial] " Paolo Bonzini
2018-06-13 13:54         ` [Qemu-devel] " Paolo Bonzini
2018-06-13 14:12         ` [Qemu-trivial] " Thomas Huth
2018-06-13 14:12           ` Thomas Huth
2018-06-13 16:10       ` [Qemu-trivial] " Eduardo Habkost
2018-06-13 16:10         ` [Qemu-devel] " Eduardo Habkost
2018-06-13 13:38   ` [Qemu-trivial] " Stefan Hajnoczi
2018-06-13 13:38     ` [Qemu-devel] " Stefan Hajnoczi
2018-06-13  5:05 ` [Qemu-trivial] [PATCH 2/4] Replace '-enable-kvm' with '-accel kvm' in docs and help texts Thomas Huth
2018-06-13  5:05   ` [Qemu-devel] " Thomas Huth
2018-06-13 12:51   ` [Qemu-trivial] " Paolo Bonzini
2018-06-13 12:51     ` [Qemu-devel] " Paolo Bonzini
2018-06-13 13:38   ` [Qemu-trivial] " Stefan Hajnoczi
2018-06-13 13:38     ` [Qemu-devel] " Stefan Hajnoczi
2018-06-13  5:05 ` [Qemu-trivial] [PATCH 3/4] qemu-options: Improve the documentation of '-accel' and '-machine accel=...' Thomas Huth
2018-06-13  5:05   ` [Qemu-devel] " Thomas Huth
2018-06-13 13:38   ` [Qemu-trivial] " Stefan Hajnoczi
2018-06-13 13:38     ` [Qemu-devel] " Stefan Hajnoczi
2018-06-13  5:05 ` [Qemu-trivial] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore Thomas Huth
2018-06-13  5:05   ` [Qemu-devel] " Thomas Huth
2018-06-13 12:51   ` [Qemu-trivial] " Paolo Bonzini
2018-06-13 12:51     ` [Qemu-devel] " Paolo Bonzini
2018-06-13 13:38   ` [Qemu-trivial] " Stefan Hajnoczi
2018-06-13 13:38     ` [Qemu-devel] " Stefan Hajnoczi
2018-06-13 13:44     ` [Qemu-trivial] " Daniel P. Berrangé
2018-06-13 13:44       ` Daniel P. Berrangé
2018-06-13 15:11       ` [Qemu-trivial] " Thomas Huth
2018-06-13 15:11         ` Thomas Huth
2018-06-13 15:19         ` [Qemu-trivial] " Daniel P. Berrangé
2018-06-13 15:19           ` Daniel P. Berrangé
2018-06-13 15:44           ` [Qemu-trivial] " Thomas Huth
2018-06-13 15:44             ` Thomas Huth
2018-06-13 16:02           ` [Qemu-trivial] " Markus Armbruster
2018-06-13 16:02             ` Markus Armbruster
2018-06-19 15:15             ` [Qemu-trivial] " Cornelia Huck
2018-06-19 15:15               ` Cornelia Huck
2018-06-19 16:16               ` [Qemu-trivial] " Paolo Bonzini
2018-06-19 16:16                 ` Paolo Bonzini
2018-06-22 18:11                 ` [Qemu-trivial] " Eduardo Habkost
2018-06-22 18:11                   ` Eduardo Habkost
2018-06-22 19:19                   ` [Qemu-trivial] " Thomas Huth
2018-06-22 19:19                     ` Thomas Huth
2018-06-22 19:35                     ` Eduardo Habkost [this message]
2018-06-22 19:35                       ` Eduardo Habkost
2018-06-22 21:22                       ` [Qemu-trivial] " Paolo Bonzini
2018-06-22 21:22                         ` Paolo Bonzini
2018-06-25  6:50                         ` [Qemu-trivial] " Markus Armbruster
2018-06-25  6:50                           ` Markus Armbruster
2018-06-25 10:28                           ` [Qemu-trivial] " Paolo Bonzini
2018-06-25 10:28                             ` Paolo Bonzini
2018-06-25 17:30                             ` [Qemu-trivial] " Eduardo Habkost
2018-06-25 17:30                               ` Eduardo Habkost
2018-06-25 18:26                               ` [Qemu-trivial] " Paolo Bonzini
2018-06-25 18:26                                 ` Paolo Bonzini
2018-06-25 19:51                                 ` [Qemu-trivial] " Eduardo Habkost
2018-06-25 19:51                                   ` Eduardo Habkost
2018-06-26  5:57                                   ` [Qemu-trivial] " Paolo Bonzini
2018-06-26  5:57                                     ` Paolo Bonzini
2018-06-26 12:29                                     ` [Qemu-trivial] " Eduardo Habkost
2018-06-26 12:29                                       ` Eduardo Habkost
2018-06-26 13:05                                       ` [Qemu-trivial] " Paolo Bonzini
2018-06-26 13:05                                         ` Paolo Bonzini
2018-06-26 16:06                                         ` [Qemu-trivial] " Eduardo Habkost
2018-06-26 16:06                                           ` Eduardo Habkost
2018-06-26 16:10                                           ` [Qemu-trivial] " Daniel P. Berrangé
2018-06-26 16:10                                             ` Daniel P. Berrangé
2018-06-27  8:39                                           ` [Qemu-trivial] " Paolo Bonzini
2018-06-27  8:39                                             ` Paolo Bonzini
2018-06-27 14:05                                             ` [Qemu-trivial] " Eduardo Habkost
2018-06-27 14:05                                               ` Eduardo Habkost
2018-06-26  4:40                                 ` [Qemu-trivial] " Thomas Huth
2018-06-26  4:40                                   ` Thomas Huth
2018-06-26  7:50                                   ` [Qemu-trivial] " Cornelia Huck
2018-06-26  7:50                                     ` Cornelia Huck
2018-06-26 12:56                                     ` [Qemu-trivial] " Eduardo Habkost
2018-06-26 12:56                                       ` Eduardo Habkost
2018-06-26 16:43                                       ` [Qemu-trivial] " Markus Armbruster
2018-06-26 16:43                                         ` Markus Armbruster
2018-06-27  8:49                                         ` [Qemu-trivial] " Paolo Bonzini
2018-06-27  8:49                                           ` Paolo Bonzini
2018-06-13 13:39 ` [Qemu-trivial] [PATCH 0/4] Clean up accelerator options Stefan Hajnoczi
2018-06-13 13:39   ` [Qemu-devel] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180622193522.GI7451@localhost.localdomain \
    --to=ehabkost@redhat.com \
    --cc=armbru@redhat.com \
    --cc=ben@skyportsystems.com \
    --cc=berrange@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.