From: Aaron Lindsay <aclindsa@gmail.com>
To: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Alistair Francis <alistair.francis@xilinx.com>,
Wei Huang <wei@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>
Cc: Aaron Lindsay <aclindsa@gmail.com>,
Michael Spradling <mspradli@codeaurora.org>,
qemu-devel@nongnu.org, Digant Desai <digantd@codeaurora.org>
Subject: [Qemu-devel] [PATCH v6 13/14] target/arm: Implement PMSWINC
Date: Wed, 10 Oct 2018 16:37:34 -0400 [thread overview]
Message-ID: <20181010203735.27918-14-aclindsa@gmail.com> (raw)
In-Reply-To: <20181010203735.27918-1-aclindsa@gmail.com>
Signed-off-by: Aaron Lindsay <alindsay@codeaurora.org>
---
target/arm/helper.c | 39 +++++++++++++++++++++++++++++++++++++--
1 file changed, 37 insertions(+), 2 deletions(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 89ceb34cb9..6c2a899009 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -994,6 +994,15 @@ static bool event_always_supported(CPUARMState *env)
return true;
}
+static uint64_t swinc_get_count(CPUARMState *env)
+{
+ /*
+ * SW_INCR events are written directly to the pmevcntr's by writes to
+ * PMSWINC, so there is no underlying count maintained by the PMU itself
+ */
+ return 0;
+}
+
/*
* Return the underlying cycle count for the PMU cycle counters. If we're in
* usermode, simply return 0.
@@ -1021,6 +1030,10 @@ static uint64_t instructions_get_count(CPUARMState *env)
#endif
static const pm_event pm_events[] = {
+ { .number = 0x000, /* SW_INCR */
+ .supported = event_always_supported,
+ .get_count = swinc_get_count,
+ },
#ifndef CONFIG_USER_ONLY
{ .number = 0x008, /* INST_RETIRED, Instruction architecturally executed */
.supported = instructions_supported,
@@ -1345,6 +1358,24 @@ static void pmcr_write(CPUARMState *env, const ARMCPRegInfo *ri,
pmu_op_finish(env);
}
+static void pmswinc_write(CPUARMState *env, const ARMCPRegInfo *ri,
+ uint64_t value)
+{
+ unsigned int i;
+ for (i = 0; i < pmu_num_counters(env); i++) {
+ /* Increment a counter's count iff: */
+ if ((value & (1 << i)) && /* counter's bit is set */
+ /* counter is enabled and not filtered */
+ pmu_counter_enabled(env, i) &&
+ /* counter is SW_INCR */
+ (env->cp15.c14_pmevtyper[i] & PMXEVTYPER_EVTCOUNT) == 0x0) {
+ pmevcntr_op_start(env, i);
+ env->cp15.c14_pmevcntr[i]++;
+ pmevcntr_op_finish(env, i);
+ }
+ }
+}
+
static uint64_t pmccntr_read(CPUARMState *env, const ARMCPRegInfo *ri)
{
uint64_t ret;
@@ -1751,9 +1782,13 @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
.fieldoffset = offsetof(CPUARMState, cp15.c9_pmovsr),
.writefn = pmovsr_write,
.raw_writefn = raw_write },
- /* Unimplemented so WI. */
{ .name = "PMSWINC", .cp = 15, .crn = 9, .crm = 12, .opc1 = 0, .opc2 = 4,
- .access = PL0_W, .accessfn = pmreg_access_swinc, .type = ARM_CP_NOP },
+ .access = PL0_W, .accessfn = pmreg_access_swinc, .type = ARM_CP_NO_RAW,
+ .writefn = pmswinc_write },
+ { .name = "PMSWINC_EL0", .state = ARM_CP_STATE_AA64,
+ .opc0 = 3, .opc1 = 3, .crn = 9, .crm = 12, .opc2 = 4,
+ .access = PL0_W, .accessfn = pmreg_access_swinc, .type = ARM_CP_NO_RAW,
+ .writefn = pmswinc_write },
{ .name = "PMSELR", .cp = 15, .crn = 9, .crm = 12, .opc1 = 0, .opc2 = 5,
.access = PL0_RW, .type = ARM_CP_ALIAS,
.fieldoffset = offsetoflow32(CPUARMState, cp15.c9_pmselr),
--
2.19.1
WARNING: multiple messages have this Message-ID (diff)
From: Aaron Lindsay <aclindsa@gmail.com>
To: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Alistair Francis <alistair.francis@xilinx.com>,
Wei Huang <wei@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>
Cc: qemu-devel@nongnu.org,
Michael Spradling <mspradli@codeaurora.org>,
Digant Desai <digantd@codeaurora.org>,
Aaron Lindsay <aclindsa@gmail.com>,
Aaron Lindsay <alindsay@codeaurora.org>
Subject: [Qemu-devel] [PATCH v6 13/14] target/arm: Implement PMSWINC
Date: Wed, 10 Oct 2018 16:37:34 -0400 [thread overview]
Message-ID: <20181010203735.27918-14-aclindsa@gmail.com> (raw)
In-Reply-To: <20181010203735.27918-1-aclindsa@gmail.com>
Signed-off-by: Aaron Lindsay <alindsay@codeaurora.org>
---
target/arm/helper.c | 39 +++++++++++++++++++++++++++++++++++++--
1 file changed, 37 insertions(+), 2 deletions(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 89ceb34cb9..6c2a899009 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -994,6 +994,15 @@ static bool event_always_supported(CPUARMState *env)
return true;
}
+static uint64_t swinc_get_count(CPUARMState *env)
+{
+ /*
+ * SW_INCR events are written directly to the pmevcntr's by writes to
+ * PMSWINC, so there is no underlying count maintained by the PMU itself
+ */
+ return 0;
+}
+
/*
* Return the underlying cycle count for the PMU cycle counters. If we're in
* usermode, simply return 0.
@@ -1021,6 +1030,10 @@ static uint64_t instructions_get_count(CPUARMState *env)
#endif
static const pm_event pm_events[] = {
+ { .number = 0x000, /* SW_INCR */
+ .supported = event_always_supported,
+ .get_count = swinc_get_count,
+ },
#ifndef CONFIG_USER_ONLY
{ .number = 0x008, /* INST_RETIRED, Instruction architecturally executed */
.supported = instructions_supported,
@@ -1345,6 +1358,24 @@ static void pmcr_write(CPUARMState *env, const ARMCPRegInfo *ri,
pmu_op_finish(env);
}
+static void pmswinc_write(CPUARMState *env, const ARMCPRegInfo *ri,
+ uint64_t value)
+{
+ unsigned int i;
+ for (i = 0; i < pmu_num_counters(env); i++) {
+ /* Increment a counter's count iff: */
+ if ((value & (1 << i)) && /* counter's bit is set */
+ /* counter is enabled and not filtered */
+ pmu_counter_enabled(env, i) &&
+ /* counter is SW_INCR */
+ (env->cp15.c14_pmevtyper[i] & PMXEVTYPER_EVTCOUNT) == 0x0) {
+ pmevcntr_op_start(env, i);
+ env->cp15.c14_pmevcntr[i]++;
+ pmevcntr_op_finish(env, i);
+ }
+ }
+}
+
static uint64_t pmccntr_read(CPUARMState *env, const ARMCPRegInfo *ri)
{
uint64_t ret;
@@ -1751,9 +1782,13 @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
.fieldoffset = offsetof(CPUARMState, cp15.c9_pmovsr),
.writefn = pmovsr_write,
.raw_writefn = raw_write },
- /* Unimplemented so WI. */
{ .name = "PMSWINC", .cp = 15, .crn = 9, .crm = 12, .opc1 = 0, .opc2 = 4,
- .access = PL0_W, .accessfn = pmreg_access_swinc, .type = ARM_CP_NOP },
+ .access = PL0_W, .accessfn = pmreg_access_swinc, .type = ARM_CP_NO_RAW,
+ .writefn = pmswinc_write },
+ { .name = "PMSWINC_EL0", .state = ARM_CP_STATE_AA64,
+ .opc0 = 3, .opc1 = 3, .crn = 9, .crm = 12, .opc2 = 4,
+ .access = PL0_W, .accessfn = pmreg_access_swinc, .type = ARM_CP_NO_RAW,
+ .writefn = pmswinc_write },
{ .name = "PMSELR", .cp = 15, .crn = 9, .crm = 12, .opc1 = 0, .opc2 = 5,
.access = PL0_RW, .type = ARM_CP_ALIAS,
.fieldoffset = offsetoflow32(CPUARMState, cp15.c9_pmselr),
--
2.19.1
next prev parent reply other threads:[~2018-10-10 20:48 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 20:37 [Qemu-arm] [PATCH v6 00/14] More fully implement ARM PMUv3 Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 01/14] target/arm: Mark PMINTENCLR and PMINTENCLR_EL1 accesses as possibly doing IO Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-15 19:19 ` Richard Henderson
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 02/14] target/arm: Mask PMOVSR writes based on supported counters Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-15 19:27 ` [Qemu-arm] " Richard Henderson
2018-10-15 19:27 ` Richard Henderson
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 03/14] migration: Add post_save function to VMStateDescription Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-15 19:36 ` Richard Henderson
2018-10-15 19:36 ` Richard Henderson
2018-10-16 8:21 ` Dr. David Alan Gilbert
2018-10-16 8:21 ` Dr. David Alan Gilbert
2018-10-16 13:55 ` Aaron Lindsay
2018-10-16 13:55 ` Aaron Lindsay
2018-10-16 14:06 ` [Qemu-arm] " Dr. David Alan Gilbert
2018-10-16 14:06 ` Dr. David Alan Gilbert
2018-10-16 14:41 ` [Qemu-arm] " Aaron Lindsay
2018-10-16 14:41 ` Aaron Lindsay
2018-10-16 14:43 ` [Qemu-arm] " Dr. David Alan Gilbert
2018-10-16 14:43 ` Dr. David Alan Gilbert
2018-10-17 12:07 ` [Qemu-arm] " Juan Quintela
2018-10-17 12:07 ` [Qemu-devel] " Juan Quintela
2018-10-17 12:05 ` [Qemu-arm] " Juan Quintela
2018-10-17 12:05 ` [Qemu-devel] " Juan Quintela
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 04/14] target/arm: Swap PMU values before/after migrations Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-15 19:45 ` [Qemu-arm] " Richard Henderson
2018-10-15 19:45 ` Richard Henderson
2018-10-15 20:44 ` [Qemu-arm] " Aaron Lindsay
2018-10-15 20:44 ` Aaron Lindsay
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 05/14] target/arm: Reorganize PMCCNTR accesses Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-15 19:50 ` [Qemu-arm] " Richard Henderson
2018-10-15 19:50 ` Richard Henderson
2018-10-15 20:19 ` [Qemu-arm] " Richard Henderson
2018-10-15 20:19 ` Richard Henderson
2018-10-15 20:30 ` Aaron Lindsay
2018-10-15 20:30 ` Aaron Lindsay
2018-10-15 20:47 ` [Qemu-arm] " Richard Henderson
2018-10-15 20:47 ` Richard Henderson
2018-10-15 20:29 ` [Qemu-arm] " Aaron Lindsay
2018-10-15 20:29 ` Aaron Lindsay
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 06/14] target/arm: Filter cycle counter based on PMCCFILTR_EL0 Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-15 20:51 ` [Qemu-arm] " Richard Henderson
2018-10-15 20:51 ` Richard Henderson
[not found] ` <20181016122542.GM3671@okra.localdomain>
2018-10-16 15:26 ` [Qemu-arm] " Aaron Lindsay
2018-10-16 15:26 ` Aaron Lindsay
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 07/14] target/arm: Allow AArch32 access for PMCCFILTR Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-15 21:06 ` [Qemu-arm] " Richard Henderson
2018-10-15 21:06 ` Richard Henderson
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 08/14] target/arm: Implement PMOVSSET Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-15 21:26 ` Richard Henderson
2018-10-10 20:37 ` [Qemu-devel] [PATCH v6 09/14] target/arm: Add array for supported PMU events, generate PMCEID[01] Aaron Lindsay
2018-10-10 20:37 ` Aaron Lindsay
2018-10-15 21:35 ` [Qemu-arm] " Richard Henderson
2018-10-15 21:35 ` Richard Henderson
2018-10-16 9:55 ` [Qemu-arm] " Aaron Lindsay
2018-10-16 9:55 ` Aaron Lindsay
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 10/14] target/arm: Finish implementation of PM[X]EVCNTR and PM[X]EVTYPER Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-17 0:02 ` [Qemu-arm] " Richard Henderson
2018-10-17 0:02 ` Richard Henderson
2018-10-10 20:37 ` [Qemu-devel] [PATCH v6 11/14] target/arm: PMU: Add instruction and cycle events Aaron Lindsay
2018-10-10 20:37 ` Aaron Lindsay
2018-10-17 0:04 ` [Qemu-arm] " Richard Henderson
2018-10-17 0:04 ` Richard Henderson
2018-10-17 19:47 ` Aaron Lindsay
2018-10-17 19:47 ` Aaron Lindsay
2018-10-17 21:12 ` Richard Henderson
2018-10-17 21:12 ` Richard Henderson
2018-10-18 16:20 ` [Qemu-arm] " Aaron Lindsay
2018-10-18 16:20 ` Aaron Lindsay
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4 Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-17 0:09 ` [Qemu-arm] " Richard Henderson
2018-10-17 0:09 ` Richard Henderson
2018-10-17 19:20 ` Aaron Lindsay
2018-10-17 19:20 ` Aaron Lindsay
2018-10-17 19:34 ` [Qemu-arm] " Richard Henderson
2018-10-17 19:34 ` Richard Henderson
2018-10-17 20:25 ` [Qemu-arm] " Aaron Lindsay
2018-10-17 20:25 ` Aaron Lindsay
2018-10-17 21:14 ` [Qemu-arm] " Richard Henderson
2018-10-17 21:14 ` Richard Henderson
2018-10-18 10:20 ` [Qemu-arm] " Peter Maydell
2018-10-18 10:20 ` Peter Maydell
2018-10-18 19:55 ` [Qemu-arm] " Aaron Lindsay
2018-10-18 19:55 ` Aaron Lindsay
2018-10-10 20:37 ` Aaron Lindsay [this message]
2018-10-10 20:37 ` [Qemu-devel] [PATCH v6 13/14] target/arm: Implement PMSWINC Aaron Lindsay
2018-10-17 0:15 ` [Qemu-arm] " Richard Henderson
2018-10-17 0:15 ` Richard Henderson
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 14/14] target/arm: Send interrupts on PMU counter overflow Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-16 12:01 ` [Qemu-devel] [PATCH v6 00/14] More fully implement ARM PMUv3 Peter Maydell
2018-10-16 12:01 ` Peter Maydell
2018-10-16 12:46 ` [Qemu-arm] " Aaron Lindsay
2018-10-16 12:46 ` [Qemu-devel] " Aaron Lindsay
2018-10-16 17:29 ` [Qemu-arm] " Richard Henderson
2018-10-16 17:29 ` [Qemu-devel] " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010203735.27918-14-aclindsa@gmail.com \
--to=aclindsa@gmail.com \
--cc=alistair.francis@xilinx.com \
--cc=crosthwaite.peter@gmail.com \
--cc=digantd@codeaurora.org \
--cc=mspradli@codeaurora.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.