From: Aaron Lindsay <aclindsa@gmail.com>
To: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Alistair Francis <alistair.francis@xilinx.com>,
Wei Huang <wei@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>
Cc: Aaron Lindsay <aclindsa@gmail.com>,
Michael Spradling <mspradli@codeaurora.org>,
qemu-devel@nongnu.org, Digant Desai <digantd@codeaurora.org>
Subject: [Qemu-arm] [PATCH v6 03/14] migration: Add post_save function to VMStateDescription
Date: Wed, 10 Oct 2018 16:37:24 -0400 [thread overview]
Message-ID: <20181010203735.27918-4-aclindsa@gmail.com> (raw)
In-Reply-To: <20181010203735.27918-1-aclindsa@gmail.com>
In some cases it may be helpful to modify state before saving it for
migration, and then modify the state back after it has been saved. The
existing pre_save function provides half of this functionality. This
patch adds a post_save function to provide the second half.
Signed-off-by: Aaron Lindsay <aclindsa@gmail.com>
---
docs/devel/migration.rst | 9 +++++++--
include/migration/vmstate.h | 1 +
migration/vmstate.c | 10 +++++++++-
3 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
index 687570754d..2a2533c9b3 100644
--- a/docs/devel/migration.rst
+++ b/docs/devel/migration.rst
@@ -419,8 +419,13 @@ The functions to do that are inside a vmstate definition, and are called:
This function is called before we save the state of one device.
-Example: You can look at hpet.c, that uses the three function to
-massage the state that is transferred.
+- ``void (*post_save)(void *opaque);``
+
+ This function is called after we save the state of one device
+ (even upon failure, unless the call to pre_save returned and error).
+
+Example: You can look at hpet.c, that uses the first three functions
+to massage the state that is transferred.
The ``VMSTATE_WITH_TMP`` macro may be useful when the migration
data doesn't match the stored device data well; it allows an
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 2b501d0466..f6053b94e4 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -185,6 +185,7 @@ struct VMStateDescription {
int (*pre_load)(void *opaque);
int (*post_load)(void *opaque, int version_id);
int (*pre_save)(void *opaque);
+ void (*post_save)(void *opaque);
bool (*needed)(void *opaque);
VMStateField *fields;
const VMStateDescription **subsections;
diff --git a/migration/vmstate.c b/migration/vmstate.c
index 0bc240a317..9afc9298f3 100644
--- a/migration/vmstate.c
+++ b/migration/vmstate.c
@@ -387,6 +387,9 @@ int vmstate_save_state_v(QEMUFile *f, const VMStateDescription *vmsd,
if (ret) {
error_report("Save of field %s/%s failed",
vmsd->name, field->name);
+ if (vmsd->post_save) {
+ vmsd->post_save(opaque);
+ }
return ret;
}
@@ -412,7 +415,12 @@ int vmstate_save_state_v(QEMUFile *f, const VMStateDescription *vmsd,
json_end_array(vmdesc);
}
- return vmstate_subsection_save(f, vmsd, opaque, vmdesc);
+ ret = vmstate_subsection_save(f, vmsd, opaque, vmdesc);
+
+ if (vmsd->post_save) {
+ vmsd->post_save(opaque);
+ }
+ return ret;
}
static const VMStateDescription *
--
2.19.1
WARNING: multiple messages have this Message-ID (diff)
From: Aaron Lindsay <aclindsa@gmail.com>
To: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Alistair Francis <alistair.francis@xilinx.com>,
Wei Huang <wei@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>
Cc: qemu-devel@nongnu.org,
Michael Spradling <mspradli@codeaurora.org>,
Digant Desai <digantd@codeaurora.org>,
Aaron Lindsay <aclindsa@gmail.com>
Subject: [Qemu-devel] [PATCH v6 03/14] migration: Add post_save function to VMStateDescription
Date: Wed, 10 Oct 2018 16:37:24 -0400 [thread overview]
Message-ID: <20181010203735.27918-4-aclindsa@gmail.com> (raw)
In-Reply-To: <20181010203735.27918-1-aclindsa@gmail.com>
In some cases it may be helpful to modify state before saving it for
migration, and then modify the state back after it has been saved. The
existing pre_save function provides half of this functionality. This
patch adds a post_save function to provide the second half.
Signed-off-by: Aaron Lindsay <aclindsa@gmail.com>
---
docs/devel/migration.rst | 9 +++++++--
include/migration/vmstate.h | 1 +
migration/vmstate.c | 10 +++++++++-
3 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
index 687570754d..2a2533c9b3 100644
--- a/docs/devel/migration.rst
+++ b/docs/devel/migration.rst
@@ -419,8 +419,13 @@ The functions to do that are inside a vmstate definition, and are called:
This function is called before we save the state of one device.
-Example: You can look at hpet.c, that uses the three function to
-massage the state that is transferred.
+- ``void (*post_save)(void *opaque);``
+
+ This function is called after we save the state of one device
+ (even upon failure, unless the call to pre_save returned and error).
+
+Example: You can look at hpet.c, that uses the first three functions
+to massage the state that is transferred.
The ``VMSTATE_WITH_TMP`` macro may be useful when the migration
data doesn't match the stored device data well; it allows an
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 2b501d0466..f6053b94e4 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -185,6 +185,7 @@ struct VMStateDescription {
int (*pre_load)(void *opaque);
int (*post_load)(void *opaque, int version_id);
int (*pre_save)(void *opaque);
+ void (*post_save)(void *opaque);
bool (*needed)(void *opaque);
VMStateField *fields;
const VMStateDescription **subsections;
diff --git a/migration/vmstate.c b/migration/vmstate.c
index 0bc240a317..9afc9298f3 100644
--- a/migration/vmstate.c
+++ b/migration/vmstate.c
@@ -387,6 +387,9 @@ int vmstate_save_state_v(QEMUFile *f, const VMStateDescription *vmsd,
if (ret) {
error_report("Save of field %s/%s failed",
vmsd->name, field->name);
+ if (vmsd->post_save) {
+ vmsd->post_save(opaque);
+ }
return ret;
}
@@ -412,7 +415,12 @@ int vmstate_save_state_v(QEMUFile *f, const VMStateDescription *vmsd,
json_end_array(vmdesc);
}
- return vmstate_subsection_save(f, vmsd, opaque, vmdesc);
+ ret = vmstate_subsection_save(f, vmsd, opaque, vmdesc);
+
+ if (vmsd->post_save) {
+ vmsd->post_save(opaque);
+ }
+ return ret;
}
static const VMStateDescription *
--
2.19.1
next prev parent reply other threads:[~2018-10-10 20:39 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 20:37 [Qemu-arm] [PATCH v6 00/14] More fully implement ARM PMUv3 Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 01/14] target/arm: Mark PMINTENCLR and PMINTENCLR_EL1 accesses as possibly doing IO Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-15 19:19 ` Richard Henderson
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 02/14] target/arm: Mask PMOVSR writes based on supported counters Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-15 19:27 ` [Qemu-arm] " Richard Henderson
2018-10-15 19:27 ` Richard Henderson
2018-10-10 20:37 ` Aaron Lindsay [this message]
2018-10-10 20:37 ` [Qemu-devel] [PATCH v6 03/14] migration: Add post_save function to VMStateDescription Aaron Lindsay
2018-10-15 19:36 ` Richard Henderson
2018-10-15 19:36 ` Richard Henderson
2018-10-16 8:21 ` Dr. David Alan Gilbert
2018-10-16 8:21 ` Dr. David Alan Gilbert
2018-10-16 13:55 ` Aaron Lindsay
2018-10-16 13:55 ` Aaron Lindsay
2018-10-16 14:06 ` [Qemu-arm] " Dr. David Alan Gilbert
2018-10-16 14:06 ` Dr. David Alan Gilbert
2018-10-16 14:41 ` [Qemu-arm] " Aaron Lindsay
2018-10-16 14:41 ` Aaron Lindsay
2018-10-16 14:43 ` [Qemu-arm] " Dr. David Alan Gilbert
2018-10-16 14:43 ` Dr. David Alan Gilbert
2018-10-17 12:07 ` [Qemu-arm] " Juan Quintela
2018-10-17 12:07 ` [Qemu-devel] " Juan Quintela
2018-10-17 12:05 ` [Qemu-arm] " Juan Quintela
2018-10-17 12:05 ` [Qemu-devel] " Juan Quintela
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 04/14] target/arm: Swap PMU values before/after migrations Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-15 19:45 ` [Qemu-arm] " Richard Henderson
2018-10-15 19:45 ` Richard Henderson
2018-10-15 20:44 ` [Qemu-arm] " Aaron Lindsay
2018-10-15 20:44 ` Aaron Lindsay
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 05/14] target/arm: Reorganize PMCCNTR accesses Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-15 19:50 ` [Qemu-arm] " Richard Henderson
2018-10-15 19:50 ` Richard Henderson
2018-10-15 20:19 ` [Qemu-arm] " Richard Henderson
2018-10-15 20:19 ` Richard Henderson
2018-10-15 20:30 ` Aaron Lindsay
2018-10-15 20:30 ` Aaron Lindsay
2018-10-15 20:47 ` [Qemu-arm] " Richard Henderson
2018-10-15 20:47 ` Richard Henderson
2018-10-15 20:29 ` [Qemu-arm] " Aaron Lindsay
2018-10-15 20:29 ` Aaron Lindsay
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 06/14] target/arm: Filter cycle counter based on PMCCFILTR_EL0 Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-15 20:51 ` [Qemu-arm] " Richard Henderson
2018-10-15 20:51 ` Richard Henderson
[not found] ` <20181016122542.GM3671@okra.localdomain>
2018-10-16 15:26 ` [Qemu-arm] " Aaron Lindsay
2018-10-16 15:26 ` Aaron Lindsay
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 07/14] target/arm: Allow AArch32 access for PMCCFILTR Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-15 21:06 ` [Qemu-arm] " Richard Henderson
2018-10-15 21:06 ` Richard Henderson
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 08/14] target/arm: Implement PMOVSSET Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-15 21:26 ` Richard Henderson
2018-10-10 20:37 ` [Qemu-devel] [PATCH v6 09/14] target/arm: Add array for supported PMU events, generate PMCEID[01] Aaron Lindsay
2018-10-10 20:37 ` Aaron Lindsay
2018-10-15 21:35 ` [Qemu-arm] " Richard Henderson
2018-10-15 21:35 ` Richard Henderson
2018-10-16 9:55 ` [Qemu-arm] " Aaron Lindsay
2018-10-16 9:55 ` Aaron Lindsay
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 10/14] target/arm: Finish implementation of PM[X]EVCNTR and PM[X]EVTYPER Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-17 0:02 ` [Qemu-arm] " Richard Henderson
2018-10-17 0:02 ` Richard Henderson
2018-10-10 20:37 ` [Qemu-devel] [PATCH v6 11/14] target/arm: PMU: Add instruction and cycle events Aaron Lindsay
2018-10-10 20:37 ` Aaron Lindsay
2018-10-17 0:04 ` [Qemu-arm] " Richard Henderson
2018-10-17 0:04 ` Richard Henderson
2018-10-17 19:47 ` Aaron Lindsay
2018-10-17 19:47 ` Aaron Lindsay
2018-10-17 21:12 ` Richard Henderson
2018-10-17 21:12 ` Richard Henderson
2018-10-18 16:20 ` [Qemu-arm] " Aaron Lindsay
2018-10-18 16:20 ` Aaron Lindsay
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4 Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-17 0:09 ` [Qemu-arm] " Richard Henderson
2018-10-17 0:09 ` Richard Henderson
2018-10-17 19:20 ` Aaron Lindsay
2018-10-17 19:20 ` Aaron Lindsay
2018-10-17 19:34 ` [Qemu-arm] " Richard Henderson
2018-10-17 19:34 ` Richard Henderson
2018-10-17 20:25 ` [Qemu-arm] " Aaron Lindsay
2018-10-17 20:25 ` Aaron Lindsay
2018-10-17 21:14 ` [Qemu-arm] " Richard Henderson
2018-10-17 21:14 ` Richard Henderson
2018-10-18 10:20 ` [Qemu-arm] " Peter Maydell
2018-10-18 10:20 ` Peter Maydell
2018-10-18 19:55 ` [Qemu-arm] " Aaron Lindsay
2018-10-18 19:55 ` Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] [PATCH v6 13/14] target/arm: Implement PMSWINC Aaron Lindsay
2018-10-10 20:37 ` Aaron Lindsay
2018-10-17 0:15 ` [Qemu-arm] " Richard Henderson
2018-10-17 0:15 ` Richard Henderson
2018-10-10 20:37 ` [Qemu-arm] [PATCH v6 14/14] target/arm: Send interrupts on PMU counter overflow Aaron Lindsay
2018-10-10 20:37 ` [Qemu-devel] " Aaron Lindsay
2018-10-16 12:01 ` [Qemu-devel] [PATCH v6 00/14] More fully implement ARM PMUv3 Peter Maydell
2018-10-16 12:01 ` Peter Maydell
2018-10-16 12:46 ` [Qemu-arm] " Aaron Lindsay
2018-10-16 12:46 ` [Qemu-devel] " Aaron Lindsay
2018-10-16 17:29 ` [Qemu-arm] " Richard Henderson
2018-10-16 17:29 ` [Qemu-devel] " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010203735.27918-4-aclindsa@gmail.com \
--to=aclindsa@gmail.com \
--cc=alistair.francis@xilinx.com \
--cc=crosthwaite.peter@gmail.com \
--cc=digantd@codeaurora.org \
--cc=mspradli@codeaurora.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.