[thud/master][RFC PATCH 1/3] ti-sgx-ddk-um: libgbm is now part of this project

[thud/master][RFC PATCH 1/3] ti-sgx-ddk-um: libgbm is now part of this project

[Andrew F. Davis]

The GBM library is tightly coupled with the system graphics systems,
other hardware GPU vendors (including our Rogue DDK) and Mesa all deploy
a version of the library as part of their GPU driver. We SGX does the
same. This should ease integration for us as we now don't rely on a
separate project for this library and our deployment strategy can match
across Mesa/RGX recipes, allowing for better re-use of common components.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---

This set is an RFC as the patch on the SGX DDK UM to make this change has
not yet been merged. When it is I will update the rev as part of this
patch to a version of the UM libs that contains libgbm.

 recipes-graphics/gbm/libgbm_10.0.0.bb         | 23 ----------------
 .../libgles/ti-sgx-ddk-um_1.17.4948957.bb     | 26 +++++++++----------
 2 files changed, 12 insertions(+), 37 deletions(-)
 delete mode 100644 recipes-graphics/gbm/libgbm_10.0.0.bb

diff --git a/recipes-graphics/gbm/libgbm_10.0.0.bb b/recipes-graphics/gbm/libgbm_10.0.0.bb
deleted file mode 100644
index 6d058b72..00000000
--- a/recipes-graphics/gbm/libgbm_10.0.0.bb
+++ /dev/null
@@ -1,23 +0,0 @@
-SUMMARY = "Userspace interface for the kernel GBM services"
-HOMEPAGE = "http://git.ti.com/glsdk/libgbm.git"
-
-LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://gbm.c;beginline=1;endline=26;md5=b871c7f2f477df29ee4c0ec437b187f7"
-
-DEPENDS = "libdrm udev"
-
-PROVIDES += "virtual/libgbm"
-
-inherit autotools pkgconfig
-
-BRANCH = "next"
-
-SRCREV = "96f37555c7e82a417b02051661377b10e6b3966e"
-
-SRC_URI = "git://git.ti.com/glsdk/libgbm.git;protocol=git;branch=${BRANCH} \
-            file://0001-gbm.c-include-sys-sysmacros.h-for-minor-major-in-new.patch"
-
-S = "${WORKDIR}/git"
-
-COMPATIBLE_HOST ?= "null"
-COMPATIBLE_HOST_ti-soc = "(.*)"
diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
index 02c9b750..3c0242e2 100644
--- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
+++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
@@ -23,22 +23,22 @@ INITSCRIPT_PARAMS = "defaults 8"
 inherit update-rc.d
 
 PR = "r33"
-PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 omap5-sgx-ddk-um-linux"
+PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm omap5-sgx-ddk-um-linux"
 
-DEPENDS += "libdrm udev libgbm wayland libffi"
-RDEPENDS_${PN} += "libdrm libudev libgbm wayland libffi libdrm-omap"
+DEPENDS += "libdrm udev wayland libffi"
+RDEPENDS_${PN} += "libdrm libudev wayland libffi libdrm-omap"
 
-RPROVIDES_${PN} = "libegl libgles1 libgles2 omap5-sgx-ddk-um-linux"
-RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev omap5-sgx-ddk-um-linux-dev"
-RPROVIDES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg omap5-sgx-ddk-um-linux-dbg"
+RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
+RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
+RPROVIDES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg omap5-sgx-ddk-um-linux-dbg"
 
-RREPLACES_${PN} = "libegl libgles1 libgles2 omap5-sgx-ddk-um-linux"
-RREPLACES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev omap5-sgx-ddk-um-linux-dev"
-RREPLACES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg omap5-sgx-ddk-um-linux-dbg"
+RREPLACES_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
+RREPLACES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
+RREPLACES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg omap5-sgx-ddk-um-linux-dbg"
 
-RCONFLICTS_${PN} = "libegl libgles1 libgles2 omap5-sgx-ddk-um-linux"
-RCONFLICTS_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev omap5-sgx-ddk-um-linux-dev"
-RCONFLICTS_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg omap5-sgx-ddk-um-linux-dbg"
+RCONFLICTS_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
+RCONFLICTS_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
+RCONFLICTS_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg omap5-sgx-ddk-um-linux-dbg"
 
 # The actual SONAME is libGLESv2.so.2, so need to explicitly specify RPROVIDES for .so.1 here
 RPROVIDES_${PN} += "libGLESv2.so.1"
@@ -47,8 +47,6 @@ S = "${WORKDIR}/git"
 
 do_install () {
     oe_runmake install DESTDIR=${D} TARGET_PRODUCT=${TARGET_PRODUCT}
-    mkdir -p ${D}${libdir}/gbm
-    ln -sf ../libpvrGBMWSEGL.so.${PV} ${D}${libdir}/gbm/gbm_pvr.so
     ln -sf libGLESv2.so.${PV} ${D}${libdir}/libGLESv2.so.1
 
     rm -f ${D}${libdir}/pkgconfig/wayland-egl.pc
-- 
2.17.1

[thud/master][RFC PATCH 2/3] ti-sgx-ddk-um: Add expat as runtime dependency

[Andrew F. Davis]

Although not needed for the IMG default EGL implementation libexpat
is needed when using the Mesa EGL version.

While here s/libudev/udev as 'libudev' is package shipped as part of the
eudev project, but we use systemd, so we actually depend on 'udev'.

Move the PACKAGE_ARCH and PR defines to a more natural spot that also
lines up with the RGX version of recipe for easier diffs.

One thing we could have done is remove the DEPENDS line. We do not have
any build dependencies as these are pre-made library binaries, but I use
the package rootfs generated by bitbake to build the binaries locally,
so leave it for now.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
index 3c0242e2..a1e35b52 100644
--- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
+++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
@@ -3,9 +3,10 @@ HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux"
 LICENSE = "TI-TSPA"
 LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=b17390502bc89535c86cfbbae961a2a8"
 
+PACKAGE_ARCH = "${MACHINE_ARCH}"
 COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15|k3"
 
-PACKAGE_ARCH = "${MACHINE_ARCH}"
+PR = "r33"
 
 BRANCH = "ti-img-sgx/thud/${PV}"
 
@@ -22,11 +23,10 @@ INITSCRIPT_PARAMS = "defaults 8"
 
 inherit update-rc.d
 
-PR = "r33"
 PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm omap5-sgx-ddk-um-linux"
 
-DEPENDS += "libdrm udev wayland libffi"
-RDEPENDS_${PN} += "libdrm libudev wayland libffi libdrm-omap"
+DEPENDS += "libdrm udev wayland libffi expat"
+RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland libffi expat"
 
 RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
 RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
-- 
2.17.1

[thud/master][RFC PATCH 3/3] ti-sgx-ddk-um: Drop omap5-sgx-ddk-um-linux package

[Andrew F. Davis]

No one depends on this and it does not really get built,
remove this from PROVIDES.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 .../libgles/ti-sgx-ddk-um_1.17.4948957.bb     | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
index a1e35b52..10c54978 100644
--- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
+++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
@@ -23,22 +23,22 @@ INITSCRIPT_PARAMS = "defaults 8"
 
 inherit update-rc.d
 
-PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm omap5-sgx-ddk-um-linux"
+PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm"
 
 DEPENDS += "libdrm udev wayland libffi expat"
 RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland libffi expat"
 
-RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
-RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
-RPROVIDES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg omap5-sgx-ddk-um-linux-dbg"
+RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm"
+RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev"
+RPROVIDES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg"
 
-RREPLACES_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
-RREPLACES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
-RREPLACES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg omap5-sgx-ddk-um-linux-dbg"
+RREPLACES_${PN} = "libegl libgles1 libgles2 libgbm"
+RREPLACES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev"
+RREPLACES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg"
 
-RCONFLICTS_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
-RCONFLICTS_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
-RCONFLICTS_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg omap5-sgx-ddk-um-linux-dbg"
+RCONFLICTS_${PN} = "libegl libgles1 libgles2 libgbm"
+RCONFLICTS_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev"
+RCONFLICTS_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg"
 
 # The actual SONAME is libGLESv2.so.2, so need to explicitly specify RPROVIDES for .so.1 here
 RPROVIDES_${PN} += "libGLESv2.so.1"
-- 
2.17.1

Re: [thud/master][RFC PATCH 3/3] ti-sgx-ddk-um: Drop omap5-sgx-ddk-um-linux package

[Denys Dmytriyenko]

On Fri, Jul 19, 2019 at 05:06:19PM -0400, Andrew F. Davis wrote:
> No one depends on this and it does not really get built,
> remove this from PROVIDES.

Bah, such a nice commit message. :)

Seriously though, it is there for backward compatibility. That was the name 
of this package few years ago. Sure, "it does not get built", but claiming 
that "no one depends on this" is really a guess. There might be old recipes 
out there depending on this package by its old name...

Anyway, I don't mind dropping this backward compatibility, since it's been 
several years already, but I would like to see a better commit message.
Thanks.

-- 
Denys


> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>  .../libgles/ti-sgx-ddk-um_1.17.4948957.bb     | 20 +++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> index a1e35b52..10c54978 100644
> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> @@ -23,22 +23,22 @@ INITSCRIPT_PARAMS = "defaults 8"
>  
>  inherit update-rc.d
>  
> -PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm omap5-sgx-ddk-um-linux"
> +PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm"
>  
>  DEPENDS += "libdrm udev wayland libffi expat"
>  RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland libffi expat"
>  
> -RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
> -RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
> -RPROVIDES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg omap5-sgx-ddk-um-linux-dbg"
> +RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm"
> +RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev"
> +RPROVIDES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg"
>  
> -RREPLACES_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
> -RREPLACES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
> -RREPLACES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg omap5-sgx-ddk-um-linux-dbg"
> +RREPLACES_${PN} = "libegl libgles1 libgles2 libgbm"
> +RREPLACES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev"
> +RREPLACES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg"
>  
> -RCONFLICTS_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
> -RCONFLICTS_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
> -RCONFLICTS_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg omap5-sgx-ddk-um-linux-dbg"
> +RCONFLICTS_${PN} = "libegl libgles1 libgles2 libgbm"
> +RCONFLICTS_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev"
> +RCONFLICTS_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg"
>  
>  # The actual SONAME is libGLESv2.so.2, so need to explicitly specify RPROVIDES for .so.1 here
>  RPROVIDES_${PN} += "libGLESv2.so.1"
> -- 
> 2.17.1
> 

Re: [thud/master][RFC PATCH 2/3] ti-sgx-ddk-um: Add expat as runtime dependency

[Denys Dmytriyenko]

On Fri, Jul 19, 2019 at 05:06:18PM -0400, Andrew F. Davis wrote:
> Although not needed for the IMG default EGL implementation libexpat
> is needed when using the Mesa EGL version.

Yes, and Rogue has it in RDEPENDS, as it uses Mesa. Why would SGX need it?


> While here s/libudev/udev as 'libudev' is package shipped as part of the
> eudev project, but we use systemd, so we actually depend on 'udev'.

And systemd also provides libudev. From run-time dependency, we really require 
libudev, not udev. As udev is just a daemon and bunch of config files - there 
is nothing to run-time depend on in there...


> Move the PACKAGE_ARCH and PR defines to a more natural spot that also
> lines up with the RGX version of recipe for easier diffs.
> 
> One thing we could have done is remove the DEPENDS line. We do not have
> any build dependencies as these are pre-made library binaries, but I use
> the package rootfs generated by bitbake to build the binaries locally,
> so leave it for now.

Is this detail really necessary for the commit message?


> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>  recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> index 3c0242e2..a1e35b52 100644
> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> @@ -3,9 +3,10 @@ HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux"
>  LICENSE = "TI-TSPA"
>  LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=b17390502bc89535c86cfbbae961a2a8"
>  
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>  COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15|k3"
>  
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> +PR = "r33"
>  
>  BRANCH = "ti-img-sgx/thud/${PV}"
>  
> @@ -22,11 +23,10 @@ INITSCRIPT_PARAMS = "defaults 8"
>  
>  inherit update-rc.d
>  
> -PR = "r33"
>  PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm omap5-sgx-ddk-um-linux"
>  
> -DEPENDS += "libdrm udev wayland libffi"
> -RDEPENDS_${PN} += "libdrm libudev wayland libffi libdrm-omap"
> +DEPENDS += "libdrm udev wayland libffi expat"
> +RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland libffi expat"
>  
>  RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
>  RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
> -- 
> 2.17.1
> 

Re: [thud/master][RFC PATCH 2/3] ti-sgx-ddk-um: Add expat as runtime dependency

[Andrew F. Davis]

On 7/24/19 3:24 PM, Denys Dmytriyenko wrote:
> On Fri, Jul 19, 2019 at 05:06:18PM -0400, Andrew F. Davis wrote:
>> Although not needed for the IMG default EGL implementation libexpat
>> is needed when using the Mesa EGL version.
> 
> Yes, and Rogue has it in RDEPENDS, as it uses Mesa. Why would SGX need it?
> 


I have SGX using Mesa now, we get some EGL extensions and much closer to
EGL1.5 support.


> 
>> While here s/libudev/udev as 'libudev' is package shipped as part of the
>> eudev project, but we use systemd, so we actually depend on 'udev'.
> 
> And systemd also provides libudev. From run-time dependency, we really require 
> libudev, not udev. As udev is just a daemon and bunch of config files - there 
> is nothing to run-time depend on in there...
> 

That's rather confusing.., will drop change for v2

> 
>> Move the PACKAGE_ARCH and PR defines to a more natural spot that also
>> lines up with the RGX version of recipe for easier diffs.
>>
>> One thing we could have done is remove the DEPENDS line. We do not have
>> any build dependencies as these are pre-made library binaries, but I use
>> the package rootfs generated by bitbake to build the binaries locally,
>> so leave it for now.
> 
> Is this detail really necessary for the commit message?
> 

Nope, just extra for the RFC, will drop from final.

Andrew

> 
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> ---
>>  recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
>> index 3c0242e2..a1e35b52 100644
>> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
>> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
>> @@ -3,9 +3,10 @@ HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux"
>>  LICENSE = "TI-TSPA"
>>  LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=b17390502bc89535c86cfbbae961a2a8"
>>  
>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>>  COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15|k3"
>>  
>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>> +PR = "r33"
>>  
>>  BRANCH = "ti-img-sgx/thud/${PV}"
>>  
>> @@ -22,11 +23,10 @@ INITSCRIPT_PARAMS = "defaults 8"
>>  
>>  inherit update-rc.d
>>  
>> -PR = "r33"
>>  PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm omap5-sgx-ddk-um-linux"
>>  
>> -DEPENDS += "libdrm udev wayland libffi"
>> -RDEPENDS_${PN} += "libdrm libudev wayland libffi libdrm-omap"
>> +DEPENDS += "libdrm udev wayland libffi expat"
>> +RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland libffi expat"
>>  
>>  RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
>>  RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
>> -- 
>> 2.17.1
>>

Re: [thud/master][RFC PATCH 3/3] ti-sgx-ddk-um: Drop omap5-sgx-ddk-um-linux package

[Andrew F. Davis]

On 7/24/19 3:14 PM, Denys Dmytriyenko wrote:
> On Fri, Jul 19, 2019 at 05:06:19PM -0400, Andrew F. Davis wrote:
>> No one depends on this and it does not really get built,
>> remove this from PROVIDES.
> 
> Bah, such a nice commit message. :)
> 
> Seriously though, it is there for backward compatibility. That was the name 
> of this package few years ago. Sure, "it does not get built", but claiming 
> that "no one depends on this" is really a guess. There might be old recipes 
> out there depending on this package by its old name...
> 
> Anyway, I don't mind dropping this backward compatibility, since it's been 
> several years already, but I would like to see a better commit message.

How does backwards compat work with Yocto? Are you saying for out of
tree recipes? If so I'll change the wording to "No one *in-tree* depends
on this".

Andrew

> Thanks.
> 

Re: [thud/master][RFC PATCH 3/3] ti-sgx-ddk-um: Drop omap5-sgx-ddk-um-linux package

[Denys Dmytriyenko]

On Wed, Jul 24, 2019 at 03:30:57PM -0400, Andrew F. Davis wrote:
> On 7/24/19 3:14 PM, Denys Dmytriyenko wrote:
> > On Fri, Jul 19, 2019 at 05:06:19PM -0400, Andrew F. Davis wrote:
> >> No one depends on this and it does not really get built,
> >> remove this from PROVIDES.
> > 
> > Bah, such a nice commit message. :)
> > 
> > Seriously though, it is there for backward compatibility. That was the name 
> > of this package few years ago. Sure, "it does not get built", but claiming 
> > that "no one depends on this" is really a guess. There might be old recipes 
> > out there depending on this package by its old name...
> > 
> > Anyway, I don't mind dropping this backward compatibility, since it's been 
> > several years already, but I would like to see a better commit message.
> 
> How does backwards compat work with Yocto? Are you saying for out of
> tree recipes? If so I'll change the wording to "No one *in-tree* depends
> on this".

Yes, out-of-tree. Yocto Project embraces layered structure. There are tons of 
layers with interdependencies. There could be outdated layers (potentially 
customers) that use the old name. In order to drop backward compatibility, we 
need to provide a clear message.

-- 
Denys

Re: [thud/master][RFC PATCH 2/3] ti-sgx-ddk-um: Add expat as runtime dependency

[Denys Dmytriyenko]

On Wed, Jul 24, 2019 at 03:29:15PM -0400, Andrew F. Davis wrote:
> On 7/24/19 3:24 PM, Denys Dmytriyenko wrote:
> > On Fri, Jul 19, 2019 at 05:06:18PM -0400, Andrew F. Davis wrote:
> >> Although not needed for the IMG default EGL implementation libexpat
> >> is needed when using the Mesa EGL version.
> > 
> > Yes, and Rogue has it in RDEPENDS, as it uses Mesa. Why would SGX need it?
> 
> I have SGX using Mesa now, we get some EGL extensions and much closer to
> EGL1.5 support.

Ah, gaining EGL 1.5 would be nice...


> >> While here s/libudev/udev as 'libudev' is package shipped as part of the
> >> eudev project, but we use systemd, so we actually depend on 'udev'.
> > 
> > And systemd also provides libudev. From run-time dependency, we really require 
> > libudev, not udev. As udev is just a daemon and bunch of config files - there 
> > is nothing to run-time depend on in there...
> 
> That's rather confusing.., will drop change for v2

Not really that confusing. Rough high-level explanation:

For build-time dependency you depend on a recipe name, which will be built 
before your package and available in the same namespace. I.e. <name>.bb

For run-time dependency, you depend on the specific binary package that is the 
build output from a recipe. I.e. <name>.ipk

Some recipes generate a package with the same name (plus regular -dev, -dbg, 
-doc, etc.). Other recipes generate multiple packages and split the output in 
more logical way. When udev was a standalone component, it had a main udev 
package for binaries and configs, plus an additional libudev package for the 
library. If your component links against libudev library, it has to have 
run-time dependency on it. While systemd absorbed udev, naming and packaging 
remained for backward compatibility. And you can switch your device manager 
from systemd to eudev and everything will build and work w/o modifying 
recipes.

For normal components built from sources Bitbake handles most of this 
automatically behind the scene and sets RDEPENDS for you based on DEPENDS 
and info from the linker. Since this is a pre-built binary component, some 
manual setup is required. But only RDEPENDS is required, DEPENDS can be 
dropped, as you said below.


> >> Move the PACKAGE_ARCH and PR defines to a more natural spot that also
> >> lines up with the RGX version of recipe for easier diffs.
> >>
> >> One thing we could have done is remove the DEPENDS line. We do not have
> >> any build dependencies as these are pre-made library binaries, but I use
> >> the package rootfs generated by bitbake to build the binaries locally,
> >> so leave it for now.
> > 
> > Is this detail really necessary for the commit message?
> > 
> 
> Nope, just extra for the RFC, will drop from final.
> 
> Andrew
> 
> > 
> >> Signed-off-by: Andrew F. Davis <afd@ti.com>
> >> ---
> >>  recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb | 8 ++++----
> >>  1 file changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> >> index 3c0242e2..a1e35b52 100644
> >> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> >> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> >> @@ -3,9 +3,10 @@ HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux"
> >>  LICENSE = "TI-TSPA"
> >>  LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=b17390502bc89535c86cfbbae961a2a8"
> >>  
> >> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> >>  COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15|k3"
> >>  
> >> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> >> +PR = "r33"
> >>  
> >>  BRANCH = "ti-img-sgx/thud/${PV}"
> >>  
> >> @@ -22,11 +23,10 @@ INITSCRIPT_PARAMS = "defaults 8"
> >>  
> >>  inherit update-rc.d
> >>  
> >> -PR = "r33"
> >>  PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm omap5-sgx-ddk-um-linux"
> >>  
> >> -DEPENDS += "libdrm udev wayland libffi"
> >> -RDEPENDS_${PN} += "libdrm libudev wayland libffi libdrm-omap"
> >> +DEPENDS += "libdrm udev wayland libffi expat"
> >> +RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland libffi expat"
> >>  
> >>  RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
> >>  RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
> >> -- 
> >> 2.17.1
> >>

Re: [thud/master][RFC PATCH 3/3] ti-sgx-ddk-um: Drop omap5-sgx-ddk-um-linux package

[Andrew F. Davis]

On 7/24/19 4:08 PM, Denys Dmytriyenko wrote:
> On Wed, Jul 24, 2019 at 03:30:57PM -0400, Andrew F. Davis wrote:
>> On 7/24/19 3:14 PM, Denys Dmytriyenko wrote:
>>> On Fri, Jul 19, 2019 at 05:06:19PM -0400, Andrew F. Davis wrote:
>>>> No one depends on this and it does not really get built,
>>>> remove this from PROVIDES.
>>>
>>> Bah, such a nice commit message. :)
>>>
>>> Seriously though, it is there for backward compatibility. That was the name 
>>> of this package few years ago. Sure, "it does not get built", but claiming 
>>> that "no one depends on this" is really a guess. There might be old recipes 
>>> out there depending on this package by its old name...
>>>
>>> Anyway, I don't mind dropping this backward compatibility, since it's been 
>>> several years already, but I would like to see a better commit message.
>>
>> How does backwards compat work with Yocto? Are you saying for out of
>> tree recipes? If so I'll change the wording to "No one *in-tree* depends
>> on this".
> 
> Yes, out-of-tree. Yocto Project embraces layered structure. There are tons of 
> layers with interdependencies. There could be outdated layers (potentially 
> customers) that use the old name. In order to drop backward compatibility, we 
> need to provide a clear message.
> 

Okay, that makes sense, will update the message with some more details.

Thanks,
Andrew

Re: [thud/master][RFC PATCH 2/3] ti-sgx-ddk-um: Add expat as runtime dependency

[Andrew F. Davis]

On 7/24/19 4:27 PM, Denys Dmytriyenko wrote:
> On Wed, Jul 24, 2019 at 03:29:15PM -0400, Andrew F. Davis wrote:
>> On 7/24/19 3:24 PM, Denys Dmytriyenko wrote:
>>> On Fri, Jul 19, 2019 at 05:06:18PM -0400, Andrew F. Davis wrote:
>>>> Although not needed for the IMG default EGL implementation libexpat
>>>> is needed when using the Mesa EGL version.
>>>
>>> Yes, and Rogue has it in RDEPENDS, as it uses Mesa. Why would SGX need it?
>>
>> I have SGX using Mesa now, we get some EGL extensions and much closer to
>> EGL1.5 support.
> 
> Ah, gaining EGL 1.5 would be nice...
> 

Yup, I'm just two extensions away from full EGL 1.5. That's the link
here to the GBM patches, as said, GBM depends on the EGL, so if we use
Mesa's EGL we will have to use Mesa's GBM also, not our external fork
libgbm we use now.

> 
>>>> While here s/libudev/udev as 'libudev' is package shipped as part of the
>>>> eudev project, but we use systemd, so we actually depend on 'udev'.
>>>
>>> And systemd also provides libudev. From run-time dependency, we really require 
>>> libudev, not udev. As udev is just a daemon and bunch of config files - there 
>>> is nothing to run-time depend on in there...
>>
>> That's rather confusing.., will drop change for v2
> 
> Not really that confusing. Rough high-level explanation:
> 
> For build-time dependency you depend on a recipe name, which will be built 
> before your package and available in the same namespace. I.e. <name>.bb
> 
> For run-time dependency, you depend on the specific binary package that is the 
> build output from a recipe. I.e. <name>.ipk
> 
> Some recipes generate a package with the same name (plus regular -dev, -dbg, 
> -doc, etc.). Other recipes generate multiple packages and split the output in 
> more logical way. When udev was a standalone component, it had a main udev 
> package for binaries and configs, plus an additional libudev package for the 
> library. If your component links against libudev library, it has to have 
> run-time dependency on it. While systemd absorbed udev, naming and packaging 
> remained for backward compatibility. And you can switch your device manager 
> from systemd to eudev and everything will build and work w/o modifying 
> recipes.
> 
> For normal components built from sources Bitbake handles most of this 
> automatically behind the scene and sets RDEPENDS for you based on DEPENDS 
> and info from the linker. Since this is a pre-built binary component, some 
> manual setup is required. But only RDEPENDS is required, DEPENDS can be 
> dropped, as you said below.
> 

That makes it much more clear, I was getting caught up with the DEPENDS
and RDEPENDS not having the same named components, makes more sense now.

Thanks,
Andrew

> 
>>>> Move the PACKAGE_ARCH and PR defines to a more natural spot that also
>>>> lines up with the RGX version of recipe for easier diffs.
>>>>
>>>> One thing we could have done is remove the DEPENDS line. We do not have
>>>> any build dependencies as these are pre-made library binaries, but I use
>>>> the package rootfs generated by bitbake to build the binaries locally,
>>>> so leave it for now.
>>>
>>> Is this detail really necessary for the commit message?
>>>
>>
>> Nope, just extra for the RFC, will drop from final.
>>
>> Andrew
>>
>>>
>>>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>>>> ---
>>>>  recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb | 8 ++++----
>>>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
>>>> index 3c0242e2..a1e35b52 100644
>>>> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
>>>> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
>>>> @@ -3,9 +3,10 @@ HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux"
>>>>  LICENSE = "TI-TSPA"
>>>>  LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=b17390502bc89535c86cfbbae961a2a8"
>>>>  
>>>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>>>>  COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15|k3"
>>>>  
>>>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>>>> +PR = "r33"
>>>>  
>>>>  BRANCH = "ti-img-sgx/thud/${PV}"
>>>>  
>>>> @@ -22,11 +23,10 @@ INITSCRIPT_PARAMS = "defaults 8"
>>>>  
>>>>  inherit update-rc.d
>>>>  
>>>> -PR = "r33"
>>>>  PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm omap5-sgx-ddk-um-linux"
>>>>  
>>>> -DEPENDS += "libdrm udev wayland libffi"
>>>> -RDEPENDS_${PN} += "libdrm libudev wayland libffi libdrm-omap"
>>>> +DEPENDS += "libdrm udev wayland libffi expat"
>>>> +RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland libffi expat"
>>>>  
>>>>  RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
>>>>  RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
>>>> -- 
>>>> 2.17.1
>>>>