All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: Dragos Tarcatu <dragos_tarcatu@mentor.com>,
	Sasha Levin <sashal@kernel.org>,
	ALSA development <alsa-devel@alsa-project.org>,
	Takashi Iwai <tiwai@suse.de>,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	stable@vger.kernel.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: topology: fix soc_tplg_fe_link_create() - link->dobj initialization order
Date: Thu, 23 Jan 2020 07:43:06 +0100	[thread overview]
Message-ID: <20200123064306.GA124954@kroah.com> (raw)
In-Reply-To: <20200122202530.GG3833@sirena.org.uk>

On Wed, Jan 22, 2020 at 08:25:30PM +0000, Mark Brown wrote:
> On Wed, Jan 22, 2020 at 01:28:57PM -0600, Pierre-Louis Bossart wrote:
> > On 1/22/20 1:07 PM, Jaroslav Kysela wrote:
> 
> > > The code which checks the return value for snd_soc_add_dai_link() call
> > > in soc_tplg_fe_link_create() moved the snd_soc_add_dai_link() call before
> > > link->dobj members initialization.
> 
> > > While it does not affect the latest kernels, the old soc-core.c code
> > > in the stable kernels is affected. The snd_soc_add_dai_link() function uses
> > > the link->dobj.type member to check, if the link structure is valid.
> 
> > > Reorder the link->dobj initialization to make things work again.
> > > It's harmless for the recent code (and the structure should be properly
> > > initialized before other calls anyway).
> 
> > > The problem is in stable linux-5.4.y since version 5.4.11 when the
> > > upstream commit 76d270364932 was applied.
> 
> > I am not following. Is this a fix for linux-5.4-y only, or is it needed on
> > Mark's tree? In the latter case, what is broken? We've been using Mark's
> > tree without issues, wondering what we missed?
> 
> He's saying it's a fix for stable but it's just a cleanup and robustness
> improvement in current kernels - when the patch 76d270364932 (ASoC:
> topology: Check return value for snd_soc_add_dai_link()) was backported
> by the bot the bot missed some other context which triggered bugs.
> 
> Copying in Sasha and Greg for stable (not sure if the list works by
> itself).

How this was marked-up is fine, our scripts can easily handle it,
thanks.

greg k-h
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Jaroslav Kysela <perex@perex.cz>,
	ALSA development <alsa-devel@alsa-project.org>,
	Dragos Tarcatu <dragos_tarcatu@mentor.com>,
	Takashi Iwai <tiwai@suse.de>,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: topology: fix soc_tplg_fe_link_create() - link->dobj initialization order
Date: Thu, 23 Jan 2020 07:43:06 +0100	[thread overview]
Message-ID: <20200123064306.GA124954@kroah.com> (raw)
In-Reply-To: <20200122202530.GG3833@sirena.org.uk>

On Wed, Jan 22, 2020 at 08:25:30PM +0000, Mark Brown wrote:
> On Wed, Jan 22, 2020 at 01:28:57PM -0600, Pierre-Louis Bossart wrote:
> > On 1/22/20 1:07 PM, Jaroslav Kysela wrote:
> 
> > > The code which checks the return value for snd_soc_add_dai_link() call
> > > in soc_tplg_fe_link_create() moved the snd_soc_add_dai_link() call before
> > > link->dobj members initialization.
> 
> > > While it does not affect the latest kernels, the old soc-core.c code
> > > in the stable kernels is affected. The snd_soc_add_dai_link() function uses
> > > the link->dobj.type member to check, if the link structure is valid.
> 
> > > Reorder the link->dobj initialization to make things work again.
> > > It's harmless for the recent code (and the structure should be properly
> > > initialized before other calls anyway).
> 
> > > The problem is in stable linux-5.4.y since version 5.4.11 when the
> > > upstream commit 76d270364932 was applied.
> 
> > I am not following. Is this a fix for linux-5.4-y only, or is it needed on
> > Mark's tree? In the latter case, what is broken? We've been using Mark's
> > tree without issues, wondering what we missed?
> 
> He's saying it's a fix for stable but it's just a cleanup and robustness
> improvement in current kernels - when the patch 76d270364932 (ASoC:
> topology: Check return value for snd_soc_add_dai_link()) was backported
> by the bot the bot missed some other context which triggered bugs.
> 
> Copying in Sasha and Greg for stable (not sure if the list works by
> itself).

How this was marked-up is fine, our scripts can easily handle it,
thanks.

greg k-h

  parent reply	other threads:[~2020-01-23  6:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22 19:07 [alsa-devel] [PATCH] ASoC: topology: fix soc_tplg_fe_link_create() - link->dobj initialization order Jaroslav Kysela
2020-01-22 19:07 ` Jaroslav Kysela
2020-01-22 19:28 ` [alsa-devel] " Pierre-Louis Bossart
2020-01-22 19:28   ` Pierre-Louis Bossart
2020-01-22 20:25   ` Mark Brown
2020-01-22 20:25     ` Mark Brown
2020-01-22 20:49     ` Jaroslav Kysela
2020-01-22 20:49       ` Jaroslav Kysela
2020-01-22 21:47       ` Pierre-Louis Bossart
2020-01-22 21:47         ` Pierre-Louis Bossart
2020-01-23  6:43     ` Greg Kroah-Hartman [this message]
2020-01-23  6:43       ` Greg Kroah-Hartman
2020-01-23 12:36 ` [alsa-devel] Applied "ASoC: topology: fix soc_tplg_fe_link_create() - link->dobj initialization order" to the asoc tree Mark Brown
2020-01-23 12:36   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200123064306.GA124954@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=dragos_tarcatu@mentor.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.