All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Jaroslav Kysela <perex@perex.cz>, Mark Brown <broonie@kernel.org>
Cc: Dragos Tarcatu <dragos_tarcatu@mentor.com>,
	Sasha Levin <sashal@kernel.org>,
	ALSA development <alsa-devel@alsa-project.org>,
	Takashi Iwai <tiwai@suse.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	stable@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: topology: fix soc_tplg_fe_link_create() - link->dobj initialization order
Date: Wed, 22 Jan 2020 15:47:34 -0600	[thread overview]
Message-ID: <67f2a1cf-fe62-76fa-ccdb-869e2b0daee2@linux.intel.com> (raw)
In-Reply-To: <045401f5-8d4c-cdc3-12fb-cf35148411e5@perex.cz>


>>> I am not following. Is this a fix for linux-5.4-y only, or is it 
>>> needed on
>>> Mark's tree? In the latter case, what is broken? We've been using Mark's
>>> tree without issues, wondering what we missed?
>>
>> He's saying it's a fix for stable but it's just a cleanup and robustness
>> improvement in current kernels - when the patch 76d270364932 (ASoC:
>> topology: Check return value for snd_soc_add_dai_link()) was backported
>> by the bot the bot missed some other context which triggered bugs.
> 
> Exactly. It's because the commit 
> 237d19080cd37e1ccf5462e63d8577d713f6da46 ("ASoC: soc-core: remove 
> topology specific operation") removed the link->dobj checks, but this 
> commit was not picked to the stable kernels.
> 
> The initialization reordering is fine for all kernels (and makes sense), 
> so I would like to apply it everywhere.

ok, thanks for the precisions.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Jaroslav Kysela <perex@perex.cz>, Mark Brown <broonie@kernel.org>
Cc: Dragos Tarcatu <dragos_tarcatu@mentor.com>,
	Sasha Levin <sashal@kernel.org>,
	ALSA development <alsa-devel@alsa-project.org>,
	Takashi Iwai <tiwai@suse.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	stable@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: topology: fix soc_tplg_fe_link_create() - link->dobj initialization order
Date: Wed, 22 Jan 2020 15:47:34 -0600	[thread overview]
Message-ID: <67f2a1cf-fe62-76fa-ccdb-869e2b0daee2@linux.intel.com> (raw)
In-Reply-To: <045401f5-8d4c-cdc3-12fb-cf35148411e5@perex.cz>


>>> I am not following. Is this a fix for linux-5.4-y only, or is it 
>>> needed on
>>> Mark's tree? In the latter case, what is broken? We've been using Mark's
>>> tree without issues, wondering what we missed?
>>
>> He's saying it's a fix for stable but it's just a cleanup and robustness
>> improvement in current kernels - when the patch 76d270364932 (ASoC:
>> topology: Check return value for snd_soc_add_dai_link()) was backported
>> by the bot the bot missed some other context which triggered bugs.
> 
> Exactly. It's because the commit 
> 237d19080cd37e1ccf5462e63d8577d713f6da46 ("ASoC: soc-core: remove 
> topology specific operation") removed the link->dobj checks, but this 
> commit was not picked to the stable kernels.
> 
> The initialization reordering is fine for all kernels (and makes sense), 
> so I would like to apply it everywhere.

ok, thanks for the precisions.

  reply	other threads:[~2020-01-22 22:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22 19:07 [alsa-devel] [PATCH] ASoC: topology: fix soc_tplg_fe_link_create() - link->dobj initialization order Jaroslav Kysela
2020-01-22 19:07 ` Jaroslav Kysela
2020-01-22 19:28 ` [alsa-devel] " Pierre-Louis Bossart
2020-01-22 19:28   ` Pierre-Louis Bossart
2020-01-22 20:25   ` Mark Brown
2020-01-22 20:25     ` Mark Brown
2020-01-22 20:49     ` Jaroslav Kysela
2020-01-22 20:49       ` Jaroslav Kysela
2020-01-22 21:47       ` Pierre-Louis Bossart [this message]
2020-01-22 21:47         ` Pierre-Louis Bossart
2020-01-23  6:43     ` Greg Kroah-Hartman
2020-01-23  6:43       ` Greg Kroah-Hartman
2020-01-23 12:36 ` [alsa-devel] Applied "ASoC: topology: fix soc_tplg_fe_link_create() - link->dobj initialization order" to the asoc tree Mark Brown
2020-01-23 12:36   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67f2a1cf-fe62-76fa-ccdb-869e2b0daee2@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=dragos_tarcatu@mentor.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=perex@perex.cz \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.