From: Tomasz Figa <tfiga@chromium.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Dongchun Zhu <dongchun.zhu@mediatek.com>
Cc: mark.rutland@arm.com, drinkcat@chromium.org,
andriy.shevchenko@linux.intel.com, srv_heupstream@mediatek.com,
devicetree@vger.kernel.org, linus.walleij@linaro.org,
shengnan.wang@mediatek.com, bgolaszewski@baylibre.com,
sj.huang@mediatek.com, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org,
Dongchun Zhu <dongchun.zhu@mediatek.com>,
louis.kuo@mediatek.com, matthias.bgg@gmail.com,
bingbu.cao@intel.com, mchehab@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [V7, 2/2] media: i2c: dw9768: Add DW9768 VCM driver
Date: Fri, 5 Jun 2020 13:02:12 +0000 [thread overview]
Message-ID: <20200605130212.GA6303@chromium.org> (raw)
In-Reply-To: <20200605121459.GS16711@paasikivi.fi.intel.com>
On Fri, Jun 05, 2020 at 03:14:59PM +0300, Sakari Ailus wrote:
> Hi Dongchun,
>
> Thank you for the update.
>
> On Fri, Jun 05, 2020 at 06:54:12PM +0800, Dongchun Zhu wrote:
> > Add a V4L2 sub-device driver for DW9768 voice coil motor, providing
> > control to set the desired focus via IIC serial interface.
> >
> > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> > ---
> > MAINTAINERS | 1 +
> > drivers/media/i2c/Kconfig | 13 ++
> > drivers/media/i2c/Makefile | 1 +
> > drivers/media/i2c/dw9768.c | 566 +++++++++++++++++++++++++++++++++++++++++++++
> > 4 files changed, 581 insertions(+)
> > create mode 100644 drivers/media/i2c/dw9768.c
[snip]
> > +static int dw9768_runtime_suspend(struct device *dev)
> > +{
> > + struct i2c_client *client = to_i2c_client(dev);
> > + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> > + struct dw9768 *dw9768 = sd_to_dw9768(sd);
> > +
> > + dw9768_release(dw9768);
> > + regulator_bulk_disable(ARRAY_SIZE(dw9768_supply_names),
> > + dw9768->supplies);
> > +
> > + return 0;
> > +}
> > +
> > +static int dw9768_runtime_resume(struct device *dev)
>
> __maybe_unused for this and the suspend callback.
>
These are always used. If runtime PM is disabled, they are called
explicitly in probe and remove.
Best regards,
Tomasz
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Figa <tfiga@chromium.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Dongchun Zhu <dongchun.zhu@mediatek.com>
Cc: mark.rutland@arm.com, drinkcat@chromium.org,
andriy.shevchenko@linux.intel.com, srv_heupstream@mediatek.com,
devicetree@vger.kernel.org, linus.walleij@linaro.org,
shengnan.wang@mediatek.com, bgolaszewski@baylibre.com,
sj.huang@mediatek.com, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org,
Dongchun Zhu <dongchun.zhu@mediatek.com>,
louis.kuo@mediatek.com, matthias.bgg@gmail.com,
bingbu.cao@intel.com, mchehab@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [V7, 2/2] media: i2c: dw9768: Add DW9768 VCM driver
Date: Fri, 5 Jun 2020 13:02:12 +0000 [thread overview]
Message-ID: <20200605130212.GA6303@chromium.org> (raw)
In-Reply-To: <20200605121459.GS16711@paasikivi.fi.intel.com>
On Fri, Jun 05, 2020 at 03:14:59PM +0300, Sakari Ailus wrote:
> Hi Dongchun,
>
> Thank you for the update.
>
> On Fri, Jun 05, 2020 at 06:54:12PM +0800, Dongchun Zhu wrote:
> > Add a V4L2 sub-device driver for DW9768 voice coil motor, providing
> > control to set the desired focus via IIC serial interface.
> >
> > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> > ---
> > MAINTAINERS | 1 +
> > drivers/media/i2c/Kconfig | 13 ++
> > drivers/media/i2c/Makefile | 1 +
> > drivers/media/i2c/dw9768.c | 566 +++++++++++++++++++++++++++++++++++++++++++++
> > 4 files changed, 581 insertions(+)
> > create mode 100644 drivers/media/i2c/dw9768.c
[snip]
> > +static int dw9768_runtime_suspend(struct device *dev)
> > +{
> > + struct i2c_client *client = to_i2c_client(dev);
> > + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> > + struct dw9768 *dw9768 = sd_to_dw9768(sd);
> > +
> > + dw9768_release(dw9768);
> > + regulator_bulk_disable(ARRAY_SIZE(dw9768_supply_names),
> > + dw9768->supplies);
> > +
> > + return 0;
> > +}
> > +
> > +static int dw9768_runtime_resume(struct device *dev)
>
> __maybe_unused for this and the suspend callback.
>
These are always used. If runtime PM is disabled, they are called
explicitly in probe and remove.
Best regards,
Tomasz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Figa <tfiga@chromium.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Dongchun Zhu <dongchun.zhu@mediatek.com>
Cc: Dongchun Zhu <dongchun.zhu@mediatek.com>,
linus.walleij@linaro.org, bgolaszewski@baylibre.com,
mchehab@kernel.org, andriy.shevchenko@linux.intel.com,
robh+dt@kernel.org, mark.rutland@arm.com, drinkcat@chromium.org,
matthias.bgg@gmail.com, bingbu.cao@intel.com,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, sj.huang@mediatek.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
louis.kuo@mediatek.com, shengnan.wang@mediatek.com
Subject: Re: [V7, 2/2] media: i2c: dw9768: Add DW9768 VCM driver
Date: Fri, 5 Jun 2020 13:02:12 +0000 [thread overview]
Message-ID: <20200605130212.GA6303@chromium.org> (raw)
In-Reply-To: <20200605121459.GS16711@paasikivi.fi.intel.com>
On Fri, Jun 05, 2020 at 03:14:59PM +0300, Sakari Ailus wrote:
> Hi Dongchun,
>
> Thank you for the update.
>
> On Fri, Jun 05, 2020 at 06:54:12PM +0800, Dongchun Zhu wrote:
> > Add a V4L2 sub-device driver for DW9768 voice coil motor, providing
> > control to set the desired focus via IIC serial interface.
> >
> > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> > ---
> > MAINTAINERS | 1 +
> > drivers/media/i2c/Kconfig | 13 ++
> > drivers/media/i2c/Makefile | 1 +
> > drivers/media/i2c/dw9768.c | 566 +++++++++++++++++++++++++++++++++++++++++++++
> > 4 files changed, 581 insertions(+)
> > create mode 100644 drivers/media/i2c/dw9768.c
[snip]
> > +static int dw9768_runtime_suspend(struct device *dev)
> > +{
> > + struct i2c_client *client = to_i2c_client(dev);
> > + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> > + struct dw9768 *dw9768 = sd_to_dw9768(sd);
> > +
> > + dw9768_release(dw9768);
> > + regulator_bulk_disable(ARRAY_SIZE(dw9768_supply_names),
> > + dw9768->supplies);
> > +
> > + return 0;
> > +}
> > +
> > +static int dw9768_runtime_resume(struct device *dev)
>
> __maybe_unused for this and the suspend callback.
>
These are always used. If runtime PM is disabled, they are called
explicitly in probe and remove.
Best regards,
Tomasz
next prev parent reply other threads:[~2020-06-05 13:02 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 10:54 [V7, 0/2] media: i2c: Add support for DW9768 VCM driver Dongchun Zhu
2020-06-05 10:54 ` Dongchun Zhu
2020-06-05 10:54 ` Dongchun Zhu
2020-06-05 10:54 ` [V7, 1/2] media: dt-bindings: media: i2c: Document DW9768 bindings Dongchun Zhu
2020-06-05 10:54 ` Dongchun Zhu
2020-06-05 10:54 ` Dongchun Zhu
2020-06-09 19:47 ` Rob Herring
2020-06-09 19:47 ` Rob Herring
2020-06-09 19:47 ` Rob Herring
2020-06-05 10:54 ` [V7, 2/2] media: i2c: dw9768: Add DW9768 VCM driver Dongchun Zhu
2020-06-05 10:54 ` Dongchun Zhu
2020-06-05 10:54 ` Dongchun Zhu
2020-06-05 12:14 ` Sakari Ailus
2020-06-05 12:14 ` Sakari Ailus
2020-06-05 12:14 ` Sakari Ailus
2020-06-05 13:02 ` Tomasz Figa [this message]
2020-06-05 13:02 ` Tomasz Figa
2020-06-05 13:02 ` Tomasz Figa
2020-06-05 13:37 ` Sakari Ailus
2020-06-05 13:37 ` Sakari Ailus
2020-06-05 13:37 ` Sakari Ailus
2020-06-06 6:24 ` Dongchun Zhu
2020-06-06 6:24 ` Dongchun Zhu
2020-06-06 6:24 ` Dongchun Zhu
2020-06-05 12:46 ` Andy Shevchenko
2020-06-05 12:46 ` Andy Shevchenko
2020-06-05 12:46 ` Andy Shevchenko
2020-06-05 13:10 ` Tomasz Figa
2020-06-05 13:10 ` Tomasz Figa
2020-06-05 13:10 ` Tomasz Figa
2020-06-06 6:19 ` Dongchun Zhu
2020-06-06 6:19 ` Dongchun Zhu
2020-06-06 6:19 ` Dongchun Zhu
2020-06-08 13:27 ` Andy Shevchenko
2020-06-08 13:27 ` Andy Shevchenko
2020-06-08 13:27 ` Andy Shevchenko
2020-06-09 3:45 ` Dongchun Zhu
2020-06-09 3:45 ` Dongchun Zhu
2020-06-09 3:45 ` Dongchun Zhu
2020-06-09 11:14 ` Andy Shevchenko
2020-06-09 11:14 ` Andy Shevchenko
2020-06-09 11:14 ` Andy Shevchenko
2020-06-10 12:58 ` Sakari Ailus
2020-06-10 12:58 ` Sakari Ailus
2020-06-10 12:58 ` Sakari Ailus
2020-06-05 13:44 ` Tomasz Figa
2020-06-05 13:44 ` Tomasz Figa
2020-06-05 13:44 ` Tomasz Figa
2020-06-06 6:42 ` Dongchun Zhu
2020-06-06 6:42 ` Dongchun Zhu
2020-06-06 6:42 ` Dongchun Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605130212.GA6303@chromium.org \
--to=tfiga@chromium.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=bingbu.cao@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dongchun.zhu@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.kuo@mediatek.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shengnan.wang@mediatek.com \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.