From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
drinkcat@chromium.org, srv_heupstream@mediatek.com,
linus.walleij@linaro.org, shengnan.wang@mediatek.com,
tfiga@chromium.org, bgolaszewski@baylibre.com,
sj.huang@mediatek.com, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org,
Dongchun Zhu <dongchun.zhu@mediatek.com>,
louis.kuo@mediatek.com, matthias.bgg@gmail.com,
bingbu.cao@intel.com, mchehab@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [V7, 2/2] media: i2c: dw9768: Add DW9768 VCM driver
Date: Wed, 10 Jun 2020 15:58:12 +0300 [thread overview]
Message-ID: <20200610125812.GF16711@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20200609111428.GH2428291@smile.fi.intel.com>
Hi Andy, Dongchun,
On Tue, Jun 09, 2020 at 02:14:28PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 09, 2020 at 11:45:41AM +0800, Dongchun Zhu wrote:
> > On Mon, 2020-06-08 at 16:27 +0300, Andy Shevchenko wrote:
> > > On Sat, Jun 06, 2020 at 02:19:18PM +0800, Dongchun Zhu wrote:
> > > > On Fri, 2020-06-05 at 15:46 +0300, Andy Shevchenko wrote:
> > > > > On Fri, Jun 05, 2020 at 06:54:12PM +0800, Dongchun Zhu wrote:
>
> ...
>
> > > > > > +#define DW9768_AAC_TIME_DEFAULT 0x20
> > > > >
> > > > > Hex? Why not decimal?
> > > > >
> > > >
> > > > There is one optional property 'dongwoon,aac-timing' defined in DT.
> > > > I don't know whether you have noticed that.
> > > >
> > > > 'DW9768_AAC_TIME_DEFAULT' is the value set to AACT[5:0] register.
> > > > I thought the Hex unit should be proper as it is directly written to the
> > > > Hex register.
> > >
> > > I see. I would rather put it like (BIT(6) / 2) to show explicitly that we
> > > choose half of the resolution.
> > >
> >
> > I knew your idea.
> > '(BIT(6) / 2)' may somewhat show the meaning of 'median of the total
> > range of AACT[5:0]'.
> >
> > But this value is still very obscure relative to '0x20'.
> > As I thought that simple is the best, especially for kernel upstream
> > patch.
>
> Okay, let's wait for maintainers to speak up.
The value 0x20 is the device default, I don't see it having any other
special significance. So I'm totally fine with 0x20.
--
Kind regards,
Sakari Ailus
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
drinkcat@chromium.org, srv_heupstream@mediatek.com,
linus.walleij@linaro.org, shengnan.wang@mediatek.com,
tfiga@chromium.org, bgolaszewski@baylibre.com,
sj.huang@mediatek.com, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org,
Dongchun Zhu <dongchun.zhu@mediatek.com>,
louis.kuo@mediatek.com, matthias.bgg@gmail.com,
bingbu.cao@intel.com, mchehab@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [V7, 2/2] media: i2c: dw9768: Add DW9768 VCM driver
Date: Wed, 10 Jun 2020 15:58:12 +0300 [thread overview]
Message-ID: <20200610125812.GF16711@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20200609111428.GH2428291@smile.fi.intel.com>
Hi Andy, Dongchun,
On Tue, Jun 09, 2020 at 02:14:28PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 09, 2020 at 11:45:41AM +0800, Dongchun Zhu wrote:
> > On Mon, 2020-06-08 at 16:27 +0300, Andy Shevchenko wrote:
> > > On Sat, Jun 06, 2020 at 02:19:18PM +0800, Dongchun Zhu wrote:
> > > > On Fri, 2020-06-05 at 15:46 +0300, Andy Shevchenko wrote:
> > > > > On Fri, Jun 05, 2020 at 06:54:12PM +0800, Dongchun Zhu wrote:
>
> ...
>
> > > > > > +#define DW9768_AAC_TIME_DEFAULT 0x20
> > > > >
> > > > > Hex? Why not decimal?
> > > > >
> > > >
> > > > There is one optional property 'dongwoon,aac-timing' defined in DT.
> > > > I don't know whether you have noticed that.
> > > >
> > > > 'DW9768_AAC_TIME_DEFAULT' is the value set to AACT[5:0] register.
> > > > I thought the Hex unit should be proper as it is directly written to the
> > > > Hex register.
> > >
> > > I see. I would rather put it like (BIT(6) / 2) to show explicitly that we
> > > choose half of the resolution.
> > >
> >
> > I knew your idea.
> > '(BIT(6) / 2)' may somewhat show the meaning of 'median of the total
> > range of AACT[5:0]'.
> >
> > But this value is still very obscure relative to '0x20'.
> > As I thought that simple is the best, especially for kernel upstream
> > patch.
>
> Okay, let's wait for maintainers to speak up.
The value 0x20 is the device default, I don't see it having any other
special significance. So I'm totally fine with 0x20.
--
Kind regards,
Sakari Ailus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Dongchun Zhu <dongchun.zhu@mediatek.com>,
linus.walleij@linaro.org, bgolaszewski@baylibre.com,
mchehab@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
drinkcat@chromium.org, tfiga@chromium.org,
matthias.bgg@gmail.com, bingbu.cao@intel.com,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, sj.huang@mediatek.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
louis.kuo@mediatek.com, shengnan.wang@mediatek.com
Subject: Re: [V7, 2/2] media: i2c: dw9768: Add DW9768 VCM driver
Date: Wed, 10 Jun 2020 15:58:12 +0300 [thread overview]
Message-ID: <20200610125812.GF16711@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20200609111428.GH2428291@smile.fi.intel.com>
Hi Andy, Dongchun,
On Tue, Jun 09, 2020 at 02:14:28PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 09, 2020 at 11:45:41AM +0800, Dongchun Zhu wrote:
> > On Mon, 2020-06-08 at 16:27 +0300, Andy Shevchenko wrote:
> > > On Sat, Jun 06, 2020 at 02:19:18PM +0800, Dongchun Zhu wrote:
> > > > On Fri, 2020-06-05 at 15:46 +0300, Andy Shevchenko wrote:
> > > > > On Fri, Jun 05, 2020 at 06:54:12PM +0800, Dongchun Zhu wrote:
>
> ...
>
> > > > > > +#define DW9768_AAC_TIME_DEFAULT 0x20
> > > > >
> > > > > Hex? Why not decimal?
> > > > >
> > > >
> > > > There is one optional property 'dongwoon,aac-timing' defined in DT.
> > > > I don't know whether you have noticed that.
> > > >
> > > > 'DW9768_AAC_TIME_DEFAULT' is the value set to AACT[5:0] register.
> > > > I thought the Hex unit should be proper as it is directly written to the
> > > > Hex register.
> > >
> > > I see. I would rather put it like (BIT(6) / 2) to show explicitly that we
> > > choose half of the resolution.
> > >
> >
> > I knew your idea.
> > '(BIT(6) / 2)' may somewhat show the meaning of 'median of the total
> > range of AACT[5:0]'.
> >
> > But this value is still very obscure relative to '0x20'.
> > As I thought that simple is the best, especially for kernel upstream
> > patch.
>
> Okay, let's wait for maintainers to speak up.
The value 0x20 is the device default, I don't see it having any other
special significance. So I'm totally fine with 0x20.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2020-06-10 12:58 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 10:54 [V7, 0/2] media: i2c: Add support for DW9768 VCM driver Dongchun Zhu
2020-06-05 10:54 ` Dongchun Zhu
2020-06-05 10:54 ` Dongchun Zhu
2020-06-05 10:54 ` [V7, 1/2] media: dt-bindings: media: i2c: Document DW9768 bindings Dongchun Zhu
2020-06-05 10:54 ` Dongchun Zhu
2020-06-05 10:54 ` Dongchun Zhu
2020-06-09 19:47 ` Rob Herring
2020-06-09 19:47 ` Rob Herring
2020-06-09 19:47 ` Rob Herring
2020-06-05 10:54 ` [V7, 2/2] media: i2c: dw9768: Add DW9768 VCM driver Dongchun Zhu
2020-06-05 10:54 ` Dongchun Zhu
2020-06-05 10:54 ` Dongchun Zhu
2020-06-05 12:14 ` Sakari Ailus
2020-06-05 12:14 ` Sakari Ailus
2020-06-05 12:14 ` Sakari Ailus
2020-06-05 13:02 ` Tomasz Figa
2020-06-05 13:02 ` Tomasz Figa
2020-06-05 13:02 ` Tomasz Figa
2020-06-05 13:37 ` Sakari Ailus
2020-06-05 13:37 ` Sakari Ailus
2020-06-05 13:37 ` Sakari Ailus
2020-06-06 6:24 ` Dongchun Zhu
2020-06-06 6:24 ` Dongchun Zhu
2020-06-06 6:24 ` Dongchun Zhu
2020-06-05 12:46 ` Andy Shevchenko
2020-06-05 12:46 ` Andy Shevchenko
2020-06-05 12:46 ` Andy Shevchenko
2020-06-05 13:10 ` Tomasz Figa
2020-06-05 13:10 ` Tomasz Figa
2020-06-05 13:10 ` Tomasz Figa
2020-06-06 6:19 ` Dongchun Zhu
2020-06-06 6:19 ` Dongchun Zhu
2020-06-06 6:19 ` Dongchun Zhu
2020-06-08 13:27 ` Andy Shevchenko
2020-06-08 13:27 ` Andy Shevchenko
2020-06-08 13:27 ` Andy Shevchenko
2020-06-09 3:45 ` Dongchun Zhu
2020-06-09 3:45 ` Dongchun Zhu
2020-06-09 3:45 ` Dongchun Zhu
2020-06-09 11:14 ` Andy Shevchenko
2020-06-09 11:14 ` Andy Shevchenko
2020-06-09 11:14 ` Andy Shevchenko
2020-06-10 12:58 ` Sakari Ailus [this message]
2020-06-10 12:58 ` Sakari Ailus
2020-06-10 12:58 ` Sakari Ailus
2020-06-05 13:44 ` Tomasz Figa
2020-06-05 13:44 ` Tomasz Figa
2020-06-05 13:44 ` Tomasz Figa
2020-06-06 6:42 ` Dongchun Zhu
2020-06-06 6:42 ` Dongchun Zhu
2020-06-06 6:42 ` Dongchun Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610125812.GF16711@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=bingbu.cao@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dongchun.zhu@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.kuo@mediatek.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=shengnan.wang@mediatek.com \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.