All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Matteo Scordino <matteo.scordino@gmail.com>
Cc: wens@csie.org, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org, mripard@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] ARM: dts: sun8i: V3/S3: Add UART1 pin definitions to the V3/S3 dtsi
Date: Thu, 29 Oct 2020 11:04:42 +0100	[thread overview]
Message-ID: <20201029100442.GA460689@aptenodytes> (raw)
In-Reply-To: <20201029022000.601913-3-matteo.scordino@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1389 bytes --]

Hi,

On Thu 29 Oct 20, 02:19, Matteo Scordino wrote:
> The Allwinner V3 and S3 can use PG6/7 as RX/TX for UART1. Since no other
> functions are assigned to those pins, they are a convenient choice for
> a debugging or application UART.
> This is specific to V3/S3 as the V3s's non-BGA package did not have
> those pins.

Looks good to me, I've had to make the same change when bringing up both
another S3 and another V3 board.

Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Cheers,

Paul

> Signed-off-by: Matteo Scordino <matteo.scordino@gmail.com>
> ---
>  arch/arm/boot/dts/sun8i-v3.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-v3.dtsi b/arch/arm/boot/dts/sun8i-v3.dtsi
> index ca4672ed2e02..c279e13583ba 100644
> --- a/arch/arm/boot/dts/sun8i-v3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-v3.dtsi
> @@ -24,4 +24,9 @@
>  
>  &pio {
>  	compatible = "allwinner,sun8i-v3-pinctrl";
> +
> +	uart1_pg_pins: uart1-pg-pins {
> +		pins = "PG6", "PG7";
> +		function = "uart1";
> +	};
>  };
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Matteo Scordino <matteo.scordino@gmail.com>
Cc: mripard@kernel.org, wens@csie.org, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] ARM: dts: sun8i: V3/S3: Add UART1 pin definitions to the V3/S3 dtsi
Date: Thu, 29 Oct 2020 11:04:42 +0100	[thread overview]
Message-ID: <20201029100442.GA460689@aptenodytes> (raw)
In-Reply-To: <20201029022000.601913-3-matteo.scordino@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]

Hi,

On Thu 29 Oct 20, 02:19, Matteo Scordino wrote:
> The Allwinner V3 and S3 can use PG6/7 as RX/TX for UART1. Since no other
> functions are assigned to those pins, they are a convenient choice for
> a debugging or application UART.
> This is specific to V3/S3 as the V3s's non-BGA package did not have
> those pins.

Looks good to me, I've had to make the same change when bringing up both
another S3 and another V3 board.

Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Cheers,

Paul

> Signed-off-by: Matteo Scordino <matteo.scordino@gmail.com>
> ---
>  arch/arm/boot/dts/sun8i-v3.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-v3.dtsi b/arch/arm/boot/dts/sun8i-v3.dtsi
> index ca4672ed2e02..c279e13583ba 100644
> --- a/arch/arm/boot/dts/sun8i-v3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-v3.dtsi
> @@ -24,4 +24,9 @@
>  
>  &pio {
>  	compatible = "allwinner,sun8i-v3-pinctrl";
> +
> +	uart1_pg_pins: uart1-pg-pins {
> +		pins = "PG6", "PG7";
> +		function = "uart1";
> +	};
>  };
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-10-29 10:06 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29  2:19 [PATCH 0/5] Elimo Impetus and Initium support Matteo Scordino
2020-10-29  2:19 ` Matteo Scordino
2020-10-29  2:19 ` [PATCH 1/5] dt-bindings: vendors: add Elimo Engineering vendor prefix Matteo Scordino
2020-10-29  2:19   ` Matteo Scordino
2020-10-29 10:05   ` Paul Kocialkowski
2020-10-29 10:05     ` Paul Kocialkowski
2020-10-29  2:19 ` [PATCH 2/5] ARM: dts: sun8i: V3/S3: Add UART1 pin definitions to the V3/S3 dtsi Matteo Scordino
2020-10-29  2:19   ` Matteo Scordino
2020-10-29 10:04   ` Paul Kocialkowski [this message]
2020-10-29 10:04     ` Paul Kocialkowski
2020-10-29  2:19 ` [PATCH 3/5] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM Matteo Scordino
2020-10-29  2:19   ` Matteo Scordino
2020-10-29 10:09   ` Paul Kocialkowski
2020-10-29 10:09     ` Paul Kocialkowski
2020-10-30  0:18     ` Matteo Scordino
2020-10-30  0:18       ` Matteo Scordino
2020-10-29  2:19 ` [PATCH 4/5] dt-bindings: arm: sunxi: add Elimo bindings Matteo Scordino
2020-10-29  2:19   ` Matteo Scordino
2020-10-29 10:13   ` Maxime Ripard
2020-10-29 10:13     ` Maxime Ripard
2020-10-29 10:24     ` Icenowy Zheng
2020-10-29 10:24       ` Icenowy Zheng
2020-10-30  0:24       ` Matteo Scordino
2020-10-30  0:24         ` Matteo Scordino
2020-10-30 10:33         ` Icenowy Zheng
2020-10-30 10:33           ` Icenowy Zheng
2020-10-29  2:20 ` [PATCH 5/5] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC Matteo Scordino
2020-10-29  2:20   ` Matteo Scordino
2020-10-29 10:10   ` Paul Kocialkowski
2020-10-29 10:10     ` Paul Kocialkowski
2020-10-30  0:26     ` Matteo Scordino
2020-10-30  0:26       ` Matteo Scordino
2020-10-30 23:43 ` [PATCH v2 0/6] Elimo Impetus and Initium support - rework Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-10-30 23:43 ` [PATCH v2 1/6] dt-bindings: vendors: add Elimo Engineering vendor prefix Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-11-02 10:02   ` Maxime Ripard
2020-11-02 10:02     ` Maxime Ripard
2020-10-30 23:43 ` [PATCH v2 2/6] ARM: dts: sun8i: V3/S3: Add UART1 pin definitions to the V3/S3 dtsi Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-11-02 10:03   ` Maxime Ripard
2020-11-02 10:03     ` Maxime Ripard
2020-10-30 23:43 ` [PATCH v2 3/6] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-11-02 10:05   ` Maxime Ripard
2020-11-02 10:05     ` Maxime Ripard
2020-11-03 16:28     ` Matteo Scordino
2020-11-03 16:28       ` Matteo Scordino
2020-11-04 19:04       ` Maxime Ripard
2020-11-04 19:04         ` Maxime Ripard
2020-10-30 23:43 ` [PATCH v2 4/6] dt-bindings: arm: sunxi: add Elimo bindings Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-10-30 23:43 ` [PATCH v2 5/6] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-11-02 10:06   ` Maxime Ripard
2020-11-02 10:06     ` Maxime Ripard
2020-11-03 16:33     ` Matteo Scordino
2020-11-03 16:33       ` Matteo Scordino
2020-11-04 19:05       ` Maxime Ripard
2020-11-04 19:05         ` Maxime Ripard
2020-10-30 23:43 ` [PATCH v2 6/6] ARM: dts: sunxi: align pinecube compatible property to other S3 boards Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-11-02 10:07   ` Maxime Ripard
2020-11-02 10:07     ` Maxime Ripard
2020-11-05 14:49 ` [PATCH v3 0/3] Elimo Impetus and Initium support Matteo Scordino
2020-11-05 14:49   ` Matteo Scordino
2020-11-05 14:49 ` [PATCH v3 1/3] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM Matteo Scordino
2020-11-05 14:49   ` Matteo Scordino
2020-11-05 14:49 ` [PATCH v3 2/3] dt-bindings: arm: sunxi: add Elimo bindings Matteo Scordino
2020-11-05 14:49   ` Matteo Scordino
2020-11-05 14:49 ` [PATCH v3 3/3] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC Matteo Scordino
2020-11-05 14:49   ` Matteo Scordino
2020-11-05 15:00   ` Maxime Ripard
2020-11-05 15:00     ` Maxime Ripard
2020-11-05 18:29     ` Matteo Scordino
2020-11-05 18:29       ` Matteo Scordino
2020-11-05 18:32 ` [PATCH v4 0/3] Elimo Impetus and Initium support Matteo Scordino
2020-11-05 18:32   ` Matteo Scordino
2020-11-05 18:32 ` [PATCH v4 1/3] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM Matteo Scordino
2020-11-05 18:32   ` Matteo Scordino
2020-11-05 18:32 ` [PATCH v4 2/3] dt-bindings: arm: sunxi: add Elimo bindings Matteo Scordino
2020-11-05 18:32   ` Matteo Scordino
2020-11-05 18:32 ` [PATCH v4 3/3] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC Matteo Scordino
2020-11-05 18:32   ` Matteo Scordino
2020-11-06 10:47   ` Maxime Ripard
2020-11-06 10:47     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201029100442.GA460689@aptenodytes \
    --to=paul.kocialkowski@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matteo.scordino@gmail.com \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.