All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matteo Scordino <matteo.scordino@gmail.com>
To: Icenowy Zheng <icenowy@aosc.io>, Maxime Ripard <maxime@cerno.tech>
Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	wens@csie.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] dt-bindings: arm: sunxi: add Elimo bindings
Date: Fri, 30 Oct 2020 00:24:04 +0000	[thread overview]
Message-ID: <ea5967cdbd6281557d6a739c0eb63a979351b453.camel@gmail.com> (raw)
In-Reply-To: <92612D42-FF4C-450C-ADB1-A220B94838CB@aosc.io>


[-- Attachment #1.1: Type: text/plain, Size: 2395 bytes --]

Hello,

thank you both for reviewing.

I didn't realise the file was kept in alphabetical order, I will fix that.
And I agree that board/som + "sochip,s3, allwinner,sun8i-v3" makes sense,
I will resubmit the patch with those (and sync them with the dt bindings file).

Should I submit a patch to update the pinecube to use "sochip,s3,
allwinner,sun8i-v3", too?

-- 
Matteo Scordino

On Thu, 2020-10-29 at 18:24 +0800, Icenowy Zheng wrote:
> 
> 于 2020年10月29日 GMT+08:00 下午6:13:04, Maxime Ripard <maxime@cerno.tech> 写到:
> > Hi,
> > 
> > On Thu, Oct 29, 2020 at 02:19:59AM +0000, Matteo Scordino wrote:
> > > Document board compatible names for Elimo Engineering Impetus and
> > Initium
> > > Signed-off-by: Matteo Scordino <matteo.scordino@gmail.com>
> > > ---
> > >  Documentation/devicetree/bindings/arm/sunxi.yaml | 10 ++++++++++
> > >  1 file changed, 10 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > index 0f23133672a3..55405809ec91 100644
> > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > @@ -898,3 +898,13 @@ properties:
> > >          items:
> > >            - const: xunlong,orangepi-zero-plus2-h3
> > >            - const: allwinner,sun8i-h3
> > > +
> > > +      - description: Elimo Engineering Impetus SoM
> > > +        items:
> > > +          - const: elimo,impetus
> > > +          - const: allwinner,sun8i-s3
> > > +
> > > +      - description: Elimo Engineering Initium
> > > +        items:
> > > +          - const: elimo,initium
> > > +          - const: allwinner,sun8i-s3
> > 
> > This should be ordered alphabetically, and most importantly, must match
> > the ones you have in the DT.
> > 
> > Here, we have kind of a mess already: the Lichee Zero+ uses
> > ,sipeed,lichee-zero-plus, sochip,s3, allwinner,sun8i-v3, while the
> > pinecube uses pine64,pinecube, allwinner,sun8i-s3
> > 
> > IIRC the S3 and V3 are pretty much the same SoCs, so the first one
> > seems
> > to make more sense to me, but then we should fix the pinecube.
> 
> I agree with this.
> 
> PineCube is originally designed for S3L (which is branded under Allwinner)
> but switch to S3 finally, so I may made error when adapting.
> 
> > Maxime

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Matteo Scordino <matteo.scordino@gmail.com>
To: Icenowy Zheng <icenowy@aosc.io>, Maxime Ripard <maxime@cerno.tech>
Cc: wens@csie.org, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Subject: Re: [PATCH 4/5] dt-bindings: arm: sunxi: add Elimo bindings
Date: Fri, 30 Oct 2020 00:24:04 +0000	[thread overview]
Message-ID: <ea5967cdbd6281557d6a739c0eb63a979351b453.camel@gmail.com> (raw)
In-Reply-To: <92612D42-FF4C-450C-ADB1-A220B94838CB@aosc.io>

[-- Attachment #1: Type: text/plain, Size: 2395 bytes --]

Hello,

thank you both for reviewing.

I didn't realise the file was kept in alphabetical order, I will fix that.
And I agree that board/som + "sochip,s3, allwinner,sun8i-v3" makes sense,
I will resubmit the patch with those (and sync them with the dt bindings file).

Should I submit a patch to update the pinecube to use "sochip,s3,
allwinner,sun8i-v3", too?

-- 
Matteo Scordino

On Thu, 2020-10-29 at 18:24 +0800, Icenowy Zheng wrote:
> 
> 于 2020年10月29日 GMT+08:00 下午6:13:04, Maxime Ripard <maxime@cerno.tech> 写到:
> > Hi,
> > 
> > On Thu, Oct 29, 2020 at 02:19:59AM +0000, Matteo Scordino wrote:
> > > Document board compatible names for Elimo Engineering Impetus and
> > Initium
> > > Signed-off-by: Matteo Scordino <matteo.scordino@gmail.com>
> > > ---
> > >  Documentation/devicetree/bindings/arm/sunxi.yaml | 10 ++++++++++
> > >  1 file changed, 10 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > index 0f23133672a3..55405809ec91 100644
> > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > @@ -898,3 +898,13 @@ properties:
> > >          items:
> > >            - const: xunlong,orangepi-zero-plus2-h3
> > >            - const: allwinner,sun8i-h3
> > > +
> > > +      - description: Elimo Engineering Impetus SoM
> > > +        items:
> > > +          - const: elimo,impetus
> > > +          - const: allwinner,sun8i-s3
> > > +
> > > +      - description: Elimo Engineering Initium
> > > +        items:
> > > +          - const: elimo,initium
> > > +          - const: allwinner,sun8i-s3
> > 
> > This should be ordered alphabetically, and most importantly, must match
> > the ones you have in the DT.
> > 
> > Here, we have kind of a mess already: the Lichee Zero+ uses
> > ,sipeed,lichee-zero-plus, sochip,s3, allwinner,sun8i-v3, while the
> > pinecube uses pine64,pinecube, allwinner,sun8i-s3
> > 
> > IIRC the S3 and V3 are pretty much the same SoCs, so the first one
> > seems
> > to make more sense to me, but then we should fix the pinecube.
> 
> I agree with this.
> 
> PineCube is originally designed for S3L (which is branded under Allwinner)
> but switch to S3 finally, so I may made error when adapting.
> 
> > Maxime

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-10-30  0:24 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29  2:19 [PATCH 0/5] Elimo Impetus and Initium support Matteo Scordino
2020-10-29  2:19 ` Matteo Scordino
2020-10-29  2:19 ` [PATCH 1/5] dt-bindings: vendors: add Elimo Engineering vendor prefix Matteo Scordino
2020-10-29  2:19   ` Matteo Scordino
2020-10-29 10:05   ` Paul Kocialkowski
2020-10-29 10:05     ` Paul Kocialkowski
2020-10-29  2:19 ` [PATCH 2/5] ARM: dts: sun8i: V3/S3: Add UART1 pin definitions to the V3/S3 dtsi Matteo Scordino
2020-10-29  2:19   ` Matteo Scordino
2020-10-29 10:04   ` Paul Kocialkowski
2020-10-29 10:04     ` Paul Kocialkowski
2020-10-29  2:19 ` [PATCH 3/5] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM Matteo Scordino
2020-10-29  2:19   ` Matteo Scordino
2020-10-29 10:09   ` Paul Kocialkowski
2020-10-29 10:09     ` Paul Kocialkowski
2020-10-30  0:18     ` Matteo Scordino
2020-10-30  0:18       ` Matteo Scordino
2020-10-29  2:19 ` [PATCH 4/5] dt-bindings: arm: sunxi: add Elimo bindings Matteo Scordino
2020-10-29  2:19   ` Matteo Scordino
2020-10-29 10:13   ` Maxime Ripard
2020-10-29 10:13     ` Maxime Ripard
2020-10-29 10:24     ` Icenowy Zheng
2020-10-29 10:24       ` Icenowy Zheng
2020-10-30  0:24       ` Matteo Scordino [this message]
2020-10-30  0:24         ` Matteo Scordino
2020-10-30 10:33         ` Icenowy Zheng
2020-10-30 10:33           ` Icenowy Zheng
2020-10-29  2:20 ` [PATCH 5/5] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC Matteo Scordino
2020-10-29  2:20   ` Matteo Scordino
2020-10-29 10:10   ` Paul Kocialkowski
2020-10-29 10:10     ` Paul Kocialkowski
2020-10-30  0:26     ` Matteo Scordino
2020-10-30  0:26       ` Matteo Scordino
2020-10-30 23:43 ` [PATCH v2 0/6] Elimo Impetus and Initium support - rework Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-10-30 23:43 ` [PATCH v2 1/6] dt-bindings: vendors: add Elimo Engineering vendor prefix Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-11-02 10:02   ` Maxime Ripard
2020-11-02 10:02     ` Maxime Ripard
2020-10-30 23:43 ` [PATCH v2 2/6] ARM: dts: sun8i: V3/S3: Add UART1 pin definitions to the V3/S3 dtsi Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-11-02 10:03   ` Maxime Ripard
2020-11-02 10:03     ` Maxime Ripard
2020-10-30 23:43 ` [PATCH v2 3/6] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-11-02 10:05   ` Maxime Ripard
2020-11-02 10:05     ` Maxime Ripard
2020-11-03 16:28     ` Matteo Scordino
2020-11-03 16:28       ` Matteo Scordino
2020-11-04 19:04       ` Maxime Ripard
2020-11-04 19:04         ` Maxime Ripard
2020-10-30 23:43 ` [PATCH v2 4/6] dt-bindings: arm: sunxi: add Elimo bindings Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-10-30 23:43 ` [PATCH v2 5/6] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-11-02 10:06   ` Maxime Ripard
2020-11-02 10:06     ` Maxime Ripard
2020-11-03 16:33     ` Matteo Scordino
2020-11-03 16:33       ` Matteo Scordino
2020-11-04 19:05       ` Maxime Ripard
2020-11-04 19:05         ` Maxime Ripard
2020-10-30 23:43 ` [PATCH v2 6/6] ARM: dts: sunxi: align pinecube compatible property to other S3 boards Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-11-02 10:07   ` Maxime Ripard
2020-11-02 10:07     ` Maxime Ripard
2020-11-05 14:49 ` [PATCH v3 0/3] Elimo Impetus and Initium support Matteo Scordino
2020-11-05 14:49   ` Matteo Scordino
2020-11-05 14:49 ` [PATCH v3 1/3] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM Matteo Scordino
2020-11-05 14:49   ` Matteo Scordino
2020-11-05 14:49 ` [PATCH v3 2/3] dt-bindings: arm: sunxi: add Elimo bindings Matteo Scordino
2020-11-05 14:49   ` Matteo Scordino
2020-11-05 14:49 ` [PATCH v3 3/3] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC Matteo Scordino
2020-11-05 14:49   ` Matteo Scordino
2020-11-05 15:00   ` Maxime Ripard
2020-11-05 15:00     ` Maxime Ripard
2020-11-05 18:29     ` Matteo Scordino
2020-11-05 18:29       ` Matteo Scordino
2020-11-05 18:32 ` [PATCH v4 0/3] Elimo Impetus and Initium support Matteo Scordino
2020-11-05 18:32   ` Matteo Scordino
2020-11-05 18:32 ` [PATCH v4 1/3] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM Matteo Scordino
2020-11-05 18:32   ` Matteo Scordino
2020-11-05 18:32 ` [PATCH v4 2/3] dt-bindings: arm: sunxi: add Elimo bindings Matteo Scordino
2020-11-05 18:32   ` Matteo Scordino
2020-11-05 18:32 ` [PATCH v4 3/3] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC Matteo Scordino
2020-11-05 18:32   ` Matteo Scordino
2020-11-06 10:47   ` Maxime Ripard
2020-11-06 10:47     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea5967cdbd6281557d6a739c0eb63a979351b453.camel@gmail.com \
    --to=matteo.scordino@gmail.com \
    --cc=icenowy@aosc.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime@cerno.tech \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.