From: Matteo Scordino <matteo.scordino@gmail.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: wens@csie.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, mripard@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM
Date: Fri, 30 Oct 2020 00:18:14 +0000 [thread overview]
Message-ID: <a44477771ede1aefd74eea404ad011cd15dbcae6.camel@gmail.com> (raw)
In-Reply-To: <20201029100936.GC460689@aptenodytes>
[-- Attachment #1.1: Type: text/plain, Size: 3850 bytes --]
Hello Paul,
Thanks for reviewing!
It seems from the comments in [PATCH 4/5] that the consensus would be to
drop allwinner,sun8i-s3 and keep sochip,s3 (I guess due to the fact that
the S3 is distributed by Sochip).
And yes, you're right that it makes sense to add allwinner,sun8i-v3 at
the end.
So I guess I will resubmit with:
compatible = "elimo,impetus", "sochip,s3", "allwinner,sun8i-v3";
Regarding adding allwinner,sun8i-v3 to sunxi.c: I agree, but I would
hear Icenowy thinks (I think she added allwinner,sun8i-v3 in a patch
last month).
--
Matteo Scordino
On Thu, 2020-10-29 at 11:09 +0100, Paul Kocialkowski wrote:
> Hi,
>
> On Thu 29 Oct 20, 02:19, Matteo Scordino wrote:
> > The Elimo Engineering Impetus is an Open Source Hardware System-on-Module
> > based on the SoChip S3 SoC.
> >
> > It is meant for integration into carrier boards or, more generally,
> > larger designs, and uses an M2 connector to facilitate that.
> >
> > Interfaces on the M.2/NGFF 42mm connector:
> > WiFi IEEE 802. 11abgn (on-module Realtek)
> > Bluetooth 4.2/BLE (on-module Realtek)
> > RGB LCD Interface (on-module connector)
> > MIPI Camera Interface (on-module connector)
> > IEEE 802. 3u Ethernet MAC (external connecto)
> > USB2.0 (Host, Device, OTG) (external connector)
> > Audio Line In/Out (external connector)
> >
> > Signed-off-by: Matteo Scordino <matteo.scordino@gmail.com>
> > ---
> > arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi | 51 +++++++++++++++++++
> > 1 file changed, 51 insertions(+)
> > create mode 100644 arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> >
> > diff --git a/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> > b/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> > new file mode 100644
> > index 000000000000..3550125cf334
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> > @@ -0,0 +1,51 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright (C) 2020 Matteo Scordino <matteo@elimo.io>
> > + */
> > +
> > +/dts-v1/;
> > +#include "sun8i-v3.dtsi"
> > +#include "sunxi-common-regulators.dtsi"
> > +
> > +/ {
> > + model = "Elimo Impetus SoM";
> > + compatible = "elimo,impetus", "sochip,s3", "allwinner,sun8i-s3";
>
> I'm wondering what to do about the SoC compatibles here:
> - Do we really need the "sochip,s3" compatible, as it seems redundant with
> "allwinner,sun8i-s3"?
> - Could we add a "allwinner,sun8i-v3" compatible at the end since there is no
> functional difference between the two?
>
> Another thing is that we should probably add "allwinner,sun8i-v3" to
> mach-sunxi/sunxi.c so that it's matched by the DT_MACHINE_START.
>
> If that seems agreeable, I can craft a patch for the latter.
>
> What do you think?
>
> The rest of the dt looks good to me :)
>
> Cheers,
>
> Paul
>
> > +
> > + aliases {
> > + serial0 = &uart0;
> > + serial1 = &uart1;
> > + };
> > +
> > + chosen {
> > + stdout-path = "serial0:115200n8";
> > + };
> > +};
> > +
> > +&mmc0 {
> > + broken-cd;
> > + bus-width = <4>;
> > + vmmc-supply = <®_vcc3v3>;
> > + status = "okay";
> > +};
> > +
> > +&uart0 {
> > + pinctrl-0 = <&uart0_pb_pins>;
> > + pinctrl-names = "default";
> > + status = "okay";
> > +};
> > +
> > +&uart1 {
> > + pinctrl-0 = <&uart1_pg_pins>;
> > + pinctrl-names = "default";
> > + status = "okay";
> > +};
> > +
> > +&usb_otg {
> > + dr_mode = "otg";
> > + status = "okay";
> > +};
> > +
> > +&usbphy {
> > + usb0_id_det-gpio = <&pio 5 6 GPIO_ACTIVE_HIGH>;
> > + status = "okay";
> > +};
> > --
> > 2.20.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Matteo Scordino <matteo.scordino@gmail.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: mripard@kernel.org, wens@csie.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM
Date: Fri, 30 Oct 2020 00:18:14 +0000 [thread overview]
Message-ID: <a44477771ede1aefd74eea404ad011cd15dbcae6.camel@gmail.com> (raw)
In-Reply-To: <20201029100936.GC460689@aptenodytes>
[-- Attachment #1: Type: text/plain, Size: 3850 bytes --]
Hello Paul,
Thanks for reviewing!
It seems from the comments in [PATCH 4/5] that the consensus would be to
drop allwinner,sun8i-s3 and keep sochip,s3 (I guess due to the fact that
the S3 is distributed by Sochip).
And yes, you're right that it makes sense to add allwinner,sun8i-v3 at
the end.
So I guess I will resubmit with:
compatible = "elimo,impetus", "sochip,s3", "allwinner,sun8i-v3";
Regarding adding allwinner,sun8i-v3 to sunxi.c: I agree, but I would
hear Icenowy thinks (I think she added allwinner,sun8i-v3 in a patch
last month).
--
Matteo Scordino
On Thu, 2020-10-29 at 11:09 +0100, Paul Kocialkowski wrote:
> Hi,
>
> On Thu 29 Oct 20, 02:19, Matteo Scordino wrote:
> > The Elimo Engineering Impetus is an Open Source Hardware System-on-Module
> > based on the SoChip S3 SoC.
> >
> > It is meant for integration into carrier boards or, more generally,
> > larger designs, and uses an M2 connector to facilitate that.
> >
> > Interfaces on the M.2/NGFF 42mm connector:
> > WiFi IEEE 802. 11abgn (on-module Realtek)
> > Bluetooth 4.2/BLE (on-module Realtek)
> > RGB LCD Interface (on-module connector)
> > MIPI Camera Interface (on-module connector)
> > IEEE 802. 3u Ethernet MAC (external connecto)
> > USB2.0 (Host, Device, OTG) (external connector)
> > Audio Line In/Out (external connector)
> >
> > Signed-off-by: Matteo Scordino <matteo.scordino@gmail.com>
> > ---
> > arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi | 51 +++++++++++++++++++
> > 1 file changed, 51 insertions(+)
> > create mode 100644 arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> >
> > diff --git a/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> > b/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> > new file mode 100644
> > index 000000000000..3550125cf334
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> > @@ -0,0 +1,51 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright (C) 2020 Matteo Scordino <matteo@elimo.io>
> > + */
> > +
> > +/dts-v1/;
> > +#include "sun8i-v3.dtsi"
> > +#include "sunxi-common-regulators.dtsi"
> > +
> > +/ {
> > + model = "Elimo Impetus SoM";
> > + compatible = "elimo,impetus", "sochip,s3", "allwinner,sun8i-s3";
>
> I'm wondering what to do about the SoC compatibles here:
> - Do we really need the "sochip,s3" compatible, as it seems redundant with
> "allwinner,sun8i-s3"?
> - Could we add a "allwinner,sun8i-v3" compatible at the end since there is no
> functional difference between the two?
>
> Another thing is that we should probably add "allwinner,sun8i-v3" to
> mach-sunxi/sunxi.c so that it's matched by the DT_MACHINE_START.
>
> If that seems agreeable, I can craft a patch for the latter.
>
> What do you think?
>
> The rest of the dt looks good to me :)
>
> Cheers,
>
> Paul
>
> > +
> > + aliases {
> > + serial0 = &uart0;
> > + serial1 = &uart1;
> > + };
> > +
> > + chosen {
> > + stdout-path = "serial0:115200n8";
> > + };
> > +};
> > +
> > +&mmc0 {
> > + broken-cd;
> > + bus-width = <4>;
> > + vmmc-supply = <®_vcc3v3>;
> > + status = "okay";
> > +};
> > +
> > +&uart0 {
> > + pinctrl-0 = <&uart0_pb_pins>;
> > + pinctrl-names = "default";
> > + status = "okay";
> > +};
> > +
> > +&uart1 {
> > + pinctrl-0 = <&uart1_pg_pins>;
> > + pinctrl-names = "default";
> > + status = "okay";
> > +};
> > +
> > +&usb_otg {
> > + dr_mode = "otg";
> > + status = "okay";
> > +};
> > +
> > +&usbphy {
> > + usb0_id_det-gpio = <&pio 5 6 GPIO_ACTIVE_HIGH>;
> > + status = "okay";
> > +};
> > --
> > 2.20.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-10-30 0:18 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 2:19 [PATCH 0/5] Elimo Impetus and Initium support Matteo Scordino
2020-10-29 2:19 ` Matteo Scordino
2020-10-29 2:19 ` [PATCH 1/5] dt-bindings: vendors: add Elimo Engineering vendor prefix Matteo Scordino
2020-10-29 2:19 ` Matteo Scordino
2020-10-29 10:05 ` Paul Kocialkowski
2020-10-29 10:05 ` Paul Kocialkowski
2020-10-29 2:19 ` [PATCH 2/5] ARM: dts: sun8i: V3/S3: Add UART1 pin definitions to the V3/S3 dtsi Matteo Scordino
2020-10-29 2:19 ` Matteo Scordino
2020-10-29 10:04 ` Paul Kocialkowski
2020-10-29 10:04 ` Paul Kocialkowski
2020-10-29 2:19 ` [PATCH 3/5] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM Matteo Scordino
2020-10-29 2:19 ` Matteo Scordino
2020-10-29 10:09 ` Paul Kocialkowski
2020-10-29 10:09 ` Paul Kocialkowski
2020-10-30 0:18 ` Matteo Scordino [this message]
2020-10-30 0:18 ` Matteo Scordino
2020-10-29 2:19 ` [PATCH 4/5] dt-bindings: arm: sunxi: add Elimo bindings Matteo Scordino
2020-10-29 2:19 ` Matteo Scordino
2020-10-29 10:13 ` Maxime Ripard
2020-10-29 10:13 ` Maxime Ripard
2020-10-29 10:24 ` Icenowy Zheng
2020-10-29 10:24 ` Icenowy Zheng
2020-10-30 0:24 ` Matteo Scordino
2020-10-30 0:24 ` Matteo Scordino
2020-10-30 10:33 ` Icenowy Zheng
2020-10-30 10:33 ` Icenowy Zheng
2020-10-29 2:20 ` [PATCH 5/5] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC Matteo Scordino
2020-10-29 2:20 ` Matteo Scordino
2020-10-29 10:10 ` Paul Kocialkowski
2020-10-29 10:10 ` Paul Kocialkowski
2020-10-30 0:26 ` Matteo Scordino
2020-10-30 0:26 ` Matteo Scordino
2020-10-30 23:43 ` [PATCH v2 0/6] Elimo Impetus and Initium support - rework Matteo Scordino
2020-10-30 23:43 ` Matteo Scordino
2020-10-30 23:43 ` [PATCH v2 1/6] dt-bindings: vendors: add Elimo Engineering vendor prefix Matteo Scordino
2020-10-30 23:43 ` Matteo Scordino
2020-11-02 10:02 ` Maxime Ripard
2020-11-02 10:02 ` Maxime Ripard
2020-10-30 23:43 ` [PATCH v2 2/6] ARM: dts: sun8i: V3/S3: Add UART1 pin definitions to the V3/S3 dtsi Matteo Scordino
2020-10-30 23:43 ` Matteo Scordino
2020-11-02 10:03 ` Maxime Ripard
2020-11-02 10:03 ` Maxime Ripard
2020-10-30 23:43 ` [PATCH v2 3/6] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM Matteo Scordino
2020-10-30 23:43 ` Matteo Scordino
2020-11-02 10:05 ` Maxime Ripard
2020-11-02 10:05 ` Maxime Ripard
2020-11-03 16:28 ` Matteo Scordino
2020-11-03 16:28 ` Matteo Scordino
2020-11-04 19:04 ` Maxime Ripard
2020-11-04 19:04 ` Maxime Ripard
2020-10-30 23:43 ` [PATCH v2 4/6] dt-bindings: arm: sunxi: add Elimo bindings Matteo Scordino
2020-10-30 23:43 ` Matteo Scordino
2020-10-30 23:43 ` [PATCH v2 5/6] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC Matteo Scordino
2020-10-30 23:43 ` Matteo Scordino
2020-11-02 10:06 ` Maxime Ripard
2020-11-02 10:06 ` Maxime Ripard
2020-11-03 16:33 ` Matteo Scordino
2020-11-03 16:33 ` Matteo Scordino
2020-11-04 19:05 ` Maxime Ripard
2020-11-04 19:05 ` Maxime Ripard
2020-10-30 23:43 ` [PATCH v2 6/6] ARM: dts: sunxi: align pinecube compatible property to other S3 boards Matteo Scordino
2020-10-30 23:43 ` Matteo Scordino
2020-11-02 10:07 ` Maxime Ripard
2020-11-02 10:07 ` Maxime Ripard
2020-11-05 14:49 ` [PATCH v3 0/3] Elimo Impetus and Initium support Matteo Scordino
2020-11-05 14:49 ` Matteo Scordino
2020-11-05 14:49 ` [PATCH v3 1/3] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM Matteo Scordino
2020-11-05 14:49 ` Matteo Scordino
2020-11-05 14:49 ` [PATCH v3 2/3] dt-bindings: arm: sunxi: add Elimo bindings Matteo Scordino
2020-11-05 14:49 ` Matteo Scordino
2020-11-05 14:49 ` [PATCH v3 3/3] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC Matteo Scordino
2020-11-05 14:49 ` Matteo Scordino
2020-11-05 15:00 ` Maxime Ripard
2020-11-05 15:00 ` Maxime Ripard
2020-11-05 18:29 ` Matteo Scordino
2020-11-05 18:29 ` Matteo Scordino
2020-11-05 18:32 ` [PATCH v4 0/3] Elimo Impetus and Initium support Matteo Scordino
2020-11-05 18:32 ` Matteo Scordino
2020-11-05 18:32 ` [PATCH v4 1/3] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM Matteo Scordino
2020-11-05 18:32 ` Matteo Scordino
2020-11-05 18:32 ` [PATCH v4 2/3] dt-bindings: arm: sunxi: add Elimo bindings Matteo Scordino
2020-11-05 18:32 ` Matteo Scordino
2020-11-05 18:32 ` [PATCH v4 3/3] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC Matteo Scordino
2020-11-05 18:32 ` Matteo Scordino
2020-11-06 10:47 ` Maxime Ripard
2020-11-06 10:47 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a44477771ede1aefd74eea404ad011cd15dbcae6.camel@gmail.com \
--to=matteo.scordino@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.