All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matteo Scordino <matteo.scordino@gmail.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: wens@csie.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/3] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC
Date: Thu, 05 Nov 2020 18:29:46 +0000	[thread overview]
Message-ID: <7051ef1a9220ab092ee33a6f65e8e84b0bdf6529.camel@gmail.com> (raw)
In-Reply-To: <20201105150013.aruomoglclrpaacf@gilmour.lan>


[-- Attachment #1.1: Type: text/plain, Size: 2510 bytes --]

Hi,

On Thu, 2020-11-05 at 16:00 +0100, Maxime Ripard wrote:
> On Thu, Nov 05, 2020 at 02:49:45PM +0000, Matteo Scordino wrote:
> > The Elimo Engineering Initium is an Open Source Hardware Single Board
> > Computer based on the Elimo Impetus SoM.
> > 
> > It is meant as the first development platform for the Impetus, providing
> > convenient access to the peripherals on the Impetus.
> > 
> > It provides:
> > USB-C power input
> > UART-to-USB bridge on the USB-C connector, connected to UART1
> > USB-A connector for USB2.0 (Host, Device, OTG)
> > Audio Line In/Out
> > Pin header to access all signals on the M2 connector of the SoM
> > 
> > Signed-off-by: Matteo Scordino <matteo.scordino@gmail.com>
> > ---
> >  arch/arm/boot/dts/Makefile                   |  1 +
> >  arch/arm/boot/dts/sun8i-s3-elimo-initium.dts | 34 ++++++++++++++++++++
> >  2 files changed, 35 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/sun8i-s3-elimo-initium.dts
> > 
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 4f0adfead547..50e438ab8a00 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -1208,6 +1208,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \
> >  	sun8i-r16-nintendo-super-nes-classic.dtb \
> >  	sun8i-r16-parrot.dtb \
> >  	sun8i-r40-bananapi-m2-ultra.dtb \
> > +	sun8i-s3-elimo-initium.dtb \
> >  	sun8i-s3-lichee-zero-plus.dtb \
> >  	sun8i-s3-pinecube.dtb \
> >  	sun8i-t3-cqa3t-bv3.dtb \
> > diff --git a/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts b/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts
> > new file mode 100644
> > index 000000000000..2119403fb65e
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts
> > @@ -0,0 +1,34 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright (C) 2020 Matteo Scordino <matteo@elimo.io>
> > + */
> > +
> > +/dts-v1/;
> > +#include "sun8i-s3-elimo-impetus.dtsi"
> > +
> > +/ {
> > +	model = "Elimo Initium";
> > +	compatible = "elimo,initium", "elimo,impetus", "sochip,s3",
> > +		     "allwinner,sun8i-v3";
> > +
> > +	aliases {
> > +		serial0 = &uart0;
> 
> This alias would come from the DTSI

Removing it.
> 
> > +		serial1 = &uart1;
> > +	};
> > +
> > +	chosen {
> > +		stdout-path = "serial0:115200n8";
> > +	};
> 
> And this node too

Removing this too. Sorry for the many iterations, as you can probably see by now,
this is my first kernel patch submission =)

> Maxime


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Matteo Scordino <matteo.scordino@gmail.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: wens@csie.org, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC
Date: Thu, 05 Nov 2020 18:29:46 +0000	[thread overview]
Message-ID: <7051ef1a9220ab092ee33a6f65e8e84b0bdf6529.camel@gmail.com> (raw)
In-Reply-To: <20201105150013.aruomoglclrpaacf@gilmour.lan>

[-- Attachment #1: Type: text/plain, Size: 2510 bytes --]

Hi,

On Thu, 2020-11-05 at 16:00 +0100, Maxime Ripard wrote:
> On Thu, Nov 05, 2020 at 02:49:45PM +0000, Matteo Scordino wrote:
> > The Elimo Engineering Initium is an Open Source Hardware Single Board
> > Computer based on the Elimo Impetus SoM.
> > 
> > It is meant as the first development platform for the Impetus, providing
> > convenient access to the peripherals on the Impetus.
> > 
> > It provides:
> > USB-C power input
> > UART-to-USB bridge on the USB-C connector, connected to UART1
> > USB-A connector for USB2.0 (Host, Device, OTG)
> > Audio Line In/Out
> > Pin header to access all signals on the M2 connector of the SoM
> > 
> > Signed-off-by: Matteo Scordino <matteo.scordino@gmail.com>
> > ---
> >  arch/arm/boot/dts/Makefile                   |  1 +
> >  arch/arm/boot/dts/sun8i-s3-elimo-initium.dts | 34 ++++++++++++++++++++
> >  2 files changed, 35 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/sun8i-s3-elimo-initium.dts
> > 
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 4f0adfead547..50e438ab8a00 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -1208,6 +1208,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \
> >  	sun8i-r16-nintendo-super-nes-classic.dtb \
> >  	sun8i-r16-parrot.dtb \
> >  	sun8i-r40-bananapi-m2-ultra.dtb \
> > +	sun8i-s3-elimo-initium.dtb \
> >  	sun8i-s3-lichee-zero-plus.dtb \
> >  	sun8i-s3-pinecube.dtb \
> >  	sun8i-t3-cqa3t-bv3.dtb \
> > diff --git a/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts b/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts
> > new file mode 100644
> > index 000000000000..2119403fb65e
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts
> > @@ -0,0 +1,34 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright (C) 2020 Matteo Scordino <matteo@elimo.io>
> > + */
> > +
> > +/dts-v1/;
> > +#include "sun8i-s3-elimo-impetus.dtsi"
> > +
> > +/ {
> > +	model = "Elimo Initium";
> > +	compatible = "elimo,initium", "elimo,impetus", "sochip,s3",
> > +		     "allwinner,sun8i-v3";
> > +
> > +	aliases {
> > +		serial0 = &uart0;
> 
> This alias would come from the DTSI

Removing it.
> 
> > +		serial1 = &uart1;
> > +	};
> > +
> > +	chosen {
> > +		stdout-path = "serial0:115200n8";
> > +	};
> 
> And this node too

Removing this too. Sorry for the many iterations, as you can probably see by now,
this is my first kernel patch submission =)

> Maxime


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-11-05 18:30 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29  2:19 [PATCH 0/5] Elimo Impetus and Initium support Matteo Scordino
2020-10-29  2:19 ` Matteo Scordino
2020-10-29  2:19 ` [PATCH 1/5] dt-bindings: vendors: add Elimo Engineering vendor prefix Matteo Scordino
2020-10-29  2:19   ` Matteo Scordino
2020-10-29 10:05   ` Paul Kocialkowski
2020-10-29 10:05     ` Paul Kocialkowski
2020-10-29  2:19 ` [PATCH 2/5] ARM: dts: sun8i: V3/S3: Add UART1 pin definitions to the V3/S3 dtsi Matteo Scordino
2020-10-29  2:19   ` Matteo Scordino
2020-10-29 10:04   ` Paul Kocialkowski
2020-10-29 10:04     ` Paul Kocialkowski
2020-10-29  2:19 ` [PATCH 3/5] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM Matteo Scordino
2020-10-29  2:19   ` Matteo Scordino
2020-10-29 10:09   ` Paul Kocialkowski
2020-10-29 10:09     ` Paul Kocialkowski
2020-10-30  0:18     ` Matteo Scordino
2020-10-30  0:18       ` Matteo Scordino
2020-10-29  2:19 ` [PATCH 4/5] dt-bindings: arm: sunxi: add Elimo bindings Matteo Scordino
2020-10-29  2:19   ` Matteo Scordino
2020-10-29 10:13   ` Maxime Ripard
2020-10-29 10:13     ` Maxime Ripard
2020-10-29 10:24     ` Icenowy Zheng
2020-10-29 10:24       ` Icenowy Zheng
2020-10-30  0:24       ` Matteo Scordino
2020-10-30  0:24         ` Matteo Scordino
2020-10-30 10:33         ` Icenowy Zheng
2020-10-30 10:33           ` Icenowy Zheng
2020-10-29  2:20 ` [PATCH 5/5] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC Matteo Scordino
2020-10-29  2:20   ` Matteo Scordino
2020-10-29 10:10   ` Paul Kocialkowski
2020-10-29 10:10     ` Paul Kocialkowski
2020-10-30  0:26     ` Matteo Scordino
2020-10-30  0:26       ` Matteo Scordino
2020-10-30 23:43 ` [PATCH v2 0/6] Elimo Impetus and Initium support - rework Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-10-30 23:43 ` [PATCH v2 1/6] dt-bindings: vendors: add Elimo Engineering vendor prefix Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-11-02 10:02   ` Maxime Ripard
2020-11-02 10:02     ` Maxime Ripard
2020-10-30 23:43 ` [PATCH v2 2/6] ARM: dts: sun8i: V3/S3: Add UART1 pin definitions to the V3/S3 dtsi Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-11-02 10:03   ` Maxime Ripard
2020-11-02 10:03     ` Maxime Ripard
2020-10-30 23:43 ` [PATCH v2 3/6] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-11-02 10:05   ` Maxime Ripard
2020-11-02 10:05     ` Maxime Ripard
2020-11-03 16:28     ` Matteo Scordino
2020-11-03 16:28       ` Matteo Scordino
2020-11-04 19:04       ` Maxime Ripard
2020-11-04 19:04         ` Maxime Ripard
2020-10-30 23:43 ` [PATCH v2 4/6] dt-bindings: arm: sunxi: add Elimo bindings Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-10-30 23:43 ` [PATCH v2 5/6] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-11-02 10:06   ` Maxime Ripard
2020-11-02 10:06     ` Maxime Ripard
2020-11-03 16:33     ` Matteo Scordino
2020-11-03 16:33       ` Matteo Scordino
2020-11-04 19:05       ` Maxime Ripard
2020-11-04 19:05         ` Maxime Ripard
2020-10-30 23:43 ` [PATCH v2 6/6] ARM: dts: sunxi: align pinecube compatible property to other S3 boards Matteo Scordino
2020-10-30 23:43   ` Matteo Scordino
2020-11-02 10:07   ` Maxime Ripard
2020-11-02 10:07     ` Maxime Ripard
2020-11-05 14:49 ` [PATCH v3 0/3] Elimo Impetus and Initium support Matteo Scordino
2020-11-05 14:49   ` Matteo Scordino
2020-11-05 14:49 ` [PATCH v3 1/3] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM Matteo Scordino
2020-11-05 14:49   ` Matteo Scordino
2020-11-05 14:49 ` [PATCH v3 2/3] dt-bindings: arm: sunxi: add Elimo bindings Matteo Scordino
2020-11-05 14:49   ` Matteo Scordino
2020-11-05 14:49 ` [PATCH v3 3/3] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC Matteo Scordino
2020-11-05 14:49   ` Matteo Scordino
2020-11-05 15:00   ` Maxime Ripard
2020-11-05 15:00     ` Maxime Ripard
2020-11-05 18:29     ` Matteo Scordino [this message]
2020-11-05 18:29       ` Matteo Scordino
2020-11-05 18:32 ` [PATCH v4 0/3] Elimo Impetus and Initium support Matteo Scordino
2020-11-05 18:32   ` Matteo Scordino
2020-11-05 18:32 ` [PATCH v4 1/3] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM Matteo Scordino
2020-11-05 18:32   ` Matteo Scordino
2020-11-05 18:32 ` [PATCH v4 2/3] dt-bindings: arm: sunxi: add Elimo bindings Matteo Scordino
2020-11-05 18:32   ` Matteo Scordino
2020-11-05 18:32 ` [PATCH v4 3/3] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC Matteo Scordino
2020-11-05 18:32   ` Matteo Scordino
2020-11-06 10:47   ` Maxime Ripard
2020-11-06 10:47     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7051ef1a9220ab092ee33a6f65e8e84b0bdf6529.camel@gmail.com \
    --to=matteo.scordino@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime@cerno.tech \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.