From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, Antoine Tenart <atenart@kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Tobias Waldekranz <tobias@waldekranz.com>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: net: phy: Dealing with 88e1543 dual-port mode
Date: Fri, 20 Nov 2020 10:25:38 +0000 [thread overview]
Message-ID: <20201120102538.GP1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20201120103601.313a166b@bootlin.com>
On Fri, Nov 20, 2020 at 10:36:01AM +0100, Maxime Chevallier wrote:
> So maybe we could be a bit more generic, with something along these lines :
>
> ethernet-phy@0 {
> ...
>
> mdi {
> port@0 {
> media = "10baseT", "100baseT", "1000baseT";
> pairs = <1>;
> };
>
> port@1 {
> media = "1000baseX", "10gbaseR"
> };
> };
> };
Don't forget that TP requires a minimum of two pairs. However, as
Andrew pointed out, we already have max-speed which can be used to
limit the speed below that which requires four pairs.
I have untested patches that allow the 88x3310 to be reconfigured
between 10GBASE-R and 1000BASE-X depending on the SFP connected -
untested because the I2C pull-ups on the Macchiatobin boards I have
are way too strong and it results in SFP EEPROM corruption and/or
failure to read the EEPROM.
> I also like the idea of having a way to express the "preferred" media,
> although I wonder if that's something we want to include in DT or that
> we would want to tweak at runtime, through ethtool for example.
I think preferred media should be configurable through ethtool -
which is preferred will be specific to the user's application.
However, there may be scope for DT to be able to specify the default
preferred media.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Tobias Waldekranz <tobias@waldekranz.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Antoine Tenart <atenart@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: net: phy: Dealing with 88e1543 dual-port mode
Date: Fri, 20 Nov 2020 10:25:38 +0000 [thread overview]
Message-ID: <20201120102538.GP1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20201120103601.313a166b@bootlin.com>
On Fri, Nov 20, 2020 at 10:36:01AM +0100, Maxime Chevallier wrote:
> So maybe we could be a bit more generic, with something along these lines :
>
> ethernet-phy@0 {
> ...
>
> mdi {
> port@0 {
> media = "10baseT", "100baseT", "1000baseT";
> pairs = <1>;
> };
>
> port@1 {
> media = "1000baseX", "10gbaseR"
> };
> };
> };
Don't forget that TP requires a minimum of two pairs. However, as
Andrew pointed out, we already have max-speed which can be used to
limit the speed below that which requires four pairs.
I have untested patches that allow the 88x3310 to be reconfigured
between 10GBASE-R and 1000BASE-X depending on the SFP connected -
untested because the I2C pull-ups on the Macchiatobin boards I have
are way too strong and it results in SFP EEPROM corruption and/or
failure to read the EEPROM.
> I also like the idea of having a way to express the "preferred" media,
> although I wonder if that's something we want to include in DT or that
> we would want to tweak at runtime, through ethtool for example.
I think preferred media should be configurable through ethtool -
which is preferred will be specific to the user's application.
However, there may be scope for DT to be able to specify the default
preferred media.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-11-20 10:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 14:22 net: phy: Dealing with 88e1543 dual-port mode Maxime Chevallier
2020-11-19 14:22 ` Maxime Chevallier
2020-11-19 14:55 ` Russell King - ARM Linux admin
2020-11-19 14:55 ` Russell King - ARM Linux admin
2020-11-19 15:19 ` Russell King - ARM Linux admin
2020-11-19 15:19 ` Russell King - ARM Linux admin
2020-11-19 15:24 ` Maxime Chevallier
2020-11-19 15:24 ` Maxime Chevallier
2020-11-19 22:43 ` Tobias Waldekranz
2020-11-19 22:43 ` Tobias Waldekranz
2020-11-19 23:16 ` Russell King - ARM Linux admin
2020-11-19 23:16 ` Russell King - ARM Linux admin
2020-11-20 0:11 ` Tobias Waldekranz
2020-11-20 0:11 ` Tobias Waldekranz
2020-11-20 0:40 ` Russell King - ARM Linux admin
2020-11-20 0:40 ` Russell King - ARM Linux admin
2020-11-20 9:12 ` Tobias Waldekranz
2020-11-20 9:12 ` Tobias Waldekranz
2020-11-20 9:36 ` Maxime Chevallier
2020-11-20 9:36 ` Maxime Chevallier
2020-11-20 10:25 ` Russell King - ARM Linux admin [this message]
2020-11-20 10:25 ` Russell King - ARM Linux admin
2020-11-20 10:59 ` Tobias Waldekranz
2020-11-20 10:59 ` Tobias Waldekranz
2020-11-20 13:55 ` Andrew Lunn
2020-11-20 13:55 ` Andrew Lunn
2020-11-20 14:18 ` Maxime Chevallier
2020-11-20 14:18 ` Maxime Chevallier
2020-11-20 0:00 ` Andrew Lunn
2020-11-20 0:00 ` Andrew Lunn
2020-11-20 9:05 ` Tobias Waldekranz
2020-11-20 9:05 ` Tobias Waldekranz
2020-11-19 15:16 ` Andrew Lunn
2020-11-19 15:16 ` Andrew Lunn
2020-11-19 15:45 ` Maxime Chevallier
2020-11-19 15:45 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120102538.GP1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.