From: Tobias Waldekranz <tobias@waldekranz.com>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, Antoine Tenart <atenart@kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: net: phy: Dealing with 88e1543 dual-port mode
Date: Thu, 19 Nov 2020 23:43:39 +0100 [thread overview]
Message-ID: <87k0uh9dd0.fsf@waldekranz.com> (raw)
In-Reply-To: <20201119162451.4c8d220d@bootlin.com>
On Thu, Nov 19, 2020 at 16:24, Maxime Chevallier <maxime.chevallier@bootlin.com> wrote:
> I don't think we have a way to distinguish from the DT if we are in
> SGMII-to-Fibre or in SGMII-to-{Copper + Fibre}, since the description is
> the same, we don't have any information in DT about wether or not the
> PHY is wired to a Copper RJ45 port.
>
> Maybe we should have a way to indicate if a PHY is wired to a Copper
> port in DT ?
Do you mean something like:
SGMII->SGMII (Fibre):
ethernet-phy@0 {
sfp = <&sfp0>;
};
SGMII->MDI (Copper):
ethernet-phy@0 {
mdi;
};
SGMII->Auto Media Detect
ethernet-phy@0 {
mdi;
sfp = <&sfp0>;
};
If so, this could also be useful in scenarios that have nothing to do
with combo ports, but where you have custom connectors.
E.g. at Westermo we make switches with M12/M12X connectors [1] that
sometimes have a 1G PHY behind a 2-pair M12 connector (for complicated
legacy reasons). In such cases we have to remove 1000-HD/FD from the
advertised link modes. Being able to describe that in the DT with
something like:
ethernet-phy@0 {
mdi = "2-pair";
};
Would be great!
On the topic of combo ports, another thing to consider is how this
should play with ethtool. Ideally it would be aware of the two media
sides, and be able to configure them both independently.
[1]: https://www.westermo.com/products/ethernet-switches/en50155/viper-208-t4g-tbn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Tobias Waldekranz <tobias@waldekranz.com>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Antoine Tenart <atenart@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: net: phy: Dealing with 88e1543 dual-port mode
Date: Thu, 19 Nov 2020 23:43:39 +0100 [thread overview]
Message-ID: <87k0uh9dd0.fsf@waldekranz.com> (raw)
In-Reply-To: <20201119162451.4c8d220d@bootlin.com>
On Thu, Nov 19, 2020 at 16:24, Maxime Chevallier <maxime.chevallier@bootlin.com> wrote:
> I don't think we have a way to distinguish from the DT if we are in
> SGMII-to-Fibre or in SGMII-to-{Copper + Fibre}, since the description is
> the same, we don't have any information in DT about wether or not the
> PHY is wired to a Copper RJ45 port.
>
> Maybe we should have a way to indicate if a PHY is wired to a Copper
> port in DT ?
Do you mean something like:
SGMII->SGMII (Fibre):
ethernet-phy@0 {
sfp = <&sfp0>;
};
SGMII->MDI (Copper):
ethernet-phy@0 {
mdi;
};
SGMII->Auto Media Detect
ethernet-phy@0 {
mdi;
sfp = <&sfp0>;
};
If so, this could also be useful in scenarios that have nothing to do
with combo ports, but where you have custom connectors.
E.g. at Westermo we make switches with M12/M12X connectors [1] that
sometimes have a 1G PHY behind a 2-pair M12 connector (for complicated
legacy reasons). In such cases we have to remove 1000-HD/FD from the
advertised link modes. Being able to describe that in the DT with
something like:
ethernet-phy@0 {
mdi = "2-pair";
};
Would be great!
On the topic of combo ports, another thing to consider is how this
should play with ethtool. Ideally it would be aware of the two media
sides, and be able to configure them both independently.
[1]: https://www.westermo.com/products/ethernet-switches/en50155/viper-208-t4g-tbn
next prev parent reply other threads:[~2020-11-19 22:45 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 14:22 net: phy: Dealing with 88e1543 dual-port mode Maxime Chevallier
2020-11-19 14:22 ` Maxime Chevallier
2020-11-19 14:55 ` Russell King - ARM Linux admin
2020-11-19 14:55 ` Russell King - ARM Linux admin
2020-11-19 15:19 ` Russell King - ARM Linux admin
2020-11-19 15:19 ` Russell King - ARM Linux admin
2020-11-19 15:24 ` Maxime Chevallier
2020-11-19 15:24 ` Maxime Chevallier
2020-11-19 22:43 ` Tobias Waldekranz [this message]
2020-11-19 22:43 ` Tobias Waldekranz
2020-11-19 23:16 ` Russell King - ARM Linux admin
2020-11-19 23:16 ` Russell King - ARM Linux admin
2020-11-20 0:11 ` Tobias Waldekranz
2020-11-20 0:11 ` Tobias Waldekranz
2020-11-20 0:40 ` Russell King - ARM Linux admin
2020-11-20 0:40 ` Russell King - ARM Linux admin
2020-11-20 9:12 ` Tobias Waldekranz
2020-11-20 9:12 ` Tobias Waldekranz
2020-11-20 9:36 ` Maxime Chevallier
2020-11-20 9:36 ` Maxime Chevallier
2020-11-20 10:25 ` Russell King - ARM Linux admin
2020-11-20 10:25 ` Russell King - ARM Linux admin
2020-11-20 10:59 ` Tobias Waldekranz
2020-11-20 10:59 ` Tobias Waldekranz
2020-11-20 13:55 ` Andrew Lunn
2020-11-20 13:55 ` Andrew Lunn
2020-11-20 14:18 ` Maxime Chevallier
2020-11-20 14:18 ` Maxime Chevallier
2020-11-20 0:00 ` Andrew Lunn
2020-11-20 0:00 ` Andrew Lunn
2020-11-20 9:05 ` Tobias Waldekranz
2020-11-20 9:05 ` Tobias Waldekranz
2020-11-19 15:16 ` Andrew Lunn
2020-11-19 15:16 ` Andrew Lunn
2020-11-19 15:45 ` Maxime Chevallier
2020-11-19 15:45 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0uh9dd0.fsf@waldekranz.com \
--to=tobias@waldekranz.com \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.