From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 3/6] sched: make struct sched_statistics independent of fair sched class
Date: Tue, 01 Dec 2020 21:30:32 +0800 [thread overview]
Message-ID: <202012012122.2YAQ5kuP-lkp@intel.com> (raw)
In-Reply-To: <20201201115416.26515-4-laoar.shao@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3758 bytes --]
Hi Yafang,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v5.10-rc6]
[cannot apply to tip/sched/core next-20201201]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Yafang-Shao/sched-support-schedstats-for-RT-sched-class/20201201-200101
base: b65054597872ce3aefbc6a666385eabdf9e288da
config: i386-randconfig-m021-20201201 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/a2e8aa563953755a3bae609996b94b02a530641e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yafang-Shao/sched-support-schedstats-for-RT-sched-class/20201201-200101
git checkout a2e8aa563953755a3bae609996b94b02a530641e
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from kernel/sched/fair.c:24:
kernel/sched/stats.h: In function 'free_tg_schedstats':
kernel/sched/stats.h:50:9: error: dereferencing pointer to incomplete type 'struct task_group'
50 | if (tg->stats)
| ^~
kernel/sched/fair.c: In function '__schedstat_from_sched_entity':
kernel/sched/fair.c:854:14: error: 'struct cfs_rq' has no member named 'tg'
854 | tg = cfs_rq->tg;
| ^~
>> kernel/sched/fair.c:847:6: warning: variable 'cpu' set but not used [-Wunused-but-set-variable]
847 | int cpu;
| ^~~
kernel/sched/fair.c: At top level:
kernel/sched/fair.c:5419:6: warning: no previous prototype for 'init_cfs_bandwidth' [-Wmissing-prototypes]
5419 | void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
| ^~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11201:6: warning: no previous prototype for 'free_fair_sched_group' [-Wmissing-prototypes]
11201 | void free_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11203:5: warning: no previous prototype for 'alloc_fair_sched_group' [-Wmissing-prototypes]
11203 | int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
| ^~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11208:6: warning: no previous prototype for 'online_fair_sched_group' [-Wmissing-prototypes]
11208 | void online_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11210:6: warning: no previous prototype for 'unregister_fair_sched_group' [-Wmissing-prototypes]
11210 | void unregister_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/cpu +847 kernel/sched/fair.c
839
840 static inline void
841 __schedstat_from_sched_entity(struct sched_entity *se,
842 struct sched_statistics **stats)
843 {
844 struct task_struct *p;
845 struct task_group *tg;
846 struct cfs_rq *cfs_rq;
> 847 int cpu;
848
849 if (entity_is_task(se)) {
850 p = task_of(se);
851 *stats = &p->stats;
852 } else {
853 cfs_rq = group_cfs_rq(se);
854 tg = cfs_rq->tg;
855 cpu = cpu_of(rq_of(cfs_rq));
856 *stats = tg->stats[cpu];
857 }
858 }
859
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39476 bytes --]
next prev parent reply other threads:[~2020-12-01 13:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 11:54 [PATCH 0/6] sched: support schedstats for RT sched class Yafang Shao
2020-12-01 11:54 ` [PATCH 1/6] sched: don't include stats.h in sched.h Yafang Shao
2020-12-01 11:54 ` [PATCH 2/6] sched, fair: use __schedstat_set() in set_next_entity() Yafang Shao
2020-12-01 12:28 ` Mel Gorman
2020-12-01 11:54 ` [PATCH 3/6] sched: make struct sched_statistics independent of fair sched class Yafang Shao
2020-12-01 12:41 ` Mel Gorman
2020-12-02 2:06 ` Yafang Shao
2020-12-01 13:19 ` kernel test robot
2020-12-01 13:30 ` kernel test robot [this message]
2020-12-01 11:54 ` [PATCH 4/6] sched: make schedstats helpers " Yafang Shao
2020-12-01 12:46 ` Mel Gorman
2020-12-02 2:04 ` Yafang Shao
2020-12-01 13:58 ` kernel test robot
2020-12-01 11:54 ` [PATCH 5/6] sched, rt: support sched_stat_runtime tracepoint for RT " Yafang Shao
2020-12-01 11:54 ` [PATCH 6/6] sched, rt: support schedstats " Yafang Shao
2020-12-01 13:59 ` kernel test robot
2020-12-01 14:13 ` kernel test robot
2020-12-01 14:30 ` kernel test robot
2020-12-02 2:07 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012012122.2YAQ5kuP-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.