Re: [PATCH 6/6] sched, rt: support schedstats for RT sched class

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4825 bytes --]

Hi Yafang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v5.10-rc6]
[cannot apply to tip/sched/core next-20201201]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Yafang-Shao/sched-support-schedstats-for-RT-sched-class/20201201-200101
base:    b65054597872ce3aefbc6a666385eabdf9e288da
config: m68k-randconfig-p001-20201201 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8fe6f2ed51d6372798149583be6c936c597c500e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yafang-Shao/sched-support-schedstats-for-RT-sched-class/20201201-200101
        git checkout 8fe6f2ed51d6372798149583be6c936c597c500e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/asm-generic/bug.h:5,
                    from arch/m68k/include/asm/bug.h:32,
                    from include/linux/bug.h:5,
                    from include/linux/thread_info.h:12,
                    from arch/m68k/include/asm/current.h:16,
                    from include/linux/sched.h:12,
                    from kernel/sched/sched.h:8,
                    from kernel/sched/rt.c:6:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/m68k/include/asm/page_no.h:33:50: warning: ordered comparison of pointer with null pointer [-Wextra]
      33 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \
         |                                                  ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |  ^~~~~~
   include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |          ^~~~~~~~~~~~~~~
   kernel/sched/rt.c: At top level:
   kernel/sched/rt.c:668:6: warning: no previous prototype for 'sched_rt_bandwidth_account' [-Wmissing-prototypes]
     668 | bool sched_rt_bandwidth_account(struct rt_rq *rt_rq)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/sched/rt.c: In function '__schedstat_from_sched_rt_entity':
   kernel/sched/rt.c:1288:13: error: 'struct rt_rq' has no member named 'tg'
    1288 |   tg = rt_rq->tg;
         |             ^~
   kernel/sched/rt.c: In function 'update_stats_wait_start_rt':
>> kernel/sched/rt.c:1308:22: warning: variable 'p' set but not used [-Wunused-but-set-variable]
    1308 |  struct task_struct *p = NULL;
         |                      ^
   kernel/sched/rt.c: In function 'update_stats_enqueue_sleeper_rt':
   kernel/sched/rt.c:1325:22: warning: variable 'p' set but not used [-Wunused-but-set-variable]
    1325 |  struct task_struct *p = NULL;
         |                      ^
   kernel/sched/rt.c: In function 'update_stats_wait_end_rt':
   kernel/sched/rt.c:1353:22: warning: variable 'p' set but not used [-Wunused-but-set-variable]
    1353 |  struct task_struct *p = NULL;
         |                      ^
   kernel/sched/rt.c: At top level:
   kernel/sched/rt.c:1698:6: warning: no previous prototype for 'set_next_task_rt' [-Wmissing-prototypes]
    1698 | void set_next_task_rt(struct rq *rq, struct task_struct *p, bool first)
         |      ^~~~~~~~~~~~~~~~

vim +/p +1308 kernel/sched/rt.c

  1303	
  1304	static inline void
  1305	update_stats_wait_start_rt(struct rt_rq *rt_rq, struct sched_rt_entity *rt_se)
  1306	{
  1307		struct sched_statistics *stats = NULL;
> 1308		struct task_struct *p = NULL;
  1309	
  1310		if (!schedstat_enabled())
  1311			return;
  1312	
  1313		if (rt_entity_is_task(rt_se))
  1314			p = rt_task_of(rt_se);
  1315	
  1316		__schedstat_from_sched_rt_entity(rt_se, &stats);
  1317	
  1318		__update_stats_wait_start(rq_of_rt_rq(rt_rq), p, stats);
  1319	}
  1320	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 20261 bytes --]