Re: [PATCH 6/6] sched, rt: support schedstats for RT sched class

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4772 bytes --]

Hi Yafang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v5.10-rc6]
[cannot apply to tip/sched/core next-20201201]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Yafang-Shao/sched-support-schedstats-for-RT-sched-class/20201201-200101
base:    b65054597872ce3aefbc6a666385eabdf9e288da
config: riscv-randconfig-r034-20201201 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ac40a2d8f16b8a8c68fc811d67f647740e965cb8)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/0day-ci/linux/commit/8fe6f2ed51d6372798149583be6c936c597c500e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yafang-Shao/sched-support-schedstats-for-RT-sched-class/20201201-200101
        git checkout 8fe6f2ed51d6372798149583be6c936c597c500e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   kernel/sched/rt.c:253:6: warning: no previous prototype for function 'free_rt_sched_group' [-Wmissing-prototypes]
   void free_rt_sched_group(struct task_group *tg) { }
        ^
   kernel/sched/rt.c:253:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void free_rt_sched_group(struct task_group *tg) { }
   ^
   static 
   kernel/sched/rt.c:255:5: warning: no previous prototype for function 'alloc_rt_sched_group' [-Wmissing-prototypes]
   int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent)
       ^
   kernel/sched/rt.c:255:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent)
   ^
   static 
   kernel/sched/rt.c:668:6: warning: no previous prototype for function 'sched_rt_bandwidth_account' [-Wmissing-prototypes]
   bool sched_rt_bandwidth_account(struct rt_rq *rt_rq)
        ^
   kernel/sched/rt.c:668:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   bool sched_rt_bandwidth_account(struct rt_rq *rt_rq)
   ^
   static 
   kernel/sched/rt.c:1288:15: error: no member named 'tg' in 'struct rt_rq'
                   tg = rt_rq->tg;
                        ~~~~~  ^
   kernel/sched/rt.c:1290:14: error: incomplete definition of type 'struct task_group'
                   *stats = tg->stats[cpu];
                            ~~^
   include/linux/sched.h:65:8: note: forward declaration of 'struct task_group'
   struct task_group;
          ^
>> kernel/sched/rt.c:1698:6: warning: no previous prototype for function 'set_next_task_rt' [-Wmissing-prototypes]
   void set_next_task_rt(struct rq *rq, struct task_struct *p, bool first)
        ^
   kernel/sched/rt.c:1698:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void set_next_task_rt(struct rq *rq, struct task_struct *p, bool first)
   ^
   static 
   4 warnings and 2 errors generated.

vim +/set_next_task_rt +1698 kernel/sched/rt.c

  1697	
> 1698	void set_next_task_rt(struct rq *rq, struct task_struct *p, bool first)
  1699	{
  1700		struct sched_rt_entity *rt_se = &p->rt;
  1701		struct rt_rq *rt_rq = &rq->rt;
  1702	
  1703		p->se.exec_start = rq_clock_task(rq);
  1704		if (on_rt_rq(&p->rt))
  1705			update_stats_wait_end_rt(rt_rq, rt_se);
  1706	
  1707		/* The running task is never eligible for pushing */
  1708		dequeue_pushable_task(rq, p);
  1709	
  1710		if (!first)
  1711			return;
  1712	
  1713		/*
  1714		 * If prev task was rt, put_prev_task() has already updated the
  1715		 * utilization. We only care of the case where we start to schedule a
  1716		 * rt task
  1717		 */
  1718		if (rq->curr->sched_class != &rt_sched_class)
  1719			update_rt_rq_load_avg(rq_clock_pelt(rq), rq, 0);
  1720	
  1721		rt_queue_push_tasks(rq);
  1722	}
  1723	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35259 bytes --]