Re: [PATCH 4/6] sched: make schedstats helpers independent of fair sched class

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4298 bytes --]

Hi Yafang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v5.10-rc6]
[cannot apply to tip/sched/core next-20201201]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Yafang-Shao/sched-support-schedstats-for-RT-sched-class/20201201-200101
base:    b65054597872ce3aefbc6a666385eabdf9e288da
config: m68k-randconfig-p001-20201201 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/e204b91936080185697938950f4db7466425716c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yafang-Shao/sched-support-schedstats-for-RT-sched-class/20201201-200101
        git checkout e204b91936080185697938950f4db7466425716c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/asm-generic/bug.h:5,
                    from arch/m68k/include/asm/bug.h:32,
                    from include/linux/bug.h:5,
                    from include/linux/thread_info.h:12,
                    from arch/m68k/include/asm/current.h:16,
                    from include/linux/sched.h:12,
                    from kernel/sched/sched.h:8,
                    from kernel/sched/fair.c:23:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/m68k/include/asm/page_no.h:33:50: warning: ordered comparison of pointer with null pointer [-Wextra]
      33 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \
         |                                                  ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |  ^~~~~~
   include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |          ^~~~~~~~~~~~~~~
   kernel/sched/fair.c: In function '__schedstat_from_sched_entity':
   kernel/sched/fair.c:854:14: error: 'struct cfs_rq' has no member named 'tg'
     854 |   tg = cfs_rq->tg;
         |              ^~
   kernel/sched/fair.c: In function 'update_stats_wait_start_fair':
>> kernel/sched/fair.c:923:22: warning: variable 'p' set but not used [-Wunused-but-set-variable]
     923 |  struct task_struct *p = NULL;
         |                      ^
   kernel/sched/fair.c: In function 'update_stats_wait_end_fair':
   kernel/sched/fair.c:940:22: warning: variable 'p' set but not used [-Wunused-but-set-variable]
     940 |  struct task_struct *p = NULL;
         |                      ^
   kernel/sched/fair.c: In function 'update_stats_enqueue_sleeper_fair':
   kernel/sched/fair.c:957:22: warning: variable 'p' set but not used [-Wunused-but-set-variable]
     957 |  struct task_struct *p = NULL;
         |                      ^

vim +/p +923 kernel/sched/fair.c

   918	
   919	static inline void
   920	update_stats_wait_start_fair(struct cfs_rq *cfs_rq, struct sched_entity *se)
   921	{
   922		struct sched_statistics *stats = NULL;
 > 923		struct task_struct *p = NULL;
   924	
   925		if (!schedstat_enabled())
   926			return;
   927	
   928		if (entity_is_task(se))
   929			p = task_of(se);
   930	
   931		__schedstat_from_sched_entity(se, &stats);
   932	
   933		__update_stats_wait_start(rq_of(cfs_rq), p, stats);
   934	}
   935	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 20261 bytes --]