From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 6/6] sched, rt: support schedstats for RT sched class
Date: Tue, 01 Dec 2020 21:59:20 +0800 [thread overview]
Message-ID: <202012012133.KYsEc5XQ-lkp@intel.com> (raw)
In-Reply-To: <20201201115416.26515-7-laoar.shao@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 4325 bytes --]
Hi Yafang,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on v5.10-rc6]
[cannot apply to tip/sched/core next-20201201]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Yafang-Shao/sched-support-schedstats-for-RT-sched-class/20201201-200101
base: b65054597872ce3aefbc6a666385eabdf9e288da
config: nds32-alldefconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/8fe6f2ed51d6372798149583be6c936c597c500e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yafang-Shao/sched-support-schedstats-for-RT-sched-class/20201201-200101
git checkout 8fe6f2ed51d6372798149583be6c936c597c500e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
kernel/sched/rt.c:253:6: warning: no previous prototype for 'free_rt_sched_group' [-Wmissing-prototypes]
253 | void free_rt_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~
kernel/sched/rt.c:255:5: warning: no previous prototype for 'alloc_rt_sched_group' [-Wmissing-prototypes]
255 | int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent)
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/rt.c:668:6: warning: no previous prototype for 'sched_rt_bandwidth_account' [-Wmissing-prototypes]
668 | bool sched_rt_bandwidth_account(struct rt_rq *rt_rq)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/rt.c: In function '__schedstat_from_sched_rt_entity':
kernel/sched/rt.c:1288:13: error: 'struct rt_rq' has no member named 'tg'
1288 | tg = rt_rq->tg;
| ^~
>> kernel/sched/rt.c:1290:14: error: dereferencing pointer to incomplete type 'struct task_group'
1290 | *stats = tg->stats[cpu];
| ^~
kernel/sched/rt.c:1281:6: warning: variable 'cpu' set but not used [-Wunused-but-set-variable]
1281 | int cpu;
| ^~~
kernel/sched/rt.c: In function 'update_stats_wait_start_rt':
kernel/sched/rt.c:1308:22: warning: variable 'p' set but not used [-Wunused-but-set-variable]
1308 | struct task_struct *p = NULL;
| ^
kernel/sched/rt.c: In function 'update_stats_enqueue_sleeper_rt':
kernel/sched/rt.c:1325:22: warning: variable 'p' set but not used [-Wunused-but-set-variable]
1325 | struct task_struct *p = NULL;
| ^
kernel/sched/rt.c: In function 'update_stats_wait_end_rt':
kernel/sched/rt.c:1353:22: warning: variable 'p' set but not used [-Wunused-but-set-variable]
1353 | struct task_struct *p = NULL;
| ^
kernel/sched/rt.c: At top level:
kernel/sched/rt.c:1698:6: warning: no previous prototype for 'set_next_task_rt' [-Wmissing-prototypes]
1698 | void set_next_task_rt(struct rq *rq, struct task_struct *p, bool first)
| ^~~~~~~~~~~~~~~~
vim +1290 kernel/sched/rt.c
1273
1274 static inline void
1275 __schedstat_from_sched_rt_entity(struct sched_rt_entity *rt_se,
1276 struct sched_statistics **stats)
1277 {
1278 struct task_struct *p;
1279 struct task_group *tg;
1280 struct rt_rq *rt_rq;
1281 int cpu;
1282
1283 if (rt_entity_is_task(rt_se)) {
1284 p = rt_task_of(rt_se);
1285 *stats = &p->stats;
1286 } else {
1287 rt_rq = group_rt_rq(rt_se);
1288 tg = rt_rq->tg;
1289 cpu = cpu_of(rq_of_rt_rq(rt_rq));
> 1290 *stats = tg->stats[cpu];
1291 }
1292 }
1293
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 7317 bytes --]
next prev parent reply other threads:[~2020-12-01 13:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 11:54 [PATCH 0/6] sched: support schedstats for RT sched class Yafang Shao
2020-12-01 11:54 ` [PATCH 1/6] sched: don't include stats.h in sched.h Yafang Shao
2020-12-01 11:54 ` [PATCH 2/6] sched, fair: use __schedstat_set() in set_next_entity() Yafang Shao
2020-12-01 12:28 ` Mel Gorman
2020-12-01 11:54 ` [PATCH 3/6] sched: make struct sched_statistics independent of fair sched class Yafang Shao
2020-12-01 12:41 ` Mel Gorman
2020-12-02 2:06 ` Yafang Shao
2020-12-01 13:19 ` kernel test robot
2020-12-01 13:30 ` kernel test robot
2020-12-01 11:54 ` [PATCH 4/6] sched: make schedstats helpers " Yafang Shao
2020-12-01 12:46 ` Mel Gorman
2020-12-02 2:04 ` Yafang Shao
2020-12-01 13:58 ` kernel test robot
2020-12-01 11:54 ` [PATCH 5/6] sched, rt: support sched_stat_runtime tracepoint for RT " Yafang Shao
2020-12-01 11:54 ` [PATCH 6/6] sched, rt: support schedstats " Yafang Shao
2020-12-01 13:59 ` kernel test robot [this message]
2020-12-01 14:13 ` kernel test robot
2020-12-01 14:30 ` kernel test robot
2020-12-02 2:07 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012012133.KYsEc5XQ-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.