From: Stafford Horne <shorne@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Jonas Bonn <jonas@southpole.se>,
Randy Dunlap <rdunlap@infradead.org>,
Openrisc <openrisc@lists.librecores.org>
Subject: [PATCH v2 10/13] openrisc/time: Fix symbol scope warnings
Date: Tue, 17 May 2022 09:55:07 +0900 [thread overview]
Message-ID: <20220517005510.3500105-11-shorne@gmail.com> (raw)
In-Reply-To: <20220517005510.3500105-1-shorne@gmail.com>
Spare reported the following warnings:
arch/openrisc/kernel/time.c:64:1: warning: symbol 'clockevent_openrisc_timer' was not declared. Should it be static?
arch/openrisc/kernel/time.c:66:6: warning: symbol 'openrisc_clockevent_init' was not declared. Should it be static?
This patch fixes by:
- Add static declaration to clockevent_openrisc_timer as it's used only in
this file.
- Add include for asm/time.h for openrisc_clockevent_init declaration.
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
arch/openrisc/kernel/time.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/openrisc/kernel/time.c b/arch/openrisc/kernel/time.c
index 6d18989d63d0..8e26c1af5441 100644
--- a/arch/openrisc/kernel/time.c
+++ b/arch/openrisc/kernel/time.c
@@ -23,6 +23,7 @@
#include <linux/of_clk.h>
#include <asm/cpuinfo.h>
+#include <asm/time.h>
/* Test the timer ticks to count, used in sync routine */
inline void openrisc_timer_set(unsigned long count)
@@ -61,7 +62,7 @@ static int openrisc_timer_set_next_event(unsigned long delta,
* timers) we cannot enable the PERIODIC feature. The tick timer can run using
* one-shot events, so no problem.
*/
-DEFINE_PER_CPU(struct clock_event_device, clockevent_openrisc_timer);
+static DEFINE_PER_CPU(struct clock_event_device, clockevent_openrisc_timer);
void openrisc_clockevent_init(void)
{
--
2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Stafford Horne <shorne@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Openrisc <openrisc@lists.librecores.org>,
Stafford Horne <shorne@gmail.com>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Randy Dunlap <rdunlap@infradead.org>
Subject: [PATCH v2 10/13] openrisc/time: Fix symbol scope warnings
Date: Tue, 17 May 2022 09:55:07 +0900 [thread overview]
Message-ID: <20220517005510.3500105-11-shorne@gmail.com> (raw)
In-Reply-To: <20220517005510.3500105-1-shorne@gmail.com>
Spare reported the following warnings:
arch/openrisc/kernel/time.c:64:1: warning: symbol 'clockevent_openrisc_timer' was not declared. Should it be static?
arch/openrisc/kernel/time.c:66:6: warning: symbol 'openrisc_clockevent_init' was not declared. Should it be static?
This patch fixes by:
- Add static declaration to clockevent_openrisc_timer as it's used only in
this file.
- Add include for asm/time.h for openrisc_clockevent_init declaration.
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
arch/openrisc/kernel/time.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/openrisc/kernel/time.c b/arch/openrisc/kernel/time.c
index 6d18989d63d0..8e26c1af5441 100644
--- a/arch/openrisc/kernel/time.c
+++ b/arch/openrisc/kernel/time.c
@@ -23,6 +23,7 @@
#include <linux/of_clk.h>
#include <asm/cpuinfo.h>
+#include <asm/time.h>
/* Test the timer ticks to count, used in sync routine */
inline void openrisc_timer_set(unsigned long count)
@@ -61,7 +62,7 @@ static int openrisc_timer_set_next_event(unsigned long delta,
* timers) we cannot enable the PERIODIC feature. The tick timer can run using
* one-shot events, so no problem.
*/
-DEFINE_PER_CPU(struct clock_event_device, clockevent_openrisc_timer);
+static DEFINE_PER_CPU(struct clock_event_device, clockevent_openrisc_timer);
void openrisc_clockevent_init(void)
{
--
2.31.1
next prev parent reply other threads:[~2022-05-17 0:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 0:54 [PATCH v2 00/13] OpenRISC misc cleanups for 5.19 Stafford Horne
2022-05-17 0:54 ` Stafford Horne
2022-05-17 0:54 ` [PATCH v2 01/13] openrisc: Add gcc machine instruction flag configuration Stafford Horne
2022-05-17 0:54 ` Stafford Horne
2022-05-17 21:27 ` Stafford Horne
2022-05-17 21:27 ` Stafford Horne
2022-05-17 0:54 ` [PATCH v2 02/13] openrisc: Cleanup emergency print handling Stafford Horne
2022-05-17 0:54 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 03/13] openrisc: Add support for liteuart emergency printing Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 04/13] openrisc: Add syscall details to emergency syscall debugging Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 05/13] openrisc: Pretty print show_registers memory dumps Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 06/13] openrisc: Update litex defconfig to support glibc userland Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 07/13] openrisc/traps: Declare file scope symbols as static Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 08/13] openrisc/traps: Remove die_if_kernel function Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 09/13] openrisc/traps: Declare unhandled_exception for asmlinkage Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` Stafford Horne [this message]
2022-05-17 0:55 ` [PATCH v2 10/13] openrisc/time: Fix symbol scope warnings Stafford Horne
2022-05-17 0:55 ` [PATCH v2 11/13] openrisc/delay: Add include to fix symbol not declared warning Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 12/13] openrisc/fault: Fix symbol scope warnings Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 13/13] openrisc: Remove unused IMMU tlb workardound Stafford Horne
2022-05-17 0:55 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517005510.3500105-11-shorne@gmail.com \
--to=shorne@gmail.com \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=openrisc@lists.librecores.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.