From: Stafford Horne <shorne@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Jonas Bonn <jonas@southpole.se>,
Openrisc <openrisc@lists.librecores.org>
Subject: Re: [PATCH v2 01/13] openrisc: Add gcc machine instruction flag configuration
Date: Wed, 18 May 2022 06:27:07 +0900 [thread overview]
Message-ID: <YoQTK4MiGzZ1DF0v@antec> (raw)
In-Reply-To: <20220517005510.3500105-2-shorne@gmail.com>
On Tue, May 17, 2022 at 09:54:58AM +0900, Stafford Horne wrote:
> OpenRISC GCC supports flags to enable the backend to output instructions
> if they are supported by a target processor. This patch adds
> configuration flags to enable configuring these flags to tune the kernel
> for a particular CPU configuration.
>
> In the future we could also enable all of these flags by default and
> provide instruction emulation in the kernel to make these choices easier
> for users but this is what we provide for now.
>
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
> arch/openrisc/Kconfig | 53 ++++++++++++++++++++++++++++++++++++++++++
> arch/openrisc/Makefile | 17 ++++++++++++++
> 2 files changed, 70 insertions(+)
>
> diff --git a/arch/openrisc/Kconfig b/arch/openrisc/Kconfig
> index 0d68adf6e02b..ea7eac20911a 100644
> --- a/arch/openrisc/Kconfig
> +++ b/arch/openrisc/Kconfig
> @@ -114,6 +114,59 @@ config OPENRISC_HAVE_INST_DIV
> default y
> help
> Select this if your implementation has a hardware divide instruction
> +
> +config OPENRISC_HAVE_INST_CMOV
> + bool "Have instruction l.cmov for conditional move"
> + default y
> + help
> + This config enables gcc to generate l.cmov instructions when compiling
> + the kernel which in general will improve performance and reduce the
> + binary size.
> +
> + Select this if your implementation has support for the Class II
> + l.cmov conistional move instruction.
> +
> + Say N if you are unsure.
> +
> +config OPENRISC_HAVE_INST_ROR
> + bool "Have instruction l.ror for rotate right"
> + default y
> + help
> + This config enables gcc to generate l.ror instructions when compiling
> + the kernel which in general will improve performance and reduce the
> + binary size.
> +
> + Select this if your implementation has support for the Class II
> + l.ror rotate right instruction.
> +
> + Say N if you are unsure.
> +
> +config OPENRISC_HAVE_INST_RORI
> + bool "Have instruction l.rori for rotate right with immediate"
> + default y
> + help
> + This config enables gcc to generate l.rori instructions when compiling
> + the kernel which in general will improve performance and reduce the
> + binary size.
> +
> + Select this if your implementation has support for the Class II
> + l.rori rotate right with immediate instruction.
> +
> + Say N if you are unsure.
> +
> +config OPENRISC_HAVE_INST_SEXT
> + bool "Have instructions l.ext* for sign extension"
> + default y
> + help
> + This config enables gcc to generate l.ext* instructions when compiling
> + the kernel which in general will improve performance and reduce the
> + binary size.
> +
> + Select this if your implementation has support for the Class II
> + l.exths, l.extbs, l.exthz and l.extbz size extend instructions.
> +
> + Say N if you are unsure.
Looking at this again and when generating the defconfig, the default for these
should be no,
-Stafford
> +
> endmenu
>
> config NR_CPUS
> diff --git a/arch/openrisc/Makefile b/arch/openrisc/Makefile
> index 760b734fb822..b446510173cd 100644
> --- a/arch/openrisc/Makefile
> +++ b/arch/openrisc/Makefile
> @@ -21,6 +21,7 @@ OBJCOPYFLAGS := -O binary -R .note -R .comment -S
> LIBGCC := $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
>
> KBUILD_CFLAGS += -pipe -ffixed-r10 -D__linux__
> +KBUILD_CFLAGS += -msfimm -mshftimm
>
> all: vmlinux.bin
>
> @@ -38,6 +39,22 @@ else
> KBUILD_CFLAGS += $(call cc-option,-msoft-div)
> endif
>
> +ifeq ($(CONFIG_OPENRISC_HAVE_INST_CMOV),y)
> + KBUILD_CFLAGS += $(call cc-option,-mcmov)
> +endif
> +
> +ifeq ($(CONFIG_OPENRISC_HAVE_INST_ROR),y)
> + KBUILD_CFLAGS += $(call cc-option,-mror)
> +endif
> +
> +ifeq ($(CONFIG_OPENRISC_HAVE_INST_RORI),y)
> + KBUILD_CFLAGS += $(call cc-option,-mrori)
> +endif
> +
> +ifeq ($(CONFIG_OPENRISC_HAVE_INST_SEXT),y)
> + KBUILD_CFLAGS += $(call cc-option,-msext)
> +endif
> +
> head-y := arch/openrisc/kernel/head.o
>
> libs-y += $(LIBGCC)
> --
> 2.31.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Stafford Horne <shorne@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Openrisc <openrisc@lists.librecores.org>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Subject: Re: [PATCH v2 01/13] openrisc: Add gcc machine instruction flag configuration
Date: Wed, 18 May 2022 06:27:07 +0900 [thread overview]
Message-ID: <YoQTK4MiGzZ1DF0v@antec> (raw)
In-Reply-To: <20220517005510.3500105-2-shorne@gmail.com>
On Tue, May 17, 2022 at 09:54:58AM +0900, Stafford Horne wrote:
> OpenRISC GCC supports flags to enable the backend to output instructions
> if they are supported by a target processor. This patch adds
> configuration flags to enable configuring these flags to tune the kernel
> for a particular CPU configuration.
>
> In the future we could also enable all of these flags by default and
> provide instruction emulation in the kernel to make these choices easier
> for users but this is what we provide for now.
>
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
> arch/openrisc/Kconfig | 53 ++++++++++++++++++++++++++++++++++++++++++
> arch/openrisc/Makefile | 17 ++++++++++++++
> 2 files changed, 70 insertions(+)
>
> diff --git a/arch/openrisc/Kconfig b/arch/openrisc/Kconfig
> index 0d68adf6e02b..ea7eac20911a 100644
> --- a/arch/openrisc/Kconfig
> +++ b/arch/openrisc/Kconfig
> @@ -114,6 +114,59 @@ config OPENRISC_HAVE_INST_DIV
> default y
> help
> Select this if your implementation has a hardware divide instruction
> +
> +config OPENRISC_HAVE_INST_CMOV
> + bool "Have instruction l.cmov for conditional move"
> + default y
> + help
> + This config enables gcc to generate l.cmov instructions when compiling
> + the kernel which in general will improve performance and reduce the
> + binary size.
> +
> + Select this if your implementation has support for the Class II
> + l.cmov conistional move instruction.
> +
> + Say N if you are unsure.
> +
> +config OPENRISC_HAVE_INST_ROR
> + bool "Have instruction l.ror for rotate right"
> + default y
> + help
> + This config enables gcc to generate l.ror instructions when compiling
> + the kernel which in general will improve performance and reduce the
> + binary size.
> +
> + Select this if your implementation has support for the Class II
> + l.ror rotate right instruction.
> +
> + Say N if you are unsure.
> +
> +config OPENRISC_HAVE_INST_RORI
> + bool "Have instruction l.rori for rotate right with immediate"
> + default y
> + help
> + This config enables gcc to generate l.rori instructions when compiling
> + the kernel which in general will improve performance and reduce the
> + binary size.
> +
> + Select this if your implementation has support for the Class II
> + l.rori rotate right with immediate instruction.
> +
> + Say N if you are unsure.
> +
> +config OPENRISC_HAVE_INST_SEXT
> + bool "Have instructions l.ext* for sign extension"
> + default y
> + help
> + This config enables gcc to generate l.ext* instructions when compiling
> + the kernel which in general will improve performance and reduce the
> + binary size.
> +
> + Select this if your implementation has support for the Class II
> + l.exths, l.extbs, l.exthz and l.extbz size extend instructions.
> +
> + Say N if you are unsure.
Looking at this again and when generating the defconfig, the default for these
should be no,
-Stafford
> +
> endmenu
>
> config NR_CPUS
> diff --git a/arch/openrisc/Makefile b/arch/openrisc/Makefile
> index 760b734fb822..b446510173cd 100644
> --- a/arch/openrisc/Makefile
> +++ b/arch/openrisc/Makefile
> @@ -21,6 +21,7 @@ OBJCOPYFLAGS := -O binary -R .note -R .comment -S
> LIBGCC := $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
>
> KBUILD_CFLAGS += -pipe -ffixed-r10 -D__linux__
> +KBUILD_CFLAGS += -msfimm -mshftimm
>
> all: vmlinux.bin
>
> @@ -38,6 +39,22 @@ else
> KBUILD_CFLAGS += $(call cc-option,-msoft-div)
> endif
>
> +ifeq ($(CONFIG_OPENRISC_HAVE_INST_CMOV),y)
> + KBUILD_CFLAGS += $(call cc-option,-mcmov)
> +endif
> +
> +ifeq ($(CONFIG_OPENRISC_HAVE_INST_ROR),y)
> + KBUILD_CFLAGS += $(call cc-option,-mror)
> +endif
> +
> +ifeq ($(CONFIG_OPENRISC_HAVE_INST_RORI),y)
> + KBUILD_CFLAGS += $(call cc-option,-mrori)
> +endif
> +
> +ifeq ($(CONFIG_OPENRISC_HAVE_INST_SEXT),y)
> + KBUILD_CFLAGS += $(call cc-option,-msext)
> +endif
> +
> head-y := arch/openrisc/kernel/head.o
>
> libs-y += $(LIBGCC)
> --
> 2.31.1
>
next prev parent reply other threads:[~2022-05-17 21:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 0:54 [PATCH v2 00/13] OpenRISC misc cleanups for 5.19 Stafford Horne
2022-05-17 0:54 ` Stafford Horne
2022-05-17 0:54 ` [PATCH v2 01/13] openrisc: Add gcc machine instruction flag configuration Stafford Horne
2022-05-17 0:54 ` Stafford Horne
2022-05-17 21:27 ` Stafford Horne [this message]
2022-05-17 21:27 ` Stafford Horne
2022-05-17 0:54 ` [PATCH v2 02/13] openrisc: Cleanup emergency print handling Stafford Horne
2022-05-17 0:54 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 03/13] openrisc: Add support for liteuart emergency printing Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 04/13] openrisc: Add syscall details to emergency syscall debugging Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 05/13] openrisc: Pretty print show_registers memory dumps Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 06/13] openrisc: Update litex defconfig to support glibc userland Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 07/13] openrisc/traps: Declare file scope symbols as static Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 08/13] openrisc/traps: Remove die_if_kernel function Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 09/13] openrisc/traps: Declare unhandled_exception for asmlinkage Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 10/13] openrisc/time: Fix symbol scope warnings Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 11/13] openrisc/delay: Add include to fix symbol not declared warning Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 12/13] openrisc/fault: Fix symbol scope warnings Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 13/13] openrisc: Remove unused IMMU tlb workardound Stafford Horne
2022-05-17 0:55 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoQTK4MiGzZ1DF0v@antec \
--to=shorne@gmail.com \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=openrisc@lists.librecores.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.