From: Stafford Horne <shorne@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Jonas Bonn <jonas@southpole.se>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Michael Ellerman <mpe@ellerman.id.au>,
"Russell King \(Oracle\)" <rmk+kernel@armlinux.org.uk>,
Openrisc <openrisc@lists.librecores.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v2 07/13] openrisc/traps: Declare file scope symbols as static
Date: Tue, 17 May 2022 09:55:04 +0900 [thread overview]
Message-ID: <20220517005510.3500105-8-shorne@gmail.com> (raw)
In-Reply-To: <20220517005510.3500105-1-shorne@gmail.com>
Sparse was reporting the following warnings:
arch/openrisc/kernel/traps.c:37:5: warning: symbol 'kstack_depth_to_print' was not declared. Should it be static?
arch/openrisc/kernel/traps.c:39:22: warning: symbol 'lwa_addr' was not declared. Should it be static?
arch/openrisc/kernel/traps.c:41:6: warning: symbol 'print_trace' was not declared. Should it be static?
The function print_trace and local variables kstack_depth_to_print and
lwa_addr are not used outside of this file. This patch marks them as
static.
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
arch/openrisc/kernel/traps.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/openrisc/kernel/traps.c b/arch/openrisc/kernel/traps.c
index f2478bba77b9..9e0937eb31ca 100644
--- a/arch/openrisc/kernel/traps.c
+++ b/arch/openrisc/kernel/traps.c
@@ -34,11 +34,11 @@
#include <asm/unwinder.h>
#include <asm/sections.h>
-int kstack_depth_to_print = 0x180;
+static int kstack_depth_to_print = 0x180;
int lwa_flag;
-unsigned long __user *lwa_addr;
+static unsigned long __user *lwa_addr;
-void print_trace(void *data, unsigned long addr, int reliable)
+static void print_trace(void *data, unsigned long addr, int reliable)
{
const char *loglvl = data;
--
2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Stafford Horne <shorne@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Openrisc <openrisc@lists.librecores.org>,
Stafford Horne <shorne@gmail.com>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Michael Ellerman <mpe@ellerman.id.au>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH v2 07/13] openrisc/traps: Declare file scope symbols as static
Date: Tue, 17 May 2022 09:55:04 +0900 [thread overview]
Message-ID: <20220517005510.3500105-8-shorne@gmail.com> (raw)
In-Reply-To: <20220517005510.3500105-1-shorne@gmail.com>
Sparse was reporting the following warnings:
arch/openrisc/kernel/traps.c:37:5: warning: symbol 'kstack_depth_to_print' was not declared. Should it be static?
arch/openrisc/kernel/traps.c:39:22: warning: symbol 'lwa_addr' was not declared. Should it be static?
arch/openrisc/kernel/traps.c:41:6: warning: symbol 'print_trace' was not declared. Should it be static?
The function print_trace and local variables kstack_depth_to_print and
lwa_addr are not used outside of this file. This patch marks them as
static.
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
arch/openrisc/kernel/traps.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/openrisc/kernel/traps.c b/arch/openrisc/kernel/traps.c
index f2478bba77b9..9e0937eb31ca 100644
--- a/arch/openrisc/kernel/traps.c
+++ b/arch/openrisc/kernel/traps.c
@@ -34,11 +34,11 @@
#include <asm/unwinder.h>
#include <asm/sections.h>
-int kstack_depth_to_print = 0x180;
+static int kstack_depth_to_print = 0x180;
int lwa_flag;
-unsigned long __user *lwa_addr;
+static unsigned long __user *lwa_addr;
-void print_trace(void *data, unsigned long addr, int reliable)
+static void print_trace(void *data, unsigned long addr, int reliable)
{
const char *loglvl = data;
--
2.31.1
next prev parent reply other threads:[~2022-05-17 0:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 0:54 [PATCH v2 00/13] OpenRISC misc cleanups for 5.19 Stafford Horne
2022-05-17 0:54 ` Stafford Horne
2022-05-17 0:54 ` [PATCH v2 01/13] openrisc: Add gcc machine instruction flag configuration Stafford Horne
2022-05-17 0:54 ` Stafford Horne
2022-05-17 21:27 ` Stafford Horne
2022-05-17 21:27 ` Stafford Horne
2022-05-17 0:54 ` [PATCH v2 02/13] openrisc: Cleanup emergency print handling Stafford Horne
2022-05-17 0:54 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 03/13] openrisc: Add support for liteuart emergency printing Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 04/13] openrisc: Add syscall details to emergency syscall debugging Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 05/13] openrisc: Pretty print show_registers memory dumps Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 06/13] openrisc: Update litex defconfig to support glibc userland Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` Stafford Horne [this message]
2022-05-17 0:55 ` [PATCH v2 07/13] openrisc/traps: Declare file scope symbols as static Stafford Horne
2022-05-17 0:55 ` [PATCH v2 08/13] openrisc/traps: Remove die_if_kernel function Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 09/13] openrisc/traps: Declare unhandled_exception for asmlinkage Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 10/13] openrisc/time: Fix symbol scope warnings Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 11/13] openrisc/delay: Add include to fix symbol not declared warning Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 12/13] openrisc/fault: Fix symbol scope warnings Stafford Horne
2022-05-17 0:55 ` Stafford Horne
2022-05-17 0:55 ` [PATCH v2 13/13] openrisc: Remove unused IMMU tlb workardound Stafford Horne
2022-05-17 0:55 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517005510.3500105-8-shorne@gmail.com \
--to=shorne@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=openrisc@lists.librecores.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.