All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stafford Horne <shorne@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Jonas Bonn <jonas@southpole.se>,
	Randy Dunlap <rdunlap@infradead.org>,
	Qi Zheng <zhengqi.arch@bytedance.com>,
	Openrisc <openrisc@lists.librecores.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v2 12/13] openrisc/fault: Fix symbol scope warnings
Date: Tue, 17 May 2022 09:55:09 +0900	[thread overview]
Message-ID: <20220517005510.3500105-13-shorne@gmail.com> (raw)
In-Reply-To: <20220517005510.3500105-1-shorne@gmail.com>

Sparse reported the following warning:

    arch/openrisc/mm/fault.c:27:15: warning: symbol 'pte_misses' was not declared. Should it be static?
    arch/openrisc/mm/fault.c:28:15: warning: symbol 'pte_errors' was not declared. Should it be static?
    arch/openrisc/mm/fault.c:33:16: warning: symbol 'current_pgd' was not declared. Should it be static?

This patch fixes these by:
 - Remove unused pte_misses and pte_errors counters which are no longer
   used.
 - Add asm/mmu_context.h include to provide the current_pgd declaration.

Signed-off-by: Stafford Horne <shorne@gmail.com>
---
 arch/openrisc/mm/fault.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/openrisc/mm/fault.c b/arch/openrisc/mm/fault.c
index 80bb66ad42f6..516cba14dec9 100644
--- a/arch/openrisc/mm/fault.c
+++ b/arch/openrisc/mm/fault.c
@@ -18,15 +18,13 @@
 #include <linux/perf_event.h>
 
 #include <linux/uaccess.h>
+#include <asm/mmu_context.h>
 #include <asm/siginfo.h>
 #include <asm/signal.h>
 
 #define NUM_TLB_ENTRIES 64
 #define TLB_OFFSET(add) (((add) >> PAGE_SHIFT) & (NUM_TLB_ENTRIES-1))
 
-unsigned long pte_misses;	/* updated by do_page_fault() */
-unsigned long pte_errors;	/* updated by do_page_fault() */
-
 /* __PHX__ :: - check the vmalloc_fault in do_page_fault()
  *            - also look into include/asm/mmu_context.h
  */
-- 
2.31.1


WARNING: multiple messages have this Message-ID (diff)
From: Stafford Horne <shorne@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Openrisc <openrisc@lists.librecores.org>,
	Stafford Horne <shorne@gmail.com>,
	Jonas Bonn <jonas@southpole.se>,
	Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Qi Zheng <zhengqi.arch@bytedance.com>
Subject: [PATCH v2 12/13] openrisc/fault: Fix symbol scope warnings
Date: Tue, 17 May 2022 09:55:09 +0900	[thread overview]
Message-ID: <20220517005510.3500105-13-shorne@gmail.com> (raw)
In-Reply-To: <20220517005510.3500105-1-shorne@gmail.com>

Sparse reported the following warning:

    arch/openrisc/mm/fault.c:27:15: warning: symbol 'pte_misses' was not declared. Should it be static?
    arch/openrisc/mm/fault.c:28:15: warning: symbol 'pte_errors' was not declared. Should it be static?
    arch/openrisc/mm/fault.c:33:16: warning: symbol 'current_pgd' was not declared. Should it be static?

This patch fixes these by:
 - Remove unused pte_misses and pte_errors counters which are no longer
   used.
 - Add asm/mmu_context.h include to provide the current_pgd declaration.

Signed-off-by: Stafford Horne <shorne@gmail.com>
---
 arch/openrisc/mm/fault.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/openrisc/mm/fault.c b/arch/openrisc/mm/fault.c
index 80bb66ad42f6..516cba14dec9 100644
--- a/arch/openrisc/mm/fault.c
+++ b/arch/openrisc/mm/fault.c
@@ -18,15 +18,13 @@
 #include <linux/perf_event.h>
 
 #include <linux/uaccess.h>
+#include <asm/mmu_context.h>
 #include <asm/siginfo.h>
 #include <asm/signal.h>
 
 #define NUM_TLB_ENTRIES 64
 #define TLB_OFFSET(add) (((add) >> PAGE_SHIFT) & (NUM_TLB_ENTRIES-1))
 
-unsigned long pte_misses;	/* updated by do_page_fault() */
-unsigned long pte_errors;	/* updated by do_page_fault() */
-
 /* __PHX__ :: - check the vmalloc_fault in do_page_fault()
  *            - also look into include/asm/mmu_context.h
  */
-- 
2.31.1


  parent reply	other threads:[~2022-05-17  0:56 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17  0:54 [PATCH v2 00/13] OpenRISC misc cleanups for 5.19 Stafford Horne
2022-05-17  0:54 ` Stafford Horne
2022-05-17  0:54 ` [PATCH v2 01/13] openrisc: Add gcc machine instruction flag configuration Stafford Horne
2022-05-17  0:54   ` Stafford Horne
2022-05-17 21:27   ` Stafford Horne
2022-05-17 21:27     ` Stafford Horne
2022-05-17  0:54 ` [PATCH v2 02/13] openrisc: Cleanup emergency print handling Stafford Horne
2022-05-17  0:54   ` Stafford Horne
2022-05-17  0:55 ` [PATCH v2 03/13] openrisc: Add support for liteuart emergency printing Stafford Horne
2022-05-17  0:55   ` Stafford Horne
2022-05-17  0:55 ` [PATCH v2 04/13] openrisc: Add syscall details to emergency syscall debugging Stafford Horne
2022-05-17  0:55   ` Stafford Horne
2022-05-17  0:55 ` [PATCH v2 05/13] openrisc: Pretty print show_registers memory dumps Stafford Horne
2022-05-17  0:55   ` Stafford Horne
2022-05-17  0:55 ` [PATCH v2 06/13] openrisc: Update litex defconfig to support glibc userland Stafford Horne
2022-05-17  0:55   ` Stafford Horne
2022-05-17  0:55 ` [PATCH v2 07/13] openrisc/traps: Declare file scope symbols as static Stafford Horne
2022-05-17  0:55   ` Stafford Horne
2022-05-17  0:55 ` [PATCH v2 08/13] openrisc/traps: Remove die_if_kernel function Stafford Horne
2022-05-17  0:55   ` Stafford Horne
2022-05-17  0:55 ` [PATCH v2 09/13] openrisc/traps: Declare unhandled_exception for asmlinkage Stafford Horne
2022-05-17  0:55   ` Stafford Horne
2022-05-17  0:55 ` [PATCH v2 10/13] openrisc/time: Fix symbol scope warnings Stafford Horne
2022-05-17  0:55   ` Stafford Horne
2022-05-17  0:55 ` [PATCH v2 11/13] openrisc/delay: Add include to fix symbol not declared warning Stafford Horne
2022-05-17  0:55   ` Stafford Horne
2022-05-17  0:55 ` Stafford Horne [this message]
2022-05-17  0:55   ` [PATCH v2 12/13] openrisc/fault: Fix symbol scope warnings Stafford Horne
2022-05-17  0:55 ` [PATCH v2 13/13] openrisc: Remove unused IMMU tlb workardound Stafford Horne
2022-05-17  0:55   ` Stafford Horne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220517005510.3500105-13-shorne@gmail.com \
    --to=shorne@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=jonas@southpole.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openrisc@lists.librecores.org \
    --cc=rdunlap@infradead.org \
    --cc=zhengqi.arch@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.